From: Eric Biggers <ebiggers@kernel.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: linux-crypto@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Herbert Xu <herbert@gondor.apana.org.au>,
dm-devel@redhat.com, linux-fscrypt@vger.kernel.org,
Gilad Ben-Yossef <gilad@benyossef.com>,
Milan Broz <gmazyland@gmail.com>
Subject: Re: [PATCH v5 2/7] fs: crypto: invoke crypto API for ESSIV handling
Date: Thu, 27 Jun 2019 09:39:38 -0700 [thread overview]
Message-ID: <20190627163938.GD686@sol.localdomain> (raw)
In-Reply-To: <20190626204047.32131-3-ard.biesheuvel@linaro.org>
On Wed, Jun 26, 2019 at 10:40:42PM +0200, Ard Biesheuvel wrote:
> diff --git a/fs/crypto/keyinfo.c b/fs/crypto/keyinfo.c
> index dcd91a3fbe49..82c7eb86ca00 100644
> --- a/fs/crypto/keyinfo.c
> +++ b/fs/crypto/keyinfo.c
> @@ -19,8 +19,6 @@
> #include <crypto/skcipher.h>
> #include "fscrypt_private.h"
Can you remove the includes that become unused as a result of this patch?
#include <crypto/aes.h>
#include <crypto/sha.h>
> @@ -495,7 +412,6 @@ static void put_crypt_info(struct fscrypt_info *ci)
> put_master_key(ci->ci_master_key);
> } else {
> crypto_free_skcipher(ci->ci_ctfm);
> - crypto_free_cipher(ci->ci_essiv_tfm);
> }
> kmem_cache_free(fscrypt_info_cachep, ci);
Nit: should remove the curly braces here.
- Eric
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
linux-fscrypt@vger.kernel.org,
Gilad Ben-Yossef <gilad@benyossef.com>,
dm-devel@redhat.com, linux-crypto@vger.kernel.org,
Milan Broz <gmazyland@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 2/7] fs: crypto: invoke crypto API for ESSIV handling
Date: Thu, 27 Jun 2019 09:39:38 -0700 [thread overview]
Message-ID: <20190627163938.GD686@sol.localdomain> (raw)
In-Reply-To: <20190626204047.32131-3-ard.biesheuvel@linaro.org>
On Wed, Jun 26, 2019 at 10:40:42PM +0200, Ard Biesheuvel wrote:
> diff --git a/fs/crypto/keyinfo.c b/fs/crypto/keyinfo.c
> index dcd91a3fbe49..82c7eb86ca00 100644
> --- a/fs/crypto/keyinfo.c
> +++ b/fs/crypto/keyinfo.c
> @@ -19,8 +19,6 @@
> #include <crypto/skcipher.h>
> #include "fscrypt_private.h"
Can you remove the includes that become unused as a result of this patch?
#include <crypto/aes.h>
#include <crypto/sha.h>
> @@ -495,7 +412,6 @@ static void put_crypt_info(struct fscrypt_info *ci)
> put_master_key(ci->ci_master_key);
> } else {
> crypto_free_skcipher(ci->ci_ctfm);
> - crypto_free_cipher(ci->ci_essiv_tfm);
> }
> kmem_cache_free(fscrypt_info_cachep, ci);
Nit: should remove the curly braces here.
- Eric
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
linux-fscrypt@vger.kernel.org,
Gilad Ben-Yossef <gilad@benyossef.com>,
dm-devel@redhat.com, linux-crypto@vger.kernel.org,
Milan Broz <gmazyland@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 2/7] fs: crypto: invoke crypto API for ESSIV handling
Date: Thu, 27 Jun 2019 09:39:38 -0700 [thread overview]
Message-ID: <20190627163938.GD686@sol.localdomain> (raw)
In-Reply-To: <20190626204047.32131-3-ard.biesheuvel@linaro.org>
On Wed, Jun 26, 2019 at 10:40:42PM +0200, Ard Biesheuvel wrote:
> diff --git a/fs/crypto/keyinfo.c b/fs/crypto/keyinfo.c
> index dcd91a3fbe49..82c7eb86ca00 100644
> --- a/fs/crypto/keyinfo.c
> +++ b/fs/crypto/keyinfo.c
> @@ -19,8 +19,6 @@
> #include <crypto/skcipher.h>
> #include "fscrypt_private.h"
Can you remove the includes that become unused as a result of this patch?
#include <crypto/aes.h>
#include <crypto/sha.h>
> @@ -495,7 +412,6 @@ static void put_crypt_info(struct fscrypt_info *ci)
> put_master_key(ci->ci_master_key);
> } else {
> crypto_free_skcipher(ci->ci_ctfm);
> - crypto_free_cipher(ci->ci_essiv_tfm);
> }
> kmem_cache_free(fscrypt_info_cachep, ci);
Nit: should remove the curly braces here.
- Eric
next prev parent reply other threads:[~2019-06-27 16:39 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 20:40 [PATCH v5 0/7] crypto: switch to crypto API for ESSIV generation Ard Biesheuvel
2019-06-26 20:40 ` Ard Biesheuvel
2019-06-26 20:40 ` Ard Biesheuvel
2019-06-26 20:40 ` [PATCH v5 1/7] crypto: essiv - create wrapper template " Ard Biesheuvel
2019-06-26 20:40 ` Ard Biesheuvel
2019-06-26 20:40 ` Ard Biesheuvel
2019-06-27 7:04 ` Ard Biesheuvel
2019-06-27 7:04 ` Ard Biesheuvel
2019-06-27 7:04 ` Ard Biesheuvel
2019-06-27 7:04 ` Ard Biesheuvel
2019-06-26 20:40 ` [PATCH v5 2/7] fs: crypto: invoke crypto API for ESSIV handling Ard Biesheuvel
2019-06-26 20:40 ` Ard Biesheuvel
2019-06-26 20:40 ` Ard Biesheuvel
2019-06-27 16:39 ` Eric Biggers [this message]
2019-06-27 16:39 ` Eric Biggers
2019-06-27 16:39 ` Eric Biggers
2019-06-26 20:40 ` [PATCH v5 3/7] md: dm-crypt: infer ESSIV block cipher from cipher string directly Ard Biesheuvel
2019-06-26 20:40 ` Ard Biesheuvel
2019-06-26 20:40 ` Ard Biesheuvel
2019-06-26 20:40 ` [PATCH v5 4/7] md: dm-crypt: switch to ESSIV crypto API template Ard Biesheuvel
2019-06-26 20:40 ` Ard Biesheuvel
2019-06-26 20:40 ` Ard Biesheuvel
2019-06-26 20:40 ` [PATCH v5 5/7] crypto: essiv - add test vector for essiv(cbc(aes),aes,sha256) Ard Biesheuvel
2019-06-26 20:40 ` [PATCH v5 5/7] crypto: essiv - add test vector for essiv(cbc(aes), aes, sha256) Ard Biesheuvel
2019-06-26 20:40 ` Ard Biesheuvel
2019-06-27 16:32 ` [PATCH v5 5/7] crypto: essiv - add test vector for essiv(cbc(aes),aes,sha256) Eric Biggers
2019-06-27 16:32 ` Eric Biggers
2019-06-27 16:32 ` Eric Biggers
2019-06-26 20:40 ` [PATCH v5 6/7] crypto: arm64/aes-cts-cbc - factor out CBC en/decryption of a walk Ard Biesheuvel
2019-06-26 20:40 ` Ard Biesheuvel
2019-06-26 20:40 ` Ard Biesheuvel
2019-06-26 20:40 ` [PATCH v5 7/7] crypto: arm64/aes - implement accelerated ESSIV/CBC mode Ard Biesheuvel
2019-06-26 20:40 ` Ard Biesheuvel
2019-06-26 20:40 ` Ard Biesheuvel
2019-06-27 16:40 ` Eric Biggers
2019-06-27 16:40 ` Eric Biggers
2019-06-27 16:40 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190627163938.GD686@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=ard.biesheuvel@linaro.org \
--cc=dm-devel@redhat.com \
--cc=gilad@benyossef.com \
--cc=gmazyland@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.