From: Stefan Hajnoczi <stefanha@redhat.com>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>,
netdev@vger.kernel.org, kvm@vger.kernel.org,
virtualization@lists.linux-foundation.org,
"Michael S. Tsirkin" <mst@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] vsock/virtio: use RCU to avoid use-after-free on the_virtio_vsock
Date: Thu, 4 Jul 2019 11:17:01 +0100 [thread overview]
Message-ID: <20190704101701.GD1609@stefanha-x1.localdomain> (raw)
In-Reply-To: <20190703104135.wg34dobv64k7u4jo@steredhat>
[-- Attachment #1: Type: text/plain, Size: 723 bytes --]
On Wed, Jul 03, 2019 at 12:41:35PM +0200, Stefano Garzarella wrote:
> On Wed, Jul 03, 2019 at 05:53:58PM +0800, Jason Wang wrote:
> > On 2019/6/28 下午8:36, Stefano Garzarella wrote:
> > Another more interesting question, I believe we will do singleton for
> > virtio_vsock structure. Then what's the point of using vdev->priv to access
> > the_virtio_vsock? It looks to me we can it brings extra troubles for doing
> > synchronization.
>
> I thought about it when I tried to use RCU to stop the worker and I
> think make sense. Maybe can be another series after this will be merged.
>
> @Stefan, what do you think about that?
Yes, let's make it a singleton and keep no other references to it.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-07-04 10:17 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 12:36 [PATCH v2 0/3] vsock/virtio: several fixes in the .probe() and .remove() Stefano Garzarella
2019-06-28 12:36 ` [PATCH v2 1/3] vsock/virtio: use RCU to avoid use-after-free on the_virtio_vsock Stefano Garzarella
2019-07-01 14:54 ` Stefan Hajnoczi
2019-07-01 14:54 ` Stefan Hajnoczi
2019-07-01 15:10 ` Stefan Hajnoczi
2019-07-01 15:10 ` Stefan Hajnoczi
2019-07-03 9:53 ` Jason Wang
2019-07-03 9:53 ` Jason Wang
2019-07-03 10:41 ` Stefano Garzarella
2019-07-04 3:58 ` Jason Wang
2019-07-04 3:58 ` Jason Wang
2019-07-04 9:20 ` Stefano Garzarella
2019-07-04 9:20 ` Stefano Garzarella
2019-07-05 0:18 ` Jason Wang
2019-07-05 0:18 ` Jason Wang
2019-07-04 10:17 ` Stefan Hajnoczi [this message]
2019-07-04 10:17 ` Stefan Hajnoczi
2019-07-03 10:41 ` Stefano Garzarella
2019-06-28 12:36 ` Stefano Garzarella
2019-06-28 12:36 ` [PATCH v2 2/3] vsock/virtio: stop workers during the .remove() Stefano Garzarella
2019-06-28 12:36 ` Stefano Garzarella
2019-07-04 4:00 ` Jason Wang
2019-07-04 4:00 ` Jason Wang
2019-06-28 12:36 ` [PATCH v2 3/3] vsock/virtio: fix flush of works " Stefano Garzarella
2019-06-28 12:36 ` Stefano Garzarella
2019-07-01 15:08 ` Stefan Hajnoczi
2019-07-01 15:08 ` Stefan Hajnoczi
2019-07-01 15:09 ` Stefan Hajnoczi
2019-07-01 15:09 ` Stefan Hajnoczi
2019-07-01 15:11 ` [PATCH v2 0/3] vsock/virtio: several fixes in the .probe() and .remove() Stefan Hajnoczi
2019-07-01 15:11 ` Stefan Hajnoczi
2019-07-01 17:03 ` Stefano Garzarella
2019-07-03 9:14 ` Stefan Hajnoczi
2019-07-03 9:14 ` Stefan Hajnoczi
2019-07-03 10:07 ` Stefano Garzarella
2019-07-03 10:07 ` Stefano Garzarella
2019-07-01 17:03 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190704101701.GD1609@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sgarzare@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.