From: Stefan Hajnoczi <stefanha@gmail.com>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: netdev@vger.kernel.org, kvm@vger.kernel.org,
"Michael S. Tsirkin" <mst@redhat.com>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Stefan Hajnoczi <stefanha@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v2 3/3] vsock/virtio: fix flush of works during the .remove()
Date: Mon, 1 Jul 2019 16:08:34 +0100 [thread overview]
Message-ID: <20190701150834.GB11900@stefanha-x1.localdomain> (raw)
In-Reply-To: <20190628123659.139576-4-sgarzare@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 647 bytes --]
On Fri, Jun 28, 2019 at 02:36:59PM +0200, Stefano Garzarella wrote:
> This patch moves the flush of works after vdev->config->del_vqs(vdev),
> because we need to be sure that no workers run before to free the
> 'vsock' object.
>
> Since we stopped the workers using the [tx|rx|event]_run flags,
> we are sure no one is accessing the device while we are calling
> vdev->config->reset(vdev), so we can safely move the workers' flush.
What about send_pkt and loopback work? How were they stopped safely?
For example, if send_pkt work executes then we're in trouble since it
accesses the tx virtqueue which is deleted by ->del_vqs().
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Stefan Hajnoczi <stefanha@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v2 3/3] vsock/virtio: fix flush of works during the .remove()
Date: Mon, 1 Jul 2019 16:08:34 +0100 [thread overview]
Message-ID: <20190701150834.GB11900@stefanha-x1.localdomain> (raw)
In-Reply-To: <20190628123659.139576-4-sgarzare@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 647 bytes --]
On Fri, Jun 28, 2019 at 02:36:59PM +0200, Stefano Garzarella wrote:
> This patch moves the flush of works after vdev->config->del_vqs(vdev),
> because we need to be sure that no workers run before to free the
> 'vsock' object.
>
> Since we stopped the workers using the [tx|rx|event]_run flags,
> we are sure no one is accessing the device while we are calling
> vdev->config->reset(vdev), so we can safely move the workers' flush.
What about send_pkt and loopback work? How were they stopped safely?
For example, if send_pkt work executes then we're in trouble since it
accesses the tx virtqueue which is deleted by ->del_vqs().
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 183 bytes --]
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2019-07-01 15:08 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 12:36 [PATCH v2 0/3] vsock/virtio: several fixes in the .probe() and .remove() Stefano Garzarella
2019-06-28 12:36 ` [PATCH v2 1/3] vsock/virtio: use RCU to avoid use-after-free on the_virtio_vsock Stefano Garzarella
2019-07-01 14:54 ` Stefan Hajnoczi
2019-07-01 14:54 ` Stefan Hajnoczi
2019-07-01 15:10 ` Stefan Hajnoczi
2019-07-01 15:10 ` Stefan Hajnoczi
2019-07-03 9:53 ` Jason Wang
2019-07-03 9:53 ` Jason Wang
2019-07-03 10:41 ` Stefano Garzarella
2019-07-04 3:58 ` Jason Wang
2019-07-04 3:58 ` Jason Wang
2019-07-04 9:20 ` Stefano Garzarella
2019-07-04 9:20 ` Stefano Garzarella
2019-07-05 0:18 ` Jason Wang
2019-07-05 0:18 ` Jason Wang
2019-07-04 10:17 ` Stefan Hajnoczi
2019-07-04 10:17 ` Stefan Hajnoczi
2019-07-03 10:41 ` Stefano Garzarella
2019-06-28 12:36 ` Stefano Garzarella
2019-06-28 12:36 ` [PATCH v2 2/3] vsock/virtio: stop workers during the .remove() Stefano Garzarella
2019-06-28 12:36 ` Stefano Garzarella
2019-07-04 4:00 ` Jason Wang
2019-07-04 4:00 ` Jason Wang
2019-06-28 12:36 ` [PATCH v2 3/3] vsock/virtio: fix flush of works " Stefano Garzarella
2019-06-28 12:36 ` Stefano Garzarella
2019-07-01 15:08 ` Stefan Hajnoczi [this message]
2019-07-01 15:08 ` Stefan Hajnoczi
2019-07-01 15:09 ` Stefan Hajnoczi
2019-07-01 15:09 ` Stefan Hajnoczi
2019-07-01 15:11 ` [PATCH v2 0/3] vsock/virtio: several fixes in the .probe() and .remove() Stefan Hajnoczi
2019-07-01 15:11 ` Stefan Hajnoczi
2019-07-01 17:03 ` Stefano Garzarella
2019-07-03 9:14 ` Stefan Hajnoczi
2019-07-03 9:14 ` Stefan Hajnoczi
2019-07-03 10:07 ` Stefano Garzarella
2019-07-03 10:07 ` Stefano Garzarella
2019-07-01 17:03 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190701150834.GB11900@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=davem@davemloft.net \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.