From: Juan Quintela <quintela@redhat.com> To: qemu-devel@nongnu.org Cc: Laurent Vivier <lvivier@redhat.com>, Richard Henderson <rth@twiddle.net>, Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Juan Quintela <quintela@redhat.com>, Thomas Huth <thuth@redhat.com>, Peter Xu <peterx@redhat.com> Subject: [PULL 15/19] kvm: Persistent per kvmslot dirty bitmap Date: Fri, 12 Jul 2019 16:32:03 +0200 [thread overview] Message-ID: <20190712143207.4214-16-quintela@redhat.com> (raw) In-Reply-To: <20190712143207.4214-1-quintela@redhat.com> From: Peter Xu <peterx@redhat.com> When synchronizing dirty bitmap from kernel KVM we do it in a per-kvmslot fashion and we allocate the userspace bitmap for each of the ioctl. This patch instead make the bitmap cache be persistent then we don't need to g_malloc0() every time. More importantly, the cached per-kvmslot dirty bitmap will be further used when we want to add support for the KVM_CLEAR_DIRTY_LOG and this cached bitmap will be used to guarantee we won't clear any unknown dirty bits otherwise that can be a severe data loss issue for migration code. Signed-off-by: Peter Xu <peterx@redhat.com> Reviewed-by: Juan Quintela <quintela@redhat.com> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Message-Id: <20190603065056.25211-9-peterx@redhat.com> Signed-off-by: Juan Quintela <quintela@redhat.com> --- accel/kvm/kvm-all.c | 10 +++++++--- include/sysemu/kvm_int.h | 2 ++ 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index a3df19da56..23ace52b9e 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -516,17 +516,19 @@ static int kvm_physical_sync_dirty_bitmap(KVMMemoryListener *kml, */ size = ALIGN(((mem->memory_size) >> TARGET_PAGE_BITS), /*HOST_LONG_BITS*/ 64) / 8; - d.dirty_bitmap = g_malloc0(size); + if (!mem->dirty_bmap) { + /* Allocate on the first log_sync, once and for all */ + mem->dirty_bmap = g_malloc0(size); + } + d.dirty_bitmap = mem->dirty_bmap; d.slot = mem->slot | (kml->as_id << 16); if (kvm_vm_ioctl(s, KVM_GET_DIRTY_LOG, &d) == -1) { DPRINTF("ioctl failed %d\n", errno); - g_free(d.dirty_bitmap); return -1; } kvm_get_dirty_pages_log_range(section, d.dirty_bitmap); - g_free(d.dirty_bitmap); } return 0; @@ -801,6 +803,8 @@ static void kvm_set_phys_mem(KVMMemoryListener *kml, } /* unregister the slot */ + g_free(mem->dirty_bmap); + mem->dirty_bmap = NULL; mem->memory_size = 0; mem->flags = 0; err = kvm_set_user_memory_region(kml, mem, false); diff --git a/include/sysemu/kvm_int.h b/include/sysemu/kvm_int.h index f838412491..687a2ee423 100644 --- a/include/sysemu/kvm_int.h +++ b/include/sysemu/kvm_int.h @@ -21,6 +21,8 @@ typedef struct KVMSlot int slot; int flags; int old_flags; + /* Dirty bitmap cache for the slot */ + unsigned long *dirty_bmap; } KVMSlot; typedef struct KVMMemoryListener { -- 2.21.0
WARNING: multiple messages have this Message-ID (diff)
From: Juan Quintela <quintela@redhat.com> To: qemu-devel@nongnu.org Cc: Laurent Vivier <lvivier@redhat.com>, Thomas Huth <thuth@redhat.com>, kvm@vger.kernel.org, Juan Quintela <quintela@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Peter Xu <peterx@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net> Subject: [Qemu-devel] [PULL 15/19] kvm: Persistent per kvmslot dirty bitmap Date: Fri, 12 Jul 2019 16:32:03 +0200 [thread overview] Message-ID: <20190712143207.4214-16-quintela@redhat.com> (raw) In-Reply-To: <20190712143207.4214-1-quintela@redhat.com> From: Peter Xu <peterx@redhat.com> When synchronizing dirty bitmap from kernel KVM we do it in a per-kvmslot fashion and we allocate the userspace bitmap for each of the ioctl. This patch instead make the bitmap cache be persistent then we don't need to g_malloc0() every time. More importantly, the cached per-kvmslot dirty bitmap will be further used when we want to add support for the KVM_CLEAR_DIRTY_LOG and this cached bitmap will be used to guarantee we won't clear any unknown dirty bits otherwise that can be a severe data loss issue for migration code. Signed-off-by: Peter Xu <peterx@redhat.com> Reviewed-by: Juan Quintela <quintela@redhat.com> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Message-Id: <20190603065056.25211-9-peterx@redhat.com> Signed-off-by: Juan Quintela <quintela@redhat.com> --- accel/kvm/kvm-all.c | 10 +++++++--- include/sysemu/kvm_int.h | 2 ++ 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index a3df19da56..23ace52b9e 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -516,17 +516,19 @@ static int kvm_physical_sync_dirty_bitmap(KVMMemoryListener *kml, */ size = ALIGN(((mem->memory_size) >> TARGET_PAGE_BITS), /*HOST_LONG_BITS*/ 64) / 8; - d.dirty_bitmap = g_malloc0(size); + if (!mem->dirty_bmap) { + /* Allocate on the first log_sync, once and for all */ + mem->dirty_bmap = g_malloc0(size); + } + d.dirty_bitmap = mem->dirty_bmap; d.slot = mem->slot | (kml->as_id << 16); if (kvm_vm_ioctl(s, KVM_GET_DIRTY_LOG, &d) == -1) { DPRINTF("ioctl failed %d\n", errno); - g_free(d.dirty_bitmap); return -1; } kvm_get_dirty_pages_log_range(section, d.dirty_bitmap); - g_free(d.dirty_bitmap); } return 0; @@ -801,6 +803,8 @@ static void kvm_set_phys_mem(KVMMemoryListener *kml, } /* unregister the slot */ + g_free(mem->dirty_bmap); + mem->dirty_bmap = NULL; mem->memory_size = 0; mem->flags = 0; err = kvm_set_user_memory_region(kml, mem, false); diff --git a/include/sysemu/kvm_int.h b/include/sysemu/kvm_int.h index f838412491..687a2ee423 100644 --- a/include/sysemu/kvm_int.h +++ b/include/sysemu/kvm_int.h @@ -21,6 +21,8 @@ typedef struct KVMSlot int slot; int flags; int old_flags; + /* Dirty bitmap cache for the slot */ + unsigned long *dirty_bmap; } KVMSlot; typedef struct KVMMemoryListener { -- 2.21.0
next prev parent reply other threads:[~2019-07-12 14:32 UTC|newest] Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-12 14:31 [PULL 00/19] Migration patches Juan Quintela 2019-07-12 14:31 ` [Qemu-devel] " Juan Quintela 2019-07-12 14:31 ` [PULL 01/19] migration: fix multifd_recv event typo Juan Quintela 2019-07-12 14:31 ` [Qemu-devel] " Juan Quintela 2019-07-12 14:31 ` [PULL 02/19] migration-test: rename parameter to parameter_int Juan Quintela 2019-07-12 14:31 ` [Qemu-devel] " Juan Quintela 2019-07-12 14:31 ` [PULL 03/19] migration-test: Add migration multifd test Juan Quintela 2019-07-12 14:31 ` [Qemu-devel] " Juan Quintela 2019-07-12 14:31 ` [PULL 04/19] migration/multifd: call multifd_send_sync_main when sending RAM_SAVE_FLAG_EOS Juan Quintela 2019-07-12 14:31 ` [Qemu-devel] " Juan Quintela 2019-07-12 14:31 ` [PULL 05/19] migration/xbzrle: update cache and current_data in one place Juan Quintela 2019-07-12 14:31 ` [Qemu-devel] " Juan Quintela 2019-07-12 14:31 ` [PULL 06/19] cutils: remove one unnecessary pointer operation Juan Quintela 2019-07-12 14:31 ` [Qemu-devel] " Juan Quintela 2019-07-12 14:31 ` [PULL 07/19] migration/multifd: sync packet_num after all thread are done Juan Quintela 2019-07-12 14:31 ` [Qemu-devel] " Juan Quintela 2019-07-12 14:31 ` [PULL 08/19] migration/ram.c: reset complete_round when we gets a queued page Juan Quintela 2019-07-12 14:31 ` [Qemu-devel] " Juan Quintela 2019-07-12 14:31 ` [PULL 09/19] migration: No need to take rcu during sync_dirty_bitmap Juan Quintela 2019-07-12 14:31 ` [Qemu-devel] " Juan Quintela 2019-07-12 14:31 ` [PULL 10/19] memory: Don't set migration bitmap when without migration Juan Quintela 2019-07-12 14:31 ` [Qemu-devel] " Juan Quintela 2019-07-12 14:31 ` [PULL 11/19] bitmap: Add bitmap_copy_with_{src|dst}_offset() Juan Quintela 2019-07-12 14:31 ` [Qemu-devel] " Juan Quintela 2019-07-12 14:32 ` [PULL 12/19] memory: Pass mr into snapshot_and_clear_dirty Juan Quintela 2019-07-12 14:32 ` [Qemu-devel] " Juan Quintela 2019-07-12 14:32 ` [PULL 13/19] memory: Introduce memory listener hook log_clear() Juan Quintela 2019-07-12 14:32 ` [Qemu-devel] " Juan Quintela 2019-07-12 14:32 ` [PULL 14/19] kvm: Update comments for sync_dirty_bitmap Juan Quintela 2019-07-12 14:32 ` [Qemu-devel] " Juan Quintela 2019-07-12 14:32 ` Juan Quintela [this message] 2019-07-12 14:32 ` [Qemu-devel] [PULL 15/19] kvm: Persistent per kvmslot dirty bitmap Juan Quintela 2019-07-12 14:32 ` [PULL 16/19] kvm: Introduce slots lock for memory listener Juan Quintela 2019-07-12 14:32 ` [Qemu-devel] " Juan Quintela 2019-07-12 14:32 ` [PULL 17/19] kvm: Support KVM_CLEAR_DIRTY_LOG Juan Quintela 2019-07-12 14:32 ` [Qemu-devel] " Juan Quintela 2019-07-12 14:32 ` [PULL 18/19] migration: Split log_clear() into smaller chunks Juan Quintela 2019-07-12 14:32 ` [Qemu-devel] " Juan Quintela 2019-07-12 14:32 ` [PULL 19/19] migration: allow private destination ram with x-ignore-shared Juan Quintela 2019-07-12 14:32 ` [Qemu-devel] " Juan Quintela 2019-07-12 16:33 ` [Qemu-devel] [PULL 00/19] Migration patches Peter Maydell 2019-07-12 16:33 ` Peter Maydell 2019-07-12 17:54 ` Dr. David Alan Gilbert 2019-07-12 17:54 ` Dr. David Alan Gilbert 2019-07-15 11:16 ` Peter Maydell 2019-07-15 11:16 ` Peter Maydell 2019-07-15 13:44 ` Juan Quintela 2019-07-15 13:44 ` [Qemu-devel] " Juan Quintela 2019-07-15 13:48 ` Peter Maydell 2019-07-15 13:48 ` [Qemu-devel] " Peter Maydell 2019-07-15 14:10 ` Juan Quintela 2019-07-15 14:10 ` [Qemu-devel] " Juan Quintela 2019-07-15 14:15 ` Peter Maydell 2019-07-15 14:15 ` [Qemu-devel] " Peter Maydell 2019-07-15 14:04 ` Daniel P. Berrangé 2019-07-15 14:04 ` Daniel P. Berrangé 2019-07-15 14:17 ` Peter Maydell 2019-07-15 14:17 ` Peter Maydell -- strict thread matches above, loose matches on Subject: below -- 2019-07-11 10:43 Juan Quintela 2019-07-11 10:44 ` [PULL 15/19] kvm: Persistent per kvmslot dirty bitmap Juan Quintela
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190712143207.4214-16-quintela@redhat.com \ --to=quintela@redhat.com \ --cc=dgilbert@redhat.com \ --cc=kvm@vger.kernel.org \ --cc=lvivier@redhat.com \ --cc=pbonzini@redhat.com \ --cc=peterx@redhat.com \ --cc=qemu-devel@nongnu.org \ --cc=rth@twiddle.net \ --cc=thuth@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.