From: Aleksa Sarai <cyphar@cyphar.com>
To: shuah <shuah@kernel.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Jeff Layton <jlayton@kernel.org>,
"J. Bruce Fields" <bfields@fieldses.org>,
Arnd Bergmann <arnd@arndb.de>,
David Howells <dhowells@redhat.com>,
Shuah Khan <skhan@linuxfoundation.org>,
Eric Biederman <ebiederm@xmission.com>,
Andy Lutomirski <luto@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Alexei Starovoitov <ast@kernel.org>,
Kees Cook <keescook@chromium.org>, Jann Horn <jannh@google.com>,
Christian Brauner <christian@brauner.io>,
Tycho Andersen <tycho@tycho.ws>,
David Drysdale <drysdale@google.com>,
Chanho Min <chanho.min@lge.com>, Oleg Nesterov <oleg@redhat.com>,
Aleksa Sarai <asarai@suse.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
containers@lists.linux-foundation.org, linux-alpha@vger
Subject: Re: [PATCH v10 8/9] kselftest: save-and-restore errno to allow for %m formatting
Date: Sat, 20 Jul 2019 00:09:30 +0000 [thread overview]
Message-ID: <20190720000930.g3jyjupgimptuubl@yavin> (raw)
In-Reply-To: <b32d95a1-8a49-65ef-4ddd-fe86a7ca01d5@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 822 bytes --]
On 2019-07-19, shuah <shuah@kernel.org> wrote:
> On 7/19/19 10:42 AM, Aleksa Sarai wrote:
> > Previously, using "%m" in a ksft_* format string can result in strange
> > output because the errno value wasn't saved before calling other libc
> > functions. The solution is to simply save and restore the errno before
> > we format the user-supplied format string.
> >
> > Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
> [...]
> Hi Aleksa,
>
> Can you send this patch separate from the patch series. I will apply
> this as bug fix to 5.3-rc2 or rc3.
>
> This isn't part of this series anyway and I would like to get this in
> right away.
Done, and I'll drop it in v11 after the rest gets reviewed.
--
Aleksa Sarai
Senior Software Engineer (Containers)
SUSE Linux GmbH
<https://www.cyphar.com/>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Aleksa Sarai <cyphar@cyphar.com>
To: shuah <shuah@kernel.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Jeff Layton <jlayton@kernel.org>,
"J. Bruce Fields" <bfields@fieldses.org>,
Arnd Bergmann <arnd@arndb.de>,
David Howells <dhowells@redhat.com>,
Shuah Khan <skhan@linuxfoundation.org>,
Eric Biederman <ebiederm@xmission.com>,
Andy Lutomirski <luto@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Alexei Starovoitov <ast@kernel.org>,
Kees Cook <keescook@chromium.org>, Jann Horn <jannh@google.com>,
Christian Brauner <christian@brauner.io>,
Tycho Andersen <tycho@tycho.ws>,
David Drysdale <drysdale@google.com>,
Chanho Min <chanho.min@lge.com>, Oleg Nesterov <oleg@redhat.com>,
Aleksa Sarai <asarai@suse.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
containers@lists.linux-foundation.org,
linux-alpha@vger.kernel.org, linux-api@vger.kernel.org,
linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-fsdevel@vger.kernel.org, linux-ia64@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-s390@vger.kernel.org, linux-sh@vger.kernel.org,
linux-xtensa@linux-xtensa.org, sparclinux@vger.kernel.org
Subject: Re: [PATCH v10 8/9] kselftest: save-and-restore errno to allow for %m formatting
Date: Sat, 20 Jul 2019 10:09:30 +1000 [thread overview]
Message-ID: <20190720000930.g3jyjupgimptuubl@yavin> (raw)
In-Reply-To: <b32d95a1-8a49-65ef-4ddd-fe86a7ca01d5@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 822 bytes --]
On 2019-07-19, shuah <shuah@kernel.org> wrote:
> On 7/19/19 10:42 AM, Aleksa Sarai wrote:
> > Previously, using "%m" in a ksft_* format string can result in strange
> > output because the errno value wasn't saved before calling other libc
> > functions. The solution is to simply save and restore the errno before
> > we format the user-supplied format string.
> >
> > Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
> [...]
> Hi Aleksa,
>
> Can you send this patch separate from the patch series. I will apply
> this as bug fix to 5.3-rc2 or rc3.
>
> This isn't part of this series anyway and I would like to get this in
> right away.
Done, and I'll drop it in v11 after the rest gets reviewed.
--
Aleksa Sarai
Senior Software Engineer (Containers)
SUSE Linux GmbH
<https://www.cyphar.com/>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Aleksa Sarai <cyphar@cyphar.com>
To: shuah <shuah@kernel.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Jeff Layton <jlayton@kernel.org>,
"J. Bruce Fields" <bfields@fieldses.org>,
Arnd Bergmann <arnd@arndb.de>,
David Howells <dhowells@redhat.com>,
Shuah Khan <skhan@linuxfoundation.org>,
Eric Biederman <ebiederm@xmission.com>,
Andy Lutomirski <luto@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Alexei Starovoitov <ast@kernel.org>,
Kees Cook <keescook@chromium.org>, Jann Horn <jannh@google.com>,
Christian Brauner <christian@brauner.io>,
Tycho Andersen <tycho@tycho.ws>,
David Drysdale <drysdale@google.com>,
Chanho Min <chanho.min@lge.com>, Oleg Nesterov <oleg@redhat.com>,
Aleksa Sarai <asarai@suse.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
containers@lists.linux-foundation.org, linux-alpha@vger
Subject: Re: [PATCH v10 8/9] kselftest: save-and-restore errno to allow for %m formatting
Date: Sat, 20 Jul 2019 10:09:30 +1000 [thread overview]
Message-ID: <20190720000930.g3jyjupgimptuubl@yavin> (raw)
In-Reply-To: <b32d95a1-8a49-65ef-4ddd-fe86a7ca01d5@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 822 bytes --]
On 2019-07-19, shuah <shuah@kernel.org> wrote:
> On 7/19/19 10:42 AM, Aleksa Sarai wrote:
> > Previously, using "%m" in a ksft_* format string can result in strange
> > output because the errno value wasn't saved before calling other libc
> > functions. The solution is to simply save and restore the errno before
> > we format the user-supplied format string.
> >
> > Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
> [...]
> Hi Aleksa,
>
> Can you send this patch separate from the patch series. I will apply
> this as bug fix to 5.3-rc2 or rc3.
>
> This isn't part of this series anyway and I would like to get this in
> right away.
Done, and I'll drop it in v11 after the rest gets reviewed.
--
Aleksa Sarai
Senior Software Engineer (Containers)
SUSE Linux GmbH
<https://www.cyphar.com/>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Aleksa Sarai <cyphar@cyphar.com>
To: shuah <shuah@kernel.org>
Cc: linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org,
Alexei Starovoitov <ast@kernel.org>,
linux-kernel@vger.kernel.org, David Howells <dhowells@redhat.com>,
linux-kselftest@vger.kernel.org, sparclinux@vger.kernel.org,
linux-arch@vger.kernel.org, linux-s390@vger.kernel.org,
Tycho Andersen <tycho@tycho.ws>, Aleksa Sarai <asarai@suse.de>,
linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
linux-xtensa@linux-xtensa.org, Kees Cook <keescook@chromium.org>,
Arnd Bergmann <arnd@arndb.de>, Jann Horn <jannh@google.com>,
linuxppc-dev@lists.ozlabs.org, linux-m68k@lists.linux-m68k.org,
Al Viro <viro@zeniv.linux.org.uk>,
Andy Lutomirski <luto@kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>,
David Drysdale <drysdale@google.com>,
Christian Brauner <christian@brauner.io>,
"J. Bruce Fields" <bfields@fieldses.org>,
linux-parisc@vger.kernel.org, linux-api@vger.kernel.org,
Chanho Min <chanho.min@lge.com>, Jeff Layton <jlayton@kernel.org>,
Oleg Nesterov <oleg@redhat.com>,
Eric Biederman <ebiederm@xmission.com>,
linux-alpha@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
containers@lists.linux-foundation.org
Subject: Re: [PATCH v10 8/9] kselftest: save-and-restore errno to allow for %m formatting
Date: Sat, 20 Jul 2019 10:09:30 +1000 [thread overview]
Message-ID: <20190720000930.g3jyjupgimptuubl@yavin> (raw)
In-Reply-To: <b32d95a1-8a49-65ef-4ddd-fe86a7ca01d5@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 822 bytes --]
On 2019-07-19, shuah <shuah@kernel.org> wrote:
> On 7/19/19 10:42 AM, Aleksa Sarai wrote:
> > Previously, using "%m" in a ksft_* format string can result in strange
> > output because the errno value wasn't saved before calling other libc
> > functions. The solution is to simply save and restore the errno before
> > we format the user-supplied format string.
> >
> > Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
> [...]
> Hi Aleksa,
>
> Can you send this patch separate from the patch series. I will apply
> this as bug fix to 5.3-rc2 or rc3.
>
> This isn't part of this series anyway and I would like to get this in
> right away.
Done, and I'll drop it in v11 after the rest gets reviewed.
--
Aleksa Sarai
Senior Software Engineer (Containers)
SUSE Linux GmbH
<https://www.cyphar.com/>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Aleksa Sarai <cyphar@cyphar.com>
To: shuah <shuah@kernel.org>
Cc: linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org,
Alexei Starovoitov <ast@kernel.org>,
linux-kernel@vger.kernel.org, David Howells <dhowells@redhat.com>,
linux-kselftest@vger.kernel.org, sparclinux@vger.kernel.org,
linux-arch@vger.kernel.org, linux-s390@vger.kernel.org,
Tycho Andersen <tycho@tycho.ws>, Aleksa Sarai <asarai@suse.de>,
linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
linux-xtensa@linux-xtensa.org, Kees Cook <keescook@chromium.org>,
Arnd Bergmann <arnd@arndb.de>, Jann Horn <jannh@google.com>,
linuxppc-dev@lists.ozlabs.org, linux-m68k@lists.linux-m68k.org,
Al Viro <viro@zeniv.linux.org.uk>,
Andy Lutomirski <luto@kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>,
David Drysdale <drysdale@google.com>,
Christian Brauner <christian@brauner.io>,
"J. Bruce Fields" <bfields@fieldses.org>,
linux-parisc@vger.kernel.org, linux-api@vger.kernel.org,
Chanho Min <chanho.min@lge.com>, Jeff Layton <jlayton@kernel.org>,
Oleg Nesterov <oleg@redhat.com>,
Eric Biederman <ebiederm@xmission.com>,
linux-alpha@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
containers@lists.linux-foundation.org
Subject: Re: [PATCH v10 8/9] kselftest: save-and-restore errno to allow for %m formatting
Date: Sat, 20 Jul 2019 10:09:30 +1000 [thread overview]
Message-ID: <20190720000930.g3jyjupgimptuubl@yavin> (raw)
In-Reply-To: <b32d95a1-8a49-65ef-4ddd-fe86a7ca01d5@kernel.org>
[-- Attachment #1.1: Type: text/plain, Size: 822 bytes --]
On 2019-07-19, shuah <shuah@kernel.org> wrote:
> On 7/19/19 10:42 AM, Aleksa Sarai wrote:
> > Previously, using "%m" in a ksft_* format string can result in strange
> > output because the errno value wasn't saved before calling other libc
> > functions. The solution is to simply save and restore the errno before
> > we format the user-supplied format string.
> >
> > Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
> [...]
> Hi Aleksa,
>
> Can you send this patch separate from the patch series. I will apply
> this as bug fix to 5.3-rc2 or rc3.
>
> This isn't part of this series anyway and I would like to get this in
> right away.
Done, and I'll drop it in v11 after the rest gets reviewed.
--
Aleksa Sarai
Senior Software Engineer (Containers)
SUSE Linux GmbH
<https://www.cyphar.com/>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-20 0:09 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 16:42 [PATCH v10 0/9] namei: openat2(2) path resolution restrictions Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` [PATCH v10 1/9] namei: obey trailing magic-link DAC permissions Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` [PATCH v10 2/9] procfs: switch magic-link modes to be more sane Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` [PATCH v10 3/9] open: O_EMPTYPATH: procfs-less file descriptor re-opening Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` [PATCH v10 4/9] namei: O_BENEATH-style path resolution flags Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` [PATCH v10 5/9] namei: LOOKUP_IN_ROOT: chroot-like path resolution Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` [PATCH v10 6/9] namei: aggressively check for nd->root escape on ".." resolution Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` [PATCH v10 7/9] open: openat2(2) syscall Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` [PATCH v10 8/9] kselftest: save-and-restore errno to allow for %m formatting Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 22:25 ` shuah
2019-07-19 22:25 ` shuah
2019-07-19 22:25 ` shuah
2019-07-19 22:25 ` shuah
2019-07-19 22:25 ` shuah
2019-07-20 0:03 ` [PATCH] " Aleksa Sarai
2019-07-20 0:09 ` Aleksa Sarai [this message]
2019-07-20 0:09 ` [PATCH v10 8/9] " Aleksa Sarai
2019-07-20 0:09 ` Aleksa Sarai
2019-07-20 0:09 ` Aleksa Sarai
2019-07-20 0:09 ` Aleksa Sarai
2019-07-19 16:42 ` [PATCH v10 9/9] selftests: add openat2(2) selftests Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
2019-07-19 16:42 ` Aleksa Sarai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190720000930.g3jyjupgimptuubl@yavin \
--to=cyphar@cyphar.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=asarai@suse.de \
--cc=ast@kernel.org \
--cc=bfields@fieldses.org \
--cc=chanho.min@lge.com \
--cc=christian@brauner.io \
--cc=containers@lists.linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=drysdale@google.com \
--cc=ebiederm@xmission.com \
--cc=jannh@google.com \
--cc=jlayton@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-alpha@vger \
--cc=luto@kernel.org \
--cc=oleg@redhat.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=torvalds@linux-foundation.org \
--cc=tycho@tycho.ws \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.