From: Gao Xiang <gaoxiang25@huawei.com> To: Alexander Viro <viro@zeniv.linux.org.uk>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Andrew Morton <akpm@linux-foundation.org>, Stephen Rothwell <sfr@canb.auug.org.au>, Theodore Ts'o <tytso@mit.edu>, "Linus Torvalds" <torvalds@linux-foundation.org> Cc: <linux-fsdevel@vger.kernel.org>, <devel@driverdev.osuosl.org>, LKML <linux-kernel@vger.kernel.org>, <linux-erofs@lists.ozlabs.org>, Chao Yu <yuchao0@huawei.com>, Miao Xie <miaoxie@huawei.com>, Li Guifu <bluce.liguifu@huawei.com>, Fang Wei <fangwei1@huawei.com>, Gao Xiang <gaoxiang25@huawei.com> Subject: [PATCH v3 19/24] erofs: add erofs_allocpage() Date: Mon, 22 Jul 2019 10:50:38 +0800 [thread overview] Message-ID: <20190722025043.166344-20-gaoxiang25@huawei.com> (raw) In-Reply-To: <20190722025043.166344-1-gaoxiang25@huawei.com> This patch introduces an temporary _on-stack_ page pool to reuse the freed page directly as much as it can for better performance and release all pages at a time, it also slightly reduces the possibility of the potential memory allocation failure. Signed-off-by: Gao Xiang <gaoxiang25@huawei.com> --- fs/erofs/internal.h | 2 ++ fs/erofs/utils.c | 14 ++++++++++++++ 2 files changed, 16 insertions(+) diff --git a/fs/erofs/internal.h b/fs/erofs/internal.h index dc5c6c5e4885..506a68efe507 100644 --- a/fs/erofs/internal.h +++ b/fs/erofs/internal.h @@ -495,6 +495,8 @@ int erofs_namei(struct inode *dir, struct qstr *name, extern const struct file_operations erofs_dir_fops; /* utils.c */ +struct page *erofs_allocpage(struct list_head *pool, gfp_t gfp, bool nofail); + #if (EROFS_PCPUBUF_NR_PAGES > 0) void *erofs_get_pcpubuf(unsigned int pagenr); #define erofs_put_pcpubuf(buf) do { \ diff --git a/fs/erofs/utils.c b/fs/erofs/utils.c index c430790a02e0..53ee6daa3f70 100644 --- a/fs/erofs/utils.c +++ b/fs/erofs/utils.c @@ -9,6 +9,20 @@ #include "internal.h" #include <linux/pagevec.h> +struct page *erofs_allocpage(struct list_head *pool, gfp_t gfp, bool nofail) +{ + struct page *page; + + if (!list_empty(pool)) { + page = lru_to_page(pool); + DBG_BUGON(page_ref_count(page) != 1); + list_del(&page->lru); + } else { + page = alloc_pages(gfp | (nofail ? __GFP_NOFAIL : 0), 0); + } + return page; +} + #if (EROFS_PCPUBUF_NR_PAGES > 0) static struct { u8 data[PAGE_SIZE * EROFS_PCPUBUF_NR_PAGES]; -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: gaoxiang25@huawei.com (Gao Xiang) Subject: [PATCH v3 19/24] erofs: add erofs_allocpage() Date: Mon, 22 Jul 2019 10:50:38 +0800 [thread overview] Message-ID: <20190722025043.166344-20-gaoxiang25@huawei.com> (raw) In-Reply-To: <20190722025043.166344-1-gaoxiang25@huawei.com> This patch introduces an temporary _on-stack_ page pool to reuse the freed page directly as much as it can for better performance and release all pages at a time, it also slightly reduces the possibility of the potential memory allocation failure. Signed-off-by: Gao Xiang <gaoxiang25 at huawei.com> --- fs/erofs/internal.h | 2 ++ fs/erofs/utils.c | 14 ++++++++++++++ 2 files changed, 16 insertions(+) diff --git a/fs/erofs/internal.h b/fs/erofs/internal.h index dc5c6c5e4885..506a68efe507 100644 --- a/fs/erofs/internal.h +++ b/fs/erofs/internal.h @@ -495,6 +495,8 @@ int erofs_namei(struct inode *dir, struct qstr *name, extern const struct file_operations erofs_dir_fops; /* utils.c */ +struct page *erofs_allocpage(struct list_head *pool, gfp_t gfp, bool nofail); + #if (EROFS_PCPUBUF_NR_PAGES > 0) void *erofs_get_pcpubuf(unsigned int pagenr); #define erofs_put_pcpubuf(buf) do { \ diff --git a/fs/erofs/utils.c b/fs/erofs/utils.c index c430790a02e0..53ee6daa3f70 100644 --- a/fs/erofs/utils.c +++ b/fs/erofs/utils.c @@ -9,6 +9,20 @@ #include "internal.h" #include <linux/pagevec.h> +struct page *erofs_allocpage(struct list_head *pool, gfp_t gfp, bool nofail) +{ + struct page *page; + + if (!list_empty(pool)) { + page = lru_to_page(pool); + DBG_BUGON(page_ref_count(page) != 1); + list_del(&page->lru); + } else { + page = alloc_pages(gfp | (nofail ? __GFP_NOFAIL : 0), 0); + } + return page; +} + #if (EROFS_PCPUBUF_NR_PAGES > 0) static struct { u8 data[PAGE_SIZE * EROFS_PCPUBUF_NR_PAGES]; -- 2.17.1
next prev parent reply other threads:[~2019-07-22 2:51 UTC|newest] Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-22 2:50 [PATCH v3 00/24] erofs: promote erofs from staging Gao Xiang 2019-07-22 2:50 ` Gao Xiang 2019-07-22 2:50 ` [PATCH v3 01/24] erofs: add on-disk layout Gao Xiang 2019-07-22 2:50 ` Gao Xiang 2019-07-22 2:50 ` Gao Xiang 2019-07-22 3:26 ` Stephen Rothwell 2019-07-22 3:26 ` Stephen Rothwell 2019-07-22 3:26 ` Stephen Rothwell 2019-07-22 3:29 ` Gao Xiang 2019-07-22 3:29 ` Gao Xiang 2019-07-22 5:05 ` Greg Kroah-Hartman 2019-07-22 5:05 ` Greg Kroah-Hartman 2019-07-22 5:24 ` Gao Xiang 2019-07-22 5:24 ` Gao Xiang 2019-07-22 2:50 ` [PATCH v3 02/24] erofs: add erofs in-memory stuffs Gao Xiang 2019-07-22 2:50 ` Gao Xiang 2019-07-22 2:50 ` [PATCH v3 03/24] erofs: add super block operations Gao Xiang 2019-07-22 2:50 ` Gao Xiang 2019-07-22 2:50 ` [PATCH v3 04/24] erofs: add raw address_space operations Gao Xiang 2019-07-22 2:50 ` Gao Xiang 2019-07-22 2:50 ` [PATCH v3 05/24] erofs: add inode operations Gao Xiang 2019-07-22 2:50 ` Gao Xiang 2019-07-22 2:50 ` [PATCH v3 06/24] erofs: support special inode Gao Xiang 2019-07-22 2:50 ` Gao Xiang 2019-07-22 2:50 ` [PATCH v3 07/24] erofs: add directory operations Gao Xiang 2019-07-22 2:50 ` Gao Xiang 2019-07-22 2:50 ` [PATCH v3 08/24] erofs: add namei functions Gao Xiang 2019-07-22 2:50 ` Gao Xiang 2019-07-22 2:50 ` [PATCH v3 09/24] erofs: support tracepoint Gao Xiang 2019-07-22 2:50 ` Gao Xiang 2019-07-22 2:50 ` [PATCH v3 10/24] erofs: update Kconfig and Makefile Gao Xiang 2019-07-22 2:50 ` Gao Xiang 2019-07-22 2:50 ` [PATCH v3 11/24] erofs: introduce xattr & posixacl support Gao Xiang 2019-07-22 2:50 ` Gao Xiang 2019-07-22 2:50 ` [PATCH v3 12/24] erofs: introduce tagged pointer Gao Xiang 2019-07-22 2:50 ` Gao Xiang 2019-07-22 4:39 ` Amir Goldstein 2019-07-22 4:39 ` Amir Goldstein 2019-07-22 5:01 ` Gao Xiang 2019-07-22 5:01 ` Gao Xiang 2019-07-22 6:16 ` Amir Goldstein 2019-07-22 6:16 ` Amir Goldstein 2019-07-22 6:31 ` Gao Xiang 2019-07-22 6:31 ` Gao Xiang 2019-07-22 14:40 ` Steven Rostedt 2019-07-22 14:40 ` Steven Rostedt 2019-07-22 15:33 ` Gao Xiang 2019-07-22 15:33 ` Gao Xiang 2019-07-22 16:35 ` Steven Rostedt 2019-07-22 16:35 ` Steven Rostedt 2019-07-22 16:52 ` Gao Xiang 2019-07-22 16:52 ` Gao Xiang 2019-07-22 2:50 ` [PATCH v3 13/24] erofs: add compression indexes support Gao Xiang 2019-07-22 2:50 ` Gao Xiang 2019-07-22 2:50 ` [PATCH v3 14/24] erofs: introduce superblock registration Gao Xiang 2019-07-22 2:50 ` Gao Xiang 2019-07-22 2:50 ` [PATCH v3 15/24] erofs: introduce erofs shrinker Gao Xiang 2019-07-22 2:50 ` Gao Xiang 2019-07-22 2:50 ` [PATCH v3 16/24] erofs: introduce workstation for decompression Gao Xiang 2019-07-22 2:50 ` Gao Xiang 2019-07-22 2:50 ` [PATCH v3 17/24] erofs: introduce per-CPU buffers implementation Gao Xiang 2019-07-22 2:50 ` Gao Xiang 2019-07-22 2:50 ` [PATCH v3 18/24] erofs: introduce pagevec for decompression subsystem Gao Xiang 2019-07-22 2:50 ` Gao Xiang 2019-07-22 2:50 ` Gao Xiang [this message] 2019-07-22 2:50 ` [PATCH v3 19/24] erofs: add erofs_allocpage() Gao Xiang 2019-07-22 2:50 ` [PATCH v3 20/24] erofs: introduce generic decompression backend Gao Xiang 2019-07-22 2:50 ` Gao Xiang 2019-07-22 2:50 ` [PATCH v3 21/24] erofs: introduce LZ4 decompression inplace Gao Xiang 2019-07-22 2:50 ` Gao Xiang 2019-07-22 2:50 ` [PATCH v3 22/24] erofs: introduce the decompression frontend Gao Xiang 2019-07-22 2:50 ` Gao Xiang 2019-07-22 2:50 ` [PATCH v3 23/24] erofs: introduce cached decompression Gao Xiang 2019-07-22 2:50 ` Gao Xiang 2019-07-22 10:18 ` David Sterba 2019-07-22 10:18 ` David Sterba 2019-07-22 10:58 ` Gao Xiang 2019-07-22 10:58 ` Gao Xiang 2019-07-22 13:25 ` Theodore Y. Ts'o 2019-07-22 13:25 ` Theodore Y. Ts'o 2019-07-22 14:16 ` Gao Xiang 2019-07-22 14:16 ` Gao Xiang 2019-07-22 15:12 ` Theodore Y. Ts'o 2019-07-22 15:12 ` Theodore Y. Ts'o 2019-07-22 16:27 ` Gao Xiang 2019-07-22 16:27 ` Gao Xiang 2019-07-23 12:31 ` David Sterba 2019-07-23 12:31 ` David Sterba 2019-07-23 13:30 ` Gao Xiang 2019-07-23 13:30 ` Gao Xiang 2019-07-22 2:50 ` [PATCH v3 24/24] erofs: add document Gao Xiang 2019-07-22 2:50 ` Gao Xiang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190722025043.166344-20-gaoxiang25@huawei.com \ --to=gaoxiang25@huawei.com \ --cc=akpm@linux-foundation.org \ --cc=bluce.liguifu@huawei.com \ --cc=devel@driverdev.osuosl.org \ --cc=fangwei1@huawei.com \ --cc=gregkh@linuxfoundation.org \ --cc=linux-erofs@lists.ozlabs.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=miaoxie@huawei.com \ --cc=sfr@canb.auug.org.au \ --cc=torvalds@linux-foundation.org \ --cc=tytso@mit.edu \ --cc=viro@zeniv.linux.org.uk \ --cc=yuchao0@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.