From: Jason Gunthorpe <jgg@ziepe.ca>
To: Selvin Xavier <selvin.xavier@broadcom.com>
Cc: linux-rdma@vger.kernel.org, dledford@redhat.com,
linux-nvme@lists.infradead.org, stable@vger.kernel.org,
Parav Pandit <parav@mellanox.com>
Subject: Re: [PATCH for-rc] RDMA/bnxt_re: Honor vlan_id in GID entry comparison
Date: Mon, 22 Jul 2019 15:07:46 -0300 [thread overview]
Message-ID: <20190722180746.GA9441@ziepe.ca> (raw)
In-Reply-To: <20190715091913.15726-1-selvin.xavier@broadcom.com>
On Mon, Jul 15, 2019 at 05:19:13AM -0400, Selvin Xavier wrote:
> GID entry consist of GID, vlan, netdev and smac.
> Extend GID duplicate check companions to consider vlan_id as well
> to support IPv6 VLAN based link local addresses. Introduce
> a new structure (bnxt_qplib_gid_info) to hold gid and vlan_id information.
>
> The issue is discussed in the following thread
> https://www.spinics.net/lists/linux-rdma/msg81594.html
>
> Fixes: 823b23da7113 ("IB/core: Allow vlan link local address based RoCE GIDs")
> Cc: <stable@vger.kernel.org> # v5.2+
> Reported-by: Yi Zhang <yi.zhang@redhat.com>
> Co-developed-by: Parav Pandit <parav@mellanox.com>
> Signed-off-by: Parav Pandit <parav@mellanox.com>
> Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com>
> Tested-by: Yi Zhang <yi.zhang@redhat.com>
> Reviewed-By: Leon R...
> Tested-by: Leon R...
> ---
> drivers/infiniband/hw/bnxt_re/ib_verbs.c | 7 +++++--
> drivers/infiniband/hw/bnxt_re/qplib_res.c | 13 +++++++++----
> drivers/infiniband/hw/bnxt_re/qplib_res.h | 2 +-
> drivers/infiniband/hw/bnxt_re/qplib_sp.c | 14 +++++++++-----
> drivers/infiniband/hw/bnxt_re/qplib_sp.h | 7 ++++++-
> 5 files changed, 30 insertions(+), 13 deletions(-)
Applied to for-rc, thanks
Please also fix that sketchy use of the gid_index
Jason
WARNING: multiple messages have this Message-ID (diff)
From: jgg@ziepe.ca (Jason Gunthorpe)
Subject: [PATCH for-rc] RDMA/bnxt_re: Honor vlan_id in GID entry comparison
Date: Mon, 22 Jul 2019 15:07:46 -0300 [thread overview]
Message-ID: <20190722180746.GA9441@ziepe.ca> (raw)
In-Reply-To: <20190715091913.15726-1-selvin.xavier@broadcom.com>
On Mon, Jul 15, 2019@05:19:13AM -0400, Selvin Xavier wrote:
> GID entry consist of GID, vlan, netdev and smac.
> Extend GID duplicate check companions to consider vlan_id as well
> to support IPv6 VLAN based link local addresses. Introduce
> a new structure (bnxt_qplib_gid_info) to hold gid and vlan_id information.
>
> The issue is discussed in the following thread
> https://www.spinics.net/lists/linux-rdma/msg81594.html
>
> Fixes: 823b23da7113 ("IB/core: Allow vlan link local address based RoCE GIDs")
> Cc: <stable at vger.kernel.org> # v5.2+
> Reported-by: Yi Zhang <yi.zhang at redhat.com>
> Co-developed-by: Parav Pandit <parav at mellanox.com>
> Signed-off-by: Parav Pandit <parav at mellanox.com>
> Signed-off-by: Selvin Xavier <selvin.xavier at broadcom.com>
> Tested-by: Yi Zhang <yi.zhang at redhat.com>
> Reviewed-By: Leon R...
> Tested-by: Leon R...
> ---
> drivers/infiniband/hw/bnxt_re/ib_verbs.c | 7 +++++--
> drivers/infiniband/hw/bnxt_re/qplib_res.c | 13 +++++++++----
> drivers/infiniband/hw/bnxt_re/qplib_res.h | 2 +-
> drivers/infiniband/hw/bnxt_re/qplib_sp.c | 14 +++++++++-----
> drivers/infiniband/hw/bnxt_re/qplib_sp.h | 7 ++++++-
> 5 files changed, 30 insertions(+), 13 deletions(-)
Applied to for-rc, thanks
Please also fix that sketchy use of the gid_index
Jason
next prev parent reply other threads:[~2019-07-22 18:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 9:19 [PATCH for-rc] RDMA/bnxt_re: Honor vlan_id in GID entry comparison Selvin Xavier
2019-07-15 9:19 ` Selvin Xavier
2019-07-15 14:17 ` Yi Zhang
2019-07-15 14:17 ` Yi Zhang
2019-07-16 7:10 ` Leon Romanovsky
2019-07-16 7:10 ` Leon Romanovsky
2019-07-16 7:16 ` Greg KH
2019-07-16 7:16 ` Greg KH
2019-07-16 8:41 ` Leon Romanovsky
2019-07-16 8:41 ` Leon Romanovsky
2019-07-16 9:09 ` Greg KH
2019-07-16 9:09 ` Greg KH
2019-07-16 9:50 ` Leon Romanovsky
2019-07-16 9:50 ` Leon Romanovsky
2019-07-16 9:58 ` Greg KH
2019-07-16 9:58 ` Greg KH
2019-07-16 10:20 ` Leon Romanovsky
2019-07-16 10:20 ` Leon Romanovsky
2019-07-22 18:07 ` Jason Gunthorpe [this message]
2019-07-22 18:07 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190722180746.GA9441@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=dledford@redhat.com \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-rdma@vger.kernel.org \
--cc=parav@mellanox.com \
--cc=selvin.xavier@broadcom.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.