All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Manish Narani <manish.narani@xilinx.com>
Cc: ulf.hansson@linaro.org, mark.rutland@arm.com, heiko@sntech.de,
	michal.simek@xilinx.com, adrian.hunter@intel.com,
	christoph.muellner@theobroma-systems.com,
	philipp.tomsich@theobroma-systems.com, viresh.kumar@linaro.org,
	scott.branden@broadcom.com, ayaka@soulik.info, kernel@esmil.dk,
	tony.xie@rock-chips.com, rajan.vaja@xilinx.com,
	jolly.shah@xilinx.com, nava.manne@xilinx.com, mdf@kernel.org,
	olof@lixom.net, linux-mmc@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v2 07/11] dt-bindings: mmc: arasan: Add optional properties for Arasan SDHCI
Date: Mon, 22 Jul 2019 16:01:34 -0600	[thread overview]
Message-ID: <20190722220134.GA8281@bogus> (raw)
In-Reply-To: <1561958991-21935-8-git-send-email-manish.narani@xilinx.com>

On Mon, Jul 01, 2019 at 10:59:47AM +0530, Manish Narani wrote:
> Add optional propeties for Arasan SDHCI which are used to set clk delays
> for different speed modes in the controller.
> 
> Signed-off-by: Manish Narani <manish.narani@xilinx.com>
> ---
>  Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> index 7c79496..7425d52 100644
> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> @@ -49,6 +49,21 @@ Optional Properties:
>      properly. Test mode can be used to force the controller to function.
>    - xlnx,int-clock-stable-broken: when present, the controller always reports
>      that the internal clock is stable even when it is not.
> +  - clk-phase-legacy: Input/Output Clock Delay pair in degrees for Legacy Mode.
> +  - clk-phase-mmc-hs: Input/Output Clock Delay pair degrees for MMC HS.
> +  - clk-phase-sd-hs: Input/Output Clock Delay pair in degrees for SD HS.
> +  - clk-phase-uhs-sdr12: Input/Output Clock Delay pair in degrees for SDR12.
> +  - clk-phase-uhs-sdr25: Input/Output Clock Delay pair in degrees for SDR25.
> +  - clk-phase-uhs-sdr50: Input/Output Clock Delay pair in degrees for SDR50.
> +  - clk-phase-uhs-sdr104: Input/Output Clock Delay pair in degrees for SDR104.
> +  - clk-phase-uhs-ddr50: Input/Output Clock Delay pair in degrees for SD DDR50.
> +  - clk-phase-mmc-ddr52: Input/Output Clock Delay pair in degrees for MMC DDR52.
> +  - clk-phase-mmc-hs200: Input/Output Clock Delay pair in degrees for MMC HS200.
> +  - clk-phase-mmc-hs400: Input/Output Clock Delay pair in degrees for MMC HS400.

Either these need vendor prefixes or be added as common properties if 
that makes sense.

Rob

> +
> +  Above mentioned are the clock (phase) delays which are to be configured in the
> +  controller while switching to particular speed mode. If not specified, driver
> +  will configure the default value defined for particular mode in it.
>  
>  Example:
>  	sdhci@e0100000 {
> -- 
> 2.1.1
> 

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Manish Narani <manish.narani@xilinx.com>
Cc: mark.rutland@arm.com, ulf.hansson@linaro.org, kernel@esmil.dk,
	viresh.kumar@linaro.org, linux-kernel@vger.kernel.org,
	tony.xie@rock-chips.com, philipp.tomsich@theobroma-systems.com,
	heiko@sntech.de, michal.simek@xilinx.com,
	linux-rockchip@lists.infradead.org, jolly.shah@xilinx.com,
	devicetree@vger.kernel.org, scott.branden@broadcom.com,
	nava.manne@xilinx.com, ayaka@soulik.info, mdf@kernel.org,
	linux-arm-kernel@lists.infradead.org, rajan.vaja@xilinx.com,
	linux-mmc@vger.kernel.org, adrian.hunter@intel.com,
	olof@lixom.net, christoph.muellner@theobroma-systems.com
Subject: Re: [PATCH v2 07/11] dt-bindings: mmc: arasan: Add optional properties for Arasan SDHCI
Date: Mon, 22 Jul 2019 16:01:34 -0600	[thread overview]
Message-ID: <20190722220134.GA8281@bogus> (raw)
In-Reply-To: <1561958991-21935-8-git-send-email-manish.narani@xilinx.com>

On Mon, Jul 01, 2019 at 10:59:47AM +0530, Manish Narani wrote:
> Add optional propeties for Arasan SDHCI which are used to set clk delays
> for different speed modes in the controller.
> 
> Signed-off-by: Manish Narani <manish.narani@xilinx.com>
> ---
>  Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> index 7c79496..7425d52 100644
> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> @@ -49,6 +49,21 @@ Optional Properties:
>      properly. Test mode can be used to force the controller to function.
>    - xlnx,int-clock-stable-broken: when present, the controller always reports
>      that the internal clock is stable even when it is not.
> +  - clk-phase-legacy: Input/Output Clock Delay pair in degrees for Legacy Mode.
> +  - clk-phase-mmc-hs: Input/Output Clock Delay pair degrees for MMC HS.
> +  - clk-phase-sd-hs: Input/Output Clock Delay pair in degrees for SD HS.
> +  - clk-phase-uhs-sdr12: Input/Output Clock Delay pair in degrees for SDR12.
> +  - clk-phase-uhs-sdr25: Input/Output Clock Delay pair in degrees for SDR25.
> +  - clk-phase-uhs-sdr50: Input/Output Clock Delay pair in degrees for SDR50.
> +  - clk-phase-uhs-sdr104: Input/Output Clock Delay pair in degrees for SDR104.
> +  - clk-phase-uhs-ddr50: Input/Output Clock Delay pair in degrees for SD DDR50.
> +  - clk-phase-mmc-ddr52: Input/Output Clock Delay pair in degrees for MMC DDR52.
> +  - clk-phase-mmc-hs200: Input/Output Clock Delay pair in degrees for MMC HS200.
> +  - clk-phase-mmc-hs400: Input/Output Clock Delay pair in degrees for MMC HS400.

Either these need vendor prefixes or be added as common properties if 
that makes sense.

Rob

> +
> +  Above mentioned are the clock (phase) delays which are to be configured in the
> +  controller while switching to particular speed mode. If not specified, driver
> +  will configure the default value defined for particular mode in it.
>  
>  Example:
>  	sdhci@e0100000 {
> -- 
> 2.1.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-07-22 22:01 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-01  5:29 [PATCH v2 00/11] Arasan SDHCI enhancements and ZynqMP Tap Delays Handling Manish Narani
2019-07-01  5:29 ` Manish Narani
2019-07-01  5:29 ` [PATCH v2 01/11] dt-bindings: mmc: arasan: Update documentation for SD Card Clock Manish Narani
2019-07-01  5:29   ` Manish Narani
2019-07-22 21:54   ` Rob Herring
2019-07-22 21:54     ` Rob Herring
2019-07-23  8:23     ` Manish Narani
2019-07-23  8:23       ` Manish Narani
2019-07-23  8:23       ` Manish Narani
2019-07-25 13:00       ` Ulf Hansson
2019-07-25 13:00         ` Ulf Hansson
2019-07-25 13:00         ` Ulf Hansson
2019-08-19  9:21         ` Manish Narani
2019-08-19  9:21           ` Manish Narani
2019-08-19  9:21           ` Manish Narani
2019-08-22 13:38           ` Ulf Hansson
2019-08-22 13:38             ` Ulf Hansson
2019-08-22 13:38             ` Ulf Hansson
2019-08-22 18:23             ` Heiko Stuebner
2019-08-22 18:23               ` Heiko Stuebner
2019-08-22 18:23               ` Heiko Stuebner
2019-08-23 10:01               ` Manish Narani
2019-08-23 10:01                 ` Manish Narani
2019-08-23 10:01                 ` Manish Narani
2019-07-01  5:29 ` [PATCH v2 02/11] arm64: dts: rockchip: Add optional clock property indicating sdcard clock Manish Narani
2019-07-01  5:29   ` Manish Narani
2019-07-01  5:29 ` [PATCH v2 03/11] mmc: sdhci-of-arasan: Replace deprecated clk API calls Manish Narani
2019-07-01  5:29   ` Manish Narani
2019-07-01  5:29   ` Manish Narani
2019-07-01  5:29 ` [PATCH v2 04/11] mmc: sdhci-of-arasan: Separate out clk related data to another structure Manish Narani
2019-07-01  5:29   ` Manish Narani
2019-07-01  5:29 ` [PATCH v2 05/11] dt-bindings: mmc: arasan: Update Documentation for the input clock Manish Narani
2019-07-01  5:29   ` Manish Narani
2019-07-22 21:56   ` Rob Herring
2019-07-22 21:56     ` Rob Herring
2019-07-01  5:29 ` [PATCH v2 06/11] mmc: sdhci-of-arasan: Add sampling clock for a phy to use Manish Narani
2019-07-01  5:29   ` Manish Narani
2019-07-01  5:29   ` Manish Narani
2019-07-01  5:29 ` [PATCH v2 07/11] dt-bindings: mmc: arasan: Add optional properties for Arasan SDHCI Manish Narani
2019-07-01  5:29   ` Manish Narani
2019-07-22 22:01   ` Rob Herring [this message]
2019-07-22 22:01     ` Rob Herring
2019-07-01  5:29 ` [PATCH v2 08/11] mmc: sdhci-of-arasan: Add support to set clock phase delays for SD Manish Narani
2019-07-01  5:29   ` Manish Narani
2019-07-01  5:29 ` [PATCH v2 09/11] firmware: xilinx: Add SDIO Tap Delay APIs Manish Narani
2019-07-01  5:29   ` Manish Narani
2019-07-01 18:06   ` Jolly Shah
2019-07-01 18:06     ` Jolly Shah
2019-07-01 18:06     ` Jolly Shah
2019-07-02  5:03     ` Manish Narani
2019-07-02  5:03       ` Manish Narani
2019-07-02  5:03       ` Manish Narani
2019-07-01  5:29 ` [PATCH v2 10/11] dt-bindings: mmc: arasan: Document 'xlnx,zynqmp-8.9a' controller Manish Narani
2019-07-01  5:29   ` [PATCH v2 10/11] dt-bindings: mmc: arasan: Document 'xlnx, zynqmp-8.9a' controller Manish Narani
2019-07-22 22:06   ` [PATCH v2 10/11] dt-bindings: mmc: arasan: Document 'xlnx,zynqmp-8.9a' controller Rob Herring
2019-07-22 22:06     ` Rob Herring
2019-07-22 22:06     ` Rob Herring
2019-07-01  5:29 ` [PATCH v2 11/11] mmc: sdhci-of-arasan: Add support for ZynqMP Platform Tap Delays Setup Manish Narani
2019-07-01  5:29   ` Manish Narani
2019-07-10 11:33 ` [PATCH v2 00/11] Arasan SDHCI enhancements and ZynqMP Tap Delays Handling Adrian Hunter
2019-07-10 11:33   ` Adrian Hunter
2019-07-15  7:15 ` Manish Narani
2019-07-15  7:15   ` Manish Narani
2019-07-15  7:15   ` Manish Narani
2019-07-22  4:56   ` Manish Narani
2019-07-22  4:56     ` Manish Narani
2019-07-22  4:56     ` Manish Narani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190722220134.GA8281@bogus \
    --to=robh@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ayaka@soulik.info \
    --cc=christoph.muellner@theobroma-systems.com \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=jolly.shah@xilinx.com \
    --cc=kernel@esmil.dk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=manish.narani@xilinx.com \
    --cc=mark.rutland@arm.com \
    --cc=mdf@kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=nava.manne@xilinx.com \
    --cc=olof@lixom.net \
    --cc=philipp.tomsich@theobroma-systems.com \
    --cc=rajan.vaja@xilinx.com \
    --cc=scott.branden@broadcom.com \
    --cc=tony.xie@rock-chips.com \
    --cc=ulf.hansson@linaro.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.