From: Sam Ravnborg <sam@ravnborg.org>
To: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
Cc: dri-devel@lists.freedesktop.org,
Neil Armstrong <narmstrong@baylibre.com>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Douglas Anderson <dianders@chromium.org>,
Thierry Reding <thierry.reding@gmail.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
kernel@collabora.com, linux-samsung-soc@vger.kernel.org,
linux-rockchip@lists.infradead.org,
Vincent Abriou <vincent.abriou@st.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
David Airlie <airlied@linux.ie>, Chen-Yu Tsai <wens@csie.org>,
Kukjin Kim <kgene@kernel.org>, NXP Linux Team <linux-imx@nxp.com>,
Dave Airlie <airlied@redhat.com>,
intel-gfx@lists.freedesktop.org, freedreno@lists.freedesktop.org,
linux-tegra@vger.kernel.org, Jonas Karlman <jonas@kwiboo.se>
Subject: Re: [PATCH v4 16/23] drm/mgag200: Provide ddc symlink in connector sysfs directory
Date: Tue, 23 Jul 2019 11:07:52 +0200 [thread overview]
Message-ID: <20190723090752.GB787@ravnborg.org> (raw)
In-Reply-To: <d32a6b1f0a3b79f1fbc8d0894080908526f6e61e.1562843413.git.andrzej.p@collabora.com>
Hi Andrzej.
On Thu, Jul 11, 2019 at 01:26:43PM +0200, Andrzej Pietrasiewicz wrote:
> Use the ddc pointer provided by the generic connector.
>
> Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
> ---
> drivers/gpu/drm/mgag200/mgag200_mode.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c
> index a25054015e8c..8fb9444b2142 100644
> --- a/drivers/gpu/drm/mgag200/mgag200_mode.c
> +++ b/drivers/gpu/drm/mgag200/mgag200_mode.c
> @@ -1703,6 +1703,11 @@ static struct drm_connector *mga_vga_init(struct drm_device *dev)
> return NULL;
>
> connector = &mga_connector->base;
> + mga_connector->i2c = mgag200_i2c_create(dev);
> + if (!mga_connector->i2c)
> + DRM_ERROR("failed to add ddc bus\n");
> +
> + connector->ddc = &mga_connector->i2c->adapter;
>
> drm_connector_init(dev, connector,
> &mga_vga_connector_funcs, DRM_MODE_CONNECTOR_VGA);
Like on other patch, assigning connector->ddc before
drm_connector_init() looks wrong.
Sam
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
Cc: dri-devel@lists.freedesktop.org,
"Neil Armstrong" <narmstrong@baylibre.com>,
"Maxime Ripard" <maxime.ripard@bootlin.com>,
"Douglas Anderson" <dianders@chromium.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
kernel@collabora.com, linux-samsung-soc@vger.kernel.org,
linux-rockchip@lists.infradead.org,
"Vincent Abriou" <vincent.abriou@st.com>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"David Airlie" <airlied@linux.ie>, "Chen-Yu Tsai" <wens@csie.org>,
"Kukjin Kim" <kgene@kernel.org>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Dave Airlie" <airlied@redhat.com>,
intel-gfx@lists.freedesktop.org, freedreno@lists.freedesktop.org,
linux-tegra@vger.kernel.org, "Jonas Karlman" <jonas@kwiboo.se>,
linux-arm-msm@vger.kernel.org,
"Alexios Zavras" <alexios.zavras@intel.com>,
"Mamta Shukla" <mamtashukla555@gmail.com>,
linux-mediatek@lists.infradead.org, "Jyri Sarha" <jsarha@ti.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Sean Paul" <sean@poorly.run>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
linux-arm-kernel@lists.infradead.org,
amd-gfx@lists.freedesktop.org,
"Tomi Valkeinen" <tomi.valkeinen@ti.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Seung-Woo Kim" <sw0312.kim@samsung.com>,
linux-kernel@vger.kernel.org,
"Todor Tomov" <todor.tomov@linaro.org>,
"Kyungmin Park" <kyungmin.park@samsung.com>,
"Huang Rui" <ray.huang@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Christian König" <christian.koenig@amd.com>,
"Gerd Hoffmann" <kraxel@redhat.com>
Subject: Re: [PATCH v4 16/23] drm/mgag200: Provide ddc symlink in connector sysfs directory
Date: Tue, 23 Jul 2019 11:07:52 +0200 [thread overview]
Message-ID: <20190723090752.GB787@ravnborg.org> (raw)
In-Reply-To: <d32a6b1f0a3b79f1fbc8d0894080908526f6e61e.1562843413.git.andrzej.p@collabora.com>
Hi Andrzej.
On Thu, Jul 11, 2019 at 01:26:43PM +0200, Andrzej Pietrasiewicz wrote:
> Use the ddc pointer provided by the generic connector.
>
> Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
> ---
> drivers/gpu/drm/mgag200/mgag200_mode.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c
> index a25054015e8c..8fb9444b2142 100644
> --- a/drivers/gpu/drm/mgag200/mgag200_mode.c
> +++ b/drivers/gpu/drm/mgag200/mgag200_mode.c
> @@ -1703,6 +1703,11 @@ static struct drm_connector *mga_vga_init(struct drm_device *dev)
> return NULL;
>
> connector = &mga_connector->base;
> + mga_connector->i2c = mgag200_i2c_create(dev);
> + if (!mga_connector->i2c)
> + DRM_ERROR("failed to add ddc bus\n");
> +
> + connector->ddc = &mga_connector->i2c->adapter;
>
> drm_connector_init(dev, connector,
> &mga_vga_connector_funcs, DRM_MODE_CONNECTOR_VGA);
Like on other patch, assigning connector->ddc before
drm_connector_init() looks wrong.
Sam
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
Cc: "Neil Armstrong" <narmstrong@baylibre.com>,
"Maxime Ripard" <maxime.ripard@bootlin.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
kernel@collabora.com, linux-samsung-soc@vger.kernel.org,
linux-rockchip@lists.infradead.org, "Sean Paul" <sean@poorly.run>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"David Airlie" <airlied@linux.ie>, "Chen-Yu Tsai" <wens@csie.org>,
"Kukjin Kim" <kgene@kernel.org>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Dave Airlie" <airlied@redhat.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Jonas Karlman" <jonas@kwiboo.se>,
linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org,
"Jyri Sarha" <jsarha@ti.com>,
"Alexios Zavras" <alexios.zavras@intel.com>,
"Mamta Shukla" <mamtashukla555@gmail.com>,
linux-mediatek@lists.infradead.org,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
linux-tegra@vger.kernel.org,
"Thomas Gleixner" <tglx@linutronix.de>,
"Vincent Abriou" <vincent.abriou@st.com>,
linux-arm-kernel@lists.infradead.org,
amd-gfx@lists.freedesktop.org,
"Tomi Valkeinen" <tomi.valkeinen@ti.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Seung-Woo Kim" <sw0312.kim@samsung.com>,
"Douglas Anderson" <dianders@chromium.org>,
"Todor Tomov" <todor.tomov@linaro.org>,
"Kyungmin Park" <kyungmin.park@samsung.com>,
"Huang Rui" <ray.huang@amd.com>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Alex Deucher" <alexander.deucher@amd.com>,
freedreno@lists.freedesktop.org,
"Christian König" <christian.koenig@amd.com>,
"Gerd Hoffmann" <kraxel@redhat.com>
Subject: Re: [PATCH v4 16/23] drm/mgag200: Provide ddc symlink in connector sysfs directory
Date: Tue, 23 Jul 2019 11:07:52 +0200 [thread overview]
Message-ID: <20190723090752.GB787@ravnborg.org> (raw)
In-Reply-To: <d32a6b1f0a3b79f1fbc8d0894080908526f6e61e.1562843413.git.andrzej.p@collabora.com>
Hi Andrzej.
On Thu, Jul 11, 2019 at 01:26:43PM +0200, Andrzej Pietrasiewicz wrote:
> Use the ddc pointer provided by the generic connector.
>
> Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
> ---
> drivers/gpu/drm/mgag200/mgag200_mode.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c
> index a25054015e8c..8fb9444b2142 100644
> --- a/drivers/gpu/drm/mgag200/mgag200_mode.c
> +++ b/drivers/gpu/drm/mgag200/mgag200_mode.c
> @@ -1703,6 +1703,11 @@ static struct drm_connector *mga_vga_init(struct drm_device *dev)
> return NULL;
>
> connector = &mga_connector->base;
> + mga_connector->i2c = mgag200_i2c_create(dev);
> + if (!mga_connector->i2c)
> + DRM_ERROR("failed to add ddc bus\n");
> +
> + connector->ddc = &mga_connector->i2c->adapter;
>
> drm_connector_init(dev, connector,
> &mga_vga_connector_funcs, DRM_MODE_CONNECTOR_VGA);
Like on other patch, assigning connector->ddc before
drm_connector_init() looks wrong.
Sam
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-23 9:07 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 11:26 [PATCH v4 00/23] Associate ddc adapters with connectors Andrzej Pietrasiewicz
2019-07-11 11:26 ` [PATCH v4 01/23] drm: Include ddc adapter pointer in struct drm_connector Andrzej Pietrasiewicz
2019-07-11 12:00 ` Ville Syrjälä
[not found] ` <5957ae96ee20eed5cfcb8a9619e2f61d71fe227e.1562843413.git.andrzej.p-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2019-07-11 12:00 ` Ville Syrjälä
2019-07-11 12:00 ` Ville Syrjälä
2019-07-11 11:26 ` [PATCH v4 02/23] drm/exynos: Provide ddc symlink in connector's sysfs Andrzej Pietrasiewicz
2019-07-11 11:26 ` [PATCH v4 03/23] drm: rockchip: Provide ddc symlink in rk3066_hdmi sysfs directory Andrzej Pietrasiewicz
2019-07-11 11:26 ` [PATCH v4 06/23] drm/sun4i: hdmi: Provide ddc symlink in sun4i hdmi connector " Andrzej Pietrasiewicz
2019-07-11 11:26 ` [PATCH v4 07/23] drm/mediatek: Provide ddc symlink in " Andrzej Pietrasiewicz
2019-07-11 11:26 ` [PATCH v4 08/23] drm/tegra: Provide ddc symlink in output " Andrzej Pietrasiewicz
2019-07-11 11:26 ` [PATCH v4 09/23] drm/imx: imx-ldb: Provide ddc symlink in connector's sysfs Andrzej Pietrasiewicz
2019-07-11 11:26 ` [PATCH v4 10/23] drm/imx: imx-tve: " Andrzej Pietrasiewicz
2019-07-11 11:26 ` [PATCH v4 11/23] drm/vc4: Provide ddc symlink in connector sysfs directory Andrzej Pietrasiewicz
2019-07-11 11:26 ` [PATCH v4 12/23] drm: zte: Provide ddc symlink in hdmi " Andrzej Pietrasiewicz
2019-07-23 5:58 ` Shawn Guo
2019-07-11 11:26 ` [PATCH v4 13/23] drm: zte: Provide ddc symlink in vga " Andrzej Pietrasiewicz
[not found] ` <9cdd2fc46dbcb6b596786e5a12b7176c77a38d78.1562843413.git.andrzej.p-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2019-07-23 5:58 ` Shawn Guo
2019-07-11 11:26 ` [PATCH v4 14/23] drm/tilcdc: Provide ddc symlink in " Andrzej Pietrasiewicz
[not found] ` <d1d415022c598fb7acd033f0f322dd67250adaa9.1562843413.git.andrzej.p-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2019-07-23 9:05 ` Sam Ravnborg
2019-07-23 9:05 ` Sam Ravnborg
2019-07-23 12:44 ` Andrzej Pietrasiewicz
2019-07-23 12:44 ` Andrzej Pietrasiewicz
2019-07-23 12:44 ` Andrzej Pietrasiewicz
[not found] ` <3ad60be5-49cf-4017-4b74-53a2d6272deb-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2019-07-23 15:19 ` Sam Ravnborg
2019-07-23 15:19 ` Sam Ravnborg
2019-07-23 15:19 ` Sam Ravnborg
2019-07-24 8:01 ` Thomas Zimmermann
2019-07-24 8:01 ` Thomas Zimmermann
2019-07-24 8:01 ` Thomas Zimmermann
2019-07-24 8:51 ` Andrzej Pietrasiewicz
2019-07-24 8:51 ` Andrzej Pietrasiewicz
2019-07-24 8:51 ` Andrzej Pietrasiewicz
[not found] ` <acfd895d-ab59-0190-e25c-1827bd8d214b-l3A5Bk7waGM@public.gmane.org>
2019-07-31 19:39 ` Ezequiel Garcia
2019-07-31 19:39 ` Ezequiel Garcia
2019-07-31 19:39 ` Ezequiel Garcia
2019-07-11 11:26 ` [PATCH v4 19/23] drm/bridge: dw-hdmi: " Andrzej Pietrasiewicz
[not found] ` <ec88a18feffa37eceb947bb83a6f9f51fb575566.1562843413.git.andrzej.p-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2019-07-30 12:17 ` Neil Armstrong
[not found] ` <449b11e6-2386-4e5b-26f7-eb6046911f24-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2019-07-30 17:30 ` Sam Ravnborg
[not found] ` <20190730173007.GA28537-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org>
2019-07-31 7:32 ` Neil Armstrong
2019-07-11 11:26 ` [PATCH v4 21/23] drm/amdgpu: " Andrzej Pietrasiewicz
2019-07-11 11:26 ` [PATCH v4 22/23] drm/radeon: " Andrzej Pietrasiewicz
[not found] ` <cover.1562843413.git.andrzej.p-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2019-07-11 11:26 ` [PATCH v4 04/23] drm: rockchip: Provide ddc symlink in inno_hdmi " Andrzej Pietrasiewicz
2019-07-11 11:26 ` [PATCH v4 05/23] drm/msm/hdmi: Provide ddc symlink in hdmi connector " Andrzej Pietrasiewicz
2019-07-11 11:26 ` [PATCH v4 15/23] drm: sti: " Andrzej Pietrasiewicz
[not found] ` <86afdc0bca6939901870176dcf55f279f7b10a08.1562843413.git.andrzej.p-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2019-07-12 7:42 ` Benjamin Gaignard
2019-07-11 11:26 ` [PATCH v4 16/23] drm/mgag200: Provide ddc symlink in " Andrzej Pietrasiewicz
2019-07-11 17:26 ` Thomas Zimmermann
2019-07-23 9:07 ` Sam Ravnborg [this message]
2019-07-23 9:07 ` Sam Ravnborg
2019-07-23 9:07 ` Sam Ravnborg
2019-07-11 11:26 ` [PATCH v4 17/23] drm/ast: " Andrzej Pietrasiewicz
2019-07-11 17:27 ` Thomas Zimmermann
2019-07-23 9:09 ` Sam Ravnborg
2019-07-23 9:09 ` Sam Ravnborg
2019-07-11 11:26 ` [PATCH v4 18/23] drm/bridge: dumb-vga-dac: " Andrzej Pietrasiewicz
2019-07-30 12:15 ` Neil Armstrong
2019-07-11 11:26 ` [PATCH v4 20/23] drm/bridge: ti-tfp410: " Andrzej Pietrasiewicz
2019-07-30 12:25 ` Neil Armstrong
2019-07-11 11:26 ` [PATCH v4 23/23] drm/i915: Provide ddc symlink in hdmi " Andrzej Pietrasiewicz
[not found] ` <1d9bb3d65127a5093d6e9f9cc62a5c7c7502f61d.1562843413.git.andrzej.p-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2019-07-11 11:59 ` Ville Syrjälä
2019-07-11 11:59 ` Ville Syrjälä
2019-07-11 11:59 ` Ville Syrjälä
2019-07-11 13:21 ` Daniel Vetter
2019-07-11 17:56 ` ✓ Fi.CI.BAT: success for Associate ddc adapters with connectors Patchwork
2019-07-12 17:48 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190723090752.GB787@ravnborg.org \
--to=sam@ravnborg.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=andrzej.p@collabora.com \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jonas@kwiboo.se \
--cc=jonathanh@nvidia.com \
--cc=kernel@collabora.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=narmstrong@baylibre.com \
--cc=thierry.reding@gmail.com \
--cc=vincent.abriou@st.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.