From: Kelsey Skunberg <skunberg.kelsey@gmail.com>
To: bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: skunberg.kelsey@gmail.com,
linux-kernel-mentees@lists.linuxfoundation.org,
skhan@linuxfoundation.org
Subject: [PATCH v2 08/11] PCI: Move pci_ats_init() to drivers/pci/pci.h
Date: Wed, 24 Jul 2019 17:38:45 -0600 [thread overview]
Message-ID: <20190724233848.73327-9-skunberg.kelsey@gmail.com> (raw)
In-Reply-To: <20190724233848.73327-1-skunberg.kelsey@gmail.com>
pci_ats_init() is only called with drivers/pci/. Since declarations do not
need to be visible to the rest of the kernel, move to drivers/pci/pci.h.
Signed-off-by: Kelsey Skunberg <skunberg.kelsey@gmail.com>
---
drivers/pci/pci.h | 7 ++++---
include/linux/pci.h | 2 --
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
index feec29853a44..7c0488b64faf 100644
--- a/drivers/pci/pci.h
+++ b/drivers/pci/pci.h
@@ -439,11 +439,12 @@ static inline void pci_restore_dpc_state(struct pci_dev *dev) {}
#endif
#ifdef CONFIG_PCI_ATS
+/* Address Translation Service */
+void pci_ats_init(struct pci_dev *dev);
void pci_restore_ats_state(struct pci_dev *dev);
#else
-static inline void pci_restore_ats_state(struct pci_dev *dev)
-{
-}
+static inline void pci_ats_init(struct pci_dev *d) { }
+static inline void pci_restore_ats_state(struct pci_dev *dev) { }
#endif /* CONFIG_PCI_ATS */
#ifdef CONFIG_PCI_IOV
diff --git a/include/linux/pci.h b/include/linux/pci.h
index c6a25c32a49a..5760e19cb625 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -1766,13 +1766,11 @@ static inline bool pci_ats_disabled(void) { return true; }
#ifdef CONFIG_PCI_ATS
/* Address Translation Service */
-void pci_ats_init(struct pci_dev *dev);
int pci_enable_ats(struct pci_dev *dev, int ps);
void pci_disable_ats(struct pci_dev *dev);
int pci_ats_queue_depth(struct pci_dev *dev);
int pci_ats_page_aligned(struct pci_dev *dev);
#else
-static inline void pci_ats_init(struct pci_dev *d) { }
static inline int pci_enable_ats(struct pci_dev *d, int ps) { return -ENODEV; }
static inline void pci_disable_ats(struct pci_dev *d) { }
static inline int pci_ats_queue_depth(struct pci_dev *d) { return -ENODEV; }
--
2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: skunberg.kelsey at gmail.com (Kelsey Skunberg)
Subject: [Linux-kernel-mentees] [PATCH v2 08/11] PCI: Move pci_ats_init() to drivers/pci/pci.h
Date: Wed, 24 Jul 2019 17:38:45 -0600 [thread overview]
Message-ID: <20190724233848.73327-9-skunberg.kelsey@gmail.com> (raw)
In-Reply-To: <20190724233848.73327-1-skunberg.kelsey@gmail.com>
pci_ats_init() is only called with drivers/pci/. Since declarations do not
need to be visible to the rest of the kernel, move to drivers/pci/pci.h.
Signed-off-by: Kelsey Skunberg <skunberg.kelsey at gmail.com>
---
drivers/pci/pci.h | 7 ++++---
include/linux/pci.h | 2 --
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
index feec29853a44..7c0488b64faf 100644
--- a/drivers/pci/pci.h
+++ b/drivers/pci/pci.h
@@ -439,11 +439,12 @@ static inline void pci_restore_dpc_state(struct pci_dev *dev) {}
#endif
#ifdef CONFIG_PCI_ATS
+/* Address Translation Service */
+void pci_ats_init(struct pci_dev *dev);
void pci_restore_ats_state(struct pci_dev *dev);
#else
-static inline void pci_restore_ats_state(struct pci_dev *dev)
-{
-}
+static inline void pci_ats_init(struct pci_dev *d) { }
+static inline void pci_restore_ats_state(struct pci_dev *dev) { }
#endif /* CONFIG_PCI_ATS */
#ifdef CONFIG_PCI_IOV
diff --git a/include/linux/pci.h b/include/linux/pci.h
index c6a25c32a49a..5760e19cb625 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -1766,13 +1766,11 @@ static inline bool pci_ats_disabled(void) { return true; }
#ifdef CONFIG_PCI_ATS
/* Address Translation Service */
-void pci_ats_init(struct pci_dev *dev);
int pci_enable_ats(struct pci_dev *dev, int ps);
void pci_disable_ats(struct pci_dev *dev);
int pci_ats_queue_depth(struct pci_dev *dev);
int pci_ats_page_aligned(struct pci_dev *dev);
#else
-static inline void pci_ats_init(struct pci_dev *d) { }
static inline int pci_enable_ats(struct pci_dev *d, int ps) { return -ENODEV; }
static inline void pci_disable_ats(struct pci_dev *d) { }
static inline int pci_ats_queue_depth(struct pci_dev *d) { return -ENODEV; }
--
2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: skunberg.kelsey@gmail.com (Kelsey Skunberg)
Subject: [Linux-kernel-mentees] [PATCH v2 08/11] PCI: Move pci_ats_init() to drivers/pci/pci.h
Date: Wed, 24 Jul 2019 17:38:45 -0600 [thread overview]
Message-ID: <20190724233848.73327-9-skunberg.kelsey@gmail.com> (raw)
Message-ID: <20190724233845.AF8NxnpY2By7DfKkGaYT2KnEZTzuUKufkuHWciOM2Ns@z> (raw)
In-Reply-To: <20190724233848.73327-1-skunberg.kelsey@gmail.com>
pci_ats_init() is only called with drivers/pci/. Since declarations do not
need to be visible to the rest of the kernel, move to drivers/pci/pci.h.
Signed-off-by: Kelsey Skunberg <skunberg.kelsey at gmail.com>
---
drivers/pci/pci.h | 7 ++++---
include/linux/pci.h | 2 --
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
index feec29853a44..7c0488b64faf 100644
--- a/drivers/pci/pci.h
+++ b/drivers/pci/pci.h
@@ -439,11 +439,12 @@ static inline void pci_restore_dpc_state(struct pci_dev *dev) {}
#endif
#ifdef CONFIG_PCI_ATS
+/* Address Translation Service */
+void pci_ats_init(struct pci_dev *dev);
void pci_restore_ats_state(struct pci_dev *dev);
#else
-static inline void pci_restore_ats_state(struct pci_dev *dev)
-{
-}
+static inline void pci_ats_init(struct pci_dev *d) { }
+static inline void pci_restore_ats_state(struct pci_dev *dev) { }
#endif /* CONFIG_PCI_ATS */
#ifdef CONFIG_PCI_IOV
diff --git a/include/linux/pci.h b/include/linux/pci.h
index c6a25c32a49a..5760e19cb625 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -1766,13 +1766,11 @@ static inline bool pci_ats_disabled(void) { return true; }
#ifdef CONFIG_PCI_ATS
/* Address Translation Service */
-void pci_ats_init(struct pci_dev *dev);
int pci_enable_ats(struct pci_dev *dev, int ps);
void pci_disable_ats(struct pci_dev *dev);
int pci_ats_queue_depth(struct pci_dev *dev);
int pci_ats_page_aligned(struct pci_dev *dev);
#else
-static inline void pci_ats_init(struct pci_dev *d) { }
static inline int pci_enable_ats(struct pci_dev *d, int ps) { return -ENODEV; }
static inline void pci_disable_ats(struct pci_dev *d) { }
static inline int pci_ats_queue_depth(struct pci_dev *d) { return -ENODEV; }
--
2.20.1
next prev parent reply other threads:[~2019-07-24 23:39 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 22:23 [PATCH 00/11] PCI: Move symbols to drivers/pci/pci.h Kelsey Skunberg
2019-07-11 22:23 ` [Linux-kernel-mentees] " Kelsey Skunberg
2019-07-11 22:23 ` skunberg.kelsey
2019-07-11 22:23 ` [PATCH 01/11] PCI: Move #define PCI_PM_* lines " Kelsey Skunberg
2019-07-11 22:23 ` [Linux-kernel-mentees] " Kelsey Skunberg
2019-07-11 22:23 ` skunberg.kelsey
2019-07-11 22:23 ` [PATCH 02/11] PCI: Move PME declarations " Kelsey Skunberg
2019-07-11 22:23 ` [Linux-kernel-mentees] " Kelsey Skunberg
2019-07-11 22:23 ` skunberg.kelsey
2019-07-11 22:23 ` [PATCH 03/11] PCI: Move *_host_bridge_device() declarations to drivers/pci.pci.h Kelsey Skunberg
2019-07-11 22:23 ` [Linux-kernel-mentees] " Kelsey Skunberg
2019-07-11 22:23 ` skunberg.kelsey
2019-07-11 22:23 ` [PATCH 04/11] PCI: Move PCI Virtual Channel declarations to drivers/pci/pci.h Kelsey Skunberg
2019-07-11 22:23 ` [Linux-kernel-mentees] " Kelsey Skunberg
2019-07-11 22:23 ` skunberg.kelsey
2019-07-11 22:23 ` [PATCH 05/11] PCI: Move pci_hotplug_*_size " Kelsey Skunberg
2019-07-11 22:23 ` [Linux-kernel-mentees] " Kelsey Skunberg
2019-07-11 22:23 ` skunberg.kelsey
2019-07-11 22:23 ` [PATCH 06/11] PCI: Move pci_bus_* " Kelsey Skunberg
2019-07-11 22:23 ` [Linux-kernel-mentees] " Kelsey Skunberg
2019-07-11 22:23 ` skunberg.kelsey
2019-07-11 22:23 ` [PATCH 07/11] PCI: Move pcie_update_link_speed() " Kelsey Skunberg
2019-07-11 22:23 ` [Linux-kernel-mentees] " Kelsey Skunberg
2019-07-11 22:23 ` skunberg.kelsey
2019-07-11 22:23 ` [PATCH 08/11] PCI: Move pci_ats_init() " Kelsey Skunberg
2019-07-11 22:23 ` [Linux-kernel-mentees] " Kelsey Skunberg
2019-07-11 22:23 ` skunberg.kelsey
2019-07-11 22:23 ` [PATCH 09/11] PCI: Move ECRC declarations " Kelsey Skunberg
2019-07-11 22:23 ` [Linux-kernel-mentees] " Kelsey Skunberg
2019-07-11 22:23 ` skunberg.kelsey
2019-07-11 22:23 ` [PATCH 10/11] PCI: Move PTM declaration " Kelsey Skunberg
2019-07-11 22:23 ` [Linux-kernel-mentees] " Kelsey Skunberg
2019-07-11 22:23 ` skunberg.kelsey
2019-07-11 22:23 ` [PATCH 11/11] PCI: Move pci_*_node() declarations " Kelsey Skunberg
2019-07-11 22:23 ` [Linux-kernel-mentees] " Kelsey Skunberg
2019-07-11 22:23 ` skunberg.kelsey
2019-07-23 23:07 ` [PATCH 00/11] PCI: Move symbols " Bjorn Helgaas
2019-07-23 23:07 ` [Linux-kernel-mentees] " Bjorn Helgaas
2019-07-23 23:07 ` helgaas
2019-07-23 23:24 ` Kelsey Skunberg
2019-07-23 23:24 ` [Linux-kernel-mentees] " Kelsey Skunberg
2019-07-23 23:24 ` skunberg.kelsey
2019-07-24 23:38 ` [PATCH v2 00/11] Hide PCI symbols that don't need to be global Kelsey Skunberg
2019-07-24 23:38 ` [Linux-kernel-mentees] " Kelsey Skunberg
2019-07-24 23:38 ` skunberg.kelsey
2019-07-24 23:38 ` [PATCH v2 01/11] PCI: Move #define PCI_PM_* lines to drivers/pci/pci.h Kelsey Skunberg
2019-07-24 23:38 ` [Linux-kernel-mentees] " Kelsey Skunberg
2019-07-24 23:38 ` skunberg.kelsey
2019-07-29 21:44 ` Bjorn Helgaas
2019-07-29 21:44 ` Bjorn Helgaas
2019-07-29 21:44 ` helgaas
2019-07-24 23:38 ` [PATCH v2 02/11] PCI: Move PME declarations " Kelsey Skunberg
2019-07-24 23:38 ` [Linux-kernel-mentees] " Kelsey Skunberg
2019-07-24 23:38 ` skunberg.kelsey
2019-07-24 23:38 ` [PATCH v2 03/11] PCI: Move *_host_bridge_device() declarations to drivers/pci.pci.h Kelsey Skunberg
2019-07-24 23:38 ` [Linux-kernel-mentees] " Kelsey Skunberg
2019-07-24 23:38 ` skunberg.kelsey
2019-07-24 23:38 ` [PATCH v2 04/11] PCI: Move PCI Virtual Channel declarations to drivers/pci/pci.h Kelsey Skunberg
2019-07-24 23:38 ` [Linux-kernel-mentees] " Kelsey Skunberg
2019-07-24 23:38 ` skunberg.kelsey
2019-07-24 23:38 ` [PATCH v2 05/11] PCI: Move pci_hotplug_*_size " Kelsey Skunberg
2019-07-24 23:38 ` [Linux-kernel-mentees] " Kelsey Skunberg
2019-07-24 23:38 ` skunberg.kelsey
2019-07-24 23:38 ` [PATCH v2 06/11] PCI: Move pci_bus_* " Kelsey Skunberg
2019-07-24 23:38 ` [Linux-kernel-mentees] " Kelsey Skunberg
2019-07-24 23:38 ` skunberg.kelsey
2019-07-24 23:38 ` [PATCH v2 07/11] PCI: Move pcie_update_link_speed() " Kelsey Skunberg
2019-07-24 23:38 ` [Linux-kernel-mentees] " Kelsey Skunberg
2019-07-24 23:38 ` skunberg.kelsey
2019-07-24 23:38 ` Kelsey Skunberg [this message]
2019-07-24 23:38 ` [Linux-kernel-mentees] [PATCH v2 08/11] PCI: Move pci_ats_init() " Kelsey Skunberg
2019-07-24 23:38 ` skunberg.kelsey
2019-07-24 23:38 ` [PATCH v2 09/11] PCI: Move ECRC declarations " Kelsey Skunberg
2019-07-24 23:38 ` [Linux-kernel-mentees] " Kelsey Skunberg
2019-07-24 23:38 ` skunberg.kelsey
2019-07-24 23:38 ` [PATCH v2 10/11] PCI: Move PTM declaration " Kelsey Skunberg
2019-07-24 23:38 ` [Linux-kernel-mentees] " Kelsey Skunberg
2019-07-24 23:38 ` skunberg.kelsey
2019-07-24 23:38 ` [PATCH v2 11/11] PCI: Move pci_*_node() declarations " Kelsey Skunberg
2019-07-24 23:38 ` [Linux-kernel-mentees] " Kelsey Skunberg
2019-07-24 23:38 ` skunberg.kelsey
2019-07-30 13:47 ` [Linux-kernel-mentees] [PATCH v2 00/11] Hide PCI symbols that don't need to be global Bjorn Helgaas
2019-07-30 13:47 ` Bjorn Helgaas
2019-07-30 13:47 ` helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190724233848.73327-9-skunberg.kelsey@gmail.com \
--to=skunberg.kelsey@gmail.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.