From: Jamie Iles <jamie@jamieiles.com> To: YueHaibing <yuehaibing@huawei.com> Cc: herbert@gondor.apana.org.au, lars.persson@axis.com, jesper.nilsson@axis.com, davem@davemloft.net, thomas.lendacky@amd.com, gary.hook@amd.com, krzk@kernel.org, kgene@kernel.org, antoine.tenart@bootlin.com, matthias.bgg@gmail.com, jamie@jamieiles.com, agross@kernel.org, heiko@sntech.de, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, clabbe.montjoie@gmail.com, mripard@kernel.org, wens@csie.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-arm-kernel@axis.com, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH -next 07/12] crypto: picoxcell - use devm_platform_ioremap_resource() to simplify code Date: Sat, 3 Aug 2019 15:13:00 +0100 [thread overview] Message-ID: <20190803141300.GA26817@willow> (raw) In-Reply-To: <20190802132809.8116-8-yuehaibing@huawei.com> On Fri, Aug 02, 2019 at 09:28:04PM +0800, YueHaibing wrote: > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Acked-by: Jamie Iles <jamie@jamieiles.com> > --- > drivers/crypto/picoxcell_crypto.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/crypto/picoxcell_crypto.c b/drivers/crypto/picoxcell_crypto.c > index b985cb85..9a939b4 100644 > --- a/drivers/crypto/picoxcell_crypto.c > +++ b/drivers/crypto/picoxcell_crypto.c > @@ -1624,7 +1624,7 @@ MODULE_DEVICE_TABLE(of, spacc_of_id_table); > static int spacc_probe(struct platform_device *pdev) > { > int i, err, ret; > - struct resource *mem, *irq; > + struct resource *irq; > struct device_node *np = pdev->dev.of_node; > struct spacc_engine *engine = devm_kzalloc(&pdev->dev, sizeof(*engine), > GFP_KERNEL); > @@ -1653,8 +1653,7 @@ static int spacc_probe(struct platform_device *pdev) > > engine->name = dev_name(&pdev->dev); > > - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - engine->regs = devm_ioremap_resource(&pdev->dev, mem); > + engine->regs = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(engine->regs)) > return PTR_ERR(engine->regs); > > -- > 2.7.4 > >
WARNING: multiple messages have this Message-ID (diff)
From: Jamie Iles <jamie@jamieiles.com> To: YueHaibing <yuehaibing@huawei.com> Cc: heiko@sntech.de, gary.hook@amd.com, clabbe.montjoie@gmail.com, linux-arm-kernel@axis.com, jamie@jamieiles.com, linux-stm32@st-md-mailman.stormreply.com, jesper.nilsson@axis.com, linux-samsung-soc@vger.kernel.org, herbert@gondor.apana.org.au, krzk@kernel.org, linux-rockchip@lists.infradead.org, wens@csie.org, agross@kernel.org, thomas.lendacky@amd.com, alexandre.torgue@st.com, antoine.tenart@bootlin.com, linux-arm-msm@vger.kernel.org, mripard@kernel.org, linux-mediatek@lists.infradead.org, lars.persson@axis.com, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, mcoquelin.stm32@gmail.com, kgene@kernel.org, davem@davemloft.net Subject: Re: [PATCH -next 07/12] crypto: picoxcell - use devm_platform_ioremap_resource() to simplify code Date: Sat, 3 Aug 2019 15:13:00 +0100 [thread overview] Message-ID: <20190803141300.GA26817@willow> (raw) In-Reply-To: <20190802132809.8116-8-yuehaibing@huawei.com> On Fri, Aug 02, 2019 at 09:28:04PM +0800, YueHaibing wrote: > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Acked-by: Jamie Iles <jamie@jamieiles.com> > --- > drivers/crypto/picoxcell_crypto.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/crypto/picoxcell_crypto.c b/drivers/crypto/picoxcell_crypto.c > index b985cb85..9a939b4 100644 > --- a/drivers/crypto/picoxcell_crypto.c > +++ b/drivers/crypto/picoxcell_crypto.c > @@ -1624,7 +1624,7 @@ MODULE_DEVICE_TABLE(of, spacc_of_id_table); > static int spacc_probe(struct platform_device *pdev) > { > int i, err, ret; > - struct resource *mem, *irq; > + struct resource *irq; > struct device_node *np = pdev->dev.of_node; > struct spacc_engine *engine = devm_kzalloc(&pdev->dev, sizeof(*engine), > GFP_KERNEL); > @@ -1653,8 +1653,7 @@ static int spacc_probe(struct platform_device *pdev) > > engine->name = dev_name(&pdev->dev); > > - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - engine->regs = devm_ioremap_resource(&pdev->dev, mem); > + engine->regs = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(engine->regs)) > return PTR_ERR(engine->regs); > > -- > 2.7.4 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-03 14:13 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-02 13:27 [PATCH -next 00/12] crypto: use devm_platform_ioremap_resource() to simplify code YueHaibing 2019-08-02 13:27 ` YueHaibing 2019-08-02 13:27 ` YueHaibing 2019-08-02 13:27 ` [PATCH -next 01/12] crypto: artpec6 - " YueHaibing 2019-08-02 13:27 ` YueHaibing 2019-08-02 13:27 ` YueHaibing 2019-08-02 13:27 ` [PATCH -next 02/12] crypto: ccp " YueHaibing 2019-08-02 13:27 ` YueHaibing 2019-08-02 13:27 ` YueHaibing 2019-08-02 13:28 ` [PATCH -next 03/12] crypto: exynos " YueHaibing 2019-08-02 13:28 ` YueHaibing 2019-08-02 13:28 ` YueHaibing 2019-08-05 9:18 ` Krzysztof Kozlowski 2019-08-05 9:18 ` Krzysztof Kozlowski 2019-08-05 9:18 ` Krzysztof Kozlowski 2019-08-02 13:28 ` [PATCH -next 04/12] crypto: img-hash " YueHaibing 2019-08-02 13:28 ` YueHaibing 2019-08-02 13:28 ` YueHaibing 2019-08-02 13:28 ` [PATCH -next 05/12] crypto: inside-secure " YueHaibing 2019-08-02 13:28 ` YueHaibing 2019-08-02 13:28 ` YueHaibing 2019-08-02 16:17 ` Antoine Tenart 2019-08-02 16:17 ` Antoine Tenart 2019-08-02 13:28 ` [PATCH -next 06/12] crypto: mediatek " YueHaibing 2019-08-02 13:28 ` YueHaibing 2019-08-02 13:28 ` YueHaibing 2019-08-02 13:28 ` [PATCH -next 07/12] crypto: picoxcell " YueHaibing 2019-08-02 13:28 ` YueHaibing 2019-08-02 13:28 ` YueHaibing 2019-08-03 14:13 ` Jamie Iles [this message] 2019-08-03 14:13 ` Jamie Iles 2019-08-02 13:28 ` [PATCH -next 08/12] crypto: sunxi-ss " YueHaibing 2019-08-02 13:28 ` YueHaibing 2019-08-02 13:28 ` YueHaibing 2019-08-02 13:28 ` [PATCH -next 09/12] crypto: rockchip " YueHaibing 2019-08-02 13:28 ` YueHaibing 2019-08-02 13:28 ` YueHaibing 2019-08-02 16:09 ` Heiko Stuebner 2019-08-02 16:09 ` Heiko Stuebner 2019-08-02 13:28 ` [PATCH -next 10/12] crypto: stm32 " YueHaibing 2019-08-02 13:28 ` YueHaibing 2019-08-02 13:28 ` YueHaibing 2019-08-02 13:28 ` [PATCH -next 11/12] crypto: qce " YueHaibing 2019-08-02 13:28 ` YueHaibing 2019-08-02 13:28 ` YueHaibing 2019-08-02 13:28 ` [PATCH -next 12/12] crypto: qcom-rng " YueHaibing 2019-08-02 13:28 ` YueHaibing 2019-08-02 13:28 ` YueHaibing 2019-08-09 6:20 ` [PATCH -next 00/12] crypto: " Herbert Xu 2019-08-09 6:20 ` Herbert Xu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190803141300.GA26817@willow \ --to=jamie@jamieiles.com \ --cc=agross@kernel.org \ --cc=alexandre.torgue@st.com \ --cc=antoine.tenart@bootlin.com \ --cc=clabbe.montjoie@gmail.com \ --cc=davem@davemloft.net \ --cc=gary.hook@amd.com \ --cc=heiko@sntech.de \ --cc=herbert@gondor.apana.org.au \ --cc=jesper.nilsson@axis.com \ --cc=kgene@kernel.org \ --cc=krzk@kernel.org \ --cc=lars.persson@axis.com \ --cc=linux-arm-kernel@axis.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-crypto@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=matthias.bgg@gmail.com \ --cc=mcoquelin.stm32@gmail.com \ --cc=mripard@kernel.org \ --cc=thomas.lendacky@amd.com \ --cc=wens@csie.org \ --cc=yuehaibing@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.