From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: kvm@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, linux-mm@kvack.org
Subject: Re: [PATCH V2 7/9] vhost: do not use RCU to synchronize MMU notifier with worker
Date: Tue, 6 Aug 2019 09:36:58 -0400 [thread overview]
Message-ID: <20190806093633-mutt-send-email-mst__48922.3655940563$1565098637$gmane$org@kernel.org> (raw)
In-Reply-To: <20190806115317.GA11627@ziepe.ca>
On Tue, Aug 06, 2019 at 08:53:17AM -0300, Jason Gunthorpe wrote:
> On Sun, Aug 04, 2019 at 04:07:17AM -0400, Michael S. Tsirkin wrote:
> > > > > Also, why can't this just permanently GUP the pages? In fact, where
> > > > > does it put_page them anyhow? Worrying that 7f466 adds a get_user page
> > > > > but does not add a put_page??
> > >
> > > You didn't answer this.. Why not just use GUP?
> > >
> > > Jason
> >
> > Sorry I misunderstood the question. Permanent GUP breaks lots of
> > functionality we need such as THP and numa balancing.
>
> Really? It doesn't look like that many pages are involved..
>
> Jason
Yea. But they just might happen to be heavily accessed ones....
--
MST
next prev parent reply other threads:[~2019-08-06 13:36 UTC|newest]
Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 8:46 [PATCH V2 0/9] Fixes for metadata accelreation Jason Wang
2019-07-31 8:46 ` [PATCH V2 1/9] vhost: don't set uaddr for invalid address Jason Wang
2019-07-31 8:46 ` Jason Wang
2019-07-31 8:46 ` [PATCH V2 2/9] vhost: validate MMU notifier registration Jason Wang
2019-07-31 8:46 ` Jason Wang
2019-07-31 8:46 ` [PATCH V2 3/9] vhost: fix vhost map leak Jason Wang
2019-07-31 8:46 ` Jason Wang
2019-07-31 8:46 ` [PATCH V2 4/9] vhost: reset invalidate_count in vhost_set_vring_num_addr() Jason Wang
2019-07-31 8:46 ` Jason Wang
2019-07-31 12:41 ` Jason Gunthorpe
2019-07-31 13:29 ` Jason Wang
2019-07-31 19:32 ` Jason Gunthorpe
2019-07-31 19:32 ` Jason Gunthorpe
2019-07-31 19:37 ` Michael S. Tsirkin
2019-07-31 19:37 ` Michael S. Tsirkin
2019-08-01 5:03 ` Jason Wang
2019-08-01 5:03 ` Jason Wang
2019-07-31 13:29 ` Jason Wang
2019-07-31 12:41 ` Jason Gunthorpe
2019-07-31 8:46 ` [PATCH V2 5/9] vhost: mark dirty pages during map uninit Jason Wang
2019-07-31 8:46 ` Jason Wang
2019-07-31 8:46 ` [PATCH V2 6/9] vhost: don't do synchronize_rcu() in vhost_uninit_vq_maps() Jason Wang
2019-07-31 8:46 ` Jason Wang
2019-07-31 8:46 ` [PATCH V2 7/9] vhost: do not use RCU to synchronize MMU notifier with worker Jason Wang
2019-07-31 8:50 ` Jason Wang
2019-07-31 8:50 ` Jason Wang
2019-07-31 12:39 ` Jason Gunthorpe
2019-07-31 13:28 ` Jason Wang
2019-07-31 13:28 ` Jason Wang
2019-07-31 19:30 ` Jason Gunthorpe
2019-07-31 19:30 ` Jason Gunthorpe
2019-08-01 5:02 ` Jason Wang
2019-08-01 5:02 ` Jason Wang
2019-08-01 14:15 ` Jason Gunthorpe
2019-08-02 9:40 ` Jason Wang
2019-08-02 12:46 ` Jason Gunthorpe
2019-08-02 14:27 ` Michael S. Tsirkin
2019-08-02 17:24 ` Jason Gunthorpe
2019-08-02 17:24 ` Jason Gunthorpe
2019-08-03 21:36 ` Michael S. Tsirkin
2019-08-03 21:36 ` Michael S. Tsirkin
2019-08-04 0:14 ` Jason Gunthorpe
2019-08-04 0:14 ` Jason Gunthorpe
2019-08-04 8:07 ` Michael S. Tsirkin
2019-08-04 8:07 ` Michael S. Tsirkin
2019-08-05 4:39 ` Jason Wang
2019-08-05 4:39 ` Jason Wang
2019-08-06 11:53 ` Jason Gunthorpe
2019-08-06 11:53 ` Jason Gunthorpe
2019-08-06 13:36 ` Michael S. Tsirkin
2019-08-06 13:40 ` Jason Gunthorpe
2019-08-06 13:40 ` Jason Gunthorpe
2019-08-06 13:36 ` Michael S. Tsirkin [this message]
2019-08-05 4:36 ` Jason Wang
2019-08-05 4:41 ` Jason Wang
2019-08-05 6:40 ` Michael S. Tsirkin
2019-08-05 8:24 ` Jason Wang
2019-08-05 8:24 ` Jason Wang
2019-08-05 6:40 ` Michael S. Tsirkin
2019-08-05 4:41 ` Jason Wang
2019-08-05 6:30 ` Michael S. Tsirkin
2019-08-05 6:30 ` Michael S. Tsirkin
2019-08-05 8:22 ` Jason Wang
2019-08-05 8:22 ` Jason Wang
2019-08-05 4:36 ` Jason Wang
2019-08-02 14:27 ` Michael S. Tsirkin
2019-08-05 4:20 ` Jason Wang
2019-08-05 4:20 ` Jason Wang
2019-08-06 12:04 ` Jason Gunthorpe
2019-08-07 6:49 ` Jason Wang
2019-08-07 6:49 ` Jason Wang
2019-08-06 12:04 ` Jason Gunthorpe
2019-08-02 12:46 ` Jason Gunthorpe
2019-08-02 14:03 ` Michael S. Tsirkin
2019-08-05 4:33 ` Jason Wang
2019-08-05 4:33 ` Jason Wang
2019-08-05 6:28 ` Michael S. Tsirkin
2019-08-05 6:28 ` Michael S. Tsirkin
2019-08-05 8:21 ` Jason Wang
2019-08-05 8:21 ` Jason Wang
2019-08-02 14:03 ` Michael S. Tsirkin
2019-08-02 9:40 ` Jason Wang
2019-08-01 14:15 ` Jason Gunthorpe
2019-07-31 12:39 ` Jason Gunthorpe
2019-07-31 18:29 ` Michael S. Tsirkin
2019-07-31 18:29 ` Michael S. Tsirkin
2019-08-01 8:06 ` Jason Wang
2019-08-01 8:06 ` Jason Wang
2019-08-01 8:06 ` Jason Wang
2019-08-03 21:54 ` Michael S. Tsirkin
2019-08-03 21:54 ` Michael S. Tsirkin
2019-08-05 8:18 ` Jason Wang
2019-08-05 8:18 ` Jason Wang
2019-07-31 8:46 ` Jason Wang
2019-07-31 8:46 ` [PATCH V2 8/9] vhost: correctly set dirty pages in MMU notifiers callback Jason Wang
2019-07-31 8:46 ` Jason Wang
2019-07-31 8:46 ` [PATCH V2 9/9] vhost: do not return -EAGIAN for non blocking invalidation too early Jason Wang
2019-07-31 8:46 ` Jason Wang
2019-07-31 9:59 ` Stefano Garzarella
2019-07-31 10:05 ` Jason Wang
2019-07-31 10:05 ` Jason Wang
2019-07-31 9:59 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20190806093633-mutt-send-email-mst__48922.3655940563$1565098637$gmane$org@kernel.org' \
--to=mst@redhat.com \
--cc=jgg@ziepe.ca \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.