From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: netdev@vger.kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jeff Kirsher <jeffrey.t.kirsher@intel.com>, "David S. Miller" <davem@davemloft.net>, intel-wired-lan@lists.osuosl.org Subject: [PATCH 15/17] i40e: no need to check return value of debugfs_create functions Date: Tue, 6 Aug 2019 18:11:26 +0200 [thread overview] Message-ID: <20190806161128.31232-16-gregkh@linuxfoundation.org> (raw) In-Reply-To: <20190806161128.31232-1-gregkh@linuxfoundation.org> When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Cc: "David S. Miller" <davem@davemloft.net> Cc: intel-wired-lan@lists.osuosl.org Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- .../net/ethernet/intel/i40e/i40e_debugfs.c | 21 ++++--------------- 1 file changed, 4 insertions(+), 17 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c index 55d20acfcf70..0df9454b3315 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c +++ b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c @@ -1732,29 +1732,16 @@ static const struct file_operations i40e_dbg_netdev_ops_fops = { **/ void i40e_dbg_pf_init(struct i40e_pf *pf) { - struct dentry *pfile; const char *name = pci_name(pf->pdev); const struct device *dev = &pf->pdev->dev; pf->i40e_dbg_pf = debugfs_create_dir(name, i40e_dbg_root); - if (!pf->i40e_dbg_pf) - return; - - pfile = debugfs_create_file("command", 0600, pf->i40e_dbg_pf, pf, - &i40e_dbg_command_fops); - if (!pfile) - goto create_failed; - pfile = debugfs_create_file("netdev_ops", 0600, pf->i40e_dbg_pf, pf, - &i40e_dbg_netdev_ops_fops); - if (!pfile) - goto create_failed; + debugfs_create_file("command", 0600, pf->i40e_dbg_pf, pf, + &i40e_dbg_command_fops); - return; - -create_failed: - dev_info(dev, "debugfs dir/file for %s failed\n", name); - debugfs_remove_recursive(pf->i40e_dbg_pf); + debugfs_create_file("netdev_ops", 0600, pf->i40e_dbg_pf, pf, + &i40e_dbg_netdev_ops_fops); } /** -- 2.22.0
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: intel-wired-lan@osuosl.org Subject: [Intel-wired-lan] [PATCH 15/17] i40e: no need to check return value of debugfs_create functions Date: Tue, 6 Aug 2019 18:11:26 +0200 [thread overview] Message-ID: <20190806161128.31232-16-gregkh@linuxfoundation.org> (raw) In-Reply-To: <20190806161128.31232-1-gregkh@linuxfoundation.org> When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Cc: "David S. Miller" <davem@davemloft.net> Cc: intel-wired-lan at lists.osuosl.org Cc: netdev at vger.kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- .../net/ethernet/intel/i40e/i40e_debugfs.c | 21 ++++--------------- 1 file changed, 4 insertions(+), 17 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c index 55d20acfcf70..0df9454b3315 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c +++ b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c @@ -1732,29 +1732,16 @@ static const struct file_operations i40e_dbg_netdev_ops_fops = { **/ void i40e_dbg_pf_init(struct i40e_pf *pf) { - struct dentry *pfile; const char *name = pci_name(pf->pdev); const struct device *dev = &pf->pdev->dev; pf->i40e_dbg_pf = debugfs_create_dir(name, i40e_dbg_root); - if (!pf->i40e_dbg_pf) - return; - - pfile = debugfs_create_file("command", 0600, pf->i40e_dbg_pf, pf, - &i40e_dbg_command_fops); - if (!pfile) - goto create_failed; - pfile = debugfs_create_file("netdev_ops", 0600, pf->i40e_dbg_pf, pf, - &i40e_dbg_netdev_ops_fops); - if (!pfile) - goto create_failed; + debugfs_create_file("command", 0600, pf->i40e_dbg_pf, pf, + &i40e_dbg_command_fops); - return; - -create_failed: - dev_info(dev, "debugfs dir/file for %s failed\n", name); - debugfs_remove_recursive(pf->i40e_dbg_pf); + debugfs_create_file("netdev_ops", 0600, pf->i40e_dbg_pf, pf, + &i40e_dbg_netdev_ops_fops); } /** -- 2.22.0
next prev parent reply other threads:[~2019-08-06 16:11 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-06 16:11 [PATCH 00/17] Networking driver debugfs cleanups Greg Kroah-Hartman 2019-08-06 16:11 ` [PATCH 01/17] wimax: no need to check return value of debugfs_create functions Greg Kroah-Hartman 2019-08-06 16:11 ` [PATCH 02/17] bonding: no need to print a message if debugfs_create_dir() fails Greg Kroah-Hartman 2019-08-06 16:11 ` [PATCH 03/17] mlx5: no need to check return value of debugfs_create functions Greg Kroah-Hartman 2019-08-06 19:41 ` Saeed Mahameed 2019-08-06 19:47 ` gregkh 2019-08-06 20:37 ` Saeed Mahameed 2019-08-06 16:11 ` [PATCH 04/17] xgbe: " Greg Kroah-Hartman 2019-08-06 16:28 ` Lendacky, Thomas 2019-08-06 16:11 ` [PATCH 05/17] bnxt: " Greg Kroah-Hartman 2019-08-06 16:11 ` [PATCH 06/17] cxgb4: " Greg Kroah-Hartman 2019-08-06 16:11 ` [PATCH 07/17] hns3: " Greg Kroah-Hartman 2019-08-06 16:11 ` [PATCH 08/17] nfp: " Greg Kroah-Hartman 2019-08-06 16:50 ` Jakub Kicinski 2019-08-06 17:00 ` Greg Kroah-Hartman 2019-08-06 17:30 ` Jakub Kicinski 2019-08-06 16:11 ` [PATCH 09/17] stmmac: " Greg Kroah-Hartman 2019-08-06 16:11 ` [PATCH 10/17] dpaa2: " Greg Kroah-Hartman 2019-08-06 16:11 ` [PATCH 11/17] qca: " Greg Kroah-Hartman 2019-08-08 6:30 ` Michael Heimpold 2019-08-06 16:11 ` [PATCH 12/17] skge: " Greg Kroah-Hartman 2019-08-06 17:44 ` Stephen Hemminger 2019-08-06 16:11 ` [PATCH 13/17] mvpp2: " Greg Kroah-Hartman 2019-08-06 16:11 ` [PATCH 14/17] fm10k: " Greg Kroah-Hartman 2019-08-06 16:11 ` [Intel-wired-lan] " Greg Kroah-Hartman 2019-08-06 16:11 ` Greg Kroah-Hartman [this message] 2019-08-06 16:11 ` [Intel-wired-lan] [PATCH 15/17] i40e: " Greg Kroah-Hartman 2019-08-06 16:11 ` [PATCH 16/17] ixgbe: " Greg Kroah-Hartman 2019-08-06 16:11 ` [Intel-wired-lan] " Greg Kroah-Hartman 2019-08-06 16:11 ` [PATCH 17/17] ieee802154: " Greg Kroah-Hartman 2019-08-06 19:22 ` Stefan Schmidt 2019-08-06 19:48 ` Greg Kroah-Hartman 2019-08-09 1:37 ` [PATCH 00/17] Networking driver debugfs cleanups David Miller 2019-08-09 1:42 ` David Miller 2019-08-09 12:30 ` Greg KH
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190806161128.31232-16-gregkh@linuxfoundation.org \ --to=gregkh@linuxfoundation.org \ --cc=davem@davemloft.net \ --cc=intel-wired-lan@lists.osuosl.org \ --cc=jeffrey.t.kirsher@intel.com \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.