From: john.hubbard@gmail.com
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Christoph Hellwig" <hch@infradead.org>,
"Dan Williams" <dan.j.williams@intel.com>,
"Dave Chinner" <david@fromorbit.com>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"Ira Weiny" <ira.weiny@intel.com>, "Jan Kara" <jack@suse.cz>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Jérôme Glisse" <jglisse@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
amd-gfx@lists.freedesktop.org, ceph-devel@vger.kernel.org,
devel@driverdev.osuosl.org, devel@lists.orangefs.org,
dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-block@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-fbdev@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-media@vger.kernel.org, linux-mm@kvack.org,
linux-nfs@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org, linux-xfs@vger.kernel.org,
netdev@vger.kernel.org, rds-devel@oss.oracle.com,
sparclinux@vger.kernel.org, x86@kernel.org,
xen-devel@lists.xenproject.org,
"John Hubbard" <jhubbard@nvidia.com>,
"Matt Porter" <mporter@kernel.crashing.org>,
"Alexandre Bounine" <alex.bou9@gmail.com>,
"Al Viro" <viro@zeniv.linux.org.uk>,
"Logan Gunthorpe" <logang@deltatee.com>,
"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>,
"Ioan Nicu" <ioan.nicu.ext@nokia.com>,
"Kees Cook" <keescook@chromium.org>,
"Tvrtko Ursulin" <tvrtko.ursulin@intel.com>
Subject: [PATCH v3 15/41] rapidio: convert put_page() to put_user_page*()
Date: Tue, 6 Aug 2019 18:33:14 -0700 [thread overview]
Message-ID: <20190807013340.9706-16-jhubbard@nvidia.com> (raw)
In-Reply-To: <20190807013340.9706-1-jhubbard@nvidia.com>
From: John Hubbard <jhubbard@nvidia.com>
For pages that were retained via get_user_pages*(), release those pages
via the new put_user_page*() routines, instead of via put_page() or
release_pages().
This is part a tree-wide conversion, as described in commit fc1d8e7cca2d
("mm: introduce put_user_page*(), placeholder versions").
Cc: Matt Porter <mporter@kernel.crashing.org>
Cc: Alexandre Bounine <alex.bou9@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Logan Gunthorpe <logang@deltatee.com>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Ioan Nicu <ioan.nicu.ext@nokia.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---
drivers/rapidio/devices/rio_mport_cdev.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/rapidio/devices/rio_mport_cdev.c b/drivers/rapidio/devices/rio_mport_cdev.c
index 8155f59ece38..0e8ea0e5a89e 100644
--- a/drivers/rapidio/devices/rio_mport_cdev.c
+++ b/drivers/rapidio/devices/rio_mport_cdev.c
@@ -572,14 +572,12 @@ static void dma_req_free(struct kref *ref)
struct mport_dma_req *req = container_of(ref, struct mport_dma_req,
refcount);
struct mport_cdev_priv *priv = req->priv;
- unsigned int i;
dma_unmap_sg(req->dmach->device->dev,
req->sgt.sgl, req->sgt.nents, req->dir);
sg_free_table(&req->sgt);
if (req->page_list) {
- for (i = 0; i < req->nr_pages; i++)
- put_page(req->page_list[i]);
+ put_user_pages(req->page_list, req->nr_pages);
kfree(req->page_list);
}
@@ -815,7 +813,7 @@ rio_dma_transfer(struct file *filp, u32 transfer_mode,
struct mport_dma_req *req;
struct mport_dev *md = priv->md;
struct dma_chan *chan;
- int i, ret;
+ int ret;
int nents;
if (xfer->length == 0)
@@ -946,8 +944,7 @@ rio_dma_transfer(struct file *filp, u32 transfer_mode,
err_pg:
if (!req->page_list) {
- for (i = 0; i < nr_pages; i++)
- put_page(page_list[i]);
+ put_user_pages(page_list, nr_pages);
kfree(page_list);
}
err_req:
--
2.22.0
WARNING: multiple messages have this Message-ID (diff)
From: john.hubbard@gmail.com
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-fbdev@vger.kernel.org, "Jan Kara" <jack@suse.cz>,
kvm@vger.kernel.org, "Dave Hansen" <dave.hansen@linux.intel.com>,
"Dave Chinner" <david@fromorbit.com>,
dri-devel@lists.freedesktop.org, linux-mm@kvack.org,
sparclinux@vger.kernel.org, ceph-devel@vger.kernel.org,
devel@driverdev.osuosl.org, rds-devel@oss.oracle.com,
linux-rdma@vger.kernel.org, x86@kernel.org,
amd-gfx@lists.freedesktop.org,
"Christoph Hellwig" <hch@infradead.org>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
xen-devel@lists.xenproject.org,
"Matt Porter" <mporter@kernel.crashing.org>,
devel@lists.orangefs.org, linux-media@vger.kernel.org,
"Kees Cook" <keescook@chromium.org>,
"John Hubbard" <jhubbard@nvidia.com>,
intel-gfx@lists.freedesktop.org, linux-block@vger.kernel.org,
"Jérôme Glisse" <jglisse@redhat.com>,
"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>,
linux-rpi-kernel@lists.infradead.org
Subject: [PATCH v3 15/41] rapidio: convert put_page() to put_user_page*()
Date: Wed, 07 Aug 2019 01:33:14 +0000 [thread overview]
Message-ID: <20190807013340.9706-16-jhubbard@nvidia.com> (raw)
In-Reply-To: <20190807013340.9706-1-jhubbard@nvidia.com>
From: John Hubbard <jhubbard@nvidia.com>
For pages that were retained via get_user_pages*(), release those pages
via the new put_user_page*() routines, instead of via put_page() or
release_pages().
This is part a tree-wide conversion, as described in commit fc1d8e7cca2d
("mm: introduce put_user_page*(), placeholder versions").
Cc: Matt Porter <mporter@kernel.crashing.org>
Cc: Alexandre Bounine <alex.bou9@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Logan Gunthorpe <logang@deltatee.com>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Ioan Nicu <ioan.nicu.ext@nokia.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---
drivers/rapidio/devices/rio_mport_cdev.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/rapidio/devices/rio_mport_cdev.c b/drivers/rapidio/devices/rio_mport_cdev.c
index 8155f59ece38..0e8ea0e5a89e 100644
--- a/drivers/rapidio/devices/rio_mport_cdev.c
+++ b/drivers/rapidio/devices/rio_mport_cdev.c
@@ -572,14 +572,12 @@ static void dma_req_free(struct kref *ref)
struct mport_dma_req *req = container_of(ref, struct mport_dma_req,
refcount);
struct mport_cdev_priv *priv = req->priv;
- unsigned int i;
dma_unmap_sg(req->dmach->device->dev,
req->sgt.sgl, req->sgt.nents, req->dir);
sg_free_table(&req->sgt);
if (req->page_list) {
- for (i = 0; i < req->nr_pages; i++)
- put_page(req->page_list[i]);
+ put_user_pages(req->page_list, req->nr_pages);
kfree(req->page_list);
}
@@ -815,7 +813,7 @@ rio_dma_transfer(struct file *filp, u32 transfer_mode,
struct mport_dma_req *req;
struct mport_dev *md = priv->md;
struct dma_chan *chan;
- int i, ret;
+ int ret;
int nents;
if (xfer->length = 0)
@@ -946,8 +944,7 @@ rio_dma_transfer(struct file *filp, u32 transfer_mode,
err_pg:
if (!req->page_list) {
- for (i = 0; i < nr_pages; i++)
- put_page(page_list[i]);
+ put_user_pages(page_list, nr_pages);
kfree(page_list);
}
err_req:
--
2.22.0
WARNING: multiple messages have this Message-ID (diff)
From: john.hubbard@gmail.com
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-fbdev@vger.kernel.org, "Jan Kara" <jack@suse.cz>,
kvm@vger.kernel.org, "Dave Hansen" <dave.hansen@linux.intel.com>,
"Dave Chinner" <david@fromorbit.com>,
dri-devel@lists.freedesktop.org, linux-mm@kvack.org,
sparclinux@vger.kernel.org, ceph-devel@vger.kernel.org,
devel@driverdev.osuosl.org, rds-devel@oss.oracle.com,
linux-rdma@vger.kernel.org, x86@kernel.org,
amd-gfx@lists.freedesktop.org,
"Christoph Hellwig" <hch@infradead.org>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
xen-devel@lists.xenproject.org,
"Matt Porter" <mporter@kernel.crashing.org>,
devel@lists.orangefs.org, linux-media@vger.kernel.org,
"Kees Cook" <keescook@chromium.org>,
"John Hubbard" <jhubbard@nvidia.com>,
intel-gfx@lists.freedesktop.org, linux-block@vger.kernel.org,
"Jérôme Glisse" <jglisse@redhat.com>,
"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>,
linux-rpi-kernel@lists.infradead.org
Subject: [PATCH v3 15/41] rapidio: convert put_page() to put_user_page*()
Date: Tue, 6 Aug 2019 18:33:14 -0700 [thread overview]
Message-ID: <20190807013340.9706-16-jhubbard@nvidia.com> (raw)
In-Reply-To: <20190807013340.9706-1-jhubbard@nvidia.com>
From: John Hubbard <jhubbard@nvidia.com>
For pages that were retained via get_user_pages*(), release those pages
via the new put_user_page*() routines, instead of via put_page() or
release_pages().
This is part a tree-wide conversion, as described in commit fc1d8e7cca2d
("mm: introduce put_user_page*(), placeholder versions").
Cc: Matt Porter <mporter@kernel.crashing.org>
Cc: Alexandre Bounine <alex.bou9@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Logan Gunthorpe <logang@deltatee.com>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Ioan Nicu <ioan.nicu.ext@nokia.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---
drivers/rapidio/devices/rio_mport_cdev.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/rapidio/devices/rio_mport_cdev.c b/drivers/rapidio/devices/rio_mport_cdev.c
index 8155f59ece38..0e8ea0e5a89e 100644
--- a/drivers/rapidio/devices/rio_mport_cdev.c
+++ b/drivers/rapidio/devices/rio_mport_cdev.c
@@ -572,14 +572,12 @@ static void dma_req_free(struct kref *ref)
struct mport_dma_req *req = container_of(ref, struct mport_dma_req,
refcount);
struct mport_cdev_priv *priv = req->priv;
- unsigned int i;
dma_unmap_sg(req->dmach->device->dev,
req->sgt.sgl, req->sgt.nents, req->dir);
sg_free_table(&req->sgt);
if (req->page_list) {
- for (i = 0; i < req->nr_pages; i++)
- put_page(req->page_list[i]);
+ put_user_pages(req->page_list, req->nr_pages);
kfree(req->page_list);
}
@@ -815,7 +813,7 @@ rio_dma_transfer(struct file *filp, u32 transfer_mode,
struct mport_dma_req *req;
struct mport_dev *md = priv->md;
struct dma_chan *chan;
- int i, ret;
+ int ret;
int nents;
if (xfer->length == 0)
@@ -946,8 +944,7 @@ rio_dma_transfer(struct file *filp, u32 transfer_mode,
err_pg:
if (!req->page_list) {
- for (i = 0; i < nr_pages; i++)
- put_page(page_list[i]);
+ put_user_pages(page_list, nr_pages);
kfree(page_list);
}
err_req:
--
2.22.0
WARNING: multiple messages have this Message-ID (diff)
From: john.hubbard@gmail.com (john.hubbard@gmail.com)
Subject: [PATCH v3 15/41] rapidio: convert put_page() to put_user_page*()
Date: Tue, 6 Aug 2019 18:33:14 -0700 [thread overview]
Message-ID: <20190807013340.9706-16-jhubbard@nvidia.com> (raw)
In-Reply-To: <20190807013340.9706-1-jhubbard@nvidia.com>
From: John Hubbard <jhubbard@nvidia.com>
For pages that were retained via get_user_pages*(), release those pages
via the new put_user_page*() routines, instead of via put_page() or
release_pages().
This is part a tree-wide conversion, as described in commit fc1d8e7cca2d
("mm: introduce put_user_page*(), placeholder versions").
Cc: Matt Porter <mporter at kernel.crashing.org>
Cc: Alexandre Bounine <alex.bou9 at gmail.com>
Cc: Al Viro <viro at zeniv.linux.org.uk>
Cc: Logan Gunthorpe <logang at deltatee.com>
Cc: Christophe JAILLET <christophe.jaillet at wanadoo.fr>
Cc: Ioan Nicu <ioan.nicu.ext at nokia.com>
Cc: Kees Cook <keescook at chromium.org>
Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
Signed-off-by: John Hubbard <jhubbard at nvidia.com>
---
drivers/rapidio/devices/rio_mport_cdev.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/rapidio/devices/rio_mport_cdev.c b/drivers/rapidio/devices/rio_mport_cdev.c
index 8155f59ece38..0e8ea0e5a89e 100644
--- a/drivers/rapidio/devices/rio_mport_cdev.c
+++ b/drivers/rapidio/devices/rio_mport_cdev.c
@@ -572,14 +572,12 @@ static void dma_req_free(struct kref *ref)
struct mport_dma_req *req = container_of(ref, struct mport_dma_req,
refcount);
struct mport_cdev_priv *priv = req->priv;
- unsigned int i;
dma_unmap_sg(req->dmach->device->dev,
req->sgt.sgl, req->sgt.nents, req->dir);
sg_free_table(&req->sgt);
if (req->page_list) {
- for (i = 0; i < req->nr_pages; i++)
- put_page(req->page_list[i]);
+ put_user_pages(req->page_list, req->nr_pages);
kfree(req->page_list);
}
@@ -815,7 +813,7 @@ rio_dma_transfer(struct file *filp, u32 transfer_mode,
struct mport_dma_req *req;
struct mport_dev *md = priv->md;
struct dma_chan *chan;
- int i, ret;
+ int ret;
int nents;
if (xfer->length == 0)
@@ -946,8 +944,7 @@ rio_dma_transfer(struct file *filp, u32 transfer_mode,
err_pg:
if (!req->page_list) {
- for (i = 0; i < nr_pages; i++)
- put_page(page_list[i]);
+ put_user_pages(page_list, nr_pages);
kfree(page_list);
}
err_req:
--
2.22.0
WARNING: multiple messages have this Message-ID (diff)
From: john.hubbard@gmail.com
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-fbdev@vger.kernel.org, "Jan Kara" <jack@suse.cz>,
kvm@vger.kernel.org, "Dave Hansen" <dave.hansen@linux.intel.com>,
"Dave Chinner" <david@fromorbit.com>,
dri-devel@lists.freedesktop.org, linux-mm@kvack.org,
sparclinux@vger.kernel.org, "Ira Weiny" <ira.weiny@intel.com>,
ceph-devel@vger.kernel.org, devel@driverdev.osuosl.org,
rds-devel@oss.oracle.com, linux-rdma@vger.kernel.org,
x86@kernel.org, amd-gfx@lists.freedesktop.org,
"Christoph Hellwig" <hch@infradead.org>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
xen-devel@lists.xenproject.org,
"Matt Porter" <mporter@kernel.crashing.org>,
devel@lists.orangefs.org, linux-media@vger.kernel.org,
"Kees Cook" <keescook@chromium.org>,
"John Hubbard" <jhubbard@nvidia.com>,
intel-gfx@lists.freedesktop.org, linux-block@vger.kernel.org,
"Jérôme Glisse" <jglisse@redhat.com>,
"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>,
linux-rpi-kernel@lists.infradead.org,
"Dan Williams" <dan.j.williams@intel.com>,
linux-arm-kernel@lists.infradead.org, linux-nfs@vger.kernel.org,
"Tvrtko Ursulin" <tvrtko.ursulin@intel.com>,
netdev@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
linux-xfs@vger.kernel.org,
"Alexandre Bounine" <alex.bou9@gmail.com>,
linux-crypto@vger.kernel.org,
"Ioan Nicu" <ioan.nicu.ext@nokia.com>,
linux-fsdevel@vger.kernel.org,
"Logan Gunthorpe" <logang@deltatee.com>,
"Al Viro" <viro@zeniv.linux.org.uk>
Subject: [PATCH v3 15/41] rapidio: convert put_page() to put_user_page*()
Date: Tue, 6 Aug 2019 18:33:14 -0700 [thread overview]
Message-ID: <20190807013340.9706-16-jhubbard@nvidia.com> (raw)
In-Reply-To: <20190807013340.9706-1-jhubbard@nvidia.com>
From: John Hubbard <jhubbard@nvidia.com>
For pages that were retained via get_user_pages*(), release those pages
via the new put_user_page*() routines, instead of via put_page() or
release_pages().
This is part a tree-wide conversion, as described in commit fc1d8e7cca2d
("mm: introduce put_user_page*(), placeholder versions").
Cc: Matt Porter <mporter@kernel.crashing.org>
Cc: Alexandre Bounine <alex.bou9@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Logan Gunthorpe <logang@deltatee.com>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Ioan Nicu <ioan.nicu.ext@nokia.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---
drivers/rapidio/devices/rio_mport_cdev.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/rapidio/devices/rio_mport_cdev.c b/drivers/rapidio/devices/rio_mport_cdev.c
index 8155f59ece38..0e8ea0e5a89e 100644
--- a/drivers/rapidio/devices/rio_mport_cdev.c
+++ b/drivers/rapidio/devices/rio_mport_cdev.c
@@ -572,14 +572,12 @@ static void dma_req_free(struct kref *ref)
struct mport_dma_req *req = container_of(ref, struct mport_dma_req,
refcount);
struct mport_cdev_priv *priv = req->priv;
- unsigned int i;
dma_unmap_sg(req->dmach->device->dev,
req->sgt.sgl, req->sgt.nents, req->dir);
sg_free_table(&req->sgt);
if (req->page_list) {
- for (i = 0; i < req->nr_pages; i++)
- put_page(req->page_list[i]);
+ put_user_pages(req->page_list, req->nr_pages);
kfree(req->page_list);
}
@@ -815,7 +813,7 @@ rio_dma_transfer(struct file *filp, u32 transfer_mode,
struct mport_dma_req *req;
struct mport_dev *md = priv->md;
struct dma_chan *chan;
- int i, ret;
+ int ret;
int nents;
if (xfer->length == 0)
@@ -946,8 +944,7 @@ rio_dma_transfer(struct file *filp, u32 transfer_mode,
err_pg:
if (!req->page_list) {
- for (i = 0; i < nr_pages; i++)
- put_page(page_list[i]);
+ put_user_pages(page_list, nr_pages);
kfree(page_list);
}
err_req:
--
2.22.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: john.hubbard@gmail.com
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-fbdev@vger.kernel.org, "Jan Kara" <jack@suse.cz>,
kvm@vger.kernel.org, "Dave Hansen" <dave.hansen@linux.intel.com>,
"Dave Chinner" <david@fromorbit.com>,
dri-devel@lists.freedesktop.org, linux-mm@kvack.org,
sparclinux@vger.kernel.org, "Ira Weiny" <ira.weiny@intel.com>,
ceph-devel@vger.kernel.org, devel@driverdev.osuosl.org,
rds-devel@oss.oracle.com, linux-rdma@vger.kernel.org,
x86@kernel.org, amd-gfx@lists.freedesktop.org,
"Christoph Hellwig" <hch@infradead.org>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
xen-devel@lists.xenproject.org,
"Matt Porter" <mporter@kernel.crashing.org>,
devel@lists.orangefs.org, linux-media@vger.kernel.org,
"Kees Cook" <keescook@chromium.org>,
"John Hubbard" <jhubbard@nvidia.com>,
intel-gfx@lists.freedesktop.org, linux-block@vger.kernel.org,
"Jérôme Glisse" <jglisse@redhat.com>,
"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>,
linux-rpi-kernel@lists.infradead.org,
"Dan Williams" <dan.j.williams@intel.com>,
linux-arm-kernel@lists.infradead.org, linux-nfs@vger.kernel.org,
"Tvrtko Ursulin" <tvrtko.ursulin@intel.com>,
netdev@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
linux-xfs@vger.kernel.org,
"Alexandre Bounine" <alex.bou9@gmail.com>,
linux-crypto@vger.kernel.org,
"Ioan Nicu" <ioan.nicu.ext@nokia.com>,
linux-fsdevel@vger.kernel.org,
"Logan Gunthorpe" <logang@deltatee.com>,
"Al Viro" <viro@zeniv.linux.org.uk>
Subject: [Xen-devel] [PATCH v3 15/41] rapidio: convert put_page() to put_user_page*()
Date: Tue, 6 Aug 2019 18:33:14 -0700 [thread overview]
Message-ID: <20190807013340.9706-16-jhubbard@nvidia.com> (raw)
In-Reply-To: <20190807013340.9706-1-jhubbard@nvidia.com>
From: John Hubbard <jhubbard@nvidia.com>
For pages that were retained via get_user_pages*(), release those pages
via the new put_user_page*() routines, instead of via put_page() or
release_pages().
This is part a tree-wide conversion, as described in commit fc1d8e7cca2d
("mm: introduce put_user_page*(), placeholder versions").
Cc: Matt Porter <mporter@kernel.crashing.org>
Cc: Alexandre Bounine <alex.bou9@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Logan Gunthorpe <logang@deltatee.com>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Ioan Nicu <ioan.nicu.ext@nokia.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---
drivers/rapidio/devices/rio_mport_cdev.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/rapidio/devices/rio_mport_cdev.c b/drivers/rapidio/devices/rio_mport_cdev.c
index 8155f59ece38..0e8ea0e5a89e 100644
--- a/drivers/rapidio/devices/rio_mport_cdev.c
+++ b/drivers/rapidio/devices/rio_mport_cdev.c
@@ -572,14 +572,12 @@ static void dma_req_free(struct kref *ref)
struct mport_dma_req *req = container_of(ref, struct mport_dma_req,
refcount);
struct mport_cdev_priv *priv = req->priv;
- unsigned int i;
dma_unmap_sg(req->dmach->device->dev,
req->sgt.sgl, req->sgt.nents, req->dir);
sg_free_table(&req->sgt);
if (req->page_list) {
- for (i = 0; i < req->nr_pages; i++)
- put_page(req->page_list[i]);
+ put_user_pages(req->page_list, req->nr_pages);
kfree(req->page_list);
}
@@ -815,7 +813,7 @@ rio_dma_transfer(struct file *filp, u32 transfer_mode,
struct mport_dma_req *req;
struct mport_dev *md = priv->md;
struct dma_chan *chan;
- int i, ret;
+ int ret;
int nents;
if (xfer->length == 0)
@@ -946,8 +944,7 @@ rio_dma_transfer(struct file *filp, u32 transfer_mode,
err_pg:
if (!req->page_list) {
- for (i = 0; i < nr_pages; i++)
- put_page(page_list[i]);
+ put_user_pages(page_list, nr_pages);
kfree(page_list);
}
err_req:
--
2.22.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-08-07 1:40 UTC|newest]
Thread overview: 318+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 1:32 [PATCH v3 00/39] put_user_pages(): miscellaneous call sites john.hubbard
2019-08-07 1:32 ` [Xen-devel] " john.hubbard
2019-08-07 1:32 ` john.hubbard
2019-08-07 1:32 ` john.hubbard
2019-08-07 1:32 ` john.hubbard
2019-08-07 1:32 ` john.hubbard
2019-08-07 1:33 ` [PATCH v3 01/41] mm/gup: add make_dirty arg to put_user_pages_dirty_lock() john.hubbard
2019-08-07 1:33 ` [Xen-devel] " john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` [PATCH v3 02/41] drivers/gpu/drm/via: convert put_page() to put_user_page*() john.hubbard
2019-08-07 1:33 ` [Xen-devel] " john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` [PATCH v3 03/41] net/xdp: " john.hubbard
2019-08-07 1:33 ` [Xen-devel] " john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` [PATCH v3 04/41] net/rds: " john.hubbard
2019-08-07 1:33 ` [Xen-devel] " john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` [PATCH v3 05/41] net/ceph: " john.hubbard
2019-08-07 1:33 ` [Xen-devel] " john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` [PATCH v3 06/41] x86/kvm: " john.hubbard
2019-08-07 1:33 ` [Xen-devel] " john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` [PATCH v3 07/41] drm/etnaviv: convert release_pages() to put_user_pages() john.hubbard
2019-08-07 1:33 ` [Xen-devel] " john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` [PATCH v3 08/41] drm/i915: convert put_page() to put_user_page*() john.hubbard
2019-08-07 1:33 ` [Xen-devel] " john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` [PATCH v3 09/41] drm/radeon: " john.hubbard
2019-08-07 1:33 ` [Xen-devel] " john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` [PATCH v3 10/41] media/ivtv: " john.hubbard
2019-08-07 1:33 ` [Xen-devel] " john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 8:51 ` Hans Verkuil
2019-08-07 8:51 ` [Xen-devel] " Hans Verkuil
2019-08-07 8:51 ` Hans Verkuil
2019-08-07 8:51 ` Hans Verkuil
2019-08-07 8:51 ` Hans Verkuil
2019-08-07 8:51 ` Hans Verkuil
2019-08-07 1:33 ` [PATCH v3 11/41] media/v4l2-core/mm: " john.hubbard
2019-08-07 1:33 ` [Xen-devel] " john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 7:20 ` Sakari Ailus
2019-08-07 7:20 ` [Xen-devel] " Sakari Ailus
2019-08-07 7:20 ` Sakari Ailus
2019-08-07 7:20 ` Sakari Ailus
2019-08-07 7:20 ` Sakari Ailus
2019-08-07 7:20 ` Sakari Ailus
2019-08-07 8:07 ` Hans Verkuil
2019-08-07 8:07 ` [Xen-devel] " Hans Verkuil
2019-08-07 8:07 ` Hans Verkuil
2019-08-07 8:07 ` Hans Verkuil
2019-08-07 8:07 ` Hans Verkuil
2019-08-07 8:07 ` Hans Verkuil
2019-08-07 1:33 ` [PATCH v3 12/41] genwqe: " john.hubbard
2019-08-07 1:33 ` [Xen-devel] " john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` [PATCH v3 13/41] scif: " john.hubbard
2019-08-07 1:33 ` [Xen-devel] " john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` [PATCH v3 14/41] vmci: " john.hubbard
2019-08-07 1:33 ` [Xen-devel] " john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard [this message]
2019-08-07 1:33 ` [Xen-devel] [PATCH v3 15/41] rapidio: " john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` [PATCH v3 16/41] oradax: " john.hubbard
2019-08-07 1:33 ` [Xen-devel] " john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` [PATCH v3 17/41] staging/vc04_services: " john.hubbard
2019-08-07 1:33 ` [Xen-devel] " john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` [PATCH v3 18/41] drivers/tee: " john.hubbard
2019-08-07 1:33 ` [Xen-devel] " john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` [PATCH v3 19/41] vfio: " john.hubbard
2019-08-07 1:33 ` [Xen-devel] " john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` [PATCH v3 20/41] fbdev/pvr2fb: " john.hubbard
2019-08-07 1:33 ` [Xen-devel] " john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-09 11:38 ` Bartlomiej Zolnierkiewicz
2019-08-09 11:38 ` [Xen-devel] " Bartlomiej Zolnierkiewicz
2019-08-09 11:38 ` Bartlomiej Zolnierkiewicz
2019-08-09 11:38 ` Bartlomiej Zolnierkiewicz
2019-08-09 11:38 ` Bartlomiej Zolnierkiewicz
2019-08-09 11:38 ` Bartlomiej Zolnierkiewicz
2019-08-07 1:33 ` [PATCH v3 21/41] fsl_hypervisor: " john.hubbard
2019-08-07 1:33 ` [Xen-devel] " john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` [PATCH v3 22/41] xen: " john.hubbard
2019-08-07 1:33 ` [Xen-devel] " john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` [PATCH v3 23/41] fs/exec.c: " john.hubbard
2019-08-07 1:33 ` [Xen-devel] " john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` [PATCH v3 24/41] orangefs: " john.hubbard
2019-08-07 1:33 ` [Xen-devel] " john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` [PATCH v3 25/41] uprobes: " john.hubbard
2019-08-07 1:33 ` [Xen-devel] " john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` [PATCH v3 26/41] futex: " john.hubbard
2019-08-07 1:33 ` [Xen-devel] " john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` [PATCH v3 27/41] mm/frame_vector.c: " john.hubbard
2019-08-07 1:33 ` [Xen-devel] " john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` [PATCH v3 28/41] mm/gup_benchmark.c: " john.hubbard
2019-08-07 1:33 ` [Xen-devel] " john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` [PATCH v3 29/41] mm/memory.c: " john.hubbard
2019-08-07 1:33 ` [Xen-devel] " john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` [PATCH v3 30/41] mm/madvise.c: " john.hubbard
2019-08-07 1:33 ` [Xen-devel] " john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` [PATCH v3 31/41] mm/process_vm_access.c: " john.hubbard
2019-08-07 1:33 ` [Xen-devel] " john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` [PATCH v3 32/41] crypt: " john.hubbard
2019-08-07 1:33 ` [Xen-devel] " john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` [PATCH v3 33/41] fs/nfs: " john.hubbard
2019-08-07 1:33 ` [Xen-devel] " john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` [PATCH v3 34/41] goldfish_pipe: " john.hubbard
2019-08-07 1:33 ` [Xen-devel] " john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` [PATCH v3 35/41] kernel/events/core.c: " john.hubbard
2019-08-07 1:33 ` [Xen-devel] " john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` [PATCH v3 36/41] fs/binfmt_elf: " john.hubbard
2019-08-07 1:33 ` [Xen-devel] " john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` [PATCH v3 37/41] security/tomoyo: " john.hubbard
2019-08-07 1:33 ` [Xen-devel] " john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` [PATCH v3 38/41] powerpc: " john.hubbard
2019-08-07 1:33 ` [Xen-devel] " john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-08 5:42 ` Michael Ellerman
2019-08-08 5:42 ` [Xen-devel] " Michael Ellerman
2019-08-08 5:42 ` Michael Ellerman
2019-08-08 5:42 ` Michael Ellerman
2019-08-08 5:42 ` Michael Ellerman
2019-08-08 5:42 ` Michael Ellerman
2019-08-08 5:42 ` Michael Ellerman
2019-08-09 1:26 ` John Hubbard
2019-08-09 1:26 ` [Xen-devel] " John Hubbard
2019-08-09 1:26 ` John Hubbard
2019-08-09 1:26 ` John Hubbard
2019-08-09 1:26 ` John Hubbard
2019-08-09 1:26 ` John Hubbard
2019-08-09 1:26 ` John Hubbard
2019-08-09 12:20 ` Michael Ellerman
2019-08-09 12:20 ` [Xen-devel] " Michael Ellerman
2019-08-09 12:20 ` Michael Ellerman
2019-08-09 12:20 ` Michael Ellerman
2019-08-09 12:20 ` Michael Ellerman
2019-08-09 12:20 ` Michael Ellerman
2019-08-09 12:20 ` Michael Ellerman
2019-08-07 1:33 ` [PATCH v3 39/41] mm/mlock.c: " john.hubbard
2019-08-07 1:33 ` [Xen-devel] " john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` [PATCH v3 40/41] mm/mempolicy.c: " john.hubbard
2019-08-07 1:33 ` [Xen-devel] " john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` [PATCH v3 41/41] mm/ksm: " john.hubbard
2019-08-07 1:33 ` [Xen-devel] " john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:33 ` john.hubbard
2019-08-07 1:49 ` [PATCH v3 00/39] put_user_pages(): miscellaneous call sites John Hubbard
2019-08-07 1:49 ` [Xen-devel] " John Hubbard
2019-08-07 1:49 ` John Hubbard
2019-08-07 1:49 ` John Hubbard
2019-08-07 1:49 ` John Hubbard
2019-08-07 1:49 ` John Hubbard
2019-08-07 1:49 ` John Hubbard
2019-08-30 1:29 ` Mike Marshall
2019-08-30 1:29 ` [Xen-devel] " Mike Marshall
2019-08-30 1:29 ` Mike Marshall
2019-08-30 1:29 ` Mike Marshall
2019-08-30 1:29 ` Mike Marshall
2019-08-30 2:21 ` John Hubbard
2019-08-30 2:21 ` [Xen-devel] " John Hubbard
2019-08-30 2:21 ` John Hubbard
2019-08-30 2:21 ` John Hubbard
2019-08-30 2:21 ` John Hubbard
2019-08-09 13:33 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-08-09 13:54 ` ✓ Fi.CI.BAT: success " Patchwork
2019-08-10 7:21 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190807013340.9706-16-jhubbard@nvidia.com \
--to=john.hubbard@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alex.bou9@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=ceph-devel@vger.kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@fromorbit.com \
--cc=devel@driverdev.osuosl.org \
--cc=devel@lists.orangefs.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@infradead.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ioan.nicu.ext@nokia.com \
--cc=ira.weiny@intel.com \
--cc=jack@suse.cz \
--cc=jgg@ziepe.ca \
--cc=jglisse@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=keescook@chromium.org \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=mporter@kernel.crashing.org \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
--cc=sparclinux@vger.kernel.org \
--cc=tvrtko.ursulin@intel.com \
--cc=viro@zeniv.linux.org.uk \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.