From: Dave Martin <Dave.Martin@arm.com> To: Cristian Marussi <cristian.marussi@arm.com> Cc: linux-kselftest@vger.kernel.org, linux-arm-kernel@lists.infradead.org, shuah@kernel.org, andreyknvl@google.com, dave.martin@arm.com Subject: Re: [PATCH v3 01/11] kselftest: arm64: introduce new boilerplate code Date: Tue, 13 Aug 2019 17:23:37 +0100 [thread overview] Message-ID: <20190813162337.GY10425@arm.com> (raw) In-Reply-To: <20190802170300.20662-2-cristian.marussi@arm.com> ^ Regarding the subject line, "boilerplate code" sounds a bit vague. Could we say something like "Add skeleton Makefile"? On Fri, Aug 02, 2019 at 06:02:50PM +0100, Cristian Marussi wrote: > Added a new arm64-specific empty subsystem amongst TARGETS of KSFT build > framework; once populated with testcases, it will be possible to build > and invoke the new KSFT TARGETS=arm64 related tests from the toplevel > Makefile in the usual ways. > > Signed-off-by: Cristian Marussi <cristian.marussi@arm.com> > --- > Reviewed the build instructions reported in the README, to be more > agnostic regarding user/device etc.. > --- > tools/testing/selftests/Makefile | 1 + > tools/testing/selftests/arm64/Makefile | 51 ++++++++++++++++++++++++++ > tools/testing/selftests/arm64/README | 43 ++++++++++++++++++++++ > 3 files changed, 95 insertions(+) > create mode 100644 tools/testing/selftests/arm64/Makefile > create mode 100644 tools/testing/selftests/arm64/README > > diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile > index 25b43a8c2b15..1722dae9381a 100644 > --- a/tools/testing/selftests/Makefile > +++ b/tools/testing/selftests/Makefile > @@ -1,5 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0 > TARGETS = android > +TARGETS += arm64 > TARGETS += bpf > TARGETS += breakpoints > TARGETS += capabilities > diff --git a/tools/testing/selftests/arm64/Makefile b/tools/testing/selftests/arm64/Makefile > new file mode 100644 > index 000000000000..03a0d4f71218 > --- /dev/null > +++ b/tools/testing/selftests/arm64/Makefile > @@ -0,0 +1,51 @@ > +# SPDX-License-Identifier: GPL-2.0 > +# Copyright (C) 2019 ARM Limited > + > +# When ARCH not overridden for crosscompiling, lookup machine > +ARCH ?= $(shell uname -m) > +ARCH := $(shell echo $(ARCH) | sed -e s/aarch64/arm64/) > + > +ifeq ("x$(ARCH)", "xarm64") > +SUBDIRS := > +else > +SUBDIRS := > +endif > + > +CFLAGS := -Wall -O2 -g > + > +export CC > +export CFLAGS > + > +all: > + @for DIR in $(SUBDIRS); do \ > + BUILD_TARGET=$(OUTPUT)/$$DIR; \ > + mkdir -p $$BUILD_TARGET; \ > + make OUTPUT=$$BUILD_TARGET -C $$DIR $@; \ > + done > + > +install: all > + @for DIR in $(SUBDIRS); do \ > + BUILD_TARGET=$(OUTPUT)/$$DIR; \ > + make OUTPUT=$$BUILD_TARGET -C $$DIR $@; \ > + done > + > +run_tests: all > + @for DIR in $(SUBDIRS); do \ > + BUILD_TARGET=$(OUTPUT)/$$DIR; \ > + make OUTPUT=$$BUILD_TARGET -C $$DIR $@; \ > + done > + > +# Avoid any output on non arm64 on emit_tests > +emit_tests: all > + @for DIR in $(SUBDIRS); do \ > + BUILD_TARGET=$(OUTPUT)/$$DIR; \ > + make OUTPUT=$$BUILD_TARGET -C $$DIR $@; \ > + done > + > +clean: > + @for DIR in $(SUBDIRS); do \ > + BUILD_TARGET=$(OUTPUT)/$$DIR; \ > + make OUTPUT=$$BUILD_TARGET -C $$DIR $@; \ > + done > + > +.PHONY: all clean install run_tests emit_tests > diff --git a/tools/testing/selftests/arm64/README b/tools/testing/selftests/arm64/README > new file mode 100644 > index 000000000000..dee3306071cc > --- /dev/null > +++ b/tools/testing/selftests/arm64/README > @@ -0,0 +1,43 @@ > +KSelfTest ARM64 > +=============== > + > +- These tests are arm64 specific and so not built or run but just skipped > + completely when env-variable ARCH is found to be different than 'arm64' > + and `uname -m` reports other than 'aarch64'. > + > +- Holding true the above, ARM64 KSFT tests can be run: > + > + + as standalone (example for signal tests) > + > + $ make -C tools/testing/selftest/arm64/signal \ > + INSTALL_PATH=<your-installation-path> install > + > + and then launching on the target device inside the installed path: > + > + $ <your-installed-path>/test_arm64_signals.sh [-k | -v] > + > + + within the KSelfTest framework using standard Linux top-level-makefile > + targets: > + > + $ make TARGETS=arm64 kselftest-clean > + $ make TARGETS=arm64 kselftest > + > + Further details on building and running KFST can be found in: > + Documentation/dev-tools/kselftest.rst The next two paragraphs aren't relevant yet. Can we split them out of this patch and add them alongside the relevant code / Makefile changes? > + > +- Tests can depend on some arch-specific definitions which can be found in a > + standard Kernel Headers installation in $(top_srcdir)/usr/include. > + Such Kernel Headers are automatically installed (via make headers_install) > + by KSFT framework itself in a dedicated directory when tests are launched > + via KSFT itself; when running standalone, instead, a Warning is issued > + if such headers cannot be found somewhere (we try to guess a few standard > + locations anyway) > + > +- Some of these tests may be related to possibly not implemented ARMv8 > + features: depending on their implementation status on the effective HW > + we'll expect different results. The tests' harness will take care to check > + at run-time if the required features are supported and will act accordingly. > + Moreover, in order to avoid any kind of compile-time dependency on the > + toolchain (possibly due to the above mentioned not-implemented features), > + we make strictly use of direct 'S3_ sysreg' raw-encoding while checking for > + those features and/or lookin up sysregs. This last paragraph is only relevant for people adding new tests. It probably makes sense to start "When adding new tests, try to avoid unnecessary toolchain dependencies where possible. [...]" Cheers ---Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Martin <Dave.Martin@arm.com> To: Cristian Marussi <cristian.marussi@arm.com> Cc: andreyknvl@google.com, shuah@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org, dave.martin@arm.com Subject: Re: [PATCH v3 01/11] kselftest: arm64: introduce new boilerplate code Date: Tue, 13 Aug 2019 17:23:37 +0100 [thread overview] Message-ID: <20190813162337.GY10425@arm.com> (raw) In-Reply-To: <20190802170300.20662-2-cristian.marussi@arm.com> ^ Regarding the subject line, "boilerplate code" sounds a bit vague. Could we say something like "Add skeleton Makefile"? On Fri, Aug 02, 2019 at 06:02:50PM +0100, Cristian Marussi wrote: > Added a new arm64-specific empty subsystem amongst TARGETS of KSFT build > framework; once populated with testcases, it will be possible to build > and invoke the new KSFT TARGETS=arm64 related tests from the toplevel > Makefile in the usual ways. > > Signed-off-by: Cristian Marussi <cristian.marussi@arm.com> > --- > Reviewed the build instructions reported in the README, to be more > agnostic regarding user/device etc.. > --- > tools/testing/selftests/Makefile | 1 + > tools/testing/selftests/arm64/Makefile | 51 ++++++++++++++++++++++++++ > tools/testing/selftests/arm64/README | 43 ++++++++++++++++++++++ > 3 files changed, 95 insertions(+) > create mode 100644 tools/testing/selftests/arm64/Makefile > create mode 100644 tools/testing/selftests/arm64/README > > diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile > index 25b43a8c2b15..1722dae9381a 100644 > --- a/tools/testing/selftests/Makefile > +++ b/tools/testing/selftests/Makefile > @@ -1,5 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0 > TARGETS = android > +TARGETS += arm64 > TARGETS += bpf > TARGETS += breakpoints > TARGETS += capabilities > diff --git a/tools/testing/selftests/arm64/Makefile b/tools/testing/selftests/arm64/Makefile > new file mode 100644 > index 000000000000..03a0d4f71218 > --- /dev/null > +++ b/tools/testing/selftests/arm64/Makefile > @@ -0,0 +1,51 @@ > +# SPDX-License-Identifier: GPL-2.0 > +# Copyright (C) 2019 ARM Limited > + > +# When ARCH not overridden for crosscompiling, lookup machine > +ARCH ?= $(shell uname -m) > +ARCH := $(shell echo $(ARCH) | sed -e s/aarch64/arm64/) > + > +ifeq ("x$(ARCH)", "xarm64") > +SUBDIRS := > +else > +SUBDIRS := > +endif > + > +CFLAGS := -Wall -O2 -g > + > +export CC > +export CFLAGS > + > +all: > + @for DIR in $(SUBDIRS); do \ > + BUILD_TARGET=$(OUTPUT)/$$DIR; \ > + mkdir -p $$BUILD_TARGET; \ > + make OUTPUT=$$BUILD_TARGET -C $$DIR $@; \ > + done > + > +install: all > + @for DIR in $(SUBDIRS); do \ > + BUILD_TARGET=$(OUTPUT)/$$DIR; \ > + make OUTPUT=$$BUILD_TARGET -C $$DIR $@; \ > + done > + > +run_tests: all > + @for DIR in $(SUBDIRS); do \ > + BUILD_TARGET=$(OUTPUT)/$$DIR; \ > + make OUTPUT=$$BUILD_TARGET -C $$DIR $@; \ > + done > + > +# Avoid any output on non arm64 on emit_tests > +emit_tests: all > + @for DIR in $(SUBDIRS); do \ > + BUILD_TARGET=$(OUTPUT)/$$DIR; \ > + make OUTPUT=$$BUILD_TARGET -C $$DIR $@; \ > + done > + > +clean: > + @for DIR in $(SUBDIRS); do \ > + BUILD_TARGET=$(OUTPUT)/$$DIR; \ > + make OUTPUT=$$BUILD_TARGET -C $$DIR $@; \ > + done > + > +.PHONY: all clean install run_tests emit_tests > diff --git a/tools/testing/selftests/arm64/README b/tools/testing/selftests/arm64/README > new file mode 100644 > index 000000000000..dee3306071cc > --- /dev/null > +++ b/tools/testing/selftests/arm64/README > @@ -0,0 +1,43 @@ > +KSelfTest ARM64 > +=============== > + > +- These tests are arm64 specific and so not built or run but just skipped > + completely when env-variable ARCH is found to be different than 'arm64' > + and `uname -m` reports other than 'aarch64'. > + > +- Holding true the above, ARM64 KSFT tests can be run: > + > + + as standalone (example for signal tests) > + > + $ make -C tools/testing/selftest/arm64/signal \ > + INSTALL_PATH=<your-installation-path> install > + > + and then launching on the target device inside the installed path: > + > + $ <your-installed-path>/test_arm64_signals.sh [-k | -v] > + > + + within the KSelfTest framework using standard Linux top-level-makefile > + targets: > + > + $ make TARGETS=arm64 kselftest-clean > + $ make TARGETS=arm64 kselftest > + > + Further details on building and running KFST can be found in: > + Documentation/dev-tools/kselftest.rst The next two paragraphs aren't relevant yet. Can we split them out of this patch and add them alongside the relevant code / Makefile changes? > + > +- Tests can depend on some arch-specific definitions which can be found in a > + standard Kernel Headers installation in $(top_srcdir)/usr/include. > + Such Kernel Headers are automatically installed (via make headers_install) > + by KSFT framework itself in a dedicated directory when tests are launched > + via KSFT itself; when running standalone, instead, a Warning is issued > + if such headers cannot be found somewhere (we try to guess a few standard > + locations anyway) > + > +- Some of these tests may be related to possibly not implemented ARMv8 > + features: depending on their implementation status on the effective HW > + we'll expect different results. The tests' harness will take care to check > + at run-time if the required features are supported and will act accordingly. > + Moreover, in order to avoid any kind of compile-time dependency on the > + toolchain (possibly due to the above mentioned not-implemented features), > + we make strictly use of direct 'S3_ sysreg' raw-encoding while checking for > + those features and/or lookin up sysregs. This last paragraph is only relevant for people adding new tests. It probably makes sense to start "When adding new tests, try to avoid unnecessary toolchain dependencies where possible. [...]" Cheers ---Dave _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-13 16:23 UTC|newest] Thread overview: 112+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-02 17:02 [PATCH v3 00/11] Add arm64/signal initial kselftest support Cristian Marussi 2019-08-02 17:02 ` Cristian Marussi 2019-08-02 17:02 ` [PATCH v3 01/11] kselftest: arm64: introduce new boilerplate code Cristian Marussi 2019-08-02 17:02 ` Cristian Marussi 2019-08-13 16:23 ` Dave Martin [this message] 2019-08-13 16:23 ` Dave Martin 2019-08-27 12:14 ` Cristian Marussi 2019-08-27 12:14 ` Cristian Marussi 2019-08-02 17:02 ` [PATCH v3 02/11] kselftest: arm64: adds first test and common utils Cristian Marussi 2019-08-02 17:02 ` Cristian Marussi 2019-08-06 15:50 ` Cristian Marussi 2019-08-06 15:50 ` Cristian Marussi 2019-08-07 15:42 ` Cristian Marussi 2019-08-07 15:42 ` Cristian Marussi 2019-08-09 10:54 ` Cristian Marussi 2019-08-09 10:54 ` Cristian Marussi 2019-08-09 11:16 ` Dave Martin 2019-08-09 11:16 ` Dave Martin 2019-08-09 12:20 ` Cristian Marussi 2019-08-09 12:20 ` Cristian Marussi 2019-08-09 12:32 ` Dave Martin 2019-08-09 12:32 ` Dave Martin 2019-08-12 12:43 ` Amit Kachhap 2019-08-12 12:43 ` Amit Kachhap 2019-08-13 13:22 ` Cristian Marussi 2019-08-13 13:22 ` Cristian Marussi 2019-08-14 10:22 ` Amit Kachhap 2019-08-14 10:22 ` Amit Kachhap 2019-08-27 14:24 ` Cristian Marussi 2019-08-27 14:24 ` Cristian Marussi 2019-08-13 16:24 ` Dave Martin 2019-08-13 16:24 ` Dave Martin 2019-08-28 17:34 ` Cristian Marussi 2019-08-28 17:34 ` Cristian Marussi 2019-09-03 15:34 ` Dave Martin 2019-09-03 15:34 ` Dave Martin 2019-09-03 16:08 ` Cristian Marussi 2019-09-03 16:08 ` Cristian Marussi 2019-08-02 17:02 ` [PATCH v3 03/11] kselftest: arm64: mangle_pstate_invalid_daif_bits Cristian Marussi 2019-08-02 17:02 ` Cristian Marussi 2019-08-13 16:24 ` Dave Martin 2019-08-13 16:24 ` Dave Martin 2019-08-29 10:19 ` Cristian Marussi 2019-08-29 10:19 ` Cristian Marussi 2019-08-02 17:02 ` [PATCH v3 04/11] kselftest: arm64: mangle_pstate_invalid_mode_el Cristian Marussi 2019-08-02 17:02 ` Cristian Marussi 2019-08-13 16:24 ` Dave Martin 2019-08-13 16:24 ` Dave Martin 2019-08-29 11:50 ` Cristian Marussi 2019-08-29 11:50 ` Cristian Marussi 2019-08-02 17:02 ` [PATCH v3 05/11] kselftest: arm64: mangle_pstate_ssbs_regs Cristian Marussi 2019-08-02 17:02 ` Cristian Marussi 2019-08-13 16:25 ` Dave Martin 2019-08-13 16:25 ` Dave Martin 2019-08-29 15:35 ` Cristian Marussi 2019-08-29 15:35 ` Cristian Marussi 2019-08-02 17:02 ` [PATCH v3 06/11] kselftest: arm64: fake_sigreturn_bad_magic Cristian Marussi 2019-08-02 17:02 ` Cristian Marussi 2019-08-13 16:25 ` Dave Martin 2019-08-13 16:25 ` Dave Martin 2019-08-30 14:29 ` Cristian Marussi 2019-08-30 14:29 ` Cristian Marussi 2019-09-04 10:05 ` Dave Martin 2019-09-04 10:05 ` Dave Martin 2019-09-04 10:37 ` Cristian Marussi 2019-09-04 10:37 ` Cristian Marussi 2019-09-04 10:47 ` Dave Martin 2019-09-04 10:47 ` Dave Martin 2019-08-02 17:02 ` [PATCH v3 07/11] kselftest: arm64: fake_sigreturn_bad_size_for_magic0 Cristian Marussi 2019-08-02 17:02 ` Cristian Marussi 2019-08-13 16:25 ` Dave Martin 2019-08-13 16:25 ` Dave Martin 2019-08-30 14:49 ` Cristian Marussi 2019-08-30 14:49 ` Cristian Marussi 2019-08-02 17:02 ` [PATCH v3 08/11] kselftest: arm64: fake_sigreturn_missing_fpsimd Cristian Marussi 2019-08-02 17:02 ` Cristian Marussi 2019-08-13 16:26 ` Dave Martin 2019-08-13 16:26 ` Dave Martin 2019-08-30 14:55 ` Cristian Marussi 2019-08-30 14:55 ` Cristian Marussi 2019-08-02 17:02 ` [PATCH v3 09/11] kselftest: arm64: fake_sigreturn_duplicated_fpsimd Cristian Marussi 2019-08-02 17:02 ` Cristian Marussi 2019-08-13 16:26 ` Dave Martin 2019-08-13 16:26 ` Dave Martin 2019-08-30 15:11 ` Cristian Marussi 2019-08-30 15:11 ` Cristian Marussi 2019-08-02 17:02 ` [PATCH v3 10/11] kselftest: arm64: fake_sigreturn_bad_size Cristian Marussi 2019-08-02 17:02 ` Cristian Marussi 2019-08-13 16:26 ` Dave Martin 2019-08-13 16:26 ` Dave Martin 2019-08-30 15:21 ` Cristian Marussi 2019-08-30 15:21 ` Cristian Marussi 2019-08-02 17:03 ` [PATCH v3 11/11] kselftest: arm64: fake_sigreturn_misaligned_sp Cristian Marussi 2019-08-02 17:03 ` Cristian Marussi 2019-08-07 16:04 ` Cristian Marussi 2019-08-07 16:04 ` Cristian Marussi 2019-08-13 16:28 ` Dave Martin 2019-08-13 16:28 ` Dave Martin 2019-08-30 15:22 ` Cristian Marussi 2019-08-30 15:22 ` Cristian Marussi 2019-08-13 16:27 ` Dave Martin 2019-08-13 16:27 ` Dave Martin 2019-08-30 16:33 ` Cristian Marussi 2019-08-30 16:33 ` Cristian Marussi 2019-08-13 16:22 ` [PATCH v3 00/11] Add arm64/signal initial kselftest support Dave Martin 2019-08-13 16:22 ` Dave Martin 2019-08-30 16:40 ` Cristian Marussi 2019-08-30 16:40 ` Cristian Marussi 2019-09-02 10:53 ` Dave Martin 2019-09-02 10:53 ` Dave Martin 2019-09-02 11:30 ` Cristian Marussi 2019-09-02 11:30 ` Cristian Marussi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190813162337.GY10425@arm.com \ --to=dave.martin@arm.com \ --cc=andreyknvl@google.com \ --cc=cristian.marussi@arm.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kselftest@vger.kernel.org \ --cc=shuah@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.