All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Brendan Higgins <brendanhiggins@google.com>,
	frowand.list@gmail.com, gregkh@linuxfoundation.org,
	jpoimboe@redhat.com, keescook@google.com,
	kieran.bingham@ideasonboard.com, mcgrof@kernel.org,
	peterz@infradead.org, robh@kernel.org, shuah@kernel.org,
	tytso@mit.edu, yamada.masahiro@socionext.com
Cc: pmladek@suse.com, linux-doc@vger.kernel.org, amir73il@gmail.com,
	dri-devel@lists.freedesktop.org, Alexander.Levin@microsoft.com,
	linux-kselftest@vger.kernel.org, linux-nvdimm@lists.01.org,
	khilman@baylibre.com, knut.omang@oracle.com, wfg@linux.intel.com,
	joel@jms.id.au, rientjes@google.com, jdike@addtoit.com,
	dan.carpenter@oracle.com, devicetree@vger.kernel.org,
	linux-kbuild@vger.kernel.org, Tim.Bird@sony.com,
	linux-um@lists.infradead.org, rostedt@goodmis.org,
	julia.lawall@lip6.fr, kunit-dev@googlegroups.com, richard@nod.at,
	rdunlap@infradead.org, linux-kernel@vger.kernel.org,
	daniel@ffwll.ch, mpe@ellerman.id.au,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v13 03/18] kunit: test: add string_stream a std::stream like string builder
Date: Wed, 14 Aug 2019 00:17:51 -0700	[thread overview]
Message-ID: <20190814071752.1CF0F2054F@mail.kernel.org> (raw)
In-Reply-To: <20190814055108.214253-4-brendanhiggins@google.com>

Quoting Brendan Higgins (2019-08-13 22:50:53)
> A number of test features need to do pretty complicated string printing
> where it may not be possible to rely on a single preallocated string
> with parameters.
> 
> So provide a library for constructing the string as you go similar to
> C++'s std::string. string_stream is really just a string builder,
> nothing more.
> 
> Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
> ---

Reviewed-by: Stephen Boyd <swboyd@chromium.org>

The spinlocks will probably need to change to be irqsaves in the future,
but I guess we can cross that bridge when we come to it.

_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org>
To: Brendan Higgins <brendanhiggins@google.com>,
	frowand.list@gmail.com, gregkh@linuxfoundation.org,
	jpoimboe@redhat.com, keescook@google.com,
	kieran.bingham@ideasonboard.com, mcgrof@kernel.org,
	peterz@infradead.org, robh@kernel.org, shuah@kernel.org,
	tytso@mit.edu, yamada.masahiro@socionext.com
Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
	kunit-dev@googlegroups.com, linux-doc@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, linux-kbuild@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-nvdimm@lists.01.org, linux-um@lists.infradead.org,
	Alexander.Levin@microsoft.com, Tim.Bird@sony.com,
	amir73il@gmail.com, dan.carpenter@oracle.com, daniel@ffwll.ch,
	jdike@addtoit.com, joel@jms.id.au, julia.lawall@lip6.fr,
	khilman@baylibre.com, knut.omang@oracle.com, logang@deltatee.com,
	mpe@ellerman.id.au, pmladek@suse.com, rdunlap@infradead.org,
	richard@nod.at, rientjes@google.com, rostedt@goodmis.org,
	wfg@linux.intel.com, Brendan Higgins <brendanhiggins@google.com>
Subject: Re: [PATCH v13 03/18] kunit: test: add string_stream a std::stream like string builder
Date: Wed, 14 Aug 2019 00:17:51 -0700	[thread overview]
Message-ID: <20190814071752.1CF0F2054F@mail.kernel.org> (raw)
In-Reply-To: <20190814055108.214253-4-brendanhiggins@google.com>

Quoting Brendan Higgins (2019-08-13 22:50:53)
> A number of test features need to do pretty complicated string printing
> where it may not be possible to rely on a single preallocated string
> with parameters.
> 
> So provide a library for constructing the string as you go similar to
> C++'s std::string. string_stream is really just a string builder,
> nothing more.
> 
> Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
> ---

Reviewed-by: Stephen Boyd <swboyd@chromium.org>

The spinlocks will probably need to change to be irqsaves in the future,
but I guess we can cross that bridge when we come to it.


WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org>
To: frowand.list@gmail.com, gregkh@linuxfoundation.org,
	jpoimboe@redhat.com, keescook@google.com,
	kieran.bingham@ideasonboard.com, mcgrof@kernel.org,
	peterz@infradead.org, robh@kernel.org, shuah@kernel.org,
	tytso@mit.edu, yamada.masahiro@socionext.com
Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
	kunit-dev@googlegroups.com, linux-doc@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, linux-kbuild@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-nvdimm@lists.01.org, linux-um@lists.infradead.org,
	Alexander.Levin@microsoft.com, Tim.Bird@sony.com,
	amir73il@gmail.com, dan.carpenter@oracle.com, daniel@ffwll.ch,
	jdike@addtoit.com, joel@jms.id.au, julia.lawall@lip6.fr,
	khilman@baylibre.com, knut.omang@oracle.com, logang@deltatee.com,
	mpe@ellerman.id.au, pmladek@suse.com, rdunlap@infradead.org,
	richard@nod.at, rientjes@google.com, rostedt@goodmis.org,
	wfg@linux.intel.com, Brendan Higgins <brendanhiggins@google.com>
Subject: Re: [PATCH v13 03/18] kunit: test: add string_stream a std::stream like string builder
Date: Wed, 14 Aug 2019 00:17:51 -0700	[thread overview]
Message-ID: <20190814071752.1CF0F2054F@mail.kernel.org> (raw)
In-Reply-To: <20190814055108.214253-4-brendanhiggins@google.com>

Quoting Brendan Higgins (2019-08-13 22:50:53)
> A number of test features need to do pretty complicated string printing
> where it may not be possible to rely on a single preallocated string
> with parameters.
> 
> So provide a library for constructing the string as you go similar to
> C++'s std::string. string_stream is really just a string builder,
> nothing more.
> 
> Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
> ---

Reviewed-by: Stephen Boyd <swboyd@chromium.org>

The spinlocks will probably need to change to be irqsaves in the future,
but I guess we can cross that bridge when we come to it.

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org>
To: Brendan Higgins <brendanhiggins@google.com>,
	frowand.list@gmail.com, gregkh@linuxfoundation.org,
	jpoimboe@redhat.com, keescook@google.com,
	kieran.bingham@ideasonboard.com, mcgrof@kernel.org,
	peterz@infradead.org, robh@kernel.org, shuah@kernel.org,
	tytso@mit.edu, yamada.masahiro@socionext.com
Cc: pmladek@suse.com, linux-doc@vger.kernel.org, amir73il@gmail.com,
	Brendan Higgins <brendanhiggins@google.com>,
	dri-devel@lists.freedesktop.org, Alexander.Levin@microsoft.com,
	linux-kselftest@vger.kernel.org, linux-nvdimm@lists.01.org,
	khilman@baylibre.com, knut.omang@oracle.com, wfg@linux.intel.com,
	joel@jms.id.au, rientjes@google.com, jdike@addtoit.com,
	dan.carpenter@oracle.com, devicetree@vger.kernel.org,
	linux-kbuild@vger.kernel.org, Tim.Bird@sony.com,
	linux-um@lists.infradead.org, rostedt@goodmis.org,
	julia.lawall@lip6.fr, kunit-dev@googlegroups.com, richard@nod.at,
	rdunlap@infradead.org, linux-kernel@vger.kernel.org,
	daniel@ffwll.ch, mpe@ellerman.id.au,
	linux-fsdevel@vger.kernel.org, logang@deltatee.com
Subject: Re: [PATCH v13 03/18] kunit: test: add string_stream a std::stream like string builder
Date: Wed, 14 Aug 2019 00:17:51 -0700	[thread overview]
Message-ID: <20190814071752.1CF0F2054F@mail.kernel.org> (raw)
In-Reply-To: <20190814055108.214253-4-brendanhiggins@google.com>

Quoting Brendan Higgins (2019-08-13 22:50:53)
> A number of test features need to do pretty complicated string printing
> where it may not be possible to rely on a single preallocated string
> with parameters.
> 
> So provide a library for constructing the string as you go similar to
> C++'s std::string. string_stream is really just a string builder,
> nothing more.
> 
> Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
> ---

Reviewed-by: Stephen Boyd <swboyd@chromium.org>

The spinlocks will probably need to change to be irqsaves in the future,
but I guess we can cross that bridge when we come to it.


_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um


  reply	other threads:[~2019-08-14  7:19 UTC|newest]

Thread overview: 103+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-14  5:50 [PATCH v13 00/18] kunit: introduce KUnit, the Linux kernel unit testing framework Brendan Higgins
2019-08-14  5:50 ` Brendan Higgins
2019-08-14  5:50 ` Brendan Higgins
2019-08-14  5:50 ` [PATCH v13 03/18] kunit: test: add string_stream a std::stream like string builder Brendan Higgins
2019-08-14  5:50   ` Brendan Higgins
2019-08-14  5:50   ` Brendan Higgins
2019-08-14  5:50   ` Brendan Higgins
2019-08-14  7:17   ` Stephen Boyd [this message]
2019-08-14  7:17     ` Stephen Boyd
2019-08-14  7:17     ` Stephen Boyd
2019-08-14  7:17     ` Stephen Boyd
2019-08-14  5:50 ` [PATCH v13 04/18] kunit: test: add assertion printing library Brendan Higgins
2019-08-14  5:50   ` Brendan Higgins
2019-08-14  5:50 ` [PATCH v13 07/18] kunit: test: add initial tests Brendan Higgins
2019-08-14  5:50   ` Brendan Higgins
2019-08-14  5:50 ` [PATCH v13 08/18] objtool: add kunit_try_catch_throw to the noreturn list Brendan Higgins
2019-08-14  5:50   ` Brendan Higgins
2019-08-14  5:50   ` Brendan Higgins
2019-08-14  5:51 ` [PATCH v13 10/18] kunit: test: add tests for kunit test abort Brendan Higgins
2019-08-14  5:51   ` Brendan Higgins
     [not found] ` <20190814055108.214253-1-brendanhiggins-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2019-08-14  5:50   ` [PATCH v13 01/18] kunit: test: add KUnit test runner core Brendan Higgins
2019-08-14  5:50     ` Brendan Higgins
2019-08-14  5:50     ` Brendan Higgins
2019-08-14  5:50   ` [PATCH v13 02/18] kunit: test: add test resource management API Brendan Higgins
2019-08-14  5:50     ` Brendan Higgins
2019-08-14  5:50     ` Brendan Higgins
2019-08-14  5:50   ` [PATCH v13 05/18] kunit: test: add the concept of expectations Brendan Higgins
2019-08-14  5:50     ` Brendan Higgins
2019-08-14  5:50     ` Brendan Higgins
2019-08-14  5:50   ` [PATCH v13 06/18] kbuild: enable building KUnit Brendan Higgins
2019-08-14  5:50     ` Brendan Higgins
2019-08-14  5:50     ` Brendan Higgins
2019-08-14  5:50   ` [PATCH v13 09/18] kunit: test: add support for test abort Brendan Higgins
2019-08-14  5:50     ` Brendan Higgins
2019-08-14  5:50     ` Brendan Higgins
2019-08-14  7:16     ` Stephen Boyd
2019-08-14  7:16       ` Stephen Boyd
2019-08-14  7:16       ` Stephen Boyd
2019-08-14  5:51   ` [PATCH v13 11/18] kunit: test: add the concept of assertions Brendan Higgins
2019-08-14  5:51     ` Brendan Higgins
2019-08-14  5:51     ` Brendan Higgins
2019-08-14  5:51   ` [PATCH v13 12/18] kunit: test: add tests for KUnit managed resources Brendan Higgins
2019-08-14  5:51     ` Brendan Higgins
2019-08-14  5:51     ` Brendan Higgins
     [not found]     ` <20190814055108.214253-13-brendanhiggins-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2019-08-14  7:18       ` Stephen Boyd
2019-08-14  7:18         ` Stephen Boyd
2019-08-14  7:18         ` Stephen Boyd
2019-08-14  7:18         ` Stephen Boyd
2019-08-14  5:51   ` [PATCH v13 13/18] kunit: tool: add Python wrappers for running KUnit tests Brendan Higgins
2019-08-14  5:51     ` Brendan Higgins
2019-08-14  5:51     ` Brendan Higgins
2019-08-14  5:51   ` [PATCH v13 14/18] kunit: defconfig: add defconfigs for building " Brendan Higgins
2019-08-14  5:51     ` Brendan Higgins
2019-08-14  5:51     ` Brendan Higgins
2019-08-14  7:18     ` Stephen Boyd
2019-08-14  7:18       ` Stephen Boyd
2019-08-14  7:18       ` Stephen Boyd
2019-08-14  5:51   ` [PATCH v13 15/18] Documentation: kunit: add documentation for KUnit Brendan Higgins
2019-08-14  5:51     ` Brendan Higgins
2019-08-14  5:51     ` Brendan Higgins
2019-08-14  5:51   ` [PATCH v13 17/18] kernel/sysctl-test: Add null pointer test for sysctl.c:proc_dointvec() Brendan Higgins
2019-08-14  5:51     ` Brendan Higgins
2019-08-14  5:51     ` Brendan Higgins
2019-08-14  5:51   ` [PATCH v13 18/18] MAINTAINERS: add proc sysctl KUnit test to PROC SYSCTL section Brendan Higgins
2019-08-14  5:51     ` Brendan Higgins
2019-08-14  5:51     ` Brendan Higgins
2019-08-14  5:51 ` [PATCH v13 16/18] MAINTAINERS: add entry for KUnit the unit testing framework Brendan Higgins
2019-08-14  5:51   ` Brendan Higgins
2019-08-14 10:03 ` [PATCH v13 00/18] kunit: introduce KUnit, the Linux kernel " Brendan Higgins
2019-08-14 10:03   ` Brendan Higgins
2019-08-14 10:03   ` Brendan Higgins
2019-08-14 10:03   ` Brendan Higgins
2019-08-14 10:03   ` Brendan Higgins
2019-08-14 17:23   ` Stephen Boyd
2019-08-14 17:23     ` Stephen Boyd
2019-08-14 17:23     ` Stephen Boyd
2019-08-14 17:23     ` Stephen Boyd
2019-08-20 17:24 ` shuah
2019-08-20 17:24   ` shuah
2019-08-20 17:24   ` shuah
2019-08-20 18:24   ` Brendan Higgins
2019-08-20 18:24     ` Brendan Higgins
2019-08-20 18:24     ` Brendan Higgins
2019-08-20 18:24     ` Brendan Higgins
2019-08-20 19:08     ` shuah
2019-08-20 19:08       ` shuah
2019-08-20 19:08       ` shuah
2019-08-20 19:08       ` shuah
2019-08-20 21:26       ` Brendan Higgins
2019-08-20 21:26         ` Brendan Higgins
2019-08-20 21:26         ` Brendan Higgins
2019-08-20 21:26         ` Brendan Higgins
2019-08-20 21:26         ` Brendan Higgins
2019-08-20 23:23         ` Brendan Higgins
2019-08-20 23:23           ` Brendan Higgins
2019-08-20 23:23           ` Brendan Higgins
2019-08-20 23:23           ` Brendan Higgins
2019-08-20 23:23           ` Brendan Higgins
2019-08-21  0:15           ` shuah
2019-08-21  0:15             ` shuah
2019-08-21  0:15             ` shuah
2019-08-21  0:15             ` shuah
2019-08-21  0:15             ` shuah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190814071752.1CF0F2054F@mail.kernel.org \
    --to=sboyd@kernel.org \
    --cc=Alexander.Levin@microsoft.com \
    --cc=Tim.Bird@sony.com \
    --cc=amir73il@gmail.com \
    --cc=brendanhiggins@google.com \
    --cc=dan.carpenter@oracle.com \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=frowand.list@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jdike@addtoit.com \
    --cc=joel@jms.id.au \
    --cc=jpoimboe@redhat.com \
    --cc=julia.lawall@lip6.fr \
    --cc=keescook@google.com \
    --cc=khilman@baylibre.com \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=knut.omang@oracle.com \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=linux-um@lists.infradead.org \
    --cc=mcgrof@kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=peterz@infradead.org \
    --cc=pmladek@suse.com \
    --cc=rdunlap@infradead.org \
    --cc=richard@nod.at \
    --cc=rientjes@google.com \
    --cc=robh@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=shuah@kernel.org \
    --cc=tytso@mit.edu \
    --cc=wfg@linux.intel.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.