From: Dariusz Marcinkiewicz <darekm@google.com>
To: dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org,
hverkuil-cisco@xs4all.nl
Cc: Dariusz Marcinkiewicz <darekm@google.com>,
Alex Deucher <alexander.deucher@amd.com>,
Allison Randal <allison@lohutok.net>,
amd-gfx@lists.freedesktop.org,
Andrzej Hajda <a.hajda@samsung.com>,
Chris Wilson <chris@chris-wilson.co.uk>,
Colin Ian King <colin.king@canonical.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
David Francis <David.Francis@amd.com>,
Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>,
Douglas Anderson <dianders@chromium.org>,
Enrico Weigelt <info@metux.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hans Verkuil <hverkuil@xs4all.nl>,
Harry Wentland <harry.wentland@amd.com>,
Imre Deak <imre.deak@intel.com>,
intel-gfx@lists.freedesktop.org,
Jani Nikula <jani.nikula@intel.com>,
Jernej Skrabec <jernej.skrabec@siol.net>
Subject: [PATCH v7 0/9] drm: cec: convert DRM drivers to the new notifier API
Date: Wed, 14 Aug 2019 12:44:58 +0200 [thread overview]
Message-ID: <20190814104520.6001-1-darekm@google.com> (raw)
This series updates DRM drivers to use new CEC notifier API.
Changes since v6:
Made CEC notifiers' registration and de-registration symmetric
in tda998x and dw-hdmi drivers. Also, accidentally dropped one
patch in v6 (change to drm_dp_cec), brought it back now.
Changes since v5:
Fixed a warning about a missing comment for a new member of
drm_dp_aux_cec struct. Sending to a wider audience,
including maintainers of respective drivers.
Changes since v4:
Addressing review comments.
Changes since v3:
Updated adapter flags in dw-hdmi-cec.
Changes since v2:
Include all DRM patches from "cec: improve notifier support,
add connector info connector info" series.
Changes since v1:
Those patches delay creation of notifiers until respective
connectors are constructed. It seems that those patches, for a
couple of drivers, by adding the delay, introduce a race between
notifiers' creation and the IRQs handling threads - at least I
don't see anything obvious in there that would explicitly forbid
such races to occur. v2 adds a write barrier to make sure IRQ
threads see the notifier once it is created (replacing the
WRITE_ONCE I put in v1). The best thing to do here, I believe,
would be not to have any synchronization and make sure that an IRQ
only gets enabled after the notifier is created.
Dariusz Marcinkiewicz (9):
drm_dp_cec: add connector info support.
drm/i915/intel_hdmi: use cec_notifier_conn_(un)register
dw-hdmi-cec: use cec_notifier_cec_adap_(un)register
tda9950: use cec_notifier_cec_adap_(un)register
drm: tda998x: use cec_notifier_conn_(un)register
drm: sti: use cec_notifier_conn_(un)register
drm: tegra: use cec_notifier_conn_(un)register
drm: dw-hdmi: use cec_notifier_conn_(un)register
drm: exynos: exynos_hdmi: use cec_notifier_conn_(un)register
.../display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +-
drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c | 13 +++---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 46 +++++++++++++------
drivers/gpu/drm/drm_dp_cec.c | 25 ++++++----
drivers/gpu/drm/exynos/exynos_hdmi.c | 31 +++++++------
drivers/gpu/drm/i2c/tda9950.c | 12 ++---
drivers/gpu/drm/i2c/tda998x_drv.c | 36 ++++++++++-----
drivers/gpu/drm/i915/display/intel_dp.c | 4 +-
drivers/gpu/drm/i915/display/intel_hdmi.c | 13 ++++--
drivers/gpu/drm/nouveau/nouveau_connector.c | 3 +-
drivers/gpu/drm/sti/sti_hdmi.c | 19 +++++---
drivers/gpu/drm/tegra/output.c | 28 ++++++++---
include/drm/drm_dp_helper.h | 17 ++++---
13 files changed, 155 insertions(+), 94 deletions(-)
--
2.23.0.rc1.153.gdeed80330f-goog
WARNING: multiple messages have this Message-ID (diff)
From: Dariusz Marcinkiewicz <darekm@google.com>
To: dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org,
hverkuil-cisco@xs4all.nl
Cc: "Dariusz Marcinkiewicz" <darekm@google.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Allison Randal" <allison@lohutok.net>,
amd-gfx@lists.freedesktop.org,
"Andrzej Hajda" <a.hajda@samsung.com>,
"Chris Wilson" <chris@chris-wilson.co.uk>,
"Colin Ian King" <colin.king@canonical.com>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"David Francis" <David.Francis@amd.com>,
"Dhinakaran Pandiyan" <dhinakaran.pandiyan@intel.com>,
"Douglas Anderson" <dianders@chromium.org>,
"Enrico Weigelt" <info@metux.net>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Hans Verkuil" <hverkuil@xs4all.nl>,
"Harry Wentland" <harry.wentland@amd.com>,
"Imre Deak" <imre.deak@intel.com>,
intel-gfx@lists.freedesktop.org,
"Jani Nikula" <jani.nikula@intel.com>,
"Jernej Skrabec" <jernej.skrabec@siol.net>,
"Jerry (Fangzhi) Zuo" <Jerry.Zuo@amd.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Kate Stewart" <kstewart@linuxfoundation.org>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Leo Li" <sunpeng.li@amd.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-tegra@vger.kernel.org, "Lyude Paul" <lyude@redhat.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Manasi Navare" <manasi.d.navare@intel.com>,
"Neil Armstrong" <narmstrong@baylibre.com>,
nouveau@lists.freedesktop.org,
"Ramalingam C" <ramalingam.c@intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Russell King" <rmk+kernel@armlinux.org.uk>,
"Sam Ravnborg" <sam@ravnborg.org>,
"Sean Paul" <seanpaul@chromium.org>,
"Shashank Sharma" <shashank.sharma@intel.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Thomas Lim" <Thomas.Lim@amd.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Subject: [PATCH v7 0/9] drm: cec: convert DRM drivers to the new notifier API
Date: Wed, 14 Aug 2019 12:44:58 +0200 [thread overview]
Message-ID: <20190814104520.6001-1-darekm@google.com> (raw)
This series updates DRM drivers to use new CEC notifier API.
Changes since v6:
Made CEC notifiers' registration and de-registration symmetric
in tda998x and dw-hdmi drivers. Also, accidentally dropped one
patch in v6 (change to drm_dp_cec), brought it back now.
Changes since v5:
Fixed a warning about a missing comment for a new member of
drm_dp_aux_cec struct. Sending to a wider audience,
including maintainers of respective drivers.
Changes since v4:
Addressing review comments.
Changes since v3:
Updated adapter flags in dw-hdmi-cec.
Changes since v2:
Include all DRM patches from "cec: improve notifier support,
add connector info connector info" series.
Changes since v1:
Those patches delay creation of notifiers until respective
connectors are constructed. It seems that those patches, for a
couple of drivers, by adding the delay, introduce a race between
notifiers' creation and the IRQs handling threads - at least I
don't see anything obvious in there that would explicitly forbid
such races to occur. v2 adds a write barrier to make sure IRQ
threads see the notifier once it is created (replacing the
WRITE_ONCE I put in v1). The best thing to do here, I believe,
would be not to have any synchronization and make sure that an IRQ
only gets enabled after the notifier is created.
Dariusz Marcinkiewicz (9):
drm_dp_cec: add connector info support.
drm/i915/intel_hdmi: use cec_notifier_conn_(un)register
dw-hdmi-cec: use cec_notifier_cec_adap_(un)register
tda9950: use cec_notifier_cec_adap_(un)register
drm: tda998x: use cec_notifier_conn_(un)register
drm: sti: use cec_notifier_conn_(un)register
drm: tegra: use cec_notifier_conn_(un)register
drm: dw-hdmi: use cec_notifier_conn_(un)register
drm: exynos: exynos_hdmi: use cec_notifier_conn_(un)register
.../display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +-
drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c | 13 +++---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 46 +++++++++++++------
drivers/gpu/drm/drm_dp_cec.c | 25 ++++++----
drivers/gpu/drm/exynos/exynos_hdmi.c | 31 +++++++------
drivers/gpu/drm/i2c/tda9950.c | 12 ++---
drivers/gpu/drm/i2c/tda998x_drv.c | 36 ++++++++++-----
drivers/gpu/drm/i915/display/intel_dp.c | 4 +-
drivers/gpu/drm/i915/display/intel_hdmi.c | 13 ++++--
drivers/gpu/drm/nouveau/nouveau_connector.c | 3 +-
drivers/gpu/drm/sti/sti_hdmi.c | 19 +++++---
drivers/gpu/drm/tegra/output.c | 28 ++++++++---
include/drm/drm_dp_helper.h | 17 ++++---
13 files changed, 155 insertions(+), 94 deletions(-)
--
2.23.0.rc1.153.gdeed80330f-goog
WARNING: multiple messages have this Message-ID (diff)
From: Dariusz Marcinkiewicz <darekm@google.com>
To: dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org,
hverkuil-cisco@xs4all.nl
Cc: "Kate Stewart" <kstewart@linuxfoundation.org>,
"Neil Armstrong" <narmstrong@baylibre.com>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Imre Deak" <imre.deak@intel.com>,
"Chris Wilson" <chris@chris-wilson.co.uk>,
"Hans Verkuil" <hverkuil@xs4all.nl>,
"Andrzej Hajda" <a.hajda@samsung.com>,
"Dhinakaran Pandiyan" <dhinakaran.pandiyan@intel.com>,
"Sam Ravnborg" <sam@ravnborg.org>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
linux-samsung-soc@vger.kernel.org,
"David Francis" <David.Francis@amd.com>,
amd-gfx@lists.freedesktop.org, "Leo Li" <sunpeng.li@amd.com>,
"Jerry (Fangzhi) Zuo" <Jerry.Zuo@amd.com>,
linux-arm-kernel@lists.infradead.org,
nouveau@lists.freedesktop.org,
"Harry Wentland" <harry.wentland@amd.com>,
"Shashank Sharma" <shashank.sharma@intel.com>,
"Lyude Paul" <lyude@redhat.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Jani Nikula" <jani.nikula@intel.com>,
intel-gfx@lists.freedesktop.org,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Ramalingam C" <ramalingam.c@intel.com>,
"Russell King" <rmk+kernel@armlinux.org.uk>,
"Sean Paul" <seanpaul@chromium.org>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
linux-tegra@vger.kernel.org,
"Thomas Gleixner" <tglx@linutronix.de>,
"Allison Randal" <allison@lohutok.net>,
"Thomas Lim" <Thomas.Lim@amd.com>,
"Jernej Skrabec" <jernej.skrabec@siol.net>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Douglas Anderson" <dianders@chromium.org>,
linux-kernel@vger.kernel.org,
"Manasi Navare" <manasi.d.navare@intel.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Colin Ian King" <colin.king@canonical.com>,
"Dariusz Marcinkiewicz" <darekm@google.com>,
"Enrico Weigelt" <info@metux.net>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>
Subject: [PATCH v7 0/9] drm: cec: convert DRM drivers to the new notifier API
Date: Wed, 14 Aug 2019 12:44:58 +0200 [thread overview]
Message-ID: <20190814104520.6001-1-darekm@google.com> (raw)
This series updates DRM drivers to use new CEC notifier API.
Changes since v6:
Made CEC notifiers' registration and de-registration symmetric
in tda998x and dw-hdmi drivers. Also, accidentally dropped one
patch in v6 (change to drm_dp_cec), brought it back now.
Changes since v5:
Fixed a warning about a missing comment for a new member of
drm_dp_aux_cec struct. Sending to a wider audience,
including maintainers of respective drivers.
Changes since v4:
Addressing review comments.
Changes since v3:
Updated adapter flags in dw-hdmi-cec.
Changes since v2:
Include all DRM patches from "cec: improve notifier support,
add connector info connector info" series.
Changes since v1:
Those patches delay creation of notifiers until respective
connectors are constructed. It seems that those patches, for a
couple of drivers, by adding the delay, introduce a race between
notifiers' creation and the IRQs handling threads - at least I
don't see anything obvious in there that would explicitly forbid
such races to occur. v2 adds a write barrier to make sure IRQ
threads see the notifier once it is created (replacing the
WRITE_ONCE I put in v1). The best thing to do here, I believe,
would be not to have any synchronization and make sure that an IRQ
only gets enabled after the notifier is created.
Dariusz Marcinkiewicz (9):
drm_dp_cec: add connector info support.
drm/i915/intel_hdmi: use cec_notifier_conn_(un)register
dw-hdmi-cec: use cec_notifier_cec_adap_(un)register
tda9950: use cec_notifier_cec_adap_(un)register
drm: tda998x: use cec_notifier_conn_(un)register
drm: sti: use cec_notifier_conn_(un)register
drm: tegra: use cec_notifier_conn_(un)register
drm: dw-hdmi: use cec_notifier_conn_(un)register
drm: exynos: exynos_hdmi: use cec_notifier_conn_(un)register
.../display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +-
drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c | 13 +++---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 46 +++++++++++++------
drivers/gpu/drm/drm_dp_cec.c | 25 ++++++----
drivers/gpu/drm/exynos/exynos_hdmi.c | 31 +++++++------
drivers/gpu/drm/i2c/tda9950.c | 12 ++---
drivers/gpu/drm/i2c/tda998x_drv.c | 36 ++++++++++-----
drivers/gpu/drm/i915/display/intel_dp.c | 4 +-
drivers/gpu/drm/i915/display/intel_hdmi.c | 13 ++++--
drivers/gpu/drm/nouveau/nouveau_connector.c | 3 +-
drivers/gpu/drm/sti/sti_hdmi.c | 19 +++++---
drivers/gpu/drm/tegra/output.c | 28 ++++++++---
include/drm/drm_dp_helper.h | 17 ++++---
13 files changed, 155 insertions(+), 94 deletions(-)
--
2.23.0.rc1.153.gdeed80330f-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2019-08-14 10:44 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 10:44 Dariusz Marcinkiewicz [this message]
2019-08-14 10:44 ` [PATCH v7 0/9] drm: cec: convert DRM drivers to the new notifier API Dariusz Marcinkiewicz
2019-08-14 10:44 ` Dariusz Marcinkiewicz
2019-08-14 10:44 ` [PATCH v7 1/9] drm_dp_cec: add connector info support Dariusz Marcinkiewicz
2019-08-14 10:44 ` Dariusz Marcinkiewicz
2019-08-15 18:10 ` Lyude Paul
2019-08-15 18:10 ` Lyude Paul
2019-08-26 9:05 ` Ben Skeggs
2019-08-26 9:05 ` Ben Skeggs
2019-08-22 8:08 ` Hans Verkuil
[not found] ` <38cda4f5-3299-2bd4-65f5-9a0f948902c6-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>
2019-08-22 12:40 ` Deucher, Alexander
2019-08-26 9:00 ` Hans Verkuil
2019-08-28 15:05 ` Ville Syrjälä
2019-08-28 15:05 ` Ville Syrjälä
2019-08-14 10:45 ` [PATCH v7 2/9] drm/i915/intel_hdmi: use cec_notifier_conn_(un)register Dariusz Marcinkiewicz
2019-08-22 8:03 ` Hans Verkuil
2019-08-26 8:59 ` Hans Verkuil
2019-08-26 12:08 ` Ville Syrjälä
2019-08-26 12:08 ` Ville Syrjälä
2019-08-14 10:45 ` [PATCH v7 3/9] dw-hdmi-cec: use cec_notifier_cec_adap_(un)register Dariusz Marcinkiewicz
2019-08-19 14:35 ` Neil Armstrong
2019-08-20 7:48 ` Neil Armstrong
2019-08-14 10:45 ` [PATCH v7 4/9] tda9950: " Dariusz Marcinkiewicz
2019-08-14 10:45 ` [PATCH v7 5/9] drm: tda998x: use cec_notifier_conn_(un)register Dariusz Marcinkiewicz
2019-08-19 9:30 ` Hans Verkuil
2019-08-19 11:22 ` [PATCH v7.1 " Dariusz Marcinkiewicz
2019-08-28 7:15 ` [PATCH v7.2 " Dariusz Marcinkiewicz
2019-08-25 13:12 ` [PATCH v7 " Hans Verkuil
2019-08-28 7:18 ` Dariusz Marcinkiewicz
2019-08-14 10:45 ` [PATCH v7 6/9] drm: sti: " Dariusz Marcinkiewicz
2019-08-19 9:34 ` Hans Verkuil
2019-08-22 8:11 ` Hans Verkuil
2019-09-02 13:11 ` Benjamin Gaignard
2019-09-02 13:11 ` Benjamin Gaignard
2019-08-14 10:45 ` [PATCH v7 7/9] drm: tegra: " Dariusz Marcinkiewicz
2019-08-19 9:33 ` Hans Verkuil
2019-08-28 8:09 ` Hans Verkuil
2019-08-28 9:38 ` Thierry Reding
2019-08-28 10:06 ` Hans Verkuil
2019-08-28 11:54 ` Thierry Reding
2019-10-04 8:48 ` Hans Verkuil
2019-10-14 7:51 ` Hans Verkuil
2019-08-28 9:36 ` Thierry Reding
2019-10-14 12:17 ` Thierry Reding
2019-08-14 10:45 ` [PATCH v7 8/9] drm: dw-hdmi: " Dariusz Marcinkiewicz
2019-08-19 9:32 ` Hans Verkuil
2019-08-19 14:05 ` Hans Verkuil
2019-08-19 14:38 ` Neil Armstrong
2019-08-19 14:41 ` Hans Verkuil
2019-08-19 14:47 ` Neil Armstrong
2019-08-19 14:47 ` Neil Armstrong
2019-08-20 7:48 ` Neil Armstrong
2019-08-14 10:45 ` [PATCH v7 9/9] drm: exynos: exynos_hdmi: " Dariusz Marcinkiewicz
2019-08-14 10:45 ` Dariusz Marcinkiewicz
2019-08-19 9:32 ` Hans Verkuil
2019-08-19 9:32 ` Hans Verkuil
2019-08-28 8:39 ` Sylwester Nawrocki
2019-08-28 8:39 ` Sylwester Nawrocki
2019-08-28 12:34 ` [PATCH v7.1 " Dariusz Marcinkiewicz
2019-08-28 12:34 ` Dariusz Marcinkiewicz
2019-08-28 12:38 ` [PATCH v7 " Dariusz Marcinkiewicz
2019-08-28 12:38 ` Dariusz Marcinkiewicz
2019-08-19 9:38 ` [PATCH v7 0/9] drm: cec: convert DRM drivers to the new notifier API Hans Verkuil
2019-08-19 9:38 ` Hans Verkuil
2019-08-19 9:38 ` Hans Verkuil
2019-08-19 11:28 ` Dariusz Marcinkiewicz
2019-08-19 11:28 ` Dariusz Marcinkiewicz
2019-08-19 11:28 ` Dariusz Marcinkiewicz
2019-08-19 12:00 ` Hans Verkuil
2019-08-19 12:00 ` Hans Verkuil
2019-08-19 12:00 ` Hans Verkuil
2019-08-19 14:48 ` Neil Armstrong
2019-08-19 14:48 ` Neil Armstrong
2019-08-19 14:48 ` Neil Armstrong
2019-08-19 14:55 ` Hans Verkuil
2019-08-19 14:55 ` Hans Verkuil
2019-08-19 14:55 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190814104520.6001-1-darekm@google.com \
--to=darekm@google.com \
--cc=David.Francis@amd.com \
--cc=a.hajda@samsung.com \
--cc=alexander.deucher@amd.com \
--cc=allison@lohutok.net \
--cc=amd-gfx@lists.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
--cc=colin.king@canonical.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dhinakaran.pandiyan@intel.com \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=harry.wentland@amd.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=hverkuil@xs4all.nl \
--cc=imre.deak@intel.com \
--cc=info@metux.net \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=jernej.skrabec@siol.net \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.