From: Brian Masney <masneyb@onstation.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>,
Andrzej Hajda <a.hajda@samsung.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
Dave Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Mark Rutland <mark.rutland@arm.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
"open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
MSM <linux-arm-msm@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
freedreno <freedreno@lists.freedesktop.org>
Subject: Re: [PATCH RFC 06/11] drm/bridge: analogix-anx78xx: add support for avdd33 regulator
Date: Thu, 15 Aug 2019 18:51:04 -0400 [thread overview]
Message-ID: <20190815225104.GB32072@onstation.org> (raw)
In-Reply-To: <CACRpkdYdQa+FVfpSjLi0SsBMDT4QC667z1P1dnapz7PXgRoB5Q@mail.gmail.com>
On Thu, Aug 15, 2019 at 10:22:45AM +0200, Linus Walleij wrote:
> On Thu, Aug 15, 2019 at 2:49 AM Brian Masney <masneyb@onstation.org> wrote:
>
> > Add support for the avdd33 regulator to the analogix-anx78xx driver.
> > Note that the regulator is currently enabled during driver probe and
> > disabled when the driver is removed. This is currently how the
> > downstream MSM kernel sources do this.
> >
> > Let's not merge this upstream for the mean time until I get the external
> > display fully working on the Nexus 5 and then I can submit proper
> > support then that powers down this regulator in the power off function.
> >
> > Signed-off-by: Brian Masney <masneyb@onstation.org>
>
> > +static void anx78xx_disable_regulator_action(void *_data)
> > +{
> > + struct anx78xx_platform_data *pdata = _data;
> > +
> > + regulator_disable(pdata->avdd33);
> > +}
> (...)
> > + err = devm_add_action(dev, anx78xx_disable_regulator_action,
> > + pdata);
>
> Clever idea. Good for initial support, probably later on it would
> need to be reworked using runtime PM so it's not constantly
> powered up.
Yes, that's my plan. I suspect that I may have a regulator disabled
somewhere so I was planning to leave this on all the time for the time
being to match the downstream behavior until I get the hot plug detect
GPIO working.
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Thanks,
Brian
WARNING: multiple messages have this Message-ID (diff)
From: Brian Masney <masneyb@onstation.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>,
Andrzej Hajda <a.hajda@samsung.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
Dave Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Mark Rutland <mark.rutland@arm.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
"open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>M
Subject: Re: [PATCH RFC 06/11] drm/bridge: analogix-anx78xx: add support for avdd33 regulator
Date: Thu, 15 Aug 2019 18:51:04 -0400 [thread overview]
Message-ID: <20190815225104.GB32072@onstation.org> (raw)
In-Reply-To: <CACRpkdYdQa+FVfpSjLi0SsBMDT4QC667z1P1dnapz7PXgRoB5Q@mail.gmail.com>
On Thu, Aug 15, 2019 at 10:22:45AM +0200, Linus Walleij wrote:
> On Thu, Aug 15, 2019 at 2:49 AM Brian Masney <masneyb@onstation.org> wrote:
>
> > Add support for the avdd33 regulator to the analogix-anx78xx driver.
> > Note that the regulator is currently enabled during driver probe and
> > disabled when the driver is removed. This is currently how the
> > downstream MSM kernel sources do this.
> >
> > Let's not merge this upstream for the mean time until I get the external
> > display fully working on the Nexus 5 and then I can submit proper
> > support then that powers down this regulator in the power off function.
> >
> > Signed-off-by: Brian Masney <masneyb@onstation.org>
>
> > +static void anx78xx_disable_regulator_action(void *_data)
> > +{
> > + struct anx78xx_platform_data *pdata = _data;
> > +
> > + regulator_disable(pdata->avdd33);
> > +}
> (...)
> > + err = devm_add_action(dev, anx78xx_disable_regulator_action,
> > + pdata);
>
> Clever idea. Good for initial support, probably later on it would
> need to be reworked using runtime PM so it's not constantly
> powered up.
Yes, that's my plan. I suspect that I may have a regulator disabled
somewhere so I was planning to leave this on all the time for the time
being to match the downstream behavior until I get the hot plug detect
GPIO working.
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Thanks,
Brian
WARNING: multiple messages have this Message-ID (diff)
From: Brian Masney <masneyb@onstation.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Neil Armstrong <narmstrong@baylibre.com>,
Dave Airlie <airlied@linux.ie>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jonas Karlman <jonas@kwiboo.se>, Andy Gross <agross@kernel.org>,
"open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Andrzej Hajda <a.hajda@samsung.com>,
Rob Clark <robdclark@gmail.com>, Rob Herring <robh+dt@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Daniel Vetter <daniel@ffwll.ch>,
MSM <linux-arm-msm@vger.kernel.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
freedreno <freedreno@lists.freedesktop.org>,
Sean Paul <sean@poorly.run>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH RFC 06/11] drm/bridge: analogix-anx78xx: add support for avdd33 regulator
Date: Thu, 15 Aug 2019 18:51:04 -0400 [thread overview]
Message-ID: <20190815225104.GB32072@onstation.org> (raw)
In-Reply-To: <CACRpkdYdQa+FVfpSjLi0SsBMDT4QC667z1P1dnapz7PXgRoB5Q@mail.gmail.com>
On Thu, Aug 15, 2019 at 10:22:45AM +0200, Linus Walleij wrote:
> On Thu, Aug 15, 2019 at 2:49 AM Brian Masney <masneyb@onstation.org> wrote:
>
> > Add support for the avdd33 regulator to the analogix-anx78xx driver.
> > Note that the regulator is currently enabled during driver probe and
> > disabled when the driver is removed. This is currently how the
> > downstream MSM kernel sources do this.
> >
> > Let's not merge this upstream for the mean time until I get the external
> > display fully working on the Nexus 5 and then I can submit proper
> > support then that powers down this regulator in the power off function.
> >
> > Signed-off-by: Brian Masney <masneyb@onstation.org>
>
> > +static void anx78xx_disable_regulator_action(void *_data)
> > +{
> > + struct anx78xx_platform_data *pdata = _data;
> > +
> > + regulator_disable(pdata->avdd33);
> > +}
> (...)
> > + err = devm_add_action(dev, anx78xx_disable_regulator_action,
> > + pdata);
>
> Clever idea. Good for initial support, probably later on it would
> need to be reworked using runtime PM so it's not constantly
> powered up.
Yes, that's my plan. I suspect that I may have a regulator disabled
somewhere so I was planning to leave this on all the time for the time
being to match the downstream behavior until I get the hot plug detect
GPIO working.
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Thanks,
Brian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-15 22:51 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190815004916epcas3p4d8a62e215eff5e227721d3449e6bfbd3@epcas3p4.samsung.com>
2019-08-15 0:48 ` [PATCH 00/11] ARM: dts: qcom: msm8974: add support for external display Brian Masney
2019-08-15 0:48 ` Brian Masney
2019-08-15 0:48 ` [PATCH 01/11] dt-bindings: drm/bridge: analogix-anx78xx: add new variants Brian Masney
2019-08-15 0:48 ` Brian Masney
2019-08-15 8:17 ` Linus Walleij
2019-08-15 8:17 ` Linus Walleij
2019-08-15 8:17 ` Linus Walleij
2019-08-27 16:20 ` Rob Herring
2019-08-27 16:20 ` Rob Herring
2019-08-15 0:48 ` [PATCH 02/11] " Brian Masney
2019-08-15 0:48 ` Brian Masney
2019-08-15 0:48 ` Brian Masney
2019-08-15 8:17 ` Linus Walleij
2019-08-15 8:17 ` Linus Walleij
2019-08-15 8:17 ` Linus Walleij
2019-08-15 0:48 ` [PATCH 03/11] drm/bridge: analogix-anx78xx: silence -EPROBE_DEFER warnings Brian Masney
2019-08-15 0:48 ` Brian Masney
2019-08-15 0:48 ` Brian Masney
2019-08-15 8:35 ` Linus Walleij
2019-08-15 8:35 ` Linus Walleij
2019-08-15 8:35 ` Linus Walleij
2019-08-15 0:48 ` [PATCH 04/11] drm/bridge: analogix-anx78xx: convert to i2c_new_dummy_device Brian Masney
2019-08-15 0:48 ` Brian Masney
2019-08-15 0:48 ` Brian Masney
2019-08-15 8:18 ` Linus Walleij
2019-08-15 8:18 ` Linus Walleij
2019-08-15 8:18 ` Linus Walleij
2019-08-15 0:48 ` [PATCH 05/11] drm/bridge: analogix-anx78xx: correct value of TX_P0 Brian Masney
2019-08-15 0:48 ` Brian Masney
2019-08-15 0:48 ` Brian Masney
2019-08-15 8:24 ` Linus Walleij
2019-08-15 8:24 ` Linus Walleij
2019-08-15 8:24 ` Linus Walleij
2019-09-16 10:02 ` Andrzej Hajda
2019-09-16 10:02 ` Andrzej Hajda
2019-09-16 10:36 ` Brian Masney
2019-09-16 10:36 ` Brian Masney
2019-09-16 10:49 ` Laurent Pinchart
2019-09-16 10:49 ` Laurent Pinchart
2019-09-16 11:32 ` Enric Balletbo i Serra
2019-09-16 11:32 ` Enric Balletbo i Serra
2019-09-16 12:02 ` Brian Masney
2019-09-16 12:02 ` Brian Masney
2019-09-16 12:25 ` Andrzej Hajda
2019-09-16 12:25 ` Andrzej Hajda
2019-09-17 7:28 ` Andrzej Hajda
2019-09-17 7:28 ` Andrzej Hajda
2019-09-16 10:36 ` Enric Balletbo i Serra
2019-09-16 10:36 ` Enric Balletbo i Serra
2019-09-16 10:40 ` Brian Masney
2019-09-16 10:40 ` Brian Masney
2019-08-15 0:48 ` [PATCH RFC 06/11] drm/bridge: analogix-anx78xx: add support for avdd33 regulator Brian Masney
2019-08-15 0:48 ` Brian Masney
2019-08-15 0:48 ` Brian Masney
2019-08-15 8:22 ` Linus Walleij
2019-08-15 8:22 ` Linus Walleij
2019-08-15 8:22 ` Linus Walleij
2019-08-15 22:51 ` Brian Masney [this message]
2019-08-15 22:51 ` Brian Masney
2019-08-15 22:51 ` Brian Masney
2019-08-15 0:48 ` [PATCH 07/11] ARM: qcom_defconfig: add CONFIG_DRM_ANALOGIX_ANX78XX Brian Masney
2019-08-15 0:48 ` Brian Masney
2019-08-15 0:48 ` Brian Masney
2019-08-15 8:23 ` Linus Walleij
2019-08-15 8:23 ` Linus Walleij
2019-08-15 8:23 ` Linus Walleij
2019-08-15 0:48 ` [PATCH 08/11] drm/msm/hdmi: silence -EPROBE_DEFER warning Brian Masney
2019-08-15 0:48 ` Brian Masney
2019-08-15 0:48 ` Brian Masney
2019-08-15 8:35 ` Linus Walleij
2019-08-15 8:35 ` Linus Walleij
2019-08-15 8:35 ` Linus Walleij
2019-08-15 0:48 ` [PATCH 09/11] ARM: dts: qcom: pm8941: add 5vs2 regulator node Brian Masney
2019-08-15 0:48 ` Brian Masney
2019-08-15 0:48 ` Brian Masney
2019-08-15 8:34 ` Linus Walleij
2019-08-15 8:34 ` Linus Walleij
2019-08-15 8:34 ` Linus Walleij
2019-08-15 22:44 ` Brian Masney
2019-08-15 22:44 ` Brian Masney
2019-08-15 22:44 ` Brian Masney
2019-08-15 0:48 ` [PATCH RFC 10/11] ARM: dts: qcom: msm8974: add HDMI nodes Brian Masney
2019-08-15 0:48 ` Brian Masney
2019-08-15 0:48 ` Brian Masney
2019-08-15 8:25 ` Linus Walleij
2019-08-15 8:25 ` Linus Walleij
2019-08-15 8:25 ` Linus Walleij
2019-08-15 0:48 ` [PATCH RFC 11/11] ARM: dts: qcom: msm8974-hammerhead: add support for external display Brian Masney
2019-08-15 0:48 ` Brian Masney
2019-08-15 0:48 ` Brian Masney
2019-08-15 8:31 ` Linus Walleij
2019-08-15 8:31 ` Linus Walleij
2019-08-15 8:31 ` Linus Walleij
2019-09-16 8:13 ` [PATCH 00/11] ARM: dts: qcom: msm8974: " Andrzej Hajda
2019-09-16 8:13 ` Andrzej Hajda
2019-09-16 9:01 ` Brian Masney
2019-09-16 9:01 ` Brian Masney
2019-09-16 12:02 ` Andrzej Hajda
2019-09-16 12:02 ` Andrzej Hajda
2019-09-16 12:02 ` Andrzej Hajda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190815225104.GB32072@onstation.org \
--to=masneyb@onstation.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=agross@kernel.org \
--cc=airlied@linux.ie \
--cc=bjorn.andersson@linaro.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=enric.balletbo@collabora.com \
--cc=freedreno@lists.freedesktop.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=narmstrong@baylibre.com \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.