From: Xiaowei Bao <xiaowei.bao@nxp.com> To: bhelgaas@google.com, robh+dt@kernel.org, mark.rutland@arm.com, shawnguo@kernel.org, leoyang.li@nxp.com, kishon@ti.com, lorenzo.pieralisi@arm.co, arnd@arndb.de, gregkh@linuxfoundation.org, minghuan.Lian@nxp.com, mingkai.hu@nxp.com, roy.zang@nxp.com, jingoohan1@gmail.com, gustavo.pimentel@synopsys.com, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, andrew.murray@arm.com Cc: Xiaowei Bao <xiaowei.bao@nxp.com> Subject: [PATCH v2 03/10] PCI: designware-ep: Move the function of getting MSI capability forward Date: Thu, 22 Aug 2019 19:22:35 +0800 [thread overview] Message-ID: <20190822112242.16309-3-xiaowei.bao@nxp.com> (raw) In-Reply-To: <20190822112242.16309-1-xiaowei.bao@nxp.com> Move the function of getting MSI capability to the front of init function, because the init function of the EP platform driver will use the return value by the function of getting MSI capability. Signed-off-by: Xiaowei Bao <xiaowei.bao@nxp.com> --- v2: - No change. drivers/pci/controller/dwc/pcie-designware-ep.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c index b8388f8..0a6c199 100644 --- a/drivers/pci/controller/dwc/pcie-designware-ep.c +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c @@ -656,6 +656,10 @@ int dw_pcie_ep_init(struct dw_pcie_ep *ep) if (ret < 0) epc->max_functions = 1; + ep->msi_cap = dw_pcie_ep_find_capability(pci, PCI_CAP_ID_MSI); + + ep->msix_cap = dw_pcie_ep_find_capability(pci, PCI_CAP_ID_MSIX); + if (ep->ops->ep_init) ep->ops->ep_init(ep); @@ -672,9 +676,6 @@ int dw_pcie_ep_init(struct dw_pcie_ep *ep) dev_err(dev, "Failed to reserve memory for MSI/MSI-X\n"); return -ENOMEM; } - ep->msi_cap = dw_pcie_ep_find_capability(pci, PCI_CAP_ID_MSI); - - ep->msix_cap = dw_pcie_ep_find_capability(pci, PCI_CAP_ID_MSIX); offset = dw_pcie_ep_find_ext_capability(pci, PCI_EXT_CAP_ID_REBAR); if (offset) { -- 2.9.5
WARNING: multiple messages have this Message-ID (diff)
From: Xiaowei Bao <xiaowei.bao@nxp.com> To: bhelgaas@google.com, robh+dt@kernel.org, mark.rutland@arm.com, shawnguo@kernel.org, leoyang.li@nxp.com, kishon@ti.com, lorenzo.pieralisi@arm.co, arnd@arndb.de, gregkh@linuxfoundation.org, minghuan.Lian@nxp.com, mingkai.hu@nxp.com, roy.zang@nxp.com, jingoohan1@gmail.com, gustavo.pimentel@synopsys.com, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, andrew.murray@arm.com Cc: Xiaowei Bao <xiaowei.bao@nxp.com> Subject: [PATCH v2 03/10] PCI: designware-ep: Move the function of getting MSI capability forward Date: Thu, 22 Aug 2019 19:22:35 +0800 [thread overview] Message-ID: <20190822112242.16309-3-xiaowei.bao@nxp.com> (raw) In-Reply-To: <20190822112242.16309-1-xiaowei.bao@nxp.com> Move the function of getting MSI capability to the front of init function, because the init function of the EP platform driver will use the return value by the function of getting MSI capability. Signed-off-by: Xiaowei Bao <xiaowei.bao@nxp.com> --- v2: - No change. drivers/pci/controller/dwc/pcie-designware-ep.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c index b8388f8..0a6c199 100644 --- a/drivers/pci/controller/dwc/pcie-designware-ep.c +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c @@ -656,6 +656,10 @@ int dw_pcie_ep_init(struct dw_pcie_ep *ep) if (ret < 0) epc->max_functions = 1; + ep->msi_cap = dw_pcie_ep_find_capability(pci, PCI_CAP_ID_MSI); + + ep->msix_cap = dw_pcie_ep_find_capability(pci, PCI_CAP_ID_MSIX); + if (ep->ops->ep_init) ep->ops->ep_init(ep); @@ -672,9 +676,6 @@ int dw_pcie_ep_init(struct dw_pcie_ep *ep) dev_err(dev, "Failed to reserve memory for MSI/MSI-X\n"); return -ENOMEM; } - ep->msi_cap = dw_pcie_ep_find_capability(pci, PCI_CAP_ID_MSI); - - ep->msix_cap = dw_pcie_ep_find_capability(pci, PCI_CAP_ID_MSIX); offset = dw_pcie_ep_find_ext_capability(pci, PCI_EXT_CAP_ID_REBAR); if (offset) { -- 2.9.5 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-22 11:33 UTC|newest] Thread overview: 166+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-22 11:22 [PATCH v2 01/10] PCI: designware-ep: Add multiple PFs support for DWC Xiaowei Bao 2019-08-22 11:22 ` Xiaowei Bao 2019-08-22 11:22 ` [PATCH v2 02/10] PCI: designware-ep: Add the doorbell mode of MSI-X in EP mode Xiaowei Bao 2019-08-22 11:22 ` Xiaowei Bao 2019-08-23 13:35 ` Andrew Murray 2019-08-23 13:35 ` Andrew Murray 2019-08-23 13:35 ` Andrew Murray 2019-08-23 23:51 ` Xiaowei Bao 2019-08-23 23:51 ` Xiaowei Bao 2019-08-23 23:51 ` Xiaowei Bao 2019-08-23 23:51 ` Xiaowei Bao 2019-08-22 11:22 ` Xiaowei Bao [this message] 2019-08-22 11:22 ` [PATCH v2 03/10] PCI: designware-ep: Move the function of getting MSI capability forward Xiaowei Bao 2019-08-23 13:38 ` Andrew Murray 2019-08-23 13:38 ` Andrew Murray 2019-08-23 13:38 ` Andrew Murray 2019-08-24 0:20 ` Xiaowei Bao 2019-08-24 0:20 ` Xiaowei Bao 2019-08-24 0:20 ` Xiaowei Bao 2019-08-24 0:20 ` Xiaowei Bao 2019-08-22 11:22 ` [PATCH v2 04/10] dt-bindings: pci: layerscape-pci: add compatible strings for ls1088a and ls2088a Xiaowei Bao 2019-08-22 11:22 ` Xiaowei Bao 2019-08-27 22:26 ` Rob Herring 2019-08-27 22:26 ` Rob Herring 2019-08-27 22:26 ` Rob Herring 2019-08-29 9:19 ` Xiaowei Bao 2019-08-29 9:19 ` Xiaowei Bao 2019-08-29 9:19 ` Xiaowei Bao 2019-08-22 11:22 ` [PATCH v2 05/10] PCI: layerscape: Fix some format issue of the code Xiaowei Bao 2019-08-22 11:22 ` Xiaowei Bao 2019-08-23 13:45 ` Andrew Murray 2019-08-23 13:45 ` Andrew Murray 2019-08-23 13:45 ` Andrew Murray 2019-08-24 0:00 ` Xiaowei Bao 2019-08-24 0:00 ` Xiaowei Bao 2019-08-24 0:00 ` Xiaowei Bao 2019-08-24 0:00 ` Xiaowei Bao 2019-08-22 11:22 ` [PATCH v2 06/10] PCI: layerscape: Modify the way of getting capability with different PEX Xiaowei Bao 2019-08-22 11:22 ` Xiaowei Bao 2019-08-22 11:43 ` Kishon Vijay Abraham I 2019-08-22 11:43 ` Kishon Vijay Abraham I 2019-08-22 11:43 ` Kishon Vijay Abraham I 2019-08-23 2:39 ` Xiaowei Bao 2019-08-23 2:39 ` Xiaowei Bao 2019-08-23 2:39 ` Xiaowei Bao 2019-08-23 2:39 ` Xiaowei Bao 2019-08-23 3:39 ` Kishon Vijay Abraham I 2019-08-23 3:39 ` Kishon Vijay Abraham I 2019-08-23 3:39 ` Kishon Vijay Abraham I 2019-08-23 3:39 ` Kishon Vijay Abraham I 2019-08-23 4:13 ` Xiaowei Bao 2019-08-23 4:13 ` Xiaowei Bao 2019-08-23 4:13 ` Xiaowei Bao 2019-08-23 4:13 ` Xiaowei Bao 2019-09-02 13:36 ` Andrew Murray 2019-09-02 13:36 ` Andrew Murray 2019-09-02 13:36 ` Andrew Murray 2019-09-02 13:36 ` Andrew Murray 2019-09-03 2:11 ` Xiaowei Bao 2019-09-03 2:11 ` Xiaowei Bao 2019-09-03 2:11 ` Xiaowei Bao 2019-09-03 2:11 ` Xiaowei Bao 2019-08-22 11:22 ` [PATCH v2 07/10] PCI: layerscape: Modify the MSIX to the doorbell way Xiaowei Bao 2019-08-22 11:22 ` Xiaowei Bao 2019-08-23 13:58 ` Andrew Murray 2019-08-23 13:58 ` Andrew Murray 2019-08-23 13:58 ` Andrew Murray 2019-08-24 0:08 ` Xiaowei Bao 2019-08-24 0:08 ` Xiaowei Bao 2019-08-24 0:08 ` Xiaowei Bao 2019-08-24 0:08 ` Xiaowei Bao 2019-08-27 13:25 ` Andrew Murray 2019-08-27 13:25 ` Andrew Murray 2019-08-27 13:25 ` Andrew Murray 2019-08-27 13:25 ` Andrew Murray 2019-08-28 2:49 ` Xiaowei Bao 2019-08-28 2:49 ` Xiaowei Bao 2019-08-28 2:49 ` Xiaowei Bao 2019-08-28 2:49 ` Xiaowei Bao 2019-08-29 5:13 ` Kishon Vijay Abraham I 2019-08-29 5:13 ` Kishon Vijay Abraham I 2019-08-29 5:13 ` Kishon Vijay Abraham I 2019-08-29 5:13 ` Kishon Vijay Abraham I 2019-11-05 12:37 ` Lorenzo Pieralisi 2019-11-05 12:37 ` Lorenzo Pieralisi 2019-11-05 12:37 ` Lorenzo Pieralisi 2019-11-06 9:33 ` Xiaowei Bao 2019-11-06 9:33 ` Xiaowei Bao 2019-11-06 9:33 ` Xiaowei Bao 2019-11-06 9:40 ` Gustavo Pimentel 2019-11-06 9:40 ` Gustavo Pimentel 2019-11-06 9:40 ` Gustavo Pimentel 2019-11-06 10:03 ` Xiaowei Bao 2019-11-06 10:03 ` Xiaowei Bao 2019-11-06 10:03 ` Xiaowei Bao 2019-11-06 13:39 ` Kishon Vijay Abraham I 2019-11-06 13:39 ` Kishon Vijay Abraham I 2019-11-06 13:39 ` Kishon Vijay Abraham I 2019-11-06 15:40 ` Gustavo Pimentel 2019-11-06 15:40 ` Gustavo Pimentel 2019-11-06 15:40 ` Gustavo Pimentel 2019-08-22 11:22 ` [PATCH v2 08/10] PCI: layerscape: Add EP mode support for ls1088a and ls2088a Xiaowei Bao 2019-08-22 11:22 ` Xiaowei Bao 2019-08-23 14:27 ` Andrew Murray 2019-08-23 14:27 ` Andrew Murray 2019-08-23 14:27 ` Andrew Murray 2019-08-24 0:18 ` Xiaowei Bao 2019-08-24 0:18 ` Xiaowei Bao 2019-08-24 0:18 ` Xiaowei Bao 2019-08-24 0:18 ` Xiaowei Bao 2019-08-24 6:45 ` christophe leroy 2019-08-24 6:45 ` christophe leroy 2019-08-24 6:45 ` christophe leroy 2019-08-24 6:45 ` christophe leroy 2019-08-25 3:07 ` Xiaowei Bao 2019-08-25 3:07 ` Xiaowei Bao 2019-08-25 3:07 ` Xiaowei Bao 2019-08-25 3:07 ` Xiaowei Bao 2019-08-27 14:48 ` Andrew Murray 2019-08-27 14:48 ` Andrew Murray 2019-08-27 14:48 ` Andrew Murray 2019-08-27 14:48 ` Andrew Murray 2019-08-28 3:25 ` Xiaowei Bao 2019-08-28 3:25 ` Xiaowei Bao 2019-08-28 3:25 ` Xiaowei Bao 2019-08-28 3:25 ` Xiaowei Bao 2019-08-26 9:49 ` Xiaowei Bao 2019-08-26 9:49 ` Xiaowei Bao 2019-08-26 9:49 ` Xiaowei Bao 2019-08-26 9:49 ` Xiaowei Bao 2019-08-27 13:34 ` Andrew Murray 2019-08-27 13:34 ` Andrew Murray 2019-08-27 13:34 ` Andrew Murray 2019-08-27 13:34 ` Andrew Murray 2019-08-28 4:29 ` Xiaowei Bao 2019-08-28 4:29 ` Xiaowei Bao 2019-08-28 4:29 ` Xiaowei Bao 2019-08-28 4:29 ` Xiaowei Bao 2019-08-28 9:01 ` Andrew Murray 2019-08-28 9:01 ` Andrew Murray 2019-08-28 9:01 ` Andrew Murray 2019-08-28 9:01 ` Andrew Murray 2019-08-29 2:03 ` Xiaowei Bao 2019-08-29 2:03 ` Xiaowei Bao 2019-08-29 2:03 ` Xiaowei Bao 2019-08-29 2:03 ` Xiaowei Bao 2019-08-22 11:22 ` [PATCH v2 09/10] arm64: dts: layerscape: Add PCIe EP node for ls1088a Xiaowei Bao 2019-08-22 11:22 ` Xiaowei Bao 2019-08-22 11:22 ` [PATCH v2 10/10] misc: pci_endpoint_test: Add LS1088a in pci_device_id table Xiaowei Bao 2019-08-22 11:22 ` Xiaowei Bao 2019-08-23 13:25 ` [PATCH v2 01/10] PCI: designware-ep: Add multiple PFs support for DWC Andrew Murray 2019-08-23 13:25 ` Andrew Murray 2019-08-23 13:25 ` Andrew Murray 2019-08-23 13:25 ` Andrew Murray 2019-08-23 23:50 ` Xiaowei Bao 2019-08-23 23:50 ` Xiaowei Bao 2019-08-23 23:50 ` Xiaowei Bao 2019-08-23 23:50 ` Xiaowei Bao 2019-08-27 13:10 ` Andrew Murray 2019-08-27 13:10 ` Andrew Murray 2019-08-27 13:10 ` Andrew Murray 2019-08-27 13:10 ` Andrew Murray 2019-08-28 7:22 ` Xiaowei Bao 2019-08-28 7:22 ` Xiaowei Bao 2019-08-28 7:22 ` Xiaowei Bao 2019-08-28 7:22 ` Xiaowei Bao
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190822112242.16309-3-xiaowei.bao@nxp.com \ --to=xiaowei.bao@nxp.com \ --cc=andrew.murray@arm.com \ --cc=arnd@arndb.de \ --cc=bhelgaas@google.com \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=gustavo.pimentel@synopsys.com \ --cc=jingoohan1@gmail.com \ --cc=kishon@ti.com \ --cc=leoyang.li@nxp.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=lorenzo.pieralisi@arm.co \ --cc=mark.rutland@arm.com \ --cc=minghuan.Lian@nxp.com \ --cc=mingkai.hu@nxp.com \ --cc=robh+dt@kernel.org \ --cc=roy.zang@nxp.com \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.