All of lore.kernel.org
 help / color / mirror / Atom feed
From: megous@megous.com
To: Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	Rob Herring <robh+dt@kernel.org>,
	Marcel Holtmann <marcel@holtmann.org>,
	Johan Hedberg <johan.hedberg@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	"David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-bluetooth@vger.kernel.org,
	Ondrej Jirman <megous@megous.com>
Subject: [RESEND PATCH 3/5] bluetooth: hci_bcm: Give more time to come out of reset
Date: Fri, 23 Aug 2019 12:31:37 +0200	[thread overview]
Message-ID: <20190823103139.17687-4-megous@megous.com> (raw)
In-Reply-To: <20190823103139.17687-1-megous@megous.com>

From: Ondrej Jirman <megous@megous.com>

Some supported devices need more time to come out of reset (eg.
BCM4345C5 in AP6256).

I don't have/found a datasheet, so the value was arrive at
experimentally with the Oprange Pi 3 board. Without increased delay,
I got intermittent failures during probe. This is a Bluetooth 5.0
device, so maybe that's why it takes longer to initialize than the
others.

Signed-off-by: Ondrej Jirman <megous@megous.com>
---
 drivers/bluetooth/hci_bcm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c
index 95c312ae94cf..7646636f2d18 100644
--- a/drivers/bluetooth/hci_bcm.c
+++ b/drivers/bluetooth/hci_bcm.c
@@ -260,7 +260,7 @@ static int bcm_gpio_set_power(struct bcm_device *dev, bool powered)
 	}
 
 	/* wait for device to power on and come out of reset */
-	usleep_range(10000, 20000);
+	usleep_range(100000, 120000);
 
 	dev->res_enabled = powered;
 
-- 
2.23.0


WARNING: multiple messages have this Message-ID (diff)
From: megous@megous.com
To: Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	Rob Herring <robh+dt@kernel.org>,
	Marcel Holtmann <marcel@holtmann.org>,
	Johan Hedberg <johan.hedberg@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Ondrej Jirman <megous@megous.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-bluetooth@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH 3/5] bluetooth: hci_bcm: Give more time to come out of reset
Date: Fri, 23 Aug 2019 12:31:37 +0200	[thread overview]
Message-ID: <20190823103139.17687-4-megous@megous.com> (raw)
In-Reply-To: <20190823103139.17687-1-megous@megous.com>

From: Ondrej Jirman <megous@megous.com>

Some supported devices need more time to come out of reset (eg.
BCM4345C5 in AP6256).

I don't have/found a datasheet, so the value was arrive at
experimentally with the Oprange Pi 3 board. Without increased delay,
I got intermittent failures during probe. This is a Bluetooth 5.0
device, so maybe that's why it takes longer to initialize than the
others.

Signed-off-by: Ondrej Jirman <megous@megous.com>
---
 drivers/bluetooth/hci_bcm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c
index 95c312ae94cf..7646636f2d18 100644
--- a/drivers/bluetooth/hci_bcm.c
+++ b/drivers/bluetooth/hci_bcm.c
@@ -260,7 +260,7 @@ static int bcm_gpio_set_power(struct bcm_device *dev, bool powered)
 	}
 
 	/* wait for device to power on and come out of reset */
-	usleep_range(10000, 20000);
+	usleep_range(100000, 120000);
 
 	dev->res_enabled = powered;
 
-- 
2.23.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-08-23 10:31 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-23 10:31 [RESEND PATCH 0/5] Add bluetooth support for Orange Pi 3 megous
2019-08-23 10:31 ` megous
2019-08-23 10:31 ` [RESEND PATCH 1/5] dt-bindings: net: Add compatible for BCM4345C5 bluetooth device megous
2019-08-23 10:31   ` megous
2019-08-23 10:31   ` megous
2019-08-29 22:45   ` Rob Herring
2019-08-29 22:45     ` Rob Herring
2019-08-29 22:45     ` Rob Herring
2019-08-23 10:31 ` [RESEND PATCH 2/5] bluetooth: bcm: Add support for loading firmware for BCM4345C5 megous
2019-08-23 10:31   ` megous
2019-08-23 10:31 ` megous [this message]
2019-08-23 10:31   ` [RESEND PATCH 3/5] bluetooth: hci_bcm: Give more time to come out of reset megous
2019-08-23 10:31 ` [RESEND PATCH 4/5] arm64: dts: allwinner: h6: Add pin configs for uart1 megous
2019-08-23 10:31   ` megous
2019-08-23 10:31 ` [RESEND PATCH 5/5] arm64: dts: allwinner: orange-pi-3: Enable UART1 / Bluetooth megous
2019-08-23 10:31   ` megous
2019-08-30  7:53 ` [RESEND PATCH 0/5] Add bluetooth support for Orange Pi 3 Marcel Holtmann
2019-08-30  7:53   ` Marcel Holtmann
2019-08-30  9:21   ` Maxime Ripard
2019-08-30  9:21     ` Maxime Ripard
2019-08-30 12:43     ` Marcel Holtmann
2019-08-30 12:43       ` Marcel Holtmann
2019-08-30 13:20       ` Maxime Ripard
2019-08-30 13:20         ` Maxime Ripard
2019-09-04 14:19         ` Marcel Holtmann
2019-09-04 14:19           ` Marcel Holtmann
2019-09-05 11:56           ` Maxime Ripard
2019-09-05 11:56             ` Maxime Ripard
2019-10-07 14:11 ` Ondřej Jirman
2019-10-07 14:11   ` Ondřej Jirman
2019-10-07 17:58   ` Maxime Ripard
2019-10-07 17:58     ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190823103139.17687-4-megous@megous.com \
    --to=megous@megous.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=mark.rutland@arm.com \
    --cc=mripard@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.