From: Will Deacon <will@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org,
linux-arch@vger.kernel.org, linux-doc@vger.kernel.org,
Szabolcs Nagy <szabolcs.nagy@arm.com>,
Andrey Konovalov <andreyknvl@google.com>,
Kevin Brodsky <kevin.brodsky@arm.com>,
Will Deacon <will.deacon@arm.com>,
Dave Hansen <dave.hansen@intel.com>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Dave P Martin <Dave.Martin@arm.com>
Subject: Re: [PATCH v8 1/5] mm: untag user pointers in mmap/munmap/mremap/brk
Date: Fri, 23 Aug 2019 16:01:23 +0100 [thread overview]
Message-ID: <20190823150123.okjow4g3mt2znz7c@willie-the-truck> (raw)
In-Reply-To: <20190822164125.acfb97de912996b2b9127c61@linux-foundation.org>
On Thu, Aug 22, 2019 at 04:41:25PM -0700, Andrew Morton wrote:
> On Mon, 19 Aug 2019 17:28:51 +0100 Will Deacon <will@kernel.org> wrote:
>
> > On Thu, Aug 15, 2019 at 04:43:59PM +0100, Catalin Marinas wrote:
> > > There isn't a good reason to differentiate between the user address
> > > space layout modification syscalls and the other memory
> > > permission/attributes ones (e.g. mprotect, madvise) w.r.t. the tagged
> > > address ABI. Untag the user addresses on entry to these functions.
> > >
> > > Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
> > > ---
> > > mm/mmap.c | 5 +++++
> > > mm/mremap.c | 6 +-----
> > > 2 files changed, 6 insertions(+), 5 deletions(-)
> >
> > Acked-by: Will Deacon <will@kernel.org>
> >
> > Andrew -- please can you pick this patch up? I'll take the rest of the
> > series via arm64 once we've finished discussing the wording details.
> >
>
> Sure, I grabbed the patch from the v9 series.
Thanks, Andrew.
> But please feel free to include this in the arm64 tree - I'll autodrop
> my copy if this turns up in linux-next.
I'd prefer for this one to go via you so that it can sit with the rest of
the core changes relating to tagged addresses. Obviously please yell if
you run into any issues with it!
Cheers,
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-arch@vger.kernel.org, linux-doc@vger.kernel.org,
Szabolcs Nagy <szabolcs.nagy@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Kevin Brodsky <kevin.brodsky@arm.com>,
Will Deacon <will.deacon@arm.com>,
Dave P Martin <Dave.Martin@arm.com>,
linux-mm@kvack.org, Andrey Konovalov <andreyknvl@google.com>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Dave Hansen <dave.hansen@intel.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v8 1/5] mm: untag user pointers in mmap/munmap/mremap/brk
Date: Fri, 23 Aug 2019 16:01:23 +0100 [thread overview]
Message-ID: <20190823150123.okjow4g3mt2znz7c@willie-the-truck> (raw)
In-Reply-To: <20190822164125.acfb97de912996b2b9127c61@linux-foundation.org>
On Thu, Aug 22, 2019 at 04:41:25PM -0700, Andrew Morton wrote:
> On Mon, 19 Aug 2019 17:28:51 +0100 Will Deacon <will@kernel.org> wrote:
>
> > On Thu, Aug 15, 2019 at 04:43:59PM +0100, Catalin Marinas wrote:
> > > There isn't a good reason to differentiate between the user address
> > > space layout modification syscalls and the other memory
> > > permission/attributes ones (e.g. mprotect, madvise) w.r.t. the tagged
> > > address ABI. Untag the user addresses on entry to these functions.
> > >
> > > Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
> > > ---
> > > mm/mmap.c | 5 +++++
> > > mm/mremap.c | 6 +-----
> > > 2 files changed, 6 insertions(+), 5 deletions(-)
> >
> > Acked-by: Will Deacon <will@kernel.org>
> >
> > Andrew -- please can you pick this patch up? I'll take the rest of the
> > series via arm64 once we've finished discussing the wording details.
> >
>
> Sure, I grabbed the patch from the v9 series.
Thanks, Andrew.
> But please feel free to include this in the arm64 tree - I'll autodrop
> my copy if this turns up in linux-next.
I'd prefer for this one to go via you so that it can sit with the rest of
the core changes relating to tagged addresses. Obviously please yell if
you run into any issues with it!
Cheers,
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-arch@vger.kernel.org, linux-doc@vger.kernel.org,
Szabolcs Nagy <szabolcs.nagy@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Kevin Brodsky <kevin.brodsky@arm.com>,
Will Deacon <will.deacon@arm.com>,
Dave P Martin <Dave.Martin@arm.com>,
linux-mm@kvack.org, Andrey Konovalov <andreyknvl@google.com>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Dave Hansen <dave.hansen@intel.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v8 1/5] mm: untag user pointers in mmap/munmap/mremap/brk
Date: Fri, 23 Aug 2019 16:01:23 +0100 [thread overview]
Message-ID: <20190823150123.okjow4g3mt2znz7c@willie-the-truck> (raw)
In-Reply-To: <20190822164125.acfb97de912996b2b9127c61@linux-foundation.org>
On Thu, Aug 22, 2019 at 04:41:25PM -0700, Andrew Morton wrote:
> On Mon, 19 Aug 2019 17:28:51 +0100 Will Deacon <will@kernel.org> wrote:
>
> > On Thu, Aug 15, 2019 at 04:43:59PM +0100, Catalin Marinas wrote:
> > > There isn't a good reason to differentiate between the user address
> > > space layout modification syscalls and the other memory
> > > permission/attributes ones (e.g. mprotect, madvise) w.r.t. the tagged
> > > address ABI. Untag the user addresses on entry to these functions.
> > >
> > > Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
> > > ---
> > > mm/mmap.c | 5 +++++
> > > mm/mremap.c | 6 +-----
> > > 2 files changed, 6 insertions(+), 5 deletions(-)
> >
> > Acked-by: Will Deacon <will@kernel.org>
> >
> > Andrew -- please can you pick this patch up? I'll take the rest of the
> > series via arm64 once we've finished discussing the wording details.
> >
>
> Sure, I grabbed the patch from the v9 series.
Thanks, Andrew.
> But please feel free to include this in the arm64 tree - I'll autodrop
> my copy if this turns up in linux-next.
I'd prefer for this one to go via you so that it can sit with the rest of
the core changes relating to tagged addresses. Obviously please yell if
you run into any issues with it!
Cheers,
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-23 15:01 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 15:43 [PATCH v8 0/2] arm64 tagged address ABI Catalin Marinas
2019-08-15 15:43 ` Catalin Marinas
2019-08-15 15:43 ` Catalin Marinas
2019-08-15 15:43 ` [PATCH v8 1/5] mm: untag user pointers in mmap/munmap/mremap/brk Catalin Marinas
2019-08-15 15:43 ` Catalin Marinas
2019-08-15 15:43 ` Catalin Marinas
2019-08-19 15:45 ` Andrey Konovalov
2019-08-19 15:45 ` Andrey Konovalov
2019-08-19 15:45 ` Andrey Konovalov
2019-08-19 15:45 ` Andrey Konovalov
2019-08-19 16:28 ` Will Deacon
2019-08-19 16:28 ` Will Deacon
2019-08-19 16:28 ` Will Deacon
2019-08-22 23:41 ` Andrew Morton
2019-08-22 23:41 ` Andrew Morton
2019-08-22 23:41 ` Andrew Morton
2019-08-23 15:01 ` Will Deacon [this message]
2019-08-23 15:01 ` Will Deacon
2019-08-23 15:01 ` Will Deacon
2019-08-15 15:44 ` [PATCH v8 2/5] arm64: Tighten the PR_{SET,GET}_TAGGED_ADDR_CTRL prctl() unused arguments Catalin Marinas
2019-08-15 15:44 ` [PATCH v8 2/5] arm64: Tighten the PR_{SET, GET}_TAGGED_ADDR_CTRL " Catalin Marinas
2019-08-15 15:44 ` Catalin Marinas
2019-08-19 15:46 ` [PATCH v8 2/5] arm64: Tighten the PR_{SET,GET}_TAGGED_ADDR_CTRL " Andrey Konovalov
2019-08-19 15:46 ` Andrey Konovalov
2019-08-19 15:46 ` Andrey Konovalov
2019-08-19 15:46 ` Andrey Konovalov
2019-08-15 15:44 ` [PATCH v8 3/5] arm64: Change the tagged_addr sysctl control semantics to only prevent the opt-in Catalin Marinas
2019-08-15 15:44 ` Catalin Marinas
2019-08-15 15:44 ` Catalin Marinas
2019-08-19 15:47 ` Andrey Konovalov
2019-08-19 15:47 ` Andrey Konovalov
2019-08-19 15:47 ` Andrey Konovalov
2019-08-19 15:47 ` Andrey Konovalov
2019-08-15 15:44 ` [PATCH v8 4/5] arm64: Define Documentation/arm64/tagged-address-abi.rst Catalin Marinas
2019-08-15 15:44 ` Catalin Marinas
2019-08-15 15:44 ` Catalin Marinas
2019-08-15 16:54 ` Kevin Brodsky
2019-08-15 16:54 ` Kevin Brodsky
2019-08-15 16:54 ` Kevin Brodsky
2019-08-19 15:50 ` Andrey Konovalov
2019-08-19 15:50 ` Andrey Konovalov
2019-08-19 15:50 ` Andrey Konovalov
2019-08-19 15:50 ` Andrey Konovalov
2019-08-19 16:25 ` Will Deacon
2019-08-19 16:25 ` Will Deacon
2019-08-19 16:25 ` Will Deacon
2019-08-15 15:44 ` [PATCH v8 5/5] arm64: Relax Documentation/arm64/tagged-pointers.rst Catalin Marinas
2019-08-15 15:44 ` Catalin Marinas
2019-08-15 15:44 ` Catalin Marinas
2019-08-19 15:48 ` Andrey Konovalov
2019-08-19 15:48 ` Andrey Konovalov
2019-08-19 15:48 ` Andrey Konovalov
2019-08-19 15:48 ` Andrey Konovalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190823150123.okjow4g3mt2znz7c@willie-the-truck \
--to=will@kernel.org \
--cc=Dave.Martin@arm.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@intel.com \
--cc=kevin.brodsky@arm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=szabolcs.nagy@arm.com \
--cc=vincenzo.frascino@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.