From: Wolfram Sang <wsa@the-dreams.de> To: Nishka Dasgupta <nishkadg.linux@gmail.com> Cc: pierre-yves.mordret@st.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, linux-i2c@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] i2c: stm32f7: Make structure stm32f7_i2c_algo constant Date: Tue, 3 Sep 2019 20:05:52 +0200 [thread overview] Message-ID: <20190903180552.GI2171@ninjato> (raw) In-Reply-To: <20190815055857.1944-1-nishkadg.linux@gmail.com> [-- Attachment #1: Type: text/plain, Size: 1175 bytes --] On Thu, Aug 15, 2019 at 11:28:57AM +0530, Nishka Dasgupta wrote: > Static structure stm32f7_i2c_algo, of type i2c_algorithm, is used only > when it is assigned to constant field algo of a variable having type > i2c_adapter. As stm32f7_i2c_algo is therefore never modified, make it > const as well to protect it from unintended modification. > Issue found with Coccinelle. > > Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com> > --- Are you guys okay with this patch? > drivers/i2c/busses/i2c-stm32f7.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c > index 266d1c269b83..d36cf08461f7 100644 > --- a/drivers/i2c/busses/i2c-stm32f7.c > +++ b/drivers/i2c/busses/i2c-stm32f7.c > @@ -1809,7 +1809,7 @@ static u32 stm32f7_i2c_func(struct i2c_adapter *adap) > I2C_FUNC_SMBUS_I2C_BLOCK; > } > > -static struct i2c_algorithm stm32f7_i2c_algo = { > +static const struct i2c_algorithm stm32f7_i2c_algo = { > .master_xfer = stm32f7_i2c_xfer, > .smbus_xfer = stm32f7_i2c_smbus_xfer, > .functionality = stm32f7_i2c_func, > -- > 2.19.1 > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de> To: Nishka Dasgupta <nishkadg.linux@gmail.com> Cc: alexandre.torgue@st.com, linux-kernel@vger.kernel.org, pierre-yves.mordret@st.com, linux-i2c@vger.kernel.org, mcoquelin.stm32@gmail.com, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] i2c: stm32f7: Make structure stm32f7_i2c_algo constant Date: Tue, 3 Sep 2019 20:05:52 +0200 [thread overview] Message-ID: <20190903180552.GI2171@ninjato> (raw) In-Reply-To: <20190815055857.1944-1-nishkadg.linux@gmail.com> [-- Attachment #1.1: Type: text/plain, Size: 1175 bytes --] On Thu, Aug 15, 2019 at 11:28:57AM +0530, Nishka Dasgupta wrote: > Static structure stm32f7_i2c_algo, of type i2c_algorithm, is used only > when it is assigned to constant field algo of a variable having type > i2c_adapter. As stm32f7_i2c_algo is therefore never modified, make it > const as well to protect it from unintended modification. > Issue found with Coccinelle. > > Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com> > --- Are you guys okay with this patch? > drivers/i2c/busses/i2c-stm32f7.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c > index 266d1c269b83..d36cf08461f7 100644 > --- a/drivers/i2c/busses/i2c-stm32f7.c > +++ b/drivers/i2c/busses/i2c-stm32f7.c > @@ -1809,7 +1809,7 @@ static u32 stm32f7_i2c_func(struct i2c_adapter *adap) > I2C_FUNC_SMBUS_I2C_BLOCK; > } > > -static struct i2c_algorithm stm32f7_i2c_algo = { > +static const struct i2c_algorithm stm32f7_i2c_algo = { > .master_xfer = stm32f7_i2c_xfer, > .smbus_xfer = stm32f7_i2c_smbus_xfer, > .functionality = stm32f7_i2c_func, > -- > 2.19.1 > [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-03 18:05 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-15 5:58 [PATCH] i2c: stm32f7: Make structure stm32f7_i2c_algo constant Nishka Dasgupta 2019-08-15 5:58 ` Nishka Dasgupta 2019-09-03 18:05 ` Wolfram Sang [this message] 2019-09-03 18:05 ` Wolfram Sang 2019-09-04 7:47 ` Pierre Yves MORDRET 2019-09-04 7:47 ` Pierre Yves MORDRET 2019-09-04 7:47 ` Pierre Yves MORDRET 2019-09-04 21:12 ` Wolfram Sang 2019-09-04 21:12 ` Wolfram Sang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190903180552.GI2171@ninjato \ --to=wsa@the-dreams.de \ --cc=alexandre.torgue@st.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=mcoquelin.stm32@gmail.com \ --cc=nishkadg.linux@gmail.com \ --cc=pierre-yves.mordret@st.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.