From: Dave Chinner <david@fromorbit.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH 0/7] xfs: log race fixes and cleanups
Date: Wed, 4 Sep 2019 14:24:44 +1000 [thread overview]
Message-ID: <20190904042451.9314-1-david@fromorbit.com> (raw)
HI folks,
This series of patches contain fixes for the generic/530 hangs that
Chandan and Jan reported recently. The first patch in the series is
the main fix for this, though in theory the last patch in the series
is necessary to totally close the problem off.
The second patch is an outstanding fix for a log flush wakeup race
in the xlog_state_do_callback() code from Rik van Riel. Given that
the next 5 patches in the series clean up iand address the tail
pushing race in xlog_state_do_callback(), it makes sense to get this
into the kernel at the same time.
Patches 3-6 factor several independent chunks out of
xlog_state_do_callback, greatly simplifying that function and
breaking the iclog IO completion processing down into discrete
chunks of separate functionality. This makes the code much easier
to read, follow and understand.
An the last patch kicks the AIL if necessary when the log tail is
moved to avod the situation where the AIL pushing has stalled
because the previous last_sync_lsn is further into the log than the
push target reaches.
Comments welcome.
-Dave.
next reply other threads:[~2019-09-04 4:24 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 4:24 Dave Chinner [this message]
2019-09-04 4:24 ` [PATCH 1/7] xfs: push the AIL in xlog_grant_head_wake Dave Chinner
2019-09-04 6:07 ` Christoph Hellwig
2019-09-04 21:46 ` Dave Chinner
2019-09-04 4:24 ` [PATCH 2/7] xfs: fix missed wakeup on l_flush_wait Dave Chinner
2019-09-04 6:07 ` Christoph Hellwig
2019-09-04 21:47 ` Dave Chinner
2019-09-04 4:24 ` [PATCH 3/7] xfs: factor debug code out of xlog_state_do_callback() Dave Chinner
2019-09-04 6:10 ` Christoph Hellwig
2019-09-04 21:14 ` Dave Chinner
2019-09-04 4:24 ` [PATCH 4/7] xfs: factor callbacks " Dave Chinner
2019-09-04 6:13 ` Christoph Hellwig
2019-09-04 6:32 ` Christoph Hellwig
2019-09-04 21:22 ` Dave Chinner
2019-09-04 4:24 ` [PATCH 5/7] xfs: factor iclog state processing " Dave Chinner
2019-09-04 6:42 ` Christoph Hellwig
2019-09-04 21:43 ` Dave Chinner
2019-09-04 4:24 ` [PATCH 6/7] xfs: push iclog state cleaning into xlog_state_clean_log Dave Chinner
2019-09-04 6:44 ` Christoph Hellwig
2019-09-04 4:24 ` [PATCH 7/7] xfs: push the grant head when the log head moves forward Dave Chinner
2019-09-04 6:45 ` Christoph Hellwig
2019-09-04 21:49 ` Dave Chinner
2019-09-04 19:34 ` Brian Foster
2019-09-04 22:50 ` Dave Chinner
2019-09-05 16:25 ` Brian Foster
2019-09-06 0:02 ` Dave Chinner
2019-09-06 13:10 ` Brian Foster
2019-09-07 15:10 ` Brian Foster
2019-09-08 23:26 ` Dave Chinner
2019-09-10 9:56 ` Brian Foster
2019-09-10 23:38 ` Dave Chinner
2019-09-12 13:46 ` Brian Foster
2019-09-17 4:31 ` Darrick J. Wong
2019-09-17 12:48 ` Brian Foster
2019-09-24 17:16 ` Darrick J. Wong
2019-09-26 13:19 ` Brian Foster
2019-09-04 5:26 ` [PATCH 0/7] xfs: log race fixes and cleanups Christoph Hellwig
2019-09-04 5:56 ` Christoph Hellwig
2019-09-04 22:57 ` Dave Chinner
[not found] ` <20190905065133.GA21840@infradead.org>
2019-09-05 7:10 ` Dave Chinner
2019-09-05 7:28 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190904042451.9314-1-david@fromorbit.com \
--to=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.