From: Jonathan Cameron <jic23@kernel.org>
To: Mircea Caprioru <mircea.caprioru@analog.com>
Cc: <Michael.Hennerich@analog.com>, <stefan.popa@analog.com>,
<lars@metafoo.de>, <gregkh@linuxfoundation.org>,
<linux-kernel@vger.kernel.org>, <linux-iio@vger.kernel.org>,
<devicetree@vger.kernel.org>, <robh+dt@kernel.org>
Subject: Re: [PATCH V4 2/4] iio: adc: ad_sigma_delta: Export ad_sd_calibrate
Date: Sun, 8 Sep 2019 10:35:44 +0100 [thread overview]
Message-ID: <20190908103544.18568d02@archlinux> (raw)
In-Reply-To: <20190902130831.23057-2-mircea.caprioru@analog.com>
On Mon, 2 Sep 2019 16:08:29 +0300
Mircea Caprioru <mircea.caprioru@analog.com> wrote:
> This patch exports the ad_sd_calibrate function in order to be able to
> call it from outside ad_sigma_delta.
>
> There are cases where the option to calibrate one channel at a time is
> necessary (ex. system calibration for zero scale and full scale).
>
> Signed-off-by: Mircea Caprioru <mircea.caprioru@analog.com>
Applied, Thanks,
> ---
> Changelog V2:
> - no changes here
>
> Changelog V3:
> - no changes here
>
> Changelog V4:
> - no changes here
>
> drivers/iio/adc/ad_sigma_delta.c | 3 ++-
> include/linux/iio/adc/ad_sigma_delta.h | 2 ++
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ad_sigma_delta.c b/drivers/iio/adc/ad_sigma_delta.c
> index 2640b75fb774..8ba90486c787 100644
> --- a/drivers/iio/adc/ad_sigma_delta.c
> +++ b/drivers/iio/adc/ad_sigma_delta.c
> @@ -205,7 +205,7 @@ int ad_sd_reset(struct ad_sigma_delta *sigma_delta,
> }
> EXPORT_SYMBOL_GPL(ad_sd_reset);
>
> -static int ad_sd_calibrate(struct ad_sigma_delta *sigma_delta,
> +int ad_sd_calibrate(struct ad_sigma_delta *sigma_delta,
> unsigned int mode, unsigned int channel)
> {
> int ret;
> @@ -242,6 +242,7 @@ static int ad_sd_calibrate(struct ad_sigma_delta *sigma_delta,
>
> return ret;
> }
> +EXPORT_SYMBOL_GPL(ad_sd_calibrate);
>
> /**
> * ad_sd_calibrate_all() - Performs channel calibration
> diff --git a/include/linux/iio/adc/ad_sigma_delta.h b/include/linux/iio/adc/ad_sigma_delta.h
> index 7716fa0c9fce..8a4e25a7080c 100644
> --- a/include/linux/iio/adc/ad_sigma_delta.h
> +++ b/include/linux/iio/adc/ad_sigma_delta.h
> @@ -119,6 +119,8 @@ int ad_sd_reset(struct ad_sigma_delta *sigma_delta,
>
> int ad_sigma_delta_single_conversion(struct iio_dev *indio_dev,
> const struct iio_chan_spec *chan, int *val);
> +int ad_sd_calibrate(struct ad_sigma_delta *sigma_delta,
> + unsigned int mode, unsigned int channel);
> int ad_sd_calibrate_all(struct ad_sigma_delta *sigma_delta,
> const struct ad_sd_calib_data *cd, unsigned int n);
> int ad_sd_init(struct ad_sigma_delta *sigma_delta, struct iio_dev *indio_dev,
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org>
To: Mircea Caprioru <mircea.caprioru@analog.com>
Cc: Michael.Hennerich@analog.com, stefan.popa@analog.com,
lars@metafoo.de, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, robh+dt@kernel.org
Subject: Re: [PATCH V4 2/4] iio: adc: ad_sigma_delta: Export ad_sd_calibrate
Date: Sun, 8 Sep 2019 10:35:44 +0100 [thread overview]
Message-ID: <20190908103544.18568d02@archlinux> (raw)
In-Reply-To: <20190902130831.23057-2-mircea.caprioru@analog.com>
On Mon, 2 Sep 2019 16:08:29 +0300
Mircea Caprioru <mircea.caprioru@analog.com> wrote:
> This patch exports the ad_sd_calibrate function in order to be able to
> call it from outside ad_sigma_delta.
>
> There are cases where the option to calibrate one channel at a time is
> necessary (ex. system calibration for zero scale and full scale).
>
> Signed-off-by: Mircea Caprioru <mircea.caprioru@analog.com>
Applied, Thanks,
> ---
> Changelog V2:
> - no changes here
>
> Changelog V3:
> - no changes here
>
> Changelog V4:
> - no changes here
>
> drivers/iio/adc/ad_sigma_delta.c | 3 ++-
> include/linux/iio/adc/ad_sigma_delta.h | 2 ++
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ad_sigma_delta.c b/drivers/iio/adc/ad_sigma_delta.c
> index 2640b75fb774..8ba90486c787 100644
> --- a/drivers/iio/adc/ad_sigma_delta.c
> +++ b/drivers/iio/adc/ad_sigma_delta.c
> @@ -205,7 +205,7 @@ int ad_sd_reset(struct ad_sigma_delta *sigma_delta,
> }
> EXPORT_SYMBOL_GPL(ad_sd_reset);
>
> -static int ad_sd_calibrate(struct ad_sigma_delta *sigma_delta,
> +int ad_sd_calibrate(struct ad_sigma_delta *sigma_delta,
> unsigned int mode, unsigned int channel)
> {
> int ret;
> @@ -242,6 +242,7 @@ static int ad_sd_calibrate(struct ad_sigma_delta *sigma_delta,
>
> return ret;
> }
> +EXPORT_SYMBOL_GPL(ad_sd_calibrate);
>
> /**
> * ad_sd_calibrate_all() - Performs channel calibration
> diff --git a/include/linux/iio/adc/ad_sigma_delta.h b/include/linux/iio/adc/ad_sigma_delta.h
> index 7716fa0c9fce..8a4e25a7080c 100644
> --- a/include/linux/iio/adc/ad_sigma_delta.h
> +++ b/include/linux/iio/adc/ad_sigma_delta.h
> @@ -119,6 +119,8 @@ int ad_sd_reset(struct ad_sigma_delta *sigma_delta,
>
> int ad_sigma_delta_single_conversion(struct iio_dev *indio_dev,
> const struct iio_chan_spec *chan, int *val);
> +int ad_sd_calibrate(struct ad_sigma_delta *sigma_delta,
> + unsigned int mode, unsigned int channel);
> int ad_sd_calibrate_all(struct ad_sigma_delta *sigma_delta,
> const struct ad_sd_calib_data *cd, unsigned int n);
> int ad_sd_init(struct ad_sigma_delta *sigma_delta, struct iio_dev *indio_dev,
next prev parent reply other threads:[~2019-09-08 10:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-02 13:08 [PATCH V4 1/4] iio: adc: ad7192: Add sysfs ABI documentation Mircea Caprioru
2019-09-02 13:08 ` Mircea Caprioru
2019-09-02 13:08 ` [PATCH V4 2/4] iio: adc: ad_sigma_delta: Export ad_sd_calibrate Mircea Caprioru
2019-09-02 13:08 ` Mircea Caprioru
2019-09-08 9:35 ` Jonathan Cameron [this message]
2019-09-08 9:35 ` Jonathan Cameron
2019-09-02 13:08 ` [PATCH V4 3/4] staging: iio: adc: ad7192: Add system calibration support Mircea Caprioru
2019-09-02 13:08 ` Mircea Caprioru
2019-09-08 9:36 ` Jonathan Cameron
2019-09-08 9:36 ` Jonathan Cameron
2019-09-02 13:08 ` [PATCH V4 4/4] dt-bindings: iio: adc: ad7192: Add binding documentation for AD7192 Mircea Caprioru
2019-09-02 13:08 ` Mircea Caprioru
2019-09-03 17:29 ` Rob Herring
2019-09-03 17:29 ` Rob Herring
2019-09-08 10:29 ` Jonathan Cameron
2019-10-02 14:44 ` Rob Herring
2019-09-08 9:35 ` [PATCH V4 1/4] iio: adc: ad7192: Add sysfs ABI documentation Jonathan Cameron
2019-09-08 9:35 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190908103544.18568d02@archlinux \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mircea.caprioru@analog.com \
--cc=robh+dt@kernel.org \
--cc=stefan.popa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.