From: Alexandru Ardelean <alexandru.ardelean@analog.com>
To: bcm-kernel-feedback-list@broadcom.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org
Cc: jic23@kernel.org, broonie@kernel.org, f.fainelli@gmail.com,
linus.walleij@linaro.org, orsonzhai@gmail.com,
baolin.wang@linaro.org, zhang.lyra@gmail.com,
Alexandru Ardelean <alexandru.ardelean@analog.com>
Subject: [PATCH v4 10/19] spi: tegra114: use `spi_transfer_delay_exec` helper
Date: Thu, 26 Sep 2019 13:51:38 +0300 [thread overview]
Message-ID: <20190926105147.7839-11-alexandru.ardelean@analog.com> (raw)
In-Reply-To: <20190926105147.7839-1-alexandru.ardelean@analog.com>
The tegra114 driver has a weird/separate `tegra_spi_transfer_delay()`
function that does 2 delays: one mdelay() and one udelay().
This was introduced via commit f4fade12d506e14867a2b0a5e2f7aaf227297d8b
("spi/tegra114: Correct support for cs_change").
There doesn't seem to be a mention in that commit message to suggest a
specific need/use-case for having the 2 delay calls.
For the most part, udelay() should be sufficient.
This change replaces it with the new `spi_transfer_delay_exec()`, which
should do the same thing.
Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
---
drivers/spi/spi-tegra114.c | 17 +++--------------
1 file changed, 3 insertions(+), 14 deletions(-)
diff --git a/drivers/spi/spi-tegra114.c b/drivers/spi/spi-tegra114.c
index 39374c2edcf3..8133dc49d34f 100644
--- a/drivers/spi/spi-tegra114.c
+++ b/drivers/spi/spi-tegra114.c
@@ -984,17 +984,6 @@ static int tegra_spi_setup(struct spi_device *spi)
return 0;
}
-static void tegra_spi_transfer_delay(int delay)
-{
- if (!delay)
- return;
-
- if (delay >= 1000)
- mdelay(delay / 1000);
-
- udelay(delay % 1000);
-}
-
static void tegra_spi_transfer_end(struct spi_device *spi)
{
struct tegra_spi_data *tspi = spi_master_get_devdata(spi->master);
@@ -1098,7 +1087,7 @@ static int tegra_spi_transfer_one_message(struct spi_master *master,
complete_xfer:
if (ret < 0 || skip) {
tegra_spi_transfer_end(spi);
- tegra_spi_transfer_delay(xfer->delay_usecs);
+ spi_transfer_delay_exec(xfer);
goto exit;
} else if (list_is_last(&xfer->transfer_list,
&msg->transfers)) {
@@ -1106,11 +1095,11 @@ static int tegra_spi_transfer_one_message(struct spi_master *master,
tspi->cs_control = spi;
else {
tegra_spi_transfer_end(spi);
- tegra_spi_transfer_delay(xfer->delay_usecs);
+ spi_transfer_delay_exec(xfer);
}
} else if (xfer->cs_change) {
tegra_spi_transfer_end(spi);
- tegra_spi_transfer_delay(xfer->delay_usecs);
+ spi_transfer_delay_exec(xfer);
}
}
--
2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Alexandru Ardelean <alexandru.ardelean@analog.com>
To: <bcm-kernel-feedback-list@broadcom.com>,
<linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-spi@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-tegra@vger.kernel.org>
Cc: <jic23@kernel.org>, <broonie@kernel.org>, <f.fainelli@gmail.com>,
<linus.walleij@linaro.org>, <orsonzhai@gmail.com>,
<baolin.wang@linaro.org>, <zhang.lyra@gmail.com>,
Alexandru Ardelean <alexandru.ardelean@analog.com>
Subject: [PATCH v4 10/19] spi: tegra114: use `spi_transfer_delay_exec` helper
Date: Thu, 26 Sep 2019 13:51:38 +0300 [thread overview]
Message-ID: <20190926105147.7839-11-alexandru.ardelean@analog.com> (raw)
In-Reply-To: <20190926105147.7839-1-alexandru.ardelean@analog.com>
The tegra114 driver has a weird/separate `tegra_spi_transfer_delay()`
function that does 2 delays: one mdelay() and one udelay().
This was introduced via commit f4fade12d506e14867a2b0a5e2f7aaf227297d8b
("spi/tegra114: Correct support for cs_change").
There doesn't seem to be a mention in that commit message to suggest a
specific need/use-case for having the 2 delay calls.
For the most part, udelay() should be sufficient.
This change replaces it with the new `spi_transfer_delay_exec()`, which
should do the same thing.
Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
---
drivers/spi/spi-tegra114.c | 17 +++--------------
1 file changed, 3 insertions(+), 14 deletions(-)
diff --git a/drivers/spi/spi-tegra114.c b/drivers/spi/spi-tegra114.c
index 39374c2edcf3..8133dc49d34f 100644
--- a/drivers/spi/spi-tegra114.c
+++ b/drivers/spi/spi-tegra114.c
@@ -984,17 +984,6 @@ static int tegra_spi_setup(struct spi_device *spi)
return 0;
}
-static void tegra_spi_transfer_delay(int delay)
-{
- if (!delay)
- return;
-
- if (delay >= 1000)
- mdelay(delay / 1000);
-
- udelay(delay % 1000);
-}
-
static void tegra_spi_transfer_end(struct spi_device *spi)
{
struct tegra_spi_data *tspi = spi_master_get_devdata(spi->master);
@@ -1098,7 +1087,7 @@ static int tegra_spi_transfer_one_message(struct spi_master *master,
complete_xfer:
if (ret < 0 || skip) {
tegra_spi_transfer_end(spi);
- tegra_spi_transfer_delay(xfer->delay_usecs);
+ spi_transfer_delay_exec(xfer);
goto exit;
} else if (list_is_last(&xfer->transfer_list,
&msg->transfers)) {
@@ -1106,11 +1095,11 @@ static int tegra_spi_transfer_one_message(struct spi_master *master,
tspi->cs_control = spi;
else {
tegra_spi_transfer_end(spi);
- tegra_spi_transfer_delay(xfer->delay_usecs);
+ spi_transfer_delay_exec(xfer);
}
} else if (xfer->cs_change) {
tegra_spi_transfer_end(spi);
- tegra_spi_transfer_delay(xfer->delay_usecs);
+ spi_transfer_delay_exec(xfer);
}
}
--
2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Alexandru Ardelean <alexandru.ardelean@analog.com>
To: <bcm-kernel-feedback-list@broadcom.com>,
<linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-spi@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-tegra@vger.kernel.org>
Cc: f.fainelli@gmail.com, baolin.wang@linaro.org,
zhang.lyra@gmail.com, linus.walleij@linaro.org,
broonie@kernel.org, orsonzhai@gmail.com,
Alexandru Ardelean <alexandru.ardelean@analog.com>,
jic23@kernel.org
Subject: [PATCH v4 10/19] spi: tegra114: use `spi_transfer_delay_exec` helper
Date: Thu, 26 Sep 2019 13:51:38 +0300 [thread overview]
Message-ID: <20190926105147.7839-11-alexandru.ardelean@analog.com> (raw)
In-Reply-To: <20190926105147.7839-1-alexandru.ardelean@analog.com>
The tegra114 driver has a weird/separate `tegra_spi_transfer_delay()`
function that does 2 delays: one mdelay() and one udelay().
This was introduced via commit f4fade12d506e14867a2b0a5e2f7aaf227297d8b
("spi/tegra114: Correct support for cs_change").
There doesn't seem to be a mention in that commit message to suggest a
specific need/use-case for having the 2 delay calls.
For the most part, udelay() should be sufficient.
This change replaces it with the new `spi_transfer_delay_exec()`, which
should do the same thing.
Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
---
drivers/spi/spi-tegra114.c | 17 +++--------------
1 file changed, 3 insertions(+), 14 deletions(-)
diff --git a/drivers/spi/spi-tegra114.c b/drivers/spi/spi-tegra114.c
index 39374c2edcf3..8133dc49d34f 100644
--- a/drivers/spi/spi-tegra114.c
+++ b/drivers/spi/spi-tegra114.c
@@ -984,17 +984,6 @@ static int tegra_spi_setup(struct spi_device *spi)
return 0;
}
-static void tegra_spi_transfer_delay(int delay)
-{
- if (!delay)
- return;
-
- if (delay >= 1000)
- mdelay(delay / 1000);
-
- udelay(delay % 1000);
-}
-
static void tegra_spi_transfer_end(struct spi_device *spi)
{
struct tegra_spi_data *tspi = spi_master_get_devdata(spi->master);
@@ -1098,7 +1087,7 @@ static int tegra_spi_transfer_one_message(struct spi_master *master,
complete_xfer:
if (ret < 0 || skip) {
tegra_spi_transfer_end(spi);
- tegra_spi_transfer_delay(xfer->delay_usecs);
+ spi_transfer_delay_exec(xfer);
goto exit;
} else if (list_is_last(&xfer->transfer_list,
&msg->transfers)) {
@@ -1106,11 +1095,11 @@ static int tegra_spi_transfer_one_message(struct spi_master *master,
tspi->cs_control = spi;
else {
tegra_spi_transfer_end(spi);
- tegra_spi_transfer_delay(xfer->delay_usecs);
+ spi_transfer_delay_exec(xfer);
}
} else if (xfer->cs_change) {
tegra_spi_transfer_end(spi);
- tegra_spi_transfer_delay(xfer->delay_usecs);
+ spi_transfer_delay_exec(xfer);
}
}
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-26 10:51 UTC|newest]
Thread overview: 136+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-26 10:51 [PATCH v4 00/19] spi: introduce `struct spi_delay` data-type Alexandru Ardelean
2019-09-26 10:51 ` Alexandru Ardelean
2019-09-26 10:51 ` Alexandru Ardelean
2019-09-26 10:51 ` Alexandru Ardelean
2019-09-26 10:51 ` [PATCH v4 01/19] spi: move `cs_change_delay` backwards compat logic outside switch Alexandru Ardelean
2019-09-26 10:51 ` Alexandru Ardelean
2019-09-26 10:51 ` Alexandru Ardelean
2019-10-15 11:12 ` Applied "spi: move `cs_change_delay` backwards compat logic outside switch" to the spi tree Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-09-26 10:51 ` [PATCH v4 02/19] spi: introduce spi_delay struct as "value + unit" & spi_delay_exec() Alexandru Ardelean
2019-09-26 10:51 ` Alexandru Ardelean
2019-09-26 10:51 ` Alexandru Ardelean
2019-09-26 10:51 ` Alexandru Ardelean
2019-10-15 11:12 ` Applied "spi: introduce spi_delay struct as "value + unit" & spi_delay_exec()" to the spi tree Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-09-26 10:51 ` [PATCH v4 03/19] spi: make `cs_change_delay` the first user of the `spi_delay` logic Alexandru Ardelean
2019-09-26 10:51 ` Alexandru Ardelean
2019-09-26 10:51 ` Alexandru Ardelean
2019-10-15 11:12 ` Applied "spi: make `cs_change_delay` the first user of the `spi_delay` logic" to the spi tree Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-09-26 10:51 ` [PATCH v4 04/19] spi: sprd: convert transfer word delay to spi_delay struct Alexandru Ardelean
2019-09-26 10:51 ` Alexandru Ardelean
2019-09-26 10:51 ` Alexandru Ardelean
2019-10-15 11:11 ` Mark Brown
2019-10-15 11:11 ` Mark Brown
2019-10-15 11:12 ` Applied "spi: sprd: convert transfer word delay to spi_delay struct" to the spi tree Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-09-26 10:51 ` [PATCH v4 05/19] spi: orion: use new `word_delay` field for SPI transfers Alexandru Ardelean
2019-09-26 10:51 ` Alexandru Ardelean
2019-09-26 10:51 ` Alexandru Ardelean
2019-10-15 11:12 ` Applied "spi: orion: use new `word_delay` field for SPI transfers" to the spi tree Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-09-26 10:51 ` [PATCH v4 06/19] spi: spidev: use new `word_delay` field for spi transfers Alexandru Ardelean
2019-09-26 10:51 ` Alexandru Ardelean
2019-09-26 10:51 ` Alexandru Ardelean
2019-10-15 11:12 ` Applied "spi: spidev: use new `word_delay` field for spi transfers" to the spi tree Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-09-26 10:51 ` [PATCH v4 07/19] spi: core,atmel: convert `word_delay_usecs` -> `word_delay` for spi_device Alexandru Ardelean
2019-09-26 10:51 ` [PATCH v4 07/19] spi: core, atmel: " Alexandru Ardelean
2019-09-26 10:51 ` [PATCH v4 07/19] spi: core,atmel: " Alexandru Ardelean
2019-10-15 11:12 ` Applied "spi: core,atmel: convert `word_delay_usecs` -> `word_delay` for spi_device" to the spi tree Mark Brown
2019-10-15 11:12 ` Applied "spi: core, atmel: " Mark Brown
2019-10-15 11:12 ` Applied "spi: core,atmel: " Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-09-26 10:51 ` [PATCH v4 08/19] spi: introduce `delay` field for `spi_transfer` + spi_transfer_delay_exec() Alexandru Ardelean
2019-09-26 10:51 ` Alexandru Ardelean
2019-09-26 10:51 ` Alexandru Ardelean
2019-10-15 11:12 ` Applied "spi: introduce `delay` field for `spi_transfer` + spi_transfer_delay_exec()" to the spi tree Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-09-26 10:51 ` [PATCH v4 09/19] spi: use new `spi_transfer_delay_exec` helper where straightforward Alexandru Ardelean
2019-09-26 10:51 ` Alexandru Ardelean
2019-09-26 10:51 ` Alexandru Ardelean
2019-09-26 10:51 ` Alexandru Ardelean [this message]
2019-09-26 10:51 ` [PATCH v4 10/19] spi: tegra114: use `spi_transfer_delay_exec` helper Alexandru Ardelean
2019-09-26 10:51 ` Alexandru Ardelean
2019-10-15 11:12 ` Applied "spi: tegra114: use `spi_transfer_delay_exec` helper" to the spi tree Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-09-26 10:51 ` [PATCH v4 11/19] spi: tegra20-sflash: use to new `spi_transfer_delay_exec` Alexandru Ardelean
2019-09-26 10:51 ` Alexandru Ardelean
2019-09-26 10:51 ` Alexandru Ardelean
2019-10-15 11:12 ` Applied "spi: tegra20-sflash: use to new `spi_transfer_delay_exec`" to the spi tree Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-09-26 10:51 ` [PATCH v4 12/19] spi: spi-loopback-test: use new `delay` field Alexandru Ardelean
2019-09-26 10:51 ` Alexandru Ardelean
2019-09-26 10:51 ` Alexandru Ardelean
2019-10-15 11:12 ` Applied "spi: spi-loopback-test: use new `delay` field" to the spi tree Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-09-26 10:51 ` [PATCH v4 13/19] spi: spidev: use new `delay` field for spi transfers Alexandru Ardelean
2019-09-26 10:51 ` Alexandru Ardelean
2019-09-26 10:51 ` Alexandru Ardelean
2019-10-15 11:12 ` Applied "spi: spidev: use new `delay` field for spi transfers" to the spi tree Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-09-26 10:51 ` [PATCH v4 14/19] spi: tegra114: change format for `spi_set_cs_timing()` function Alexandru Ardelean
2019-09-26 10:51 ` Alexandru Ardelean
2019-09-26 10:51 ` Alexandru Ardelean
2019-10-15 11:12 ` Applied "spi: tegra114: change format for `spi_set_cs_timing()` function" to the spi tree Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-09-26 10:51 ` [PATCH v4 15/19] spi: implement SW control for CS times Alexandru Ardelean
2019-09-26 10:51 ` Alexandru Ardelean
2019-09-26 10:51 ` Alexandru Ardelean
2019-10-15 11:12 ` Applied "spi: implement SW control for CS times" to the spi tree Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-09-26 10:51 ` [PATCH v4 16/19] spi: spi-fsl-espi: convert transfer delay to `spi_delay` format Alexandru Ardelean
2019-09-26 10:51 ` Alexandru Ardelean
2019-09-26 10:51 ` Alexandru Ardelean
2019-10-15 11:12 ` Applied "spi: spi-fsl-espi: convert transfer delay to `spi_delay` format" to the spi tree Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-09-26 10:51 ` [PATCH v4 17/19] spi: spi-falcon: extend warning to `delay` as well Alexandru Ardelean
2019-09-26 10:51 ` Alexandru Ardelean
2019-09-26 10:51 ` Alexandru Ardelean
2019-10-15 11:12 ` Applied "spi: spi-falcon: extend warning to `delay` as well" to the spi tree Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-09-26 10:51 ` [PATCH v4 18/19] spi: bcm63xx: extend error condition to `delay` as well Alexandru Ardelean
2019-09-26 10:51 ` Alexandru Ardelean
2019-09-26 10:51 ` Alexandru Ardelean
2019-10-15 11:12 ` Applied "spi: bcm63xx: extend error condition to `delay` as well" to the spi tree Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-09-26 10:51 ` [PATCH v4 19/19] spi: spi-axi: extend support for the `delay` field Alexandru Ardelean
2019-09-26 10:51 ` Alexandru Ardelean
2019-09-26 10:51 ` Alexandru Ardelean
2019-10-15 11:12 ` Applied "spi: spi-axi: extend support for the `delay` field" to the spi tree Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-10-15 11:12 ` Mark Brown
2019-10-15 11:12 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190926105147.7839-11-alexandru.ardelean@analog.com \
--to=alexandru.ardelean@analog.com \
--cc=baolin.wang@linaro.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=broonie@kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jic23@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.