From: Andrew Murray <andrew.murray@arm.com> To: Rob Herring <robh@kernel.org> Cc: Marc Gonzalez <marc.w.gonzalez@free.fr>, Robin Murphy <robin.murphy@arm.com>, Bjorn Helgaas <helgaas@kernel.org>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Marc Zyngier <maz@kernel.org>, Ard Biesheuvel <ard.biesheuvel@linaro.org>, Mans Rullgard <mans@mansr.com>, Linux ARM <linux-arm-kernel@lists.infradead.org>, PCI <linux-pci@vger.kernel.org> Subject: Re: [PATCH 00/11] PCI dma-ranges parsing consolidation Date: Thu, 26 Sep 2019 14:38:49 +0100 [thread overview] Message-ID: <20190926133849.GF9720@e119886-lin.cambridge.arm.com> (raw) In-Reply-To: <CAL_JsqLtYYXCgGN6_t8SuPqPmQwhhRJXaf8+kxnKxLHbRQRaDQ@mail.gmail.com> On Thu, Sep 26, 2019 at 08:11:16AM -0500, Rob Herring wrote: > On Thu, Sep 26, 2019 at 6:20 AM Marc Gonzalez <marc.w.gonzalez@free.fr> wrote: > > > > [ Tweaking recipients list ] > > > > On 26/09/2019 10:49, Andrew Murray wrote: > > > > > On Tue, Sep 24, 2019 at 04:46:19PM -0500, Rob Herring wrote: > > > > > >> pci-rcar-gen2 is the only remaining driver doing its own dma-ranges > > >> handling as it is still using the old ARM PCI functions. Looks like it > > >> is the last one (in drivers/pci/). > > > > > > It also seems that pcie-tango is using of_pci_dma_range_parser_init > > > and so parsing dma-ranges. Though it's using the dma_ranges for a > > > slightly different purpose. > > Seems I missed that as I only grep'ed for for_each_of_pci_range... > > > > > The rationale for that code can be found here: > > > > https://patchwork.kernel.org/patch/9915469/ > > > > NB: 1) The PCIE_TANGO_SMP8759 Kconfig symbol is marked "depends on BROKEN", > > and 2) The driver adds TAINT_CRAP, > > and 3) The maker of the tango platform is dead. > Thanks for the context Marc, much appreciated. Is there a path to make this driver not BROKEN? Or is this likely to bit rot? > Given that and that I'd have to rework the probe to do the MSI range > setup after pci_host_common_probe, I'm just going to leave this one > alone. I don't see any harm with that. Thanks, Andrew Murray > > Rob
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Murray <andrew.murray@arm.com> To: Rob Herring <robh@kernel.org> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Ard Biesheuvel <ard.biesheuvel@linaro.org>, Marc Zyngier <maz@kernel.org>, Marc Gonzalez <marc.w.gonzalez@free.fr>, Mans Rullgard <mans@mansr.com>, Bjorn Helgaas <helgaas@kernel.org>, PCI <linux-pci@vger.kernel.org>, Robin Murphy <robin.murphy@arm.com>, Linux ARM <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 00/11] PCI dma-ranges parsing consolidation Date: Thu, 26 Sep 2019 14:38:49 +0100 [thread overview] Message-ID: <20190926133849.GF9720@e119886-lin.cambridge.arm.com> (raw) In-Reply-To: <CAL_JsqLtYYXCgGN6_t8SuPqPmQwhhRJXaf8+kxnKxLHbRQRaDQ@mail.gmail.com> On Thu, Sep 26, 2019 at 08:11:16AM -0500, Rob Herring wrote: > On Thu, Sep 26, 2019 at 6:20 AM Marc Gonzalez <marc.w.gonzalez@free.fr> wrote: > > > > [ Tweaking recipients list ] > > > > On 26/09/2019 10:49, Andrew Murray wrote: > > > > > On Tue, Sep 24, 2019 at 04:46:19PM -0500, Rob Herring wrote: > > > > > >> pci-rcar-gen2 is the only remaining driver doing its own dma-ranges > > >> handling as it is still using the old ARM PCI functions. Looks like it > > >> is the last one (in drivers/pci/). > > > > > > It also seems that pcie-tango is using of_pci_dma_range_parser_init > > > and so parsing dma-ranges. Though it's using the dma_ranges for a > > > slightly different purpose. > > Seems I missed that as I only grep'ed for for_each_of_pci_range... > > > > > The rationale for that code can be found here: > > > > https://patchwork.kernel.org/patch/9915469/ > > > > NB: 1) The PCIE_TANGO_SMP8759 Kconfig symbol is marked "depends on BROKEN", > > and 2) The driver adds TAINT_CRAP, > > and 3) The maker of the tango platform is dead. > Thanks for the context Marc, much appreciated. Is there a path to make this driver not BROKEN? Or is this likely to bit rot? > Given that and that I'd have to rework the probe to do the MSI range > setup after pci_host_common_probe, I'm just going to leave this one > alone. I don't see any harm with that. Thanks, Andrew Murray > > Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-26 13:38 UTC|newest] Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-09-24 21:46 [PATCH 00/11] PCI dma-ranges parsing consolidation Rob Herring 2019-09-24 21:46 ` Rob Herring 2019-09-24 21:46 ` Rob Herring 2019-09-24 21:46 ` [PATCH 01/11] PCI: aardvark: Use pci_parse_request_of_pci_ranges() Rob Herring 2019-09-24 21:46 ` Rob Herring 2019-09-25 8:59 ` Thomas Petazzoni 2019-09-25 8:59 ` Thomas Petazzoni 2019-09-25 9:04 ` Andrew Murray 2019-09-25 9:04 ` Andrew Murray 2019-09-24 21:46 ` [PATCH 02/11] PCI: altera: " Rob Herring 2019-09-24 21:46 ` Rob Herring 2019-09-25 10:24 ` Andrew Murray 2019-09-25 10:24 ` Andrew Murray 2019-09-25 12:33 ` Rob Herring 2019-09-25 12:33 ` Rob Herring 2019-09-30 15:13 ` Andrew Murray 2019-09-30 15:13 ` Andrew Murray 2019-09-30 17:36 ` Rob Herring 2019-09-30 17:36 ` Rob Herring 2019-10-15 11:02 ` Lorenzo Pieralisi 2019-10-15 11:02 ` Lorenzo Pieralisi 2019-10-15 11:17 ` Rob Herring 2019-10-15 11:17 ` Rob Herring 2019-09-24 21:46 ` [PATCH 03/11] PCI: mediatek: " Rob Herring 2019-09-24 21:46 ` Rob Herring 2019-09-24 21:46 ` Rob Herring 2019-09-25 11:34 ` Andrew Murray 2019-09-25 11:34 ` Andrew Murray 2019-09-25 11:34 ` Andrew Murray 2019-09-24 21:46 ` [PATCH 04/11] PCI: versatile: Enable COMPILE_TEST Rob Herring 2019-09-24 21:46 ` Rob Herring 2019-09-26 8:12 ` Andrew Murray 2019-09-26 8:12 ` Andrew Murray 2019-09-24 21:46 ` [PATCH 05/11] PCI: versatile: Use pci_parse_request_of_pci_ranges() Rob Herring 2019-09-24 21:46 ` Rob Herring 2019-09-25 10:37 ` Andrew Murray 2019-09-25 10:37 ` Andrew Murray 2019-09-26 21:44 ` Rob Herring 2019-09-26 21:44 ` Rob Herring 2019-09-30 15:16 ` Andrew Murray 2019-09-30 15:16 ` Andrew Murray 2019-09-30 16:56 ` Peter Maydell 2019-09-30 16:56 ` Peter Maydell 2019-09-30 19:36 ` Andrew Murray 2019-09-30 19:36 ` Andrew Murray 2019-09-24 21:46 ` [PATCH 06/11] PCI: of: Add inbound resource parsing to helpers Rob Herring 2020-01-13 9:56 ` Bharat Kumar Gogada 2020-01-13 9:56 ` Bharat Kumar Gogada 2019-09-24 21:46 ` Rob Herring 2019-09-24 21:46 ` Rob Herring 2019-09-25 9:00 ` Thomas Petazzoni 2019-09-25 9:00 ` Thomas Petazzoni 2019-09-25 9:00 ` Thomas Petazzoni 2019-09-26 8:29 ` Andrew Murray 2019-09-26 8:29 ` Andrew Murray 2019-09-26 8:29 ` Andrew Murray 2019-09-26 10:43 ` Gustavo Pimentel 2019-09-26 10:43 ` Gustavo Pimentel 2019-09-26 10:43 ` Gustavo Pimentel 2019-09-27 16:12 ` Jingoo Han 2019-09-27 16:12 ` Jingoo Han 2019-09-27 16:12 ` Jingoo Han 2019-09-27 16:12 ` Jingoo Han 2019-09-27 16:12 ` Jingoo Han 2019-09-27 16:12 ` Jingoo Han 2019-09-24 21:46 ` [PATCH 07/11] PCI: ftpci100: Use inbound resources for setup Rob Herring 2019-09-24 21:46 ` Rob Herring 2019-09-26 8:39 ` Andrew Murray 2019-09-26 8:39 ` Andrew Murray 2019-09-24 21:46 ` [PATCH 08/11] PCI: v3-semi: " Rob Herring 2019-09-24 21:46 ` Rob Herring 2019-09-26 8:39 ` Andrew Murray 2019-09-26 8:39 ` Andrew Murray 2019-09-30 22:00 ` Linus Walleij 2019-09-30 22:00 ` Linus Walleij 2019-09-24 21:46 ` [PATCH 09/11] PCI: xgene: " Rob Herring 2019-09-24 21:46 ` Rob Herring 2019-09-26 8:39 ` Andrew Murray 2019-09-26 8:39 ` Andrew Murray 2019-09-24 21:46 ` [PATCH 10/11] PCI: iproc: " Rob Herring 2019-09-24 21:46 ` Rob Herring 2019-09-26 8:39 ` Andrew Murray 2019-09-26 8:39 ` Andrew Murray 2019-09-24 21:46 ` [PATCH 11/11] PCI: rcar: " Rob Herring 2019-09-24 21:46 ` Rob Herring 2019-09-26 8:47 ` Andrew Murray 2019-09-26 8:47 ` Andrew Murray 2019-09-26 12:53 ` Rob Herring 2019-09-26 12:53 ` Rob Herring 2019-09-26 13:32 ` Andrew Murray 2019-09-26 13:32 ` Andrew Murray 2019-09-26 8:49 ` [PATCH 00/11] PCI dma-ranges parsing consolidation Andrew Murray 2019-09-26 8:49 ` Andrew Murray 2019-09-26 8:49 ` Andrew Murray 2019-09-26 11:20 ` Marc Gonzalez 2019-09-26 11:20 ` Marc Gonzalez 2019-09-26 13:11 ` Rob Herring 2019-09-26 13:11 ` Rob Herring 2019-09-26 13:38 ` Andrew Murray [this message] 2019-09-26 13:38 ` Andrew Murray 2019-09-26 14:09 ` Marc Gonzalez 2019-09-26 14:09 ` Marc Gonzalez
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190926133849.GF9720@e119886-lin.cambridge.arm.com \ --to=andrew.murray@arm.com \ --cc=ard.biesheuvel@linaro.org \ --cc=helgaas@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-pci@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=mans@mansr.com \ --cc=marc.w.gonzalez@free.fr \ --cc=maz@kernel.org \ --cc=robh@kernel.org \ --cc=robin.murphy@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.