From: Andre Przywara <andre.przywara@arm.com> To: Paolo Bonzini <pbonzini@redhat.com>, Andrew Jones <drjones@redhat.com> Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org Subject: [kvm-unit-tests PATCH 6/6] arm: Add missing test name prefix calls Date: Fri, 27 Sep 2019 11:42:27 +0100 [thread overview] Message-ID: <20190927104227.253466-7-andre.przywara@arm.com> (raw) In-Reply-To: <20190927104227.253466-1-andre.przywara@arm.com> When running the unit tests in TAP mode (./run_tests.sh -t), every single test result is printed. This works fine for most tests which use the reporting prefix feature to indicate the actual test name. However psci and pci were missing those names, so the reporting left people scratching their head what was actually tested: ... ok 74 - invalid-function ok 75 - affinity-info-on ok 76 - affinity-info-off ok 77 - cpu-on Push a "psci" prefix before running those tests to make those report lines more descriptive. While at it, do the same for pci, even though it is less ambigious there. Also the GIC ITARGETSR test was missing a report_prefix_pop(). Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- arm/gic.c | 2 ++ arm/pci-test.c | 2 ++ arm/psci.c | 2 ++ 3 files changed, 6 insertions(+) diff --git a/arm/gic.c b/arm/gic.c index 66dcafe..ebb6ea2 100644 --- a/arm/gic.c +++ b/arm/gic.c @@ -480,6 +480,8 @@ static void test_targets(int nr_irqs) test_byte_access(targetsptr + GIC_FIRST_SPI, pattern, cpu_mask); writel(orig_targets, targetsptr + GIC_FIRST_SPI); + + report_prefix_pop(); } static void gic_test_mmio(void) diff --git a/arm/pci-test.c b/arm/pci-test.c index cf128ac..7c3836e 100644 --- a/arm/pci-test.c +++ b/arm/pci-test.c @@ -19,6 +19,8 @@ int main(void) return report_summary(); } + report_prefix_push("pci"); + pci_print(); ret = pci_testdev(); diff --git a/arm/psci.c b/arm/psci.c index 5cb4d5c..536c9b7 100644 --- a/arm/psci.c +++ b/arm/psci.c @@ -126,6 +126,8 @@ int main(void) { int ver = psci_invoke(PSCI_0_2_FN_PSCI_VERSION, 0, 0, 0); + report_prefix_push("psci"); + if (nr_cpus < 2) { report_skip("At least 2 cpus required"); goto done; -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Andre Przywara <andre.przywara@arm.com> To: Paolo Bonzini <pbonzini@redhat.com>, Andrew Jones <drjones@redhat.com> Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org Subject: [kvm-unit-tests PATCH 6/6] arm: Add missing test name prefix calls Date: Fri, 27 Sep 2019 11:42:27 +0100 [thread overview] Message-ID: <20190927104227.253466-7-andre.przywara@arm.com> (raw) In-Reply-To: <20190927104227.253466-1-andre.przywara@arm.com> When running the unit tests in TAP mode (./run_tests.sh -t), every single test result is printed. This works fine for most tests which use the reporting prefix feature to indicate the actual test name. However psci and pci were missing those names, so the reporting left people scratching their head what was actually tested: ... ok 74 - invalid-function ok 75 - affinity-info-on ok 76 - affinity-info-off ok 77 - cpu-on Push a "psci" prefix before running those tests to make those report lines more descriptive. While at it, do the same for pci, even though it is less ambigious there. Also the GIC ITARGETSR test was missing a report_prefix_pop(). Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- arm/gic.c | 2 ++ arm/pci-test.c | 2 ++ arm/psci.c | 2 ++ 3 files changed, 6 insertions(+) diff --git a/arm/gic.c b/arm/gic.c index 66dcafe..ebb6ea2 100644 --- a/arm/gic.c +++ b/arm/gic.c @@ -480,6 +480,8 @@ static void test_targets(int nr_irqs) test_byte_access(targetsptr + GIC_FIRST_SPI, pattern, cpu_mask); writel(orig_targets, targetsptr + GIC_FIRST_SPI); + + report_prefix_pop(); } static void gic_test_mmio(void) diff --git a/arm/pci-test.c b/arm/pci-test.c index cf128ac..7c3836e 100644 --- a/arm/pci-test.c +++ b/arm/pci-test.c @@ -19,6 +19,8 @@ int main(void) return report_summary(); } + report_prefix_push("pci"); + pci_print(); ret = pci_testdev(); diff --git a/arm/psci.c b/arm/psci.c index 5cb4d5c..536c9b7 100644 --- a/arm/psci.c +++ b/arm/psci.c @@ -126,6 +126,8 @@ int main(void) { int ver = psci_invoke(PSCI_0_2_FN_PSCI_VERSION, 0, 0, 0); + report_prefix_push("psci"); + if (nr_cpus < 2) { report_skip("At least 2 cpus required"); goto done; -- 2.17.1 _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next prev parent reply other threads:[~2019-09-27 10:42 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-09-27 10:42 [kvm-unit-tests PATCH 0/6] arm: Use stable test output lines Andre Przywara 2019-09-27 10:42 ` Andre Przywara 2019-09-27 10:42 ` [kvm-unit-tests PATCH 1/6] arm: gic: check_acked: add test description Andre Przywara 2019-09-27 10:42 ` Andre Przywara 2019-09-27 12:18 ` Andrew Jones 2019-09-27 12:18 ` Andrew Jones 2019-09-27 12:40 ` Andre Przywara 2019-09-27 12:40 ` Andre Przywara 2019-09-27 12:55 ` Andrew Jones 2019-09-27 12:55 ` Andrew Jones 2019-09-27 10:42 ` [kvm-unit-tests PATCH 2/6] arm: gic: Split variable output data from test name Andre Przywara 2019-09-27 10:42 ` Andre Przywara 2019-09-27 12:25 ` Andrew Jones 2019-09-27 12:25 ` Andrew Jones 2019-09-27 10:42 ` [kvm-unit-tests PATCH 3/6] arm: timer: " Andre Przywara 2019-09-27 10:42 ` Andre Przywara 2019-09-27 12:25 ` Andrew Jones 2019-09-27 12:25 ` Andrew Jones 2019-09-27 10:42 ` [kvm-unit-tests PATCH 4/6] arm: selftest: " Andre Przywara 2019-09-27 10:42 ` Andre Przywara 2019-09-27 12:26 ` Andrew Jones 2019-09-27 12:26 ` Andrew Jones 2019-09-27 10:42 ` [kvm-unit-tests PATCH 5/6] arm: selftest: Make MPIDR output stable Andre Przywara 2019-09-27 10:42 ` Andre Przywara 2019-09-27 12:30 ` Andrew Jones 2019-09-27 12:30 ` Andrew Jones 2019-09-27 10:42 ` Andre Przywara [this message] 2019-09-27 10:42 ` [kvm-unit-tests PATCH 6/6] arm: Add missing test name prefix calls Andre Przywara 2019-09-27 12:31 ` Andrew Jones 2019-09-27 12:31 ` Andrew Jones
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190927104227.253466-7-andre.przywara@arm.com \ --to=andre.przywara@arm.com \ --cc=drjones@redhat.com \ --cc=kvm@vger.kernel.org \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=pbonzini@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.