Re: [PATCH 07/10] ASoC: cros_ec_codec: support WoV

From: kbuild test robot <lkp@intel.com>
Cc: gwendal@google.com, devicetree@vger.kernel.org,
	alsa-devel@alsa-project.org, cychiang@google.com,
	drinkcat@google.com, robh+dt@kernel.org, tzungbi@google.com,
	broonie@kernel.org, kbuild-all@01.org,
	enric.balletbo@collabora.com, bleung@google.com,
	dgreid@google.com
Subject: Re: [PATCH 07/10] ASoC: cros_ec_codec: support WoV
Date: Sat, 5 Oct 2019 15:08:32 +0800	[thread overview]
Message-ID: <201910051510.bvaANc5Y%lkp@intel.com> (raw)
In-Reply-To: <20191005130552.7.I5388b69a7a9c551078fed216a77440cee6dedf49@changeid>

[-- Attachment #1: Type: text/plain, Size: 2692 bytes --]

Hi Tzung-Bi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on asoc/for-next]
[cannot apply to v5.4-rc1 next-20191004]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Tzung-Bi-Shih/ASoC-mediatek-mt8183-mt6358-ts3a227-max98357-support-WoV/20191005-142224
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: m68k-allyesconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

   sound/soc/codecs/cros_ec_codec.c: In function 'calculate_sha256':
>> sound/soc/codecs/cros_ec_codec.c:117:7: error: 'struct shash_desc' has no member named 'flags'
      desc->flags = 0x0;
          ^~
   sound/soc/codecs/cros_ec_codec.c: In function 'wov_map_shm':
>> sound/soc/codecs/cros_ec_codec.c:469:10: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
      return (void *)(priv->ap_shm_addr + offset);
             ^
   sound/soc/codecs/cros_ec_codec.c: In function 'cros_ec_codec_platform_probe':
>> sound/soc/codecs/cros_ec_codec.c:1002:24: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
       priv->ap_shm_addr = (uint64_t)devm_ioremap_wc(
                           ^

vim +117 sound/soc/codecs/cros_ec_codec.c

   101	
   102	static int calculate_sha256(struct cros_ec_codec_priv *priv,
   103				    uint8_t *buf, uint32_t size, uint8_t *digest)
   104	{
   105		struct crypto_shash *tfm;
   106	
   107		tfm = crypto_alloc_shash("sha256", CRYPTO_ALG_TYPE_SHASH, 0);
   108		if (IS_ERR(tfm)) {
   109			dev_err(priv->dev, "can't alloc shash\n");
   110			return PTR_ERR(tfm);
   111		}
   112	
   113		{
   114			SHASH_DESC_ON_STACK(desc, tfm);
   115	
   116			desc->tfm = tfm;
 > 117			desc->flags = 0x0;
   118	
   119			crypto_shash_digest(desc, buf, size, digest);
   120			shash_desc_zero(desc);
   121		}
   122	
   123		crypto_free_shash(tfm);
   124	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 51676 bytes --]

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]