Re: [PATCH 7/7] regulator: max77686: switch to using fwnode_gpiod_get_index

From: kbuild test robot <lkp@intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: kbuild-all@01.org, Mark Brown <broonie@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	linux-kernel@vger.kernel.org,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH 7/7] regulator: max77686: switch to using fwnode_gpiod_get_index
Date: Sat, 5 Oct 2019 15:26:34 +0800	[thread overview]
Message-ID: <201910051559.F48xdXPc%lkp@intel.com> (raw)
In-Reply-To: <20191004231017.130290-8-dmitry.torokhov@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 3110 bytes --]

Hi Dmitry,

I love your patch! Yet something to improve:

[auto build test ERROR on regulator/for-next]
[cannot apply to v5.4-rc1 next-20191004]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Dmitry-Torokhov/regulator-switch-to-using-devm_-fwnode_gpiod_get_index/20191005-085020
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=sh 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

   drivers//regulator/max77686-regulator.c: In function 'max77686_of_parse_cb':
>> drivers//regulator/max77686-regulator.c:259:23: error: implicit declaration of function 'fwnode_gpiod_get_index'; did you mean 'devm_gpiod_get_index'? [-Werror=implicit-function-declaration]
      config->ena_gpiod = fwnode_gpiod_get_index(
                          ^~~~~~~~~~~~~~~~~~~~~~
                          devm_gpiod_get_index
>> drivers//regulator/max77686-regulator.c:259:21: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
      config->ena_gpiod = fwnode_gpiod_get_index(
                        ^
   cc1: some warnings being treated as errors

vim +259 drivers//regulator/max77686-regulator.c

   247	
   248	static int max77686_of_parse_cb(struct device_node *np,
   249			const struct regulator_desc *desc,
   250			struct regulator_config *config)
   251	{
   252		struct max77686_data *max77686 = config->driver_data;
   253		int ret;
   254	
   255		switch (desc->id) {
   256		case MAX77686_BUCK8:
   257		case MAX77686_BUCK9:
   258		case MAX77686_LDO20 ... MAX77686_LDO22:
 > 259			config->ena_gpiod = fwnode_gpiod_get_index(
   260					of_fwnode_handle(np),
   261					"maxim,ena",
   262					0,
   263					GPIOD_OUT_HIGH | GPIOD_FLAGS_BIT_NONEXCLUSIVE,
   264					"max77686-regulator");
   265			if (IS_ERR(config->ena_gpiod))
   266				config->ena_gpiod = NULL;
   267			break;
   268		default:
   269			return 0;
   270		}
   271	
   272		if (config->ena_gpiod) {
   273			set_bit(desc->id, max77686->gpio_enabled);
   274	
   275			ret = regmap_update_bits(config->regmap, desc->enable_reg,
   276						 desc->enable_mask,
   277						 MAX77686_GPIO_CONTROL);
   278			if (ret) {
   279				gpiod_put(config->ena_gpiod);
   280				config->ena_gpiod = NULL;
   281			}
   282		}
   283	
   284		return 0;
   285	}
   286	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 52234 bytes --]