From: Bartosz Golaszewski <brgl@bgdev.pl> To: Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, Lee Jones <lee.jones@linaro.org>, Daniel Thompson <daniel.thompson@linaro.org>, Jingoo Han <jingoohan1@gmail.com>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, Linus Walleij <linus.walleij@linaro.org>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Jacopo Mondi <jacopo@jmondi.org> Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Bartosz Golaszewski <bgolaszewski@baylibre.com> Subject: [PATCH v5 0/7] backlight: gpio: simplify the driver Date: Mon, 07 Oct 2019 03:30:54 +0000 [thread overview] Message-ID: <20191007033101.13343-1-brgl@bgdev.pl> (raw) From: Bartosz Golaszewski <bgolaszewski@baylibre.com> While working on my other series related to gpio-backlight[1] I noticed that we could simplify the driver if we made the only user of platform data use GPIO lookups and device properties. This series tries to do that. The first patch adds all necessary data structures to ecovec24. Patch 2/7 unifies much of the code for both pdata and non-pdata cases. Patches 3-4/7 remove unused platform data fields. Last three patches contain additional improvements for the GPIO backlight driver while we're already modifying it. I don't have access to this HW but hopefully this works. Only compile tested. [1] https://lkml.org/lkml/2019/6/25/900 v1 -> v2: - rebased on top of v5.3-rc1 and adjusted to the recent changes from Andy - added additional two patches with minor improvements v2 -> v3: - in patch 7/7: used initializers to set values for pdata and dev local vars v3 -> v4: - rebased on top of v5.4-rc1 - removed changes that are no longer relevant after commit ec665b756e6f ("backlight: gpio-backlight: Correct initial power state handling") - added patch 7/7 v4 ->V5: - in patch 7/7: added a comment replacing the name of the function being pulled into probe() Bartosz Golaszewski (7): backlight: gpio: remove unneeded include sh: ecovec24: add additional properties to the backlight device backlight: gpio: simplify the platform data handling sh: ecovec24: don't set unused fields in platform data backlight: gpio: remove unused fields from platform data backlight: gpio: use a helper variable for &pdev->dev backlight: gpio: pull gpio_backlight_initial_power_state() into probe arch/sh/boards/mach-ecovec24/setup.c | 33 ++++-- drivers/video/backlight/gpio_backlight.c | 108 +++++-------------- include/linux/platform_data/gpio_backlight.h | 3 - 3 files changed, 53 insertions(+), 91 deletions(-) -- 2.23.0
WARNING: multiple messages have this Message-ID (diff)
From: Bartosz Golaszewski <brgl@bgdev.pl> To: Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, Lee Jones <lee.jones@linaro.org>, Daniel Thompson <daniel.thompson@linaro.org>, Jingoo Han <jingoohan1@gmail.com>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, Linus Walleij <linus.walleij@linaro.org>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Jacopo Mondi <jacopo@jmondi.org> Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Bartosz Golaszewski <bgolaszewski@baylibre.com> Subject: [PATCH v5 0/7] backlight: gpio: simplify the driver Date: Mon, 7 Oct 2019 05:30:54 +0200 [thread overview] Message-ID: <20191007033101.13343-1-brgl@bgdev.pl> (raw) From: Bartosz Golaszewski <bgolaszewski@baylibre.com> While working on my other series related to gpio-backlight[1] I noticed that we could simplify the driver if we made the only user of platform data use GPIO lookups and device properties. This series tries to do that. The first patch adds all necessary data structures to ecovec24. Patch 2/7 unifies much of the code for both pdata and non-pdata cases. Patches 3-4/7 remove unused platform data fields. Last three patches contain additional improvements for the GPIO backlight driver while we're already modifying it. I don't have access to this HW but hopefully this works. Only compile tested. [1] https://lkml.org/lkml/2019/6/25/900 v1 -> v2: - rebased on top of v5.3-rc1 and adjusted to the recent changes from Andy - added additional two patches with minor improvements v2 -> v3: - in patch 7/7: used initializers to set values for pdata and dev local vars v3 -> v4: - rebased on top of v5.4-rc1 - removed changes that are no longer relevant after commit ec665b756e6f ("backlight: gpio-backlight: Correct initial power state handling") - added patch 7/7 v4 ->V5: - in patch 7/7: added a comment replacing the name of the function being pulled into probe() Bartosz Golaszewski (7): backlight: gpio: remove unneeded include sh: ecovec24: add additional properties to the backlight device backlight: gpio: simplify the platform data handling sh: ecovec24: don't set unused fields in platform data backlight: gpio: remove unused fields from platform data backlight: gpio: use a helper variable for &pdev->dev backlight: gpio: pull gpio_backlight_initial_power_state() into probe arch/sh/boards/mach-ecovec24/setup.c | 33 ++++-- drivers/video/backlight/gpio_backlight.c | 108 +++++-------------- include/linux/platform_data/gpio_backlight.h | 3 - 3 files changed, 53 insertions(+), 91 deletions(-) -- 2.23.0
next reply other threads:[~2019-10-07 3:30 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-07 3:30 Bartosz Golaszewski [this message] 2019-10-07 3:30 ` [PATCH v5 0/7] backlight: gpio: simplify the driver Bartosz Golaszewski 2019-10-07 3:31 ` Bartosz Golaszewski 2019-10-07 3:31 ` Bartosz Golaszewski 2019-10-07 3:31 ` [PATCH v5 1/7] backlight: gpio: remove unneeded include Bartosz Golaszewski 2019-10-07 3:31 ` Bartosz Golaszewski 2019-10-07 3:31 ` [PATCH v5 2/7] sh: ecovec24: add additional properties to the backlight device Bartosz Golaszewski 2019-10-07 3:31 ` Bartosz Golaszewski 2019-10-07 3:31 ` [PATCH v5 3/7] backlight: gpio: simplify the platform data handling Bartosz Golaszewski 2019-10-07 3:31 ` Bartosz Golaszewski 2019-10-07 3:31 ` [PATCH v5 4/7] sh: ecovec24: don't set unused fields in platform data Bartosz Golaszewski 2019-10-07 3:31 ` Bartosz Golaszewski 2019-10-07 3:31 ` [PATCH v5 5/7] backlight: gpio: remove unused fields from " Bartosz Golaszewski 2019-10-07 3:31 ` Bartosz Golaszewski 2019-10-07 3:31 ` [PATCH v5 6/7] backlight: gpio: use a helper variable for &pdev->dev Bartosz Golaszewski 2019-10-07 3:31 ` Bartosz Golaszewski 2019-10-07 3:32 ` [PATCH v5 7/7] backlight: gpio: pull gpio_backlight_initial_power_state() into probe Bartosz Golaszewski 2019-10-07 3:32 ` Bartosz Golaszewski 2019-10-07 12:56 ` Daniel Thompson 2019-10-07 12:56 ` Daniel Thompson 2019-10-07 12:56 ` Daniel Thompson 2019-10-14 8:12 ` [PATCH v5 0/7] backlight: gpio: simplify the driver Lee Jones 2019-10-14 8:12 ` Lee Jones 2019-10-14 8:15 ` Bartosz Golaszewski 2019-10-14 8:15 ` Bartosz Golaszewski 2019-10-16 12:56 ` Linus Walleij 2019-10-16 12:56 ` Linus Walleij 2019-10-16 13:05 ` Jacopo Mondi 2019-10-16 13:05 ` Jacopo Mondi 2019-10-17 7:25 ` Lee Jones 2019-10-17 7:25 ` Lee Jones 2019-10-18 15:04 ` Jacopo Mondi 2019-10-18 15:04 ` Jacopo Mondi 2019-10-18 15:04 ` Jacopo Mondi 2019-10-18 16:20 ` Bartosz Golaszewski 2019-10-18 16:20 ` Bartosz Golaszewski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191007033101.13343-1-brgl@bgdev.pl \ --to=brgl@bgdev.pl \ --cc=andriy.shevchenko@linux.intel.com \ --cc=b.zolnierkie@samsung.com \ --cc=bgolaszewski@baylibre.com \ --cc=dalias@libc.org \ --cc=daniel.thompson@linaro.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=jacopo@jmondi.org \ --cc=jingoohan1@gmail.com \ --cc=lee.jones@linaro.org \ --cc=linus.walleij@linaro.org \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-sh@vger.kernel.org \ --cc=ysato@users.sourceforge.jp \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.