From: Tero Kristo <t-kristo@ti.com> To: linux-omap@vger.kernel.org, ssantosh@kernel.org Cc: tony@atomide.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, p.zabel@pengutronix.de Subject: [PATCHv7 3/9] soc: ti: omap-prm: poll for reset complete during de-assert Date: Tue, 8 Oct 2019 10:19:07 +0300 [thread overview] Message-ID: <20191008071913.28740-4-t-kristo@ti.com> (raw) In-Reply-To: <20191008071913.28740-1-t-kristo@ti.com> Poll for reset completion status during de-assertion of reset, otherwise the IP in question might be accessed before it has left reset properly. Signed-off-by: Tero Kristo <t-kristo@ti.com> --- drivers/soc/ti/omap_prm.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/soc/ti/omap_prm.c b/drivers/soc/ti/omap_prm.c index ab0b66ad715d..96fa2aad9b93 100644 --- a/drivers/soc/ti/omap_prm.c +++ b/drivers/soc/ti/omap_prm.c @@ -153,6 +153,18 @@ static int omap_reset_deassert(struct reset_controller_dev *rcdev, writel_relaxed(v, reset->prm->base + reset->prm->data->rstctrl); spin_unlock_irqrestore(&reset->lock, flags); + if (!has_rstst) + return 0; + + /* wait for the status to be set */ + ret = readl_relaxed_poll_timeout(reset->prm->base + + reset->prm->data->rstst, + v, v & BIT(st_bit), 1, + OMAP_RESET_MAX_WAIT); + if (ret) + pr_err("%s: timedout waiting for %s:%lu\n", __func__, + reset->prm->data->name, id); + return 0; } -- 2.17.1 -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
WARNING: multiple messages have this Message-ID (diff)
From: Tero Kristo <t-kristo@ti.com> To: <linux-omap@vger.kernel.org>, <ssantosh@kernel.org> Cc: tony@atomide.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, p.zabel@pengutronix.de Subject: [PATCHv7 3/9] soc: ti: omap-prm: poll for reset complete during de-assert Date: Tue, 8 Oct 2019 10:19:07 +0300 [thread overview] Message-ID: <20191008071913.28740-4-t-kristo@ti.com> (raw) In-Reply-To: <20191008071913.28740-1-t-kristo@ti.com> Poll for reset completion status during de-assertion of reset, otherwise the IP in question might be accessed before it has left reset properly. Signed-off-by: Tero Kristo <t-kristo@ti.com> --- drivers/soc/ti/omap_prm.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/soc/ti/omap_prm.c b/drivers/soc/ti/omap_prm.c index ab0b66ad715d..96fa2aad9b93 100644 --- a/drivers/soc/ti/omap_prm.c +++ b/drivers/soc/ti/omap_prm.c @@ -153,6 +153,18 @@ static int omap_reset_deassert(struct reset_controller_dev *rcdev, writel_relaxed(v, reset->prm->base + reset->prm->data->rstctrl); spin_unlock_irqrestore(&reset->lock, flags); + if (!has_rstst) + return 0; + + /* wait for the status to be set */ + ret = readl_relaxed_poll_timeout(reset->prm->base + + reset->prm->data->rstst, + v, v & BIT(st_bit), 1, + OMAP_RESET_MAX_WAIT); + if (ret) + pr_err("%s: timedout waiting for %s:%lu\n", __func__, + reset->prm->data->name, id); + return 0; } -- 2.17.1 -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-08 7:19 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-08 7:19 [PATCHv7 0/9] soc: ti: add OMAP PRM driver (for reset) Tero Kristo 2019-10-08 7:19 ` Tero Kristo 2019-10-08 7:19 ` [PATCHv7 1/9] dt-bindings: omap: add new binding for PRM instances Tero Kristo 2019-10-08 7:19 ` Tero Kristo 2019-10-08 7:19 ` [PATCHv7 2/9] soc: ti: add initial PRM driver with reset control support Tero Kristo 2019-10-08 7:19 ` Tero Kristo 2019-10-08 11:39 ` Philipp Zabel 2019-10-08 11:39 ` Philipp Zabel 2019-10-08 12:42 ` Tero Kristo 2019-10-08 12:42 ` Tero Kristo 2019-10-08 7:19 ` Tero Kristo [this message] 2019-10-08 7:19 ` [PATCHv7 3/9] soc: ti: omap-prm: poll for reset complete during de-assert Tero Kristo 2019-10-08 11:40 ` Philipp Zabel 2019-10-08 11:40 ` Philipp Zabel 2019-10-08 7:19 ` [PATCHv7 4/9] soc: ti: omap-prm: add support for denying idle for reset clockdomain Tero Kristo 2019-10-08 7:19 ` Tero Kristo 2019-10-08 7:19 ` [PATCHv7 5/9] soc: ti: omap-prm: add omap4 PRM data Tero Kristo 2019-10-08 7:19 ` Tero Kristo 2019-10-08 7:19 ` [PATCHv7 6/9] soc: ti: omap-prm: add data for am33xx Tero Kristo 2019-10-08 7:19 ` Tero Kristo 2019-10-08 7:19 ` [PATCHv7 7/9] soc: ti: omap-prm: add dra7 PRM data Tero Kristo 2019-10-08 7:19 ` Tero Kristo 2019-10-08 7:19 ` [PATCHv7 8/9] soc: ti: omap-prm: add am4 " Tero Kristo 2019-10-08 7:19 ` Tero Kristo 2019-10-08 7:19 ` [PATCHv7 9/9] soc: ti: omap-prm: add omap5 " Tero Kristo 2019-10-08 7:19 ` Tero Kristo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191008071913.28740-4-t-kristo@ti.com \ --to=t-kristo@ti.com \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ --cc=p.zabel@pengutronix.de \ --cc=ssantosh@kernel.org \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.