From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-xfs@vger.kernel.org, linux-nvdimm@lists.01.org,
linux-kernel@vger.kernel.org, rgoldwyn@suse.de,
gujx@cn.fujitsu.com, david@fromorbit.com, qi.fuli@fujitsu.com
Subject: Re: [RFC PATCH 0/7] xfs: add reflink & dedupe support for fsdax.
Date: Wed, 9 Oct 2019 10:11:52 -0700 [thread overview]
Message-ID: <20191009171152.GF13108@magnolia> (raw)
In-Reply-To: <20191009063144.GA4300@infradead.org>
On Tue, Oct 08, 2019 at 11:31:44PM -0700, Christoph Hellwig wrote:
> Btw, I just had a chat with Dan last week on this. And he pointed out
> that while this series deals with the read/write path issues of
> reflink on DAX it doesn't deal with the mmap side issue that
> page->mapping and page->index can point back to exactly one file.
>
> I think we want a few xfstests that reflink a file and then use the
> different links using mmap, as that should blow up pretty reliably.
Hmm, you're right, we don't actually have a test that checks the
behavior of mwriting all copies of a shared block. Ok, I'll go write
one.
--D
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Shiyang Ruan <ruansy.fnst@cn.fujitsu.com>,
linux-xfs@vger.kernel.org, linux-nvdimm@lists.01.org,
linux-kernel@vger.kernel.org, rgoldwyn@suse.de,
gujx@cn.fujitsu.com, david@fromorbit.com, qi.fuli@fujitsu.com,
caoj.fnst@cn.fujitsu.com
Subject: Re: [RFC PATCH 0/7] xfs: add reflink & dedupe support for fsdax.
Date: Wed, 9 Oct 2019 10:11:52 -0700 [thread overview]
Message-ID: <20191009171152.GF13108@magnolia> (raw)
In-Reply-To: <20191009063144.GA4300@infradead.org>
On Tue, Oct 08, 2019 at 11:31:44PM -0700, Christoph Hellwig wrote:
> Btw, I just had a chat with Dan last week on this. And he pointed out
> that while this series deals with the read/write path issues of
> reflink on DAX it doesn't deal with the mmap side issue that
> page->mapping and page->index can point back to exactly one file.
>
> I think we want a few xfstests that reflink a file and then use the
> different links using mmap, as that should blow up pretty reliably.
Hmm, you're right, we don't actually have a test that checks the
behavior of mwriting all copies of a shared block. Ok, I'll go write
one.
--D
next prev parent reply other threads:[~2019-10-09 17:12 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 11:49 [RFC PATCH 0/7] xfs: add reflink & dedupe support for fsdax Shiyang Ruan
2019-07-31 11:49 ` Shiyang Ruan
2019-07-31 11:49 ` Shiyang Ruan
2019-07-31 11:49 ` [RFC PATCH 1/7] dax: Introduce dax_copy_edges() for COW Shiyang Ruan
2019-07-31 11:49 ` Shiyang Ruan
2019-07-31 11:49 ` Shiyang Ruan
2019-07-31 11:49 ` [RFC PATCH 2/7] dax: copy data before write Shiyang Ruan
2019-07-31 11:49 ` Shiyang Ruan
2019-07-31 11:49 ` Shiyang Ruan
2019-07-31 11:49 ` [RFC PATCH 3/7] dax: replace mmap entry in case of CoW Shiyang Ruan
2019-07-31 11:49 ` Shiyang Ruan
2019-07-31 11:49 ` Shiyang Ruan
2019-07-31 11:49 ` [RFC PATCH 4/7] fs: dedup file range to use a compare function Shiyang Ruan
2019-07-31 11:49 ` Shiyang Ruan
2019-07-31 11:49 ` Shiyang Ruan
2019-07-31 11:49 ` [RFC PATCH 5/7] dax: memcpy before zeroing range Shiyang Ruan
2019-07-31 11:49 ` Shiyang Ruan
2019-07-31 11:49 ` Shiyang Ruan
2019-07-31 11:49 ` [RFC PATCH 6/7] xfs: Add COW handle for fsdax Shiyang Ruan
2019-07-31 11:49 ` Shiyang Ruan
2019-07-31 11:49 ` Shiyang Ruan
2019-07-31 11:49 ` [RFC PATCH 7/7] xfs: Add dedupe support " Shiyang Ruan
2019-07-31 11:49 ` Shiyang Ruan
2019-07-31 11:49 ` Shiyang Ruan
2019-07-31 20:33 ` [RFC PATCH 0/7] xfs: add reflink & " Goldwyn Rodrigues
2019-07-31 20:33 ` Goldwyn Rodrigues
2019-08-01 1:37 ` Shiyang Ruan
2019-08-01 1:37 ` Shiyang Ruan
2019-08-01 1:37 ` Shiyang Ruan
2019-08-05 0:21 ` Dave Chinner
2019-08-05 0:21 ` Dave Chinner
2019-10-09 6:31 ` Christoph Hellwig
2019-10-09 6:31 ` Christoph Hellwig
2019-10-09 17:11 ` Darrick J. Wong [this message]
2019-10-09 17:11 ` Darrick J. Wong
2019-10-10 7:30 ` Dave Chinner
2019-10-10 7:30 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191009171152.GF13108@magnolia \
--to=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=gujx@cn.fujitsu.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
--cc=qi.fuli@fujitsu.com \
--cc=rgoldwyn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.