From: Marc Zyngier <maz@kernel.org>
To: linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org
Cc: Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
James Morse <james.morse@arm.com>,
Julien Thierry <julien.thierry.kdev@gmail.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Andrew Murray <andrew.murray@arm.com>
Subject: [PATCH v3 0/4] KVM: arm64: Assorted PMU emulation fixes
Date: Fri, 11 Oct 2019 13:39:50 +0100 [thread overview]
Message-ID: <20191011123954.31378-1-maz@kernel.org> (raw)
I recently came across a number of PMU emulation bugs, all which can
result in unexpected behaviours in an unsuspecting guest. The first
two patches already have been discussed on the list, but I'm including
them here as part of a slightly longer series.
The third patch is new as of v2, and fixes a bug preventing chained
events from ever being used.
The last patch fixes an issue that has been here from day one, where
we confuse architectural overflow of a counter and perf sampling
period, and uses a terrible hack^W^W creative way to interact with the
underlying PMU driver so that we can reload the period when handling
the overflow.
* From v2 [1]
- Dropped PMUv3 patch and moved the logic into the KVM code
- Properly use UPDATE/RELOAD
- Collected Andrew's RB
[1] https://lore.kernel.org/kvmarm/20191008160128.8872-1-maz@kernel.org/
Marc Zyngier (4):
KVM: arm64: pmu: Fix cycle counter truncation
arm64: KVM: Handle PMCR_EL0.LC as RES1 on pure AArch64 systems
KVM: arm64: pmu: Set the CHAINED attribute before creating the
in-kernel event
KVM: arm64: pmu: Reset sample period on overflow handling
arch/arm64/kvm/sys_regs.c | 4 ++++
virt/kvm/arm/pmu.c | 48 ++++++++++++++++++++++++++++-----------
2 files changed, 39 insertions(+), 13 deletions(-)
--
2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org
Cc: Will Deacon <will@kernel.org>
Subject: [PATCH v3 0/4] KVM: arm64: Assorted PMU emulation fixes
Date: Fri, 11 Oct 2019 13:39:50 +0100 [thread overview]
Message-ID: <20191011123954.31378-1-maz@kernel.org> (raw)
I recently came across a number of PMU emulation bugs, all which can
result in unexpected behaviours in an unsuspecting guest. The first
two patches already have been discussed on the list, but I'm including
them here as part of a slightly longer series.
The third patch is new as of v2, and fixes a bug preventing chained
events from ever being used.
The last patch fixes an issue that has been here from day one, where
we confuse architectural overflow of a counter and perf sampling
period, and uses a terrible hack^W^W creative way to interact with the
underlying PMU driver so that we can reload the period when handling
the overflow.
* From v2 [1]
- Dropped PMUv3 patch and moved the logic into the KVM code
- Properly use UPDATE/RELOAD
- Collected Andrew's RB
[1] https://lore.kernel.org/kvmarm/20191008160128.8872-1-maz@kernel.org/
Marc Zyngier (4):
KVM: arm64: pmu: Fix cycle counter truncation
arm64: KVM: Handle PMCR_EL0.LC as RES1 on pure AArch64 systems
KVM: arm64: pmu: Set the CHAINED attribute before creating the
in-kernel event
KVM: arm64: pmu: Reset sample period on overflow handling
arch/arm64/kvm/sys_regs.c | 4 ++++
virt/kvm/arm/pmu.c | 48 ++++++++++++++++++++++++++++-----------
2 files changed, 39 insertions(+), 13 deletions(-)
--
2.20.1
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org
Cc: Mark Rutland <mark.rutland@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
James Morse <james.morse@arm.com>,
Andrew Murray <andrew.murray@arm.com>,
Will Deacon <will@kernel.org>,
Julien Thierry <julien.thierry.kdev@gmail.com>
Subject: [PATCH v3 0/4] KVM: arm64: Assorted PMU emulation fixes
Date: Fri, 11 Oct 2019 13:39:50 +0100 [thread overview]
Message-ID: <20191011123954.31378-1-maz@kernel.org> (raw)
I recently came across a number of PMU emulation bugs, all which can
result in unexpected behaviours in an unsuspecting guest. The first
two patches already have been discussed on the list, but I'm including
them here as part of a slightly longer series.
The third patch is new as of v2, and fixes a bug preventing chained
events from ever being used.
The last patch fixes an issue that has been here from day one, where
we confuse architectural overflow of a counter and perf sampling
period, and uses a terrible hack^W^W creative way to interact with the
underlying PMU driver so that we can reload the period when handling
the overflow.
* From v2 [1]
- Dropped PMUv3 patch and moved the logic into the KVM code
- Properly use UPDATE/RELOAD
- Collected Andrew's RB
[1] https://lore.kernel.org/kvmarm/20191008160128.8872-1-maz@kernel.org/
Marc Zyngier (4):
KVM: arm64: pmu: Fix cycle counter truncation
arm64: KVM: Handle PMCR_EL0.LC as RES1 on pure AArch64 systems
KVM: arm64: pmu: Set the CHAINED attribute before creating the
in-kernel event
KVM: arm64: pmu: Reset sample period on overflow handling
arch/arm64/kvm/sys_regs.c | 4 ++++
virt/kvm/arm/pmu.c | 48 ++++++++++++++++++++++++++++-----------
2 files changed, 39 insertions(+), 13 deletions(-)
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2019-10-11 12:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 12:39 Marc Zyngier [this message]
2019-10-11 12:39 ` [PATCH v3 0/4] KVM: arm64: Assorted PMU emulation fixes Marc Zyngier
2019-10-11 12:39 ` Marc Zyngier
2019-10-11 12:39 ` [PATCH v3 1/4] KVM: arm64: pmu: Fix cycle counter truncation Marc Zyngier
2019-10-11 12:39 ` Marc Zyngier
2019-10-11 12:39 ` Marc Zyngier
2019-10-11 12:39 ` [PATCH v3 2/4] arm64: KVM: Handle PMCR_EL0.LC as RES1 on pure AArch64 systems Marc Zyngier
2019-10-11 12:39 ` Marc Zyngier
2019-10-11 12:39 ` Marc Zyngier
2019-10-11 12:39 ` [PATCH v3 3/4] KVM: arm64: pmu: Set the CHAINED attribute before creating the in-kernel event Marc Zyngier
2019-10-11 12:39 ` Marc Zyngier
2019-10-11 12:39 ` Marc Zyngier
2019-10-11 14:19 ` Andrew Murray
2019-10-11 14:19 ` Andrew Murray
2019-10-11 14:19 ` Andrew Murray
2019-10-11 12:39 ` [PATCH v3 4/4] KVM: arm64: pmu: Reset sample period on overflow handling Marc Zyngier
2019-10-11 12:39 ` Marc Zyngier
2019-10-11 12:39 ` Marc Zyngier
2019-10-15 10:00 ` Andrew Murray
2019-10-15 10:00 ` Andrew Murray
2019-10-15 10:00 ` Andrew Murray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191011123954.31378-1-maz@kernel.org \
--to=maz@kernel.org \
--cc=andrew.murray@arm.com \
--cc=james.morse@arm.com \
--cc=julien.thierry.kdev@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.