Re: [PATCH] iomap: iomap that extends beyond EOF should be marked dirty

From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Dave Chinner <david@fromorbit.com>,
	linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] iomap: iomap that extends beyond EOF should be marked dirty
Date: Tue, 15 Oct 2019 23:40:33 -0700	[thread overview]
Message-ID: <20191016064033.GA18326@infradead.org> (raw)
In-Reply-To: <20191016052713.GX13108@magnolia>

On Tue, Oct 15, 2019 at 10:27:13PM -0700, Darrick J. Wong wrote:
> > +	/*
> > +	 * Writes that span EOF might trigger an IO size update on completion,
> > +	 * so consider them to be dirty for the purposes of O_DSYNC even if
> > +	 * there is no other metadata changes being made or are pending here.
> > +	 */
> > +	if (offset + count > i_size_read(inode))
> > +		iomap->flags |= IOMAP_F_DIRTY;
> 
> This ought to be in xfs_direct_write_iomap_begin(), right?
> 
> (Hoping to see another rev of Christoph's iomap cleanup series... ;))

I need to finish off all the nitpicks on the first iomap series..

Also we'll want this patch in first as it is 5.4 / -stable material,
so I'll need to rebase on top of that as well.