From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2] iomap: iomap that extends beyond EOF should be marked dirty
Date: Tue, 15 Oct 2019 23:43:53 -0700 [thread overview]
Message-ID: <20191016064353.GA25846@infradead.org> (raw)
In-Reply-To: <20191016060604.GH16973@dread.disaster.area>
I wonder if the i_size check should be done in core, similar to the
iomap_block_needs_zeroing helper. But independent of what is nicer
this version does look correct to me:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2019-10-16 6:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 5:11 [PATCH] iomap: iomap that extends beyond EOF should be marked dirty Dave Chinner
2019-10-16 5:25 ` Dave Chinner
2019-10-16 5:27 ` Darrick J. Wong
2019-10-16 6:40 ` Christoph Hellwig
2019-10-16 6:06 ` [PATCH v2] " Dave Chinner
2019-10-16 6:43 ` Christoph Hellwig [this message]
2019-10-17 12:29 ` Theodore Y. Ts'o
2019-10-17 14:17 ` Christoph Hellwig
2019-10-17 14:48 ` Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191016064353.GA25846@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.