From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: linus.walleij@linaro.org, afaerber@suse.de, f.fainelli@gmail.com,
rjui@broadcom.com, sbranden@broadcom.com,
bcm-kernel-feedback-list@broadcom.com, jesper.nilsson@axis.com,
lars.persson@axis.com, ludovic.desroches@microchip.com,
nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com,
baruch@tkos.co.il, linux-arm-kernel@lists.infradead.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@axis.com, linux-oxnas@groups.io,
linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-tegra@vger.kernel.org, vz@mleia.com,
narmstrong@baylibre.com, geert+renesas@glider.be,
daniel@zonque.org, haojian.zhuang@gmail.com, wens@csie.org,
thierry.reding@gmail.com, jonathanh@nvidia.com,
agross@kernel.org
Subject: Re: [PATCH -next 28/30] pinctrl: actions: use devm_platform_ioremap_resource() to simplify code
Date: Thu, 17 Oct 2019 18:29:40 +0530 [thread overview]
Message-ID: <20191017125940.GA25046@mani> (raw)
In-Reply-To: <20191017122640.22976-29-yuehaibing@huawei.com>
On Thu, Oct 17, 2019 at 08:26:38PM +0800, YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> ---
> drivers/pinctrl/actions/pinctrl-owl.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pinctrl/actions/pinctrl-owl.c b/drivers/pinctrl/actions/pinctrl-owl.c
> index 5dfe718..5a0c8e8 100644
> --- a/drivers/pinctrl/actions/pinctrl-owl.c
> +++ b/drivers/pinctrl/actions/pinctrl-owl.c
> @@ -915,7 +915,6 @@ static int owl_gpio_init(struct owl_pinctrl *pctrl)
> int owl_pinctrl_probe(struct platform_device *pdev,
> struct owl_pinctrl_soc_data *soc_data)
> {
> - struct resource *res;
> struct owl_pinctrl *pctrl;
> int ret, i;
>
> @@ -923,8 +922,7 @@ int owl_pinctrl_probe(struct platform_device *pdev,
> if (!pctrl)
> return -ENOMEM;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - pctrl->base = devm_ioremap_resource(&pdev->dev, res);
> + pctrl->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(pctrl->base))
> return PTR_ERR(pctrl->base);
>
> --
> 2.7.4
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: alexandre.belloni@bootlin.com, geert+renesas@glider.be,
narmstrong@baylibre.com, linus.walleij@linaro.org,
baruch@tkos.co.il, linux-kernel@vger.kernel.org,
thierry.reding@gmail.com, jesper.nilsson@axis.com,
f.fainelli@gmail.com, wens@csie.org, linux-arm-kernel@axis.com,
jonathanh@nvidia.com, ludovic.desroches@microchip.com,
agross@kernel.org, bcm-kernel-feedback-list@broadcom.com,
linux-arm-msm@vger.kernel.org, rjui@broadcom.com,
haojian.zhuang@gmail.com, vz@mleia.com,
linux-gpio@vger.kernel.org, lars.persson@axis.com,
linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, sbranden@broadcom.com,
linux-renesas-soc@vger.kernel.org, linux-oxnas@groups.io,
afaerber@suse.de, daniel@zonque.org
Subject: Re: [PATCH -next 28/30] pinctrl: actions: use devm_platform_ioremap_resource() to simplify code
Date: Thu, 17 Oct 2019 18:29:40 +0530 [thread overview]
Message-ID: <20191017125940.GA25046@mani> (raw)
In-Reply-To: <20191017122640.22976-29-yuehaibing@huawei.com>
On Thu, Oct 17, 2019 at 08:26:38PM +0800, YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> ---
> drivers/pinctrl/actions/pinctrl-owl.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pinctrl/actions/pinctrl-owl.c b/drivers/pinctrl/actions/pinctrl-owl.c
> index 5dfe718..5a0c8e8 100644
> --- a/drivers/pinctrl/actions/pinctrl-owl.c
> +++ b/drivers/pinctrl/actions/pinctrl-owl.c
> @@ -915,7 +915,6 @@ static int owl_gpio_init(struct owl_pinctrl *pctrl)
> int owl_pinctrl_probe(struct platform_device *pdev,
> struct owl_pinctrl_soc_data *soc_data)
> {
> - struct resource *res;
> struct owl_pinctrl *pctrl;
> int ret, i;
>
> @@ -923,8 +922,7 @@ int owl_pinctrl_probe(struct platform_device *pdev,
> if (!pctrl)
> return -ENOMEM;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - pctrl->base = devm_ioremap_resource(&pdev->dev, res);
> + pctrl->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(pctrl->base))
> return PTR_ERR(pctrl->base);
>
> --
> 2.7.4
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-17 12:59 UTC|newest]
Thread overview: 116+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 12:26 [PATCH -next 00/30] pinctrl: use devm_platform_ioremap_resource() to simplify code YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` [PATCH -next 01/30] pinctrl: pxa25x: " YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-11-04 0:18 ` Linus Walleij
2019-11-04 0:18 ` Linus Walleij
2019-11-04 0:18 ` Linus Walleij
2019-11-04 1:17 ` Yuehaibing
2019-11-04 1:17 ` Yuehaibing
2019-11-04 1:17 ` Yuehaibing
2019-11-04 14:26 ` [PATCH v2] pinctrl: " YueHaibing
2019-11-05 14:34 ` Linus Walleij
2019-10-17 12:26 ` [PATCH -next 02/30] pinctrl: pxa27x: " YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` [PATCH -next 03/30] pinctrl: cygnus-mux: " YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` [PATCH -next 04/30] pinctrl: pic32: " YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` [PATCH -next 05/30] pinctrl: nsp-gpio: " YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` [PATCH -next 06/30] pinctrl: nsp: " YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` [PATCH -next 07/30] pinctrl: ns2: " YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` [PATCH -next 08/30] pinctrl: bcm281xx: " YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` [PATCH -next 09/30] pinctrl: sunxi: " YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` [PATCH -next 10/30] pinctrl: tegra: " YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:52 ` Thierry Reding
2019-10-17 12:52 ` Thierry Reding
2019-10-17 12:26 ` [PATCH -next 11/30] pinctrl: msm: " YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-18 17:06 ` Bjorn Andersson
2019-10-18 17:06 ` Bjorn Andersson
2019-10-17 12:26 ` [PATCH -next 12/30] pinctrl: spear: " YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` [PATCH -next 13/30] pinctrl: zte: " YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` [PATCH -next 14/30] pinctrl: at91: " YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` [PATCH -next 15/30] pinctrl: oxnas: " YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:50 ` Neil Armstrong
2019-10-17 12:50 ` Neil Armstrong
2019-10-17 12:26 ` [PATCH -next 16/30] pinctrl: pistachio: " YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` [PATCH -next 17/30] pinctrl: lpc18xx: " YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` [PATCH -next 18/30] pinctrl: da850-pupd: " YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` [PATCH -next 19/30] pinctrl: tb10x: " YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` [PATCH -next 20/30] pinctrl: u300: " YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` [PATCH -next 21/30] pinctrl: vt8500: " YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` [PATCH -next 22/30] pinctrl: xway: " YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` [PATCH -next 23/30] pinctrl: rza2: " YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` [PATCH -next 24/30] pinctrl: digicolor: " YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` [PATCH -next 25/30] pinctrl: coh901: " YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` [PATCH -next 26/30] pinctrl: bm1880: " YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 13:00 ` Manivannan Sadhasivam
2019-10-17 13:00 ` Manivannan Sadhasivam
2019-10-17 12:26 ` [PATCH -next 27/30] pinctrl: artpec6: " YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:51 ` Jesper Nilsson
2019-10-17 12:51 ` Jesper Nilsson
2019-10-17 12:51 ` Jesper Nilsson
2019-10-17 12:26 ` [PATCH -next 28/30] pinctrl: actions: " YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:59 ` Manivannan Sadhasivam [this message]
2019-10-17 12:59 ` Manivannan Sadhasivam
2019-10-17 12:26 ` [PATCH -next 29/30] pinctrl: at91-pio4: " YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` [PATCH -next 30/30] pinctrl: iproc: " YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 12:26 ` YueHaibing
2019-10-17 13:09 ` [PATCH -next 00/30] pinctrl: " Alexandre Belloni
2019-10-17 13:09 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191017125940.GA25046@mani \
--to=manivannan.sadhasivam@linaro.org \
--cc=afaerber@suse.de \
--cc=agross@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=baruch@tkos.co.il \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=daniel@zonque.org \
--cc=f.fainelli@gmail.com \
--cc=geert+renesas@glider.be \
--cc=haojian.zhuang@gmail.com \
--cc=jesper.nilsson@axis.com \
--cc=jonathanh@nvidia.com \
--cc=lars.persson@axis.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@axis.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-oxnas@groups.io \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=narmstrong@baylibre.com \
--cc=nicolas.ferre@microchip.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=thierry.reding@gmail.com \
--cc=vz@mleia.com \
--cc=wens@csie.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.