From: Ben Dooks <ben.dooks@codethink.co.uk> To: linux-tegra@vger.kernel.org, alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Thierry Reding <thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com> Cc: linux-kernel@lists.codethink.co.uk, Ben Dooks <ben.dooks@codethink.co.uk> Subject: [PATCH v5 5/7] ASoC: tegra: set i2s_offset to 0 for tdm Date: Fri, 18 Oct 2019 16:48:31 +0100 [thread overview] Message-ID: <20191018154833.7560-6-ben.dooks@codethink.co.uk> (raw) In-Reply-To: <20191018154833.7560-1-ben.dooks@codethink.co.uk> Set the offset to 0 for TDM mode, as per the current setup. Note we also move the data offset programming to the i2s hw_parameters call as per the suggestion from Jon Hunter. Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> --- v2: - fix the review comments and move the i2s offset setting v3: - fix data-offset for dsp-a and dsp-b --- sound/soc/tegra/tegra30_i2s.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/sound/soc/tegra/tegra30_i2s.c b/sound/soc/tegra/tegra30_i2s.c index 3839e3d955a8..e99126600fc4 100644 --- a/sound/soc/tegra/tegra30_i2s.c +++ b/sound/soc/tegra/tegra30_i2s.c @@ -66,7 +66,7 @@ static int tegra30_i2s_set_fmt(struct snd_soc_dai *dai, unsigned int fmt) { struct tegra30_i2s *i2s = snd_soc_dai_get_drvdata(dai); - unsigned int mask = 0, val = 0; + unsigned int mask = 0, val = 0, data_offset = 1; unsigned int ch_mask, ch_val = 0; switch (fmt & SND_SOC_DAIFMT_INV_MASK) { @@ -100,6 +100,7 @@ static int tegra30_i2s_set_fmt(struct snd_soc_dai *dai, ch_val = TEGRA30_I2S_CH_CTRL_EGDE_CTRL_POS_EDGE; val |= TEGRA30_I2S_CTRL_FRAME_FORMAT_FSYNC; val |= TEGRA30_I2S_CTRL_LRCK_R_LOW; + data_offset = 0; break; case SND_SOC_DAIFMT_I2S: val |= TEGRA30_I2S_CTRL_FRAME_FORMAT_LRCK; @@ -120,6 +121,10 @@ static int tegra30_i2s_set_fmt(struct snd_soc_dai *dai, pm_runtime_get_sync(dai->dev); regmap_update_bits(i2s->regmap, TEGRA30_I2S_CTRL, mask, val); regmap_update_bits(i2s->regmap, TEGRA30_I2S_CH_CTRL, ch_mask, ch_val); + val = (data_offset << TEGRA30_I2S_OFFSET_RX_DATA_OFFSET_SHIFT) | + (data_offset << TEGRA30_I2S_OFFSET_TX_DATA_OFFSET_SHIFT); + regmap_write(i2s->regmap, TEGRA30_I2S_OFFSET, val); + pm_runtime_put(dai->dev); return 0; @@ -203,11 +208,6 @@ static int tegra30_i2s_hw_params(struct snd_pcm_substream *substream, } i2s->soc_data->set_audio_cif(i2s->regmap, reg, &cif_conf); - - val = (1 << TEGRA30_I2S_OFFSET_RX_DATA_OFFSET_SHIFT) | - (1 << TEGRA30_I2S_OFFSET_TX_DATA_OFFSET_SHIFT); - regmap_write(i2s->regmap, TEGRA30_I2S_OFFSET, val); - return 0; } -- 2.23.0
WARNING: multiple messages have this Message-ID (diff)
From: Ben Dooks <ben.dooks@codethink.co.uk> To: linux-tegra@vger.kernel.org, alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Thierry Reding <thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com> Cc: linux-kernel@lists.codethink.co.uk, Ben Dooks <ben.dooks@codethink.co.uk> Subject: [alsa-devel] [PATCH v5 5/7] ASoC: tegra: set i2s_offset to 0 for tdm Date: Fri, 18 Oct 2019 16:48:31 +0100 [thread overview] Message-ID: <20191018154833.7560-6-ben.dooks@codethink.co.uk> (raw) In-Reply-To: <20191018154833.7560-1-ben.dooks@codethink.co.uk> Set the offset to 0 for TDM mode, as per the current setup. Note we also move the data offset programming to the i2s hw_parameters call as per the suggestion from Jon Hunter. Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> --- v2: - fix the review comments and move the i2s offset setting v3: - fix data-offset for dsp-a and dsp-b --- sound/soc/tegra/tegra30_i2s.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/sound/soc/tegra/tegra30_i2s.c b/sound/soc/tegra/tegra30_i2s.c index 3839e3d955a8..e99126600fc4 100644 --- a/sound/soc/tegra/tegra30_i2s.c +++ b/sound/soc/tegra/tegra30_i2s.c @@ -66,7 +66,7 @@ static int tegra30_i2s_set_fmt(struct snd_soc_dai *dai, unsigned int fmt) { struct tegra30_i2s *i2s = snd_soc_dai_get_drvdata(dai); - unsigned int mask = 0, val = 0; + unsigned int mask = 0, val = 0, data_offset = 1; unsigned int ch_mask, ch_val = 0; switch (fmt & SND_SOC_DAIFMT_INV_MASK) { @@ -100,6 +100,7 @@ static int tegra30_i2s_set_fmt(struct snd_soc_dai *dai, ch_val = TEGRA30_I2S_CH_CTRL_EGDE_CTRL_POS_EDGE; val |= TEGRA30_I2S_CTRL_FRAME_FORMAT_FSYNC; val |= TEGRA30_I2S_CTRL_LRCK_R_LOW; + data_offset = 0; break; case SND_SOC_DAIFMT_I2S: val |= TEGRA30_I2S_CTRL_FRAME_FORMAT_LRCK; @@ -120,6 +121,10 @@ static int tegra30_i2s_set_fmt(struct snd_soc_dai *dai, pm_runtime_get_sync(dai->dev); regmap_update_bits(i2s->regmap, TEGRA30_I2S_CTRL, mask, val); regmap_update_bits(i2s->regmap, TEGRA30_I2S_CH_CTRL, ch_mask, ch_val); + val = (data_offset << TEGRA30_I2S_OFFSET_RX_DATA_OFFSET_SHIFT) | + (data_offset << TEGRA30_I2S_OFFSET_TX_DATA_OFFSET_SHIFT); + regmap_write(i2s->regmap, TEGRA30_I2S_OFFSET, val); + pm_runtime_put(dai->dev); return 0; @@ -203,11 +208,6 @@ static int tegra30_i2s_hw_params(struct snd_pcm_substream *substream, } i2s->soc_data->set_audio_cif(i2s->regmap, reg, &cif_conf); - - val = (1 << TEGRA30_I2S_OFFSET_RX_DATA_OFFSET_SHIFT) | - (1 << TEGRA30_I2S_OFFSET_TX_DATA_OFFSET_SHIFT); - regmap_write(i2s->regmap, TEGRA30_I2S_OFFSET, val); - return 0; } -- 2.23.0 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-10-18 15:48 UTC|newest] Thread overview: 182+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-18 15:48 tegra30 tdm audio support Ben Dooks 2019-10-18 15:48 ` [alsa-devel] " Ben Dooks 2019-10-18 15:48 ` [PATCH v5 1/7] ASoC: tegra: add a TDM configuration callback Ben Dooks 2019-10-18 15:48 ` [alsa-devel] " Ben Dooks 2019-10-24 15:50 ` Jon Hunter 2019-10-24 15:50 ` [alsa-devel] " Jon Hunter 2019-10-25 10:12 ` Applied "ASoC: tegra: add a TDM configuration callback" to the asoc tree Mark Brown 2019-10-25 10:12 ` [alsa-devel] " Mark Brown 2019-10-18 15:48 ` [PATCH v5 2/7] ASoC: tegra: Allow 24bit and 32bit samples Ben Dooks 2019-10-18 15:48 ` [alsa-devel] " Ben Dooks 2019-10-24 15:54 ` Jon Hunter 2019-10-24 15:54 ` [alsa-devel] " Jon Hunter 2019-10-25 10:12 ` Applied "ASoC: tegra: Allow 24bit and 32bit samples" to the asoc tree Mark Brown 2019-10-25 10:12 ` [alsa-devel] " Mark Brown 2019-11-23 21:09 ` [PATCH v5 2/7] ASoC: tegra: Allow 24bit and 32bit samples Dmitry Osipenko 2019-11-23 21:09 ` [alsa-devel] " Dmitry Osipenko 2019-11-25 10:37 ` Ben Dooks 2019-11-25 10:37 ` [alsa-devel] " Ben Dooks 2019-11-25 17:22 ` Dmitry Osipenko 2019-11-25 17:22 ` [alsa-devel] " Dmitry Osipenko 2019-11-25 17:28 ` Dmitry Osipenko 2019-11-25 17:28 ` [alsa-devel] " Dmitry Osipenko 2019-12-19 21:21 ` Dmitry Osipenko 2019-12-19 21:21 ` [alsa-devel] " Dmitry Osipenko 2019-12-20 10:56 ` Ben Dooks 2019-12-20 10:56 ` [alsa-devel] " Ben Dooks 2019-12-20 11:30 ` Jon Hunter 2019-12-20 11:30 ` [alsa-devel] " Jon Hunter 2019-12-20 11:38 ` Ben Dooks 2019-12-20 11:38 ` [alsa-devel] " Ben Dooks 2019-12-20 13:57 ` Jon Hunter 2019-12-20 13:57 ` [alsa-devel] " Jon Hunter 2019-12-20 14:43 ` Dmitry Osipenko 2019-12-20 14:43 ` [alsa-devel] " Dmitry Osipenko 2019-12-20 14:56 ` Ben Dooks 2019-12-20 14:56 ` [alsa-devel] " Ben Dooks 2019-12-20 15:02 ` Dmitry Osipenko 2019-12-20 15:02 ` [alsa-devel] " Dmitry Osipenko 2019-12-20 15:25 ` Ben Dooks 2019-12-20 15:25 ` [alsa-devel] " Ben Dooks 2019-12-20 16:40 ` Dmitry Osipenko 2019-12-20 16:40 ` [alsa-devel] " Dmitry Osipenko 2019-12-20 17:06 ` Ben Dooks 2019-12-20 17:06 ` [alsa-devel] " Ben Dooks 2019-12-22 17:08 ` Dmitry Osipenko 2019-12-22 17:08 ` [alsa-devel] " Dmitry Osipenko 2020-01-05 0:04 ` Ben Dooks 2020-01-05 0:04 ` [alsa-devel] " Ben Dooks 2020-01-05 1:48 ` Dmitry Osipenko 2020-01-05 1:48 ` [alsa-devel] " Dmitry Osipenko 2020-01-05 10:53 ` Ben Dooks 2020-01-05 10:53 ` [alsa-devel] " Ben Dooks 2020-01-06 19:00 ` [Linux-kernel] " Ben Dooks 2020-01-06 19:00 ` [alsa-devel] " Ben Dooks 2020-01-07 1:39 ` Dmitry Osipenko 2020-01-07 1:39 ` [alsa-devel] " Dmitry Osipenko 2020-01-08 11:37 ` Jon Hunter 2020-01-08 11:37 ` [alsa-devel] " Jon Hunter [not found] ` <07cd66dc-1a6c-6b49-55a9-1420fe235161-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2020-01-20 16:50 ` Dmitry Osipenko 2020-01-20 16:50 ` [alsa-devel] " Dmitry Osipenko [not found] ` <ebfaa0d3-1236-cac4-4bd8-4456a171d773-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-01-20 17:36 ` Ben Dooks 2020-01-20 17:36 ` [alsa-devel] " Ben Dooks [not found] ` <a2744ea0-cf6d-d083-75e6-853746195001-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-01-23 19:38 ` Ben Dooks 2020-01-23 19:38 ` Ben Dooks [not found] ` <28cafc56-095b-68c6-638d-270608a2983f-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org> 2020-01-23 21:59 ` Ben Dooks 2020-01-23 21:59 ` Ben Dooks [not found] ` <9b3a0cdd-34c7-ecb4-4a26-268fd4a63041-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org> 2020-01-23 22:11 ` Dmitry Osipenko 2020-01-23 22:11 ` Dmitry Osipenko [not found] ` <76a6a818-ab60-45eb-a85e-fa3090266d6f-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-01-24 4:31 ` Dmitry Osipenko 2020-01-24 4:31 ` Dmitry Osipenko 2020-01-24 16:56 ` Jon Hunter 2020-01-24 16:56 ` Jon Hunter [not found] ` <26aeb591-e770-5e6a-5ee4-05414ae4ddc6-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2020-01-24 17:00 ` Mark Brown 2020-01-24 17:00 ` Mark Brown [not found] ` <20200124170059.GB4918-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> 2020-01-24 17:03 ` Ben Dooks 2020-01-24 17:03 ` Ben Dooks 2020-01-24 16:50 ` Jon Hunter 2020-01-24 16:50 ` Jon Hunter [not found] ` <3d8544be-af20-f382-85fd-32183365267b-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2020-01-24 17:00 ` Ben Dooks 2020-01-24 17:00 ` Ben Dooks [not found] ` <318f0256-fe6d-c34d-4deb-74540fca8d0d-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org> 2020-01-28 7:49 ` Ricard Wanderlof 2020-01-28 7:49 ` Ricard Wanderlof 2020-01-24 17:06 ` Ben Dooks 2020-01-24 17:06 ` Ben Dooks 2020-01-27 19:20 ` Dmitry Osipenko 2020-01-27 19:20 ` Dmitry Osipenko [not found] ` <1b3c2af4-510e-306c-749a-efffc994b20a-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-01-27 19:23 ` Dmitry Osipenko 2020-01-27 19:23 ` Dmitry Osipenko 2020-01-28 8:59 ` Ben Dooks 2020-01-28 8:59 ` [alsa-devel] " Ben Dooks [not found] ` <62cea895-c1f1-a833-b63c-050642bb8a79-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org> 2020-01-28 13:19 ` Jon Hunter 2020-01-28 13:19 ` Jon Hunter [not found] ` <d6bb92e2-16ba-3c00-2f07-e741ecaa5ec8-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2020-01-28 15:25 ` Dmitry Osipenko 2020-01-28 15:25 ` Dmitry Osipenko 2020-01-28 15:26 ` Mark Brown 2020-01-28 15:26 ` Mark Brown [not found] ` <20200128152632.GF4689-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> 2020-01-28 17:45 ` Dmitry Osipenko 2020-01-28 17:45 ` Dmitry Osipenko 2020-01-28 18:42 ` Jon Hunter 2020-01-28 18:42 ` Jon Hunter [not found] ` <7d9a06b5-c001-2d01-f999-10ccd1195ebe-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2020-01-30 8:04 ` Ben Dooks 2020-01-30 8:04 ` Ben Dooks 2020-01-28 12:13 ` Mark Brown 2020-01-28 12:13 ` Mark Brown [not found] ` <20200128121315.GD4689-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> 2020-01-28 17:42 ` Dmitry Osipenko 2020-01-28 17:42 ` Dmitry Osipenko [not found] ` <047c8caa-e715-5295-9794-67ff3e10cea2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-01-28 18:19 ` Jon Hunter 2020-01-28 18:19 ` Jon Hunter [not found] ` <70f344bf-f991-606c-55ab-bdadea27d233-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2020-01-29 0:17 ` Dmitry Osipenko 2020-01-29 0:17 ` Dmitry Osipenko [not found] ` <2ff97414-f0a5-7224-0e53-6cad2ed0ccd2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-01-30 8:05 ` Ben Dooks 2020-01-30 8:05 ` [alsa-devel] (no subject) Ben Dooks 2020-01-30 9:31 ` Clemens Ladisch 2020-01-30 9:31 ` [alsa-devel] " Clemens Ladisch [not found] ` <96ed04cb-24ab-7e4d-bd44-6a4bb7c046ac-P6GI/4k7KOmELgA04lAiVw@public.gmane.org> 2020-01-30 9:39 ` Ben Dooks 2020-01-30 9:39 ` Ben Dooks [not found] ` <8161fc88-fa8c-ec92-cc14-1caa5c6f2fe7-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org> 2020-01-30 14:58 ` Clemens Ladisch 2020-01-30 14:58 ` Clemens Ladisch [not found] ` <182fd434-f15a-f049-1ba1-83bd864b4590-P6GI/4k7KOmELgA04lAiVw@public.gmane.org> 2020-01-31 10:50 ` Ben Dooks 2020-01-31 10:50 ` Ben Dooks 2020-01-31 11:03 ` Clemens Ladisch 2020-01-31 11:03 ` [alsa-devel] " Clemens Ladisch 2020-01-29 10:49 ` [alsa-devel] [Linux-kernel] [PATCH v5 2/7] ASoC: tegra: Allow 24bit and 32bit samples Jon Hunter 2020-01-29 10:49 ` Jon Hunter [not found] ` <4b90efd2-5d0c-84df-961d-80cee288e0d4-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2020-01-29 14:33 ` Jon Hunter 2020-01-29 14:33 ` Jon Hunter [not found] ` <586ea2b9-c204-2bd1-f8e2-875e0974e42d-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2020-01-29 15:22 ` Dmitry Osipenko 2020-01-29 15:22 ` Dmitry Osipenko 2020-01-30 8:17 ` Ben Dooks 2020-01-30 8:17 ` Ben Dooks [not found] ` <fe002ec7-ae6e-f770-b82a-49237e0b29c6-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org> 2020-01-30 12:05 ` Jon Hunter 2020-01-30 12:05 ` Jon Hunter [not found] ` <c01e6e09-d3ed-7c39-5a66-e25950f8bdcc-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2020-01-30 12:07 ` Ben Dooks 2020-01-30 12:07 ` Ben Dooks [not found] ` <5898e2ed-1773-8f8f-b26b-d4613a8ad4de-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org> 2020-01-30 13:09 ` Jon Hunter 2020-01-30 13:09 ` Jon Hunter 2020-01-30 13:10 ` Mark Brown 2020-01-30 13:10 ` Mark Brown [not found] ` <20200130131039.GC6682-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> 2020-03-19 15:32 ` Ben Dooks 2020-03-19 15:32 ` Ben Dooks [not found] ` <1df9cc13ea636502ac09191523ff0669-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org> 2020-03-20 14:18 ` Dmitry Osipenko 2020-03-20 14:18 ` Dmitry Osipenko 2020-01-30 8:06 ` Ben Dooks 2020-01-30 8:06 ` Ben Dooks 2020-01-29 17:52 ` Ben Dooks 2020-01-29 17:52 ` Ben Dooks 2020-01-28 8:58 ` Ben Dooks 2020-01-28 8:58 ` [alsa-devel] " Ben Dooks 2020-01-07 10:29 ` Jon Hunter 2020-01-07 10:29 ` [alsa-devel] " Jon Hunter 2020-01-07 10:35 ` Ben Dooks 2020-01-07 10:35 ` [alsa-devel] " Ben Dooks [not found] ` <eb90ee78-e462-401a-de60-4a9bfc2a00c4-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2020-01-21 18:15 ` Ben Dooks 2020-01-21 18:15 ` Ben Dooks [not found] ` <9fc97644-b679-ef9f-41ca-1d3a5f296f3a-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org> 2020-01-21 18:54 ` Dmitry Osipenko 2020-01-21 18:54 ` Dmitry Osipenko 2019-10-18 15:48 ` [PATCH v5 3/7] ASoC: tegra: i2s: Add support for more than 2 channels Ben Dooks 2019-10-18 15:48 ` [alsa-devel] " Ben Dooks 2019-10-24 16:12 ` Jon Hunter 2019-10-24 16:12 ` [alsa-devel] " Jon Hunter 2019-10-24 19:18 ` Mark Brown 2019-10-24 19:18 ` [alsa-devel] " Mark Brown 2019-10-25 7:48 ` Jon Hunter 2019-10-25 7:48 ` [alsa-devel] " Jon Hunter 2019-10-18 15:48 ` [PATCH v5 4/7] ASoC: tegra: disable rx_fifo after disable stream Ben Dooks 2019-10-18 15:48 ` [alsa-devel] " Ben Dooks 2019-10-24 16:12 ` Jon Hunter 2019-10-24 16:12 ` [alsa-devel] " Jon Hunter 2019-10-25 10:12 ` Applied "ASoC: tegra: disable rx_fifo after disable stream" to the asoc tree Mark Brown 2019-10-25 10:12 ` [alsa-devel] " Mark Brown 2019-10-18 15:48 ` Ben Dooks [this message] 2019-10-18 15:48 ` [alsa-devel] [PATCH v5 5/7] ASoC: tegra: set i2s_offset to 0 for tdm Ben Dooks 2019-10-25 7:58 ` Jon Hunter 2019-10-25 7:58 ` [alsa-devel] " Jon Hunter 2019-10-18 15:48 ` [PATCH v5 6/7] ASoC: tegra: config fifos on hw_param changes Ben Dooks 2019-10-18 15:48 ` [alsa-devel] " Ben Dooks 2019-10-25 8:18 ` Jon Hunter 2019-10-25 8:18 ` [alsa-devel] " Jon Hunter 2019-10-18 15:48 ` [PATCH v5 7/7] ASoC: tegra: take packing settings from the audio cif_config Ben Dooks 2019-10-18 15:48 ` [alsa-devel] " Ben Dooks 2019-10-25 8:47 ` Jon Hunter 2019-10-25 8:47 ` [alsa-devel] " Jon Hunter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191018154833.7560-6-ben.dooks@codethink.co.uk \ --to=ben.dooks@codethink.co.uk \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=jonathanh@nvidia.com \ --cc=lgirdwood@gmail.com \ --cc=linux-kernel@lists.codethink.co.uk \ --cc=linux-tegra@vger.kernel.org \ --cc=perex@perex.cz \ --cc=thierry.reding@gmail.com \ --cc=tiwai@suse.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.