Re: [PATCH v7 2/2] drm/bridge: Add NWL MIPI DSI host controller support

From: kbuild test robot <lkp@intel.com>
To: "Guido Günther" <agx@sigxcpu.org>
Cc: kbuild-all@lists.01.org, "David Airlie" <airlied@linux.ie>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	"NXP Linux Team" <linux-imx@nxp.com>,
	"Andrzej Hajda" <a.hajda@samsung.com>,
	"Neil Armstrong" <narmstrong@baylibre.com>,
	"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
	"Jonas Karlman" <jonas@kwiboo.se>,
	"Jernej Skrabec" <jernej.skrabec@siol.net>,
	"Lee Jones" <lee.jones@linaro.org>,
	"Guido Günther" <agx@sigxcpu.org>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	"Robert Chiras" <robert.chiras@nxp.com>,
	"Sam Ravnborg" <sam@ravnborg.org>,
	"Arnd Bergmann" <arnd@arndb.de>
Subject: Re: [PATCH v7 2/2] drm/bridge: Add NWL MIPI DSI host controller support
Date: Mon, 21 Oct 2019 19:11:12 +0800	[thread overview]
Message-ID: <201910211901.yB3b4mYu%lkp@intel.com> (raw)
In-Reply-To: <e0304ab9320cbbf3e63d78449e50975c036b2633.1571494140.git.agx@sigxcpu.org>

[-- Attachment #1: Type: text/plain, Size: 3065 bytes --]

Hi "Guido,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[cannot apply to v5.4-rc4 next-20191018]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Guido-G-nther/dt-bindings-display-bridge-Add-binding-for-NWL-mipi-dsi-host-controller/20191021-180825
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 7d194c2100ad2a6dded545887d02754948ca5241
config: mips-allmodconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/gpu/drm/bridge/nwl-dsi.c: In function 'nwl_dsi_host_attach':
>> drivers/gpu/drm/bridge/nwl-dsi.c:384:12: error: too few arguments to function 'drm_panel_bridge_add'
      bridge = drm_panel_bridge_add(panel);
               ^~~~~~~~~~~~~~~~~~~~
   In file included from include/drm/drm_crtc.h:44:0,
                    from include/drm/drm_atomic_helper.h:31,
                    from drivers/gpu/drm/bridge/nwl-dsi.c:24:
   include/drm/drm_bridge.h:432:20: note: declared here
    struct drm_bridge *drm_panel_bridge_add(struct drm_panel *panel,
                       ^~~~~~~~~~~~~~~~~~~~

vim +/drm_panel_bridge_add +384 drivers/gpu/drm/bridge/nwl-dsi.c

   358	
   359	static int nwl_dsi_host_attach(struct mipi_dsi_host *dsi_host,
   360				       struct mipi_dsi_device *device)
   361	{
   362		struct nwl_dsi *dsi = container_of(dsi_host, struct nwl_dsi, dsi_host);
   363		struct device *dev = dsi->dev;
   364		struct drm_bridge *bridge;
   365		struct drm_panel *panel;
   366		int ret;
   367	
   368		DRM_DEV_INFO(dev, "lanes=%u, format=0x%x flags=0x%lx\n", device->lanes,
   369			     device->format, device->mode_flags);
   370	
   371		if (device->lanes < 1 || device->lanes > 4)
   372			return -EINVAL;
   373	
   374		dsi->lanes = device->lanes;
   375		dsi->format = device->format;
   376		dsi->dsi_mode_flags = device->mode_flags;
   377	
   378		ret = drm_of_find_panel_or_bridge(dsi->dev->of_node, 1, 0, &panel,
   379						  &bridge);
   380		if (ret)
   381			return ret;
   382	
   383		if (panel) {
 > 384			bridge = drm_panel_bridge_add(panel);
   385			if (IS_ERR(bridge))
   386				return PTR_ERR(bridge);
   387		}
   388	
   389		dsi->panel_bridge = bridge;
   390		drm_bridge_add(&dsi->bridge);
   391	
   392		return 0;
   393	}
   394	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 62096 bytes --]