From: Steven Rostedt <rostedt@goodmis.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: jthierry@redhat.com, will@kernel.org, ard.biesheuvel@linaro.org,
peterz@infradead.org, catalin.marinas@arm.com, deller@gmx.de,
jpoimboe@redhat.com, linux-kernel@vger.kernel.org,
takahiro.akashi@linaro.org, mingo@redhat.com,
james.morse@arm.com, jeyu@kernel.org, amit.kachhap@arm.com,
svens@stackframe.org, duwe@suse.de,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/8] ftrace: add ftrace_init_nop()
Date: Tue, 22 Oct 2019 12:01:06 -0400 [thread overview]
Message-ID: <20191022120106.234790cb@gandalf.local.home> (raw)
In-Reply-To: <20191022153335.GC52920@lakrids.cambridge.arm.com>
On Tue, 22 Oct 2019 16:33:35 +0100
Mark Rutland <mark.rutland@arm.com> wrote:
> On Tue, Oct 22, 2019 at 04:30:35PM +0100, Mark Rutland wrote:
> > On Tue, Oct 22, 2019 at 08:54:28AM -0400, Steven Rostedt wrote:
> > > On Tue, 22 Oct 2019 12:28:11 +0100
> > > Mark Rutland <mark.rutland@arm.com> wrote:
> > > > | /**
> > > > | * ftrace_init_nop - initialize a nop call site
> > > > | * @mod: module structure if called by module load initialization
> > > > | * @rec: the mcount call site record
> > >
> > > Perhaps say "mcount/fentry"
> >
> > This is the exact wording that ftrace_make_nop and ftrace_modify_call
> > have. For consistency, I think those should all match.
>
> Now that I read this again, I see what you meant.
>
> If it's ok, I'll change those to:
>
> | @rec: the call site record (e.g. mcount/fentry)
>
Ack
-- Steve
WARNING: multiple messages have this Message-ID (diff)
From: Steven Rostedt <rostedt@goodmis.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: jthierry@redhat.com, svens@stackframe.org,
ard.biesheuvel@linaro.org, peterz@infradead.org,
catalin.marinas@arm.com, deller@gmx.de, jeyu@kernel.org,
linux-kernel@vger.kernel.org, takahiro.akashi@linaro.org,
mingo@redhat.com, james.morse@arm.com, jpoimboe@redhat.com,
amit.kachhap@arm.com, will@kernel.org, duwe@suse.de,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/8] ftrace: add ftrace_init_nop()
Date: Tue, 22 Oct 2019 12:01:06 -0400 [thread overview]
Message-ID: <20191022120106.234790cb@gandalf.local.home> (raw)
In-Reply-To: <20191022153335.GC52920@lakrids.cambridge.arm.com>
On Tue, 22 Oct 2019 16:33:35 +0100
Mark Rutland <mark.rutland@arm.com> wrote:
> On Tue, Oct 22, 2019 at 04:30:35PM +0100, Mark Rutland wrote:
> > On Tue, Oct 22, 2019 at 08:54:28AM -0400, Steven Rostedt wrote:
> > > On Tue, 22 Oct 2019 12:28:11 +0100
> > > Mark Rutland <mark.rutland@arm.com> wrote:
> > > > | /**
> > > > | * ftrace_init_nop - initialize a nop call site
> > > > | * @mod: module structure if called by module load initialization
> > > > | * @rec: the mcount call site record
> > >
> > > Perhaps say "mcount/fentry"
> >
> > This is the exact wording that ftrace_make_nop and ftrace_modify_call
> > have. For consistency, I think those should all match.
>
> Now that I read this again, I see what you meant.
>
> If it's ok, I'll change those to:
>
> | @rec: the call site record (e.g. mcount/fentry)
>
Ack
-- Steve
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-22 16:01 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 16:34 [PATCH 0/8] arm64: ftrace cleanup + FTRACE_WITH_REGS Mark Rutland
2019-10-21 16:34 ` Mark Rutland
2019-10-21 16:34 ` [PATCH 1/8] ftrace: add ftrace_init_nop() Mark Rutland
2019-10-21 16:34 ` Mark Rutland
2019-10-21 18:07 ` Steven Rostedt
2019-10-21 18:07 ` Steven Rostedt
2019-10-22 11:28 ` Mark Rutland
2019-10-22 11:28 ` Mark Rutland
2019-10-22 12:54 ` Steven Rostedt
2019-10-22 12:54 ` Steven Rostedt
2019-10-22 15:30 ` Mark Rutland
2019-10-22 15:30 ` Mark Rutland
2019-10-22 15:33 ` Mark Rutland
2019-10-22 15:33 ` Mark Rutland
2019-10-22 16:01 ` Steven Rostedt [this message]
2019-10-22 16:01 ` Steven Rostedt
2019-10-21 16:34 ` [PATCH 2/8] module/ftrace: handle patchable-function-entry Mark Rutland
2019-10-21 16:34 ` Mark Rutland
2019-10-21 16:34 ` [PATCH 3/8] arm64: module: rework special section handling Mark Rutland
2019-10-21 16:34 ` Mark Rutland
2019-10-21 16:34 ` [PATCH 4/8] arm64: module/ftrace: intialize PLT at load time Mark Rutland
2019-10-21 16:34 ` Mark Rutland
2019-10-21 16:34 ` [PATCH 5/8] arm64: insn: add encoder for MOV (register) Mark Rutland
2019-10-21 16:34 ` Mark Rutland
2019-10-21 16:34 ` [PATCH 6/8] arm64: asm-offsets: add S_FP Mark Rutland
2019-10-21 16:34 ` Mark Rutland
2019-10-21 16:34 ` [PATCH 7/8] arm64: implement ftrace with regs Mark Rutland
2019-10-21 16:34 ` Mark Rutland
2019-10-21 16:34 ` [PATCH 8/8] arm64: ftrace: minimize ifdeffery Mark Rutland
2019-10-21 16:34 ` Mark Rutland
2019-10-24 16:32 ` [PATCH 0/8] arm64: ftrace cleanup + FTRACE_WITH_REGS Ard Biesheuvel
2019-10-24 16:32 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191022120106.234790cb@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=amit.kachhap@arm.com \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=deller@gmx.de \
--cc=duwe@suse.de \
--cc=james.morse@arm.com \
--cc=jeyu@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=jthierry@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=svens@stackframe.org \
--cc=takahiro.akashi@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.