From: Eugeniu Rosca <erosca@de.adit-jv.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Eugeniu Rosca <erosca@de.adit-jv.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>, <alsa-devel@alsa-project.org>,
<linux-kernel@vger.kernel.org>,
Eugeniu Rosca <roscaeugeniu@gmail.com>,
Jiada Wang <jiada_wang@mentor.com>,
Timo Wischer <twischer@de.adit-jv.com>,
Andrew Gabbasov <andrew_gabbasov@mentor.com>,
<stable@vger.kernel.org>
Subject: Re: [RESEND PATCH] ASoC: rsnd: dma: fix SSI9 4/5/6/7 busif dma address
Date: Wed, 23 Oct 2019 11:55:45 +0200 [thread overview]
Message-ID: <20191023095545.GA20748@vmlxhi-102.adit-jv.com> (raw)
In-Reply-To: <87h840z3l3.wl-kuninori.morimoto.gx@renesas.com>
Hi Morimoto-san,
On Wed, Oct 23, 2019 at 09:51:36AM +0900, Kuninori Morimoto wrote:
>
> Hi
>
> > From: Jiada Wang <jiada_wang@mentor.com>
> >
> > Currently each SSI unit's busif dma address is calculated by
> > following calculation formula:
> > 0xec540000 + 0x1000 * id + busif / 4 * 0xA000 + busif % 4 * 0x400
> >
> > But according to R-Car3 HW manual 41.1.4 Register Configuration,
> > ssi9 4/5/6/7 busif data register address
> > (SSI9_4_BUSIF/SSI9_5_BUSIF/SSI9_6_BUSIF/SSI9_7_BUSIF)
> > are out of this rule.
> >
> > This patch updates the calculation formula to correct
> > ssi9 4/5/6/7 busif data register address.
> >
> > Fixes: 5e45a6fab3b9 ("ASoc: rsnd: dma: Calculate dma address with consider of BUSIF")
> > Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
> > Signed-off-by: Timo Wischer <twischer@de.adit-jv.com>
> > [erosca: minor improvements in commit description]
> > Cc: Andrew Gabbasov <andrew_gabbasov@mentor.com>
> > Cc: stable@vger.kernel.org # v4.20+
> > Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
> > ---
>
> Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Many thanks for the prompt responses.
--
Best Regards,
Eugeniu
WARNING: multiple messages have this Message-ID (diff)
From: Eugeniu Rosca <erosca@de.adit-jv.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Timo Wischer <twischer@de.adit-jv.com>,
alsa-devel@alsa-project.org,
Andrew Gabbasov <andrew_gabbasov@mentor.com>,
Eugeniu Rosca <roscaeugeniu@gmail.com>,
Jiada Wang <jiada_wang@mentor.com>,
linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
stable@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Eugeniu Rosca <erosca@de.adit-jv.com>
Subject: Re: [alsa-devel] [RESEND PATCH] ASoC: rsnd: dma: fix SSI9 4/5/6/7 busif dma address
Date: Wed, 23 Oct 2019 11:55:45 +0200 [thread overview]
Message-ID: <20191023095545.GA20748@vmlxhi-102.adit-jv.com> (raw)
In-Reply-To: <87h840z3l3.wl-kuninori.morimoto.gx@renesas.com>
Hi Morimoto-san,
On Wed, Oct 23, 2019 at 09:51:36AM +0900, Kuninori Morimoto wrote:
>
> Hi
>
> > From: Jiada Wang <jiada_wang@mentor.com>
> >
> > Currently each SSI unit's busif dma address is calculated by
> > following calculation formula:
> > 0xec540000 + 0x1000 * id + busif / 4 * 0xA000 + busif % 4 * 0x400
> >
> > But according to R-Car3 HW manual 41.1.4 Register Configuration,
> > ssi9 4/5/6/7 busif data register address
> > (SSI9_4_BUSIF/SSI9_5_BUSIF/SSI9_6_BUSIF/SSI9_7_BUSIF)
> > are out of this rule.
> >
> > This patch updates the calculation formula to correct
> > ssi9 4/5/6/7 busif data register address.
> >
> > Fixes: 5e45a6fab3b9 ("ASoc: rsnd: dma: Calculate dma address with consider of BUSIF")
> > Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
> > Signed-off-by: Timo Wischer <twischer@de.adit-jv.com>
> > [erosca: minor improvements in commit description]
> > Cc: Andrew Gabbasov <andrew_gabbasov@mentor.com>
> > Cc: stable@vger.kernel.org # v4.20+
> > Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
> > ---
>
> Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Many thanks for the prompt responses.
--
Best Regards,
Eugeniu
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-10-23 9:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 18:54 [RESEND PATCH] ASoC: rsnd: dma: fix SSI9 4/5/6/7 busif dma address Eugeniu Rosca
2019-10-22 18:54 ` [alsa-devel] " Eugeniu Rosca
2019-10-23 0:51 ` Kuninori Morimoto
2019-10-23 0:51 ` [alsa-devel] " Kuninori Morimoto
2019-10-23 9:55 ` Eugeniu Rosca [this message]
2019-10-23 9:55 ` Eugeniu Rosca
2019-10-23 18:56 ` Applied "ASoC: rsnd: dma: fix SSI9 4/5/6/7 busif dma address" to the asoc tree Mark Brown
2019-10-23 18:56 ` [alsa-devel] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191023095545.GA20748@vmlxhi-102.adit-jv.com \
--to=erosca@de.adit-jv.com \
--cc=alsa-devel@alsa-project.org \
--cc=andrew_gabbasov@mentor.com \
--cc=broonie@kernel.org \
--cc=jiada_wang@mentor.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=roscaeugeniu@gmail.com \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
--cc=twischer@de.adit-jv.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.