From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: Maxime Ripard <mripard@kernel.org>
Cc: davem@davemloft.net, herbert@gondor.apana.org.au,
mark.rutland@arm.com, robh+dt@kernel.org, wens@csie.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-sunxi@googlegroups.com
Subject: Re: [PATCH v2 2/4] dt-bindings: crypto: Add DT bindings documentation for sun8i-ss Security System
Date: Thu, 24 Oct 2019 11:31:18 +0200 [thread overview]
Message-ID: <20191024093118.GA15113@Red> (raw)
In-Reply-To: <20191024065005.hdypdl2dgqsrry5i@gilmour>
On Thu, Oct 24, 2019 at 08:50:05AM +0200, Maxime Ripard wrote:
> Hi,
>
> On Wed, Oct 23, 2019 at 10:10:14PM +0200, Corentin Labbe wrote:
> > This patch adds documentation for Device-Tree bindings of the
> > Security System cryptographic offloader driver.
> >
> > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> > ---
> > .../bindings/crypto/allwinner,sun8i-ss.yaml | 64 +++++++++++++++++++
> > 1 file changed, 64 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/crypto/allwinner,sun8i-ss.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/crypto/allwinner,sun8i-ss.yaml b/Documentation/devicetree/bindings/crypto/allwinner,sun8i-ss.yaml
> > new file mode 100644
> > index 000000000000..99b7736975bc
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/crypto/allwinner,sun8i-ss.yaml
> > @@ -0,0 +1,64 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/crypto/allwinner,sun8i-ss.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Allwinner Security System v2 driver
> > +
> > +maintainers:
> > + - Corentin Labbe <corentin.labbe@gmail.com>
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - allwinner,sun8i-a83t-crypto
> > + - allwinner,sun9i-a80-crypto
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + clocks:
> > + items:
> > + - description: Bus clock
> > + - description: Module clock
> > +
> > + clock-names:
> > + items:
> > + - const: bus
> > + - const: mod
> > +
> > + resets:
> > + maxItems: 1
>
> The A83t at least has a reset line, so please make a condition to have
> it required.
>
Hello
The A80 have one also, so I need to set minItems: 1
But setting both minItems: 1 and maxItems:1 lead to a check failure:
properties:resets: {'minItems': 1, 'maxItems': 1} is not valid under any of the given schemas
How to do that ?
Furthermore, I try to do that for interrupts and reg, since they are also mandatory and same failure.
> > + reset-names:
> > + const: bus
>
> You don't need reset-names at all in that binding.
Fixed
Thanks
WARNING: multiple messages have this Message-ID (diff)
From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: Maxime Ripard <mripard@kernel.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
herbert@gondor.apana.org.au, linux-sunxi@googlegroups.com,
linux-kernel@vger.kernel.org, wens@csie.org, robh+dt@kernel.org,
linux-crypto@vger.kernel.org, davem@davemloft.net,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/4] dt-bindings: crypto: Add DT bindings documentation for sun8i-ss Security System
Date: Thu, 24 Oct 2019 11:31:18 +0200 [thread overview]
Message-ID: <20191024093118.GA15113@Red> (raw)
In-Reply-To: <20191024065005.hdypdl2dgqsrry5i@gilmour>
On Thu, Oct 24, 2019 at 08:50:05AM +0200, Maxime Ripard wrote:
> Hi,
>
> On Wed, Oct 23, 2019 at 10:10:14PM +0200, Corentin Labbe wrote:
> > This patch adds documentation for Device-Tree bindings of the
> > Security System cryptographic offloader driver.
> >
> > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> > ---
> > .../bindings/crypto/allwinner,sun8i-ss.yaml | 64 +++++++++++++++++++
> > 1 file changed, 64 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/crypto/allwinner,sun8i-ss.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/crypto/allwinner,sun8i-ss.yaml b/Documentation/devicetree/bindings/crypto/allwinner,sun8i-ss.yaml
> > new file mode 100644
> > index 000000000000..99b7736975bc
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/crypto/allwinner,sun8i-ss.yaml
> > @@ -0,0 +1,64 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/crypto/allwinner,sun8i-ss.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Allwinner Security System v2 driver
> > +
> > +maintainers:
> > + - Corentin Labbe <corentin.labbe@gmail.com>
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - allwinner,sun8i-a83t-crypto
> > + - allwinner,sun9i-a80-crypto
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + clocks:
> > + items:
> > + - description: Bus clock
> > + - description: Module clock
> > +
> > + clock-names:
> > + items:
> > + - const: bus
> > + - const: mod
> > +
> > + resets:
> > + maxItems: 1
>
> The A83t at least has a reset line, so please make a condition to have
> it required.
>
Hello
The A80 have one also, so I need to set minItems: 1
But setting both minItems: 1 and maxItems:1 lead to a check failure:
properties:resets: {'minItems': 1, 'maxItems': 1} is not valid under any of the given schemas
How to do that ?
Furthermore, I try to do that for interrupts and reg, since they are also mandatory and same failure.
> > + reset-names:
> > + const: bus
>
> You don't need reset-names at all in that binding.
Fixed
Thanks
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-24 9:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 20:10 [PATCH v2 0/4] crypto: add sun8i-ss driver for Allwinner Security System Corentin Labbe
2019-10-23 20:10 ` Corentin Labbe
2019-10-23 20:10 ` [PATCH v2 1/4] crypto: Add Allwinner sun8i-ss cryptographic offloader Corentin Labbe
2019-10-23 20:10 ` Corentin Labbe
2019-10-23 20:10 ` [PATCH v2 2/4] dt-bindings: crypto: Add DT bindings documentation for sun8i-ss Security System Corentin Labbe
2019-10-23 20:10 ` Corentin Labbe
2019-10-24 6:50 ` Maxime Ripard
2019-10-24 6:50 ` Maxime Ripard
2019-10-24 9:31 ` Corentin Labbe [this message]
2019-10-24 9:31 ` Corentin Labbe
2019-10-24 18:24 ` Maxime Ripard
2019-10-24 18:24 ` Maxime Ripard
2019-10-23 20:10 ` [PATCH v2 3/4] ARM: dts: sun8i: a83t: Add Security System node Corentin Labbe
2019-10-23 20:10 ` Corentin Labbe
2019-10-23 20:10 ` [PATCH v2 4/4] ARM: dts: sun9i: a80: " Corentin Labbe
2019-10-23 20:10 ` Corentin Labbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191024093118.GA15113@Red \
--to=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.