From: Steven Price <steven.price@arm.com> To: linux-mm@kvack.org Cc: "Steven Price" <steven.price@arm.com>, "Andy Lutomirski" <luto@kernel.org>, "Ard Biesheuvel" <ard.biesheuvel@linaro.org>, "Arnd Bergmann" <arnd@arndb.de>, "Borislav Petkov" <bp@alien8.de>, "Catalin Marinas" <catalin.marinas@arm.com>, "Dave Hansen" <dave.hansen@linux.intel.com>, "Ingo Molnar" <mingo@redhat.com>, "James Morse" <james.morse@arm.com>, "Jérôme Glisse" <jglisse@redhat.com>, "Peter Zijlstra" <peterz@infradead.org>, "Thomas Gleixner" <tglx@linutronix.de>, "Will Deacon" <will@kernel.org>, x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "Mark Rutland" <Mark.Rutland@arm.com>, "Liang, Kan" <kan.liang@linux.intel.com>, "Andrew Morton" <akpm@linux-foundation.org> Subject: [PATCH v14 18/22] x86: mm: Convert ptdump_walk_pgd_level_core() to take an mm_struct Date: Mon, 28 Oct 2019 13:59:06 +0000 [thread overview] Message-ID: <20191028135910.33253-19-steven.price@arm.com> (raw) In-Reply-To: <20191028135910.33253-1-steven.price@arm.com> An mm_struct is needed to enable x86 to use of the generic walk_page_range() function. In the case of walking the user page tables (when CONFIG_PAGE_TABLE_ISOLATION is enabled), it is necessary to create a fake_mm structure because there isn't an mm_struct with a pointer to the pgd of the user page tables. This fake_mm structure is initialised with the minimum necessary for the generic page walk code. Signed-off-by: Steven Price <steven.price@arm.com> --- arch/x86/mm/dump_pagetables.c | 36 ++++++++++++++++++++--------------- 1 file changed, 21 insertions(+), 15 deletions(-) diff --git a/arch/x86/mm/dump_pagetables.c b/arch/x86/mm/dump_pagetables.c index 2f5f32f21f81..3632be89ec99 100644 --- a/arch/x86/mm/dump_pagetables.c +++ b/arch/x86/mm/dump_pagetables.c @@ -107,8 +107,6 @@ static struct addr_marker address_markers[] = { [END_OF_SPACE_NR] = { -1, NULL } }; -#define INIT_PGD ((pgd_t *) &init_top_pgt) - #else /* CONFIG_X86_64 */ enum address_markers_idx { @@ -143,8 +141,6 @@ static struct addr_marker address_markers[] = { [END_OF_SPACE_NR] = { -1, NULL } }; -#define INIT_PGD (swapper_pg_dir) - #endif /* !CONFIG_X86_64 */ /* Multipliers for offsets within the PTEs */ @@ -515,10 +511,10 @@ static inline bool is_hypervisor_range(int idx) #endif } -static void ptdump_walk_pgd_level_core(struct seq_file *m, pgd_t *pgd, +static void ptdump_walk_pgd_level_core(struct seq_file *m, struct mm_struct *mm, bool checkwx, bool dmesg) { - pgd_t *start = pgd; + pgd_t *start = mm->pgd; pgprotval_t prot, eff; int i; struct pg_state st = {}; @@ -565,39 +561,49 @@ static void ptdump_walk_pgd_level_core(struct seq_file *m, pgd_t *pgd, void ptdump_walk_pgd_level(struct seq_file *m, struct mm_struct *mm) { - ptdump_walk_pgd_level_core(m, mm->pgd, false, true); + ptdump_walk_pgd_level_core(m, mm, false, true); } +#ifdef CONFIG_PAGE_TABLE_ISOLATION +static void ptdump_walk_pgd_level_user_core(struct seq_file *m, + struct mm_struct *mm, + bool checkwx, bool dmesg) +{ + struct mm_struct fake_mm = { + .pgd = kernel_to_user_pgdp(mm->pgd) + }; + init_rwsem(&fake_mm.mmap_sem); + ptdump_walk_pgd_level_core(m, &fake_mm, checkwx, dmesg); +} +#endif + void ptdump_walk_pgd_level_debugfs(struct seq_file *m, struct mm_struct *mm, bool user) { - pgd_t *pgd = mm->pgd; #ifdef CONFIG_PAGE_TABLE_ISOLATION if (user && boot_cpu_has(X86_FEATURE_PTI)) - pgd = kernel_to_user_pgdp(pgd); + ptdump_walk_pgd_level_user_core(m, mm, false, false); + else #endif - ptdump_walk_pgd_level_core(m, pgd, false, false); + ptdump_walk_pgd_level_core(m, mm, false, false); } EXPORT_SYMBOL_GPL(ptdump_walk_pgd_level_debugfs); void ptdump_walk_user_pgd_level_checkwx(void) { #ifdef CONFIG_PAGE_TABLE_ISOLATION - pgd_t *pgd = INIT_PGD; - if (!(__supported_pte_mask & _PAGE_NX) || !boot_cpu_has(X86_FEATURE_PTI)) return; pr_info("x86/mm: Checking user space page tables\n"); - pgd = kernel_to_user_pgdp(pgd); - ptdump_walk_pgd_level_core(NULL, pgd, true, false); + ptdump_walk_pgd_level_user_core(NULL, &init_mm, true, false); #endif } void ptdump_walk_pgd_level_checkwx(void) { - ptdump_walk_pgd_level_core(NULL, INIT_PGD, true, false); + ptdump_walk_pgd_level_core(NULL, &init_mm, true, false); } static int __init pt_dump_init(void) -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Steven Price <steven.price@arm.com> To: linux-mm@kvack.org Cc: "Mark Rutland" <Mark.Rutland@arm.com>, x86@kernel.org, "Arnd Bergmann" <arnd@arndb.de>, "Ard Biesheuvel" <ard.biesheuvel@linaro.org>, "Peter Zijlstra" <peterz@infradead.org>, "Catalin Marinas" <catalin.marinas@arm.com>, "Dave Hansen" <dave.hansen@linux.intel.com>, linux-kernel@vger.kernel.org, "Steven Price" <steven.price@arm.com>, "Jérôme Glisse" <jglisse@redhat.com>, "Ingo Molnar" <mingo@redhat.com>, "Borislav Petkov" <bp@alien8.de>, "Andy Lutomirski" <luto@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>, "James Morse" <james.morse@arm.com>, "Thomas Gleixner" <tglx@linutronix.de>, "Will Deacon" <will@kernel.org>, "Andrew Morton" <akpm@linux-foundation.org>, linux-arm-kernel@lists.infradead.org, "Liang, Kan" <kan.liang@linux.intel.com> Subject: [PATCH v14 18/22] x86: mm: Convert ptdump_walk_pgd_level_core() to take an mm_struct Date: Mon, 28 Oct 2019 13:59:06 +0000 [thread overview] Message-ID: <20191028135910.33253-19-steven.price@arm.com> (raw) In-Reply-To: <20191028135910.33253-1-steven.price@arm.com> An mm_struct is needed to enable x86 to use of the generic walk_page_range() function. In the case of walking the user page tables (when CONFIG_PAGE_TABLE_ISOLATION is enabled), it is necessary to create a fake_mm structure because there isn't an mm_struct with a pointer to the pgd of the user page tables. This fake_mm structure is initialised with the minimum necessary for the generic page walk code. Signed-off-by: Steven Price <steven.price@arm.com> --- arch/x86/mm/dump_pagetables.c | 36 ++++++++++++++++++++--------------- 1 file changed, 21 insertions(+), 15 deletions(-) diff --git a/arch/x86/mm/dump_pagetables.c b/arch/x86/mm/dump_pagetables.c index 2f5f32f21f81..3632be89ec99 100644 --- a/arch/x86/mm/dump_pagetables.c +++ b/arch/x86/mm/dump_pagetables.c @@ -107,8 +107,6 @@ static struct addr_marker address_markers[] = { [END_OF_SPACE_NR] = { -1, NULL } }; -#define INIT_PGD ((pgd_t *) &init_top_pgt) - #else /* CONFIG_X86_64 */ enum address_markers_idx { @@ -143,8 +141,6 @@ static struct addr_marker address_markers[] = { [END_OF_SPACE_NR] = { -1, NULL } }; -#define INIT_PGD (swapper_pg_dir) - #endif /* !CONFIG_X86_64 */ /* Multipliers for offsets within the PTEs */ @@ -515,10 +511,10 @@ static inline bool is_hypervisor_range(int idx) #endif } -static void ptdump_walk_pgd_level_core(struct seq_file *m, pgd_t *pgd, +static void ptdump_walk_pgd_level_core(struct seq_file *m, struct mm_struct *mm, bool checkwx, bool dmesg) { - pgd_t *start = pgd; + pgd_t *start = mm->pgd; pgprotval_t prot, eff; int i; struct pg_state st = {}; @@ -565,39 +561,49 @@ static void ptdump_walk_pgd_level_core(struct seq_file *m, pgd_t *pgd, void ptdump_walk_pgd_level(struct seq_file *m, struct mm_struct *mm) { - ptdump_walk_pgd_level_core(m, mm->pgd, false, true); + ptdump_walk_pgd_level_core(m, mm, false, true); } +#ifdef CONFIG_PAGE_TABLE_ISOLATION +static void ptdump_walk_pgd_level_user_core(struct seq_file *m, + struct mm_struct *mm, + bool checkwx, bool dmesg) +{ + struct mm_struct fake_mm = { + .pgd = kernel_to_user_pgdp(mm->pgd) + }; + init_rwsem(&fake_mm.mmap_sem); + ptdump_walk_pgd_level_core(m, &fake_mm, checkwx, dmesg); +} +#endif + void ptdump_walk_pgd_level_debugfs(struct seq_file *m, struct mm_struct *mm, bool user) { - pgd_t *pgd = mm->pgd; #ifdef CONFIG_PAGE_TABLE_ISOLATION if (user && boot_cpu_has(X86_FEATURE_PTI)) - pgd = kernel_to_user_pgdp(pgd); + ptdump_walk_pgd_level_user_core(m, mm, false, false); + else #endif - ptdump_walk_pgd_level_core(m, pgd, false, false); + ptdump_walk_pgd_level_core(m, mm, false, false); } EXPORT_SYMBOL_GPL(ptdump_walk_pgd_level_debugfs); void ptdump_walk_user_pgd_level_checkwx(void) { #ifdef CONFIG_PAGE_TABLE_ISOLATION - pgd_t *pgd = INIT_PGD; - if (!(__supported_pte_mask & _PAGE_NX) || !boot_cpu_has(X86_FEATURE_PTI)) return; pr_info("x86/mm: Checking user space page tables\n"); - pgd = kernel_to_user_pgdp(pgd); - ptdump_walk_pgd_level_core(NULL, pgd, true, false); + ptdump_walk_pgd_level_user_core(NULL, &init_mm, true, false); #endif } void ptdump_walk_pgd_level_checkwx(void) { - ptdump_walk_pgd_level_core(NULL, INIT_PGD, true, false); + ptdump_walk_pgd_level_core(NULL, &init_mm, true, false); } static int __init pt_dump_init(void) -- 2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-28 14:00 UTC|newest] Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-28 13:58 [PATCH v14 00/22] Generic page walk and ptdump Steven Price 2019-10-28 13:58 ` Steven Price 2019-10-28 13:58 ` [PATCH v14 01/22] mm: Add generic p?d_leaf() macros Steven Price 2019-10-28 13:58 ` Steven Price 2019-10-28 13:58 ` [PATCH v14 02/22] arc: mm: Add p?d_leaf() definitions Steven Price 2019-10-28 13:58 ` Steven Price 2019-10-28 13:58 ` Steven Price 2019-10-28 13:58 ` [PATCH v14 03/22] arm: " Steven Price 2019-10-28 13:58 ` Steven Price 2019-10-28 13:58 ` [PATCH v14 04/22] arm64: " Steven Price 2019-10-28 13:58 ` Steven Price 2019-10-30 15:31 ` Catalin Marinas 2019-10-30 15:31 ` Catalin Marinas 2019-10-28 13:58 ` [PATCH v14 05/22] mips: " Steven Price 2019-10-28 13:58 ` Steven Price 2019-10-28 13:58 ` [PATCH v14 06/22] powerpc: " Steven Price 2019-10-28 13:58 ` Steven Price 2019-10-28 13:58 ` Steven Price 2019-10-28 13:58 ` [PATCH v14 07/22] riscv: " Steven Price 2019-10-28 13:58 ` Steven Price 2019-10-28 13:58 ` Steven Price 2019-10-28 13:58 ` [PATCH v14 08/22] s390: " Steven Price 2019-10-28 13:58 ` Steven Price 2019-10-28 13:58 ` [PATCH v14 09/22] sparc: " Steven Price 2019-10-28 13:58 ` Steven Price 2019-10-28 13:58 ` Steven Price 2019-10-28 13:58 ` [PATCH v14 10/22] x86: " Steven Price 2019-10-28 13:58 ` Steven Price 2019-10-28 13:58 ` [PATCH v14 11/22] mm: pagewalk: Add p4d_entry() and pgd_entry() Steven Price 2019-10-28 13:58 ` Steven Price 2019-10-28 13:59 ` [PATCH v14 12/22] mm: pagewalk: Allow walking without vma Steven Price 2019-10-28 13:59 ` Steven Price 2019-10-31 15:15 ` [mm] 9343f6818b: BUG:kernel_NULL_pointer_dereference,address kernel test robot 2019-10-31 15:15 ` kernel test robot 2019-10-31 15:15 ` [LTP] [mm] 9343f6818b: BUG:kernel_NULL_pointer_dereference, address kernel test robot 2019-10-31 17:22 ` [mm] 9343f6818b: BUG:kernel_NULL_pointer_dereference,address Steven Price 2019-10-31 17:22 ` [mm] 9343f6818b: BUG:kernel_NULL_pointer_dereference, address Steven Price 2019-10-31 17:22 ` [LTP] " Steven Price 2019-10-31 17:22 ` [mm] 9343f6818b: BUG:kernel_NULL_pointer_dereference,address Steven Price 2019-10-28 13:59 ` [PATCH v14 13/22] mm: pagewalk: Add test_p?d callbacks Steven Price 2019-10-28 13:59 ` Steven Price 2019-10-28 13:59 ` [PATCH v14 14/22] mm: pagewalk: Add 'depth' parameter to pte_hole Steven Price 2019-10-28 13:59 ` Steven Price 2019-10-28 13:59 ` [PATCH v14 15/22] x86: mm: Point to struct seq_file from struct pg_state Steven Price 2019-10-28 13:59 ` Steven Price 2019-10-28 13:59 ` [PATCH v14 16/22] x86: mm+efi: Convert ptdump_walk_pgd_level() to take a mm_struct Steven Price 2019-10-28 13:59 ` Steven Price 2019-10-28 13:59 ` [PATCH v14 17/22] x86: mm: Convert ptdump_walk_pgd_level_debugfs() to take an mm_struct Steven Price 2019-10-28 13:59 ` Steven Price 2019-10-28 13:59 ` Steven Price [this message] 2019-10-28 13:59 ` [PATCH v14 18/22] x86: mm: Convert ptdump_walk_pgd_level_core() " Steven Price 2019-10-28 13:59 ` [PATCH v14 19/22] mm: Add generic ptdump Steven Price 2019-10-28 13:59 ` Steven Price 2019-10-30 16:48 ` Catalin Marinas 2019-10-30 16:48 ` Catalin Marinas 2019-10-28 13:59 ` [PATCH v14 20/22] x86: mm: Convert dump_pagetables to use walk_page_range Steven Price 2019-10-28 13:59 ` Steven Price 2019-10-28 13:59 ` [PATCH v14 21/22] arm64: mm: Convert mm/dump.c to use walk_page_range() Steven Price 2019-10-28 13:59 ` Steven Price 2019-10-30 16:45 ` Catalin Marinas 2019-10-30 16:45 ` Catalin Marinas 2019-10-31 13:32 ` Steven Price 2019-10-31 13:32 ` Steven Price 2019-10-31 13:33 ` [PATCH] mm: ptdump: Reduce level numbers by 1 in note_page() Steven Price 2019-10-31 13:33 ` Steven Price 2019-10-31 14:36 ` Catalin Marinas 2019-10-31 14:36 ` Catalin Marinas 2019-10-31 14:00 ` [PATCH v14 21/22] arm64: mm: Convert mm/dump.c to use walk_page_range() Catalin Marinas 2019-10-31 14:00 ` Catalin Marinas 2019-10-31 14:37 ` Catalin Marinas 2019-10-31 14:37 ` Catalin Marinas 2019-10-28 13:59 ` [PATCH v14 22/22] arm64: mm: Display non-present entries in ptdump Steven Price 2019-10-28 13:59 ` Steven Price 2019-10-30 16:50 ` Catalin Marinas 2019-10-30 16:50 ` Catalin Marinas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191028135910.33253-19-steven.price@arm.com \ --to=steven.price@arm.com \ --cc=Mark.Rutland@arm.com \ --cc=akpm@linux-foundation.org \ --cc=ard.biesheuvel@linaro.org \ --cc=arnd@arndb.de \ --cc=bp@alien8.de \ --cc=catalin.marinas@arm.com \ --cc=dave.hansen@linux.intel.com \ --cc=hpa@zytor.com \ --cc=james.morse@arm.com \ --cc=jglisse@redhat.com \ --cc=kan.liang@linux.intel.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=luto@kernel.org \ --cc=mingo@redhat.com \ --cc=peterz@infradead.org \ --cc=tglx@linutronix.de \ --cc=will@kernel.org \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.