From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: robh+dt@kernel.org, devicetree@vger.kernel.org,
vireshk@kernel.org, linux-pm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, b.zolnierkie@samsung.com,
m.szyprowski@samsung.com
Subject: Re: [PATCH 3/3] dt-bindings: arm: samsung: Drop syscon compatible from CHIPID binding
Date: Mon, 28 Oct 2019 16:47:32 +0100 [thread overview]
Message-ID: <20191028154732.GA3746@pi3> (raw)
In-Reply-To: <20191028152050.10220-3-s.nawrocki@samsung.com>
On Mon, Oct 28, 2019 at 04:20:50PM +0100, Sylwester Nawrocki wrote:
> The "syscon" compatible string was introduced mainly to allow sharing
> of the CHIPID IO region between multiple drivers. However, such sharing
> can be also done without an additional compatible so remove "syscon".
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
>
> Suggested-by: Krzysztof Kozlowski <krzk@kernel.org>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> ---
> .../devicetree/bindings/arm/samsung/exynos-chipid.yaml | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
> index 53c29d567789..afcd70803c12 100644
> --- a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
> +++ b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
> @@ -13,7 +13,6 @@ properties:
> compatible:
> items:
> - const: samsung,exynos4210-chipid
> - - const: syscon
>
> reg:
> maxItems: 1
> @@ -34,7 +33,7 @@ required:
> examples:
> - |
> chipid@10000000 {
> - compatible = "samsung,exynos4210-chipid", "syscon";
> + compatible = "samsung,exynos4210-chipid";
> reg = <0x10000000 0x100>;
> samsung,asv-bin = <2>;
> };
> --
> 2.17.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-pm@vger.kernel.org, vireshk@kernel.org,
b.zolnierkie@samsung.com, robh+dt@kernel.org,
linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com
Subject: Re: [PATCH 3/3] dt-bindings: arm: samsung: Drop syscon compatible from CHIPID binding
Date: Mon, 28 Oct 2019 16:47:32 +0100 [thread overview]
Message-ID: <20191028154732.GA3746@pi3> (raw)
In-Reply-To: <20191028152050.10220-3-s.nawrocki@samsung.com>
On Mon, Oct 28, 2019 at 04:20:50PM +0100, Sylwester Nawrocki wrote:
> The "syscon" compatible string was introduced mainly to allow sharing
> of the CHIPID IO region between multiple drivers. However, such sharing
> can be also done without an additional compatible so remove "syscon".
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
>
> Suggested-by: Krzysztof Kozlowski <krzk@kernel.org>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> ---
> .../devicetree/bindings/arm/samsung/exynos-chipid.yaml | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
> index 53c29d567789..afcd70803c12 100644
> --- a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
> +++ b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
> @@ -13,7 +13,6 @@ properties:
> compatible:
> items:
> - const: samsung,exynos4210-chipid
> - - const: syscon
>
> reg:
> maxItems: 1
> @@ -34,7 +33,7 @@ required:
> examples:
> - |
> chipid@10000000 {
> - compatible = "samsung,exynos4210-chipid", "syscon";
> + compatible = "samsung,exynos4210-chipid";
> reg = <0x10000000 0x100>;
> samsung,asv-bin = <2>;
> };
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-28 15:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20191028152057eucas1p1d6b4252e9ce3f15c0d81e6941a62d2be@eucas1p1.samsung.com>
2019-10-28 15:20 ` [PATCH 1/3] soc: samsung: Drop "syscon" compatible requirement from the chipid driver Sylwester Nawrocki
2019-10-28 15:20 ` Sylwester Nawrocki
[not found] ` <CGME20191028152059eucas1p2b48166c35f61dfc8edfa99f54434e8ee@eucas1p2.samsung.com>
2019-10-28 15:20 ` [PATCH 2/3] ARM: dts: exynos: Remove syscon compatible from chipid node on Exynos5 Sylwester Nawrocki
2019-10-28 15:20 ` Sylwester Nawrocki
2019-12-11 18:20 ` Krzysztof Kozlowski
2019-12-11 18:20 ` Krzysztof Kozlowski
[not found] ` <CGME20191028152100eucas1p2ed6bd2d53670c85f6bf550af0631a55a@eucas1p2.samsung.com>
2019-10-28 15:20 ` [PATCH 3/3] dt-bindings: arm: samsung: Drop syscon compatible from CHIPID binding Sylwester Nawrocki
2019-10-28 15:20 ` Sylwester Nawrocki
2019-10-28 15:47 ` Krzysztof Kozlowski [this message]
2019-10-28 15:47 ` Krzysztof Kozlowski
2019-11-06 3:28 ` Rob Herring
2019-11-06 3:28 ` Rob Herring
2019-10-28 17:35 ` [PATCH 1/3] soc: samsung: Drop "syscon" compatible requirement from the chipid driver Krzysztof Kozlowski
2019-10-28 17:35 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191028154732.GA3746@pi3 \
--to=krzk@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.