From: Sascha Hauer <s.hauer@pengutronix.de> To: linux-fsdevel@vger.kernel.org Cc: linux-mtd@lists.infradead.org, Jan Kara <jack@suse.com>, Richard Weinberger <richard@nod.at>, kernel@pengutronix.de, Sascha Hauer <s.hauer@pengutronix.de> Subject: [PATCH 07/10] ubifs: do not ubifs_inode() on potentially NULL pointer Date: Wed, 30 Oct 2019 16:26:59 +0100 [thread overview] Message-ID: <20191030152702.14269-8-s.hauer@pengutronix.de> (raw) In-Reply-To: <20191030152702.14269-1-s.hauer@pengutronix.de> new_inode() may return NULL, so only derefence the return inode when non NULL. This is merely a cleanup as calling ubifs_inode() on a NULL pointer doesn't do any harm, only using the return value would. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> --- fs/ubifs/dir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c index 0b98e3c8b461..cfce5fee9262 100644 --- a/fs/ubifs/dir.c +++ b/fs/ubifs/dir.c @@ -95,10 +95,10 @@ struct inode *ubifs_new_inode(struct ubifs_info *c, struct inode *dir, } inode = new_inode(c->vfs_sb); - ui = ubifs_inode(inode); if (!inode) return ERR_PTR(-ENOMEM); + ui = ubifs_inode(inode); /* * Set 'S_NOCMTIME' to prevent VFS form updating [mc]time of inodes and * marking them dirty in file write path (see 'file_update_time()'). -- 2.24.0.rc1
WARNING: multiple messages have this Message-ID (diff)
From: Sascha Hauer <s.hauer@pengutronix.de> To: linux-fsdevel@vger.kernel.org Cc: Richard Weinberger <richard@nod.at>, Sascha Hauer <s.hauer@pengutronix.de>, linux-mtd@lists.infradead.org, kernel@pengutronix.de, Jan Kara <jack@suse.com> Subject: [PATCH 07/10] ubifs: do not ubifs_inode() on potentially NULL pointer Date: Wed, 30 Oct 2019 16:26:59 +0100 [thread overview] Message-ID: <20191030152702.14269-8-s.hauer@pengutronix.de> (raw) In-Reply-To: <20191030152702.14269-1-s.hauer@pengutronix.de> new_inode() may return NULL, so only derefence the return inode when non NULL. This is merely a cleanup as calling ubifs_inode() on a NULL pointer doesn't do any harm, only using the return value would. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> --- fs/ubifs/dir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c index 0b98e3c8b461..cfce5fee9262 100644 --- a/fs/ubifs/dir.c +++ b/fs/ubifs/dir.c @@ -95,10 +95,10 @@ struct inode *ubifs_new_inode(struct ubifs_info *c, struct inode *dir, } inode = new_inode(c->vfs_sb); - ui = ubifs_inode(inode); if (!inode) return ERR_PTR(-ENOMEM); + ui = ubifs_inode(inode); /* * Set 'S_NOCMTIME' to prevent VFS form updating [mc]time of inodes and * marking them dirty in file write path (see 'file_update_time()'). -- 2.24.0.rc1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-10-30 15:27 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-30 15:26 [PATCH v2 00/10] Add quota support to UBIFS Sascha Hauer 2019-10-30 15:26 ` Sascha Hauer 2019-10-30 15:26 ` [PATCH 01/10] quota: Make inode optional Sascha Hauer 2019-10-30 15:26 ` Sascha Hauer 2019-11-01 18:07 ` Jan Kara 2019-11-01 18:07 ` Jan Kara 2019-11-04 7:48 ` Sascha Hauer 2019-11-04 7:48 ` Sascha Hauer 2019-10-30 15:26 ` [PATCH 02/10] quota: Pass sb to vfs_load_quota_inode() Sascha Hauer 2019-10-30 15:26 ` Sascha Hauer 2019-10-30 15:26 ` [PATCH 03/10] quota: Introduce dquot_enable_sb() Sascha Hauer 2019-10-30 15:26 ` Sascha Hauer 2019-10-30 15:26 ` [PATCH 04/10] quota: Allow to pass mount path to quotactl Sascha Hauer 2019-10-30 15:26 ` Sascha Hauer 2019-11-01 16:07 ` Jan Kara 2019-11-01 16:07 ` Jan Kara 2019-11-11 10:08 ` Sascha Hauer 2019-11-11 10:08 ` Sascha Hauer 2019-11-11 11:05 ` Jan Kara 2019-11-11 11:05 ` Jan Kara 2019-11-11 11:14 ` Sascha Hauer 2019-11-11 11:14 ` Sascha Hauer 2019-10-30 15:26 ` [PATCH 05/10] ubifs: move checks and preparation into setflags() Sascha Hauer 2019-10-30 15:26 ` Sascha Hauer 2019-10-30 15:26 ` [PATCH 06/10] ubifs: Add support for FS_IOC_FS[SG]ETXATTR ioctls Sascha Hauer 2019-10-30 15:26 ` Sascha Hauer 2019-10-30 15:26 ` Sascha Hauer [this message] 2019-10-30 15:26 ` [PATCH 07/10] ubifs: do not ubifs_inode() on potentially NULL pointer Sascha Hauer 2019-10-30 15:27 ` [PATCH 08/10] ubifs: Add support for project id Sascha Hauer 2019-10-30 15:27 ` Sascha Hauer 2019-10-30 15:27 ` [PATCH 09/10] ubifs: export get_znode Sascha Hauer 2019-10-30 15:27 ` Sascha Hauer 2019-10-30 15:27 ` [PATCH 10/10] ubifs: Add quota support Sascha Hauer 2019-10-30 15:27 ` Sascha Hauer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191030152702.14269-8-s.hauer@pengutronix.de \ --to=s.hauer@pengutronix.de \ --cc=jack@suse.com \ --cc=kernel@pengutronix.de \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=richard@nod.at \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.