All of lore.kernel.org
 help / color / mirror / Atom feed
From: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
To: Chris Wilson <chris.p.wilson@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/perf: Configure OAR controls for specific context
Date: Thu, 7 Nov 2019 15:41:05 -0800	[thread overview]
Message-ID: <20191107234105.GA65581@orsosgc001.amr.corp.intel.com> (raw)
In-Reply-To: <157316945131.6935.7754884674203739014@skylake-alporthouse-com>

On Thu, Nov 07, 2019 at 11:30:51PM +0000, Chris Wilson wrote:
>Quoting Umesh Nerlige Ramappa (2019-11-07 23:22:34)
>> It turns out that the OAR CONTROL register is not getting configured
>> correctly in conjunction with the context save/restore bit. When
>> measuring work for a single context, the OAR counters do not increment.
>>
>> Configure OAR format and enable OAR counters at the same time as
>> enabling context save/restore for OAR counters.
>
>Did you write a test case to capture this bug for posterity? If so,
>please include a Testcase: link. If not, please do so :)

I did, although the test is also up for review here in an igt series - 
https://patchwork.freedesktop.org/patch/339514/

Thanks,
Umesh

>-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
To: Chris Wilson <chris.p.wilson@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/perf: Configure OAR controls for specific context
Date: Thu, 7 Nov 2019 15:41:05 -0800	[thread overview]
Message-ID: <20191107234105.GA65581@orsosgc001.amr.corp.intel.com> (raw)
Message-ID: <20191107234105.sSMRSA3Qi-T7AGjjtc7PaFq1KNqW82bjtBJFS7q61IE@z> (raw)
In-Reply-To: <157316945131.6935.7754884674203739014@skylake-alporthouse-com>

On Thu, Nov 07, 2019 at 11:30:51PM +0000, Chris Wilson wrote:
>Quoting Umesh Nerlige Ramappa (2019-11-07 23:22:34)
>> It turns out that the OAR CONTROL register is not getting configured
>> correctly in conjunction with the context save/restore bit. When
>> measuring work for a single context, the OAR counters do not increment.
>>
>> Configure OAR format and enable OAR counters at the same time as
>> enabling context save/restore for OAR counters.
>
>Did you write a test case to capture this bug for posterity? If so,
>please include a Testcase: link. If not, please do so :)

I did, although the test is also up for review here in an igt series - 
https://patchwork.freedesktop.org/patch/339514/

Thanks,
Umesh

>-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-11-07 23:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-07 23:22 [PATCH] drm/i915/perf: Configure OAR controls for specific context Umesh Nerlige Ramappa
2019-11-07 23:22 ` [Intel-gfx] " Umesh Nerlige Ramappa
2019-11-07 23:30 ` Chris Wilson
2019-11-07 23:30   ` [Intel-gfx] " Chris Wilson
2019-11-07 23:41   ` Umesh Nerlige Ramappa [this message]
2019-11-07 23:41     ` Umesh Nerlige Ramappa
2019-11-07 23:34 Umesh Nerlige Ramappa
2019-11-08  7:22 ` Lionel Landwerlin
2019-11-10 17:14   ` Umesh Nerlige Ramappa
2019-11-11  9:38     ` Lionel Landwerlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191107234105.GA65581@orsosgc001.amr.corp.intel.com \
    --to=umesh.nerlige.ramappa@intel.com \
    --cc=chris.p.wilson@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.