From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Kever Yang <kever.yang@rock-chips.com>
Cc: heiko@sntech.de, linux-rockchip@lists.infradead.org,
Akash Gajjar <akash@openedev.com>,
Ezequiel Garcia <ezequiel@collabora.com>,
Jagan Teki <jagan@amarulasolutions.com>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] arm64: dts: rk3399-rock960: add vdd_log
Date: Mon, 11 Nov 2019 10:52:32 +0530 [thread overview]
Message-ID: <20191111052232.GA2842@Mani-XPS-13-9360> (raw)
In-Reply-To: <20191111005158.25070-2-kever.yang@rock-chips.com>
Hi Kever,
On Mon, Nov 11, 2019 at 08:51:57AM +0800, Kever Yang wrote:
> Add vdd_log node according to rock960 schematic V13.
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
>
> arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
> index c7d48d41e184..73afee257115 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
> @@ -76,6 +76,18 @@
> regulator-always-on;
> vin-supply = <&vcc5v0_sys>;
> };
> +
> + vdd_log: vdd-log {
> + compatible = "pwm-regulator";
> + pwms = <&pwm2 0 25000 1>;
> + regulator-name = "vdd_log";
> + regulator-always-on;
> + regulator-boot-on;
> + regulator-min-microvolt = <800000>;
> + regulator-max-microvolt = <1400000>;
> + regulator-init-microvolt = <950000>;
The default value seems to be 0.9v as per both Rock960 and Ficus schematics.
Other than that,
Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> + vin-supply = <&vcc_sys>;
> + };
> };
>
> &cpu_l0 {
> --
> 2.17.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Kever Yang <kever.yang@rock-chips.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, heiko@sntech.de,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Jagan Teki <jagan@amarulasolutions.com>,
Ezequiel Garcia <ezequiel@collabora.com>,
linux-arm-kernel@lists.infradead.org,
Akash Gajjar <akash@openedev.com>
Subject: Re: [PATCH 2/3] arm64: dts: rk3399-rock960: add vdd_log
Date: Mon, 11 Nov 2019 10:52:32 +0530 [thread overview]
Message-ID: <20191111052232.GA2842@Mani-XPS-13-9360> (raw)
In-Reply-To: <20191111005158.25070-2-kever.yang@rock-chips.com>
Hi Kever,
On Mon, Nov 11, 2019 at 08:51:57AM +0800, Kever Yang wrote:
> Add vdd_log node according to rock960 schematic V13.
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
>
> arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
> index c7d48d41e184..73afee257115 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
> @@ -76,6 +76,18 @@
> regulator-always-on;
> vin-supply = <&vcc5v0_sys>;
> };
> +
> + vdd_log: vdd-log {
> + compatible = "pwm-regulator";
> + pwms = <&pwm2 0 25000 1>;
> + regulator-name = "vdd_log";
> + regulator-always-on;
> + regulator-boot-on;
> + regulator-min-microvolt = <800000>;
> + regulator-max-microvolt = <1400000>;
> + regulator-init-microvolt = <950000>;
The default value seems to be 0.9v as per both Rock960 and Ficus schematics.
Other than that,
Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> + vin-supply = <&vcc_sys>;
> + };
> };
>
> &cpu_l0 {
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-11 5:22 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 0:51 [PATCH 1/3] arm64: dts: rockchip: Fix min voltage for rk3399-firefly vdd_log Kever Yang
2019-11-11 0:51 ` Kever Yang
2019-11-11 0:51 ` [PATCH 2/3] arm64: dts: rk3399-rock960: add vdd_log Kever Yang
2019-11-11 0:51 ` Kever Yang
2019-11-11 0:51 ` Kever Yang
2019-11-11 5:22 ` Manivannan Sadhasivam [this message]
2019-11-11 5:22 ` Manivannan Sadhasivam
2019-11-11 5:26 ` Manivannan Sadhasivam
2019-11-11 5:26 ` Manivannan Sadhasivam
2019-11-11 5:26 ` Manivannan Sadhasivam
2019-11-12 8:10 ` Kever Yang
2019-11-12 8:10 ` Kever Yang
2019-11-12 17:17 ` Manivannan Sadhasivam
2019-11-12 17:17 ` Manivannan Sadhasivam
2019-11-13 2:44 ` Kever Yang
2019-11-13 2:44 ` Kever Yang
2019-11-13 3:21 ` Manivannan Sadhasivam
2019-11-13 3:21 ` Manivannan Sadhasivam
2019-11-11 0:51 ` [PATCH 3/3] arm64: dts: rk3399: Add init voltage for vdd_log Kever Yang
2019-11-11 0:51 ` Kever Yang
2019-11-11 0:51 ` Kever Yang
2019-11-11 8:42 ` Soeren Moch
2019-11-11 8:42 ` Soeren Moch
2019-11-11 8:42 ` Soeren Moch
2019-11-12 8:04 ` Kever Yang
2019-11-12 8:04 ` Kever Yang
2019-11-12 8:10 ` Heiko Stübner
2019-11-12 8:10 ` Heiko Stübner
2019-11-12 8:10 ` Heiko Stübner
2019-11-13 3:21 ` Kever Yang
2019-11-13 3:21 ` Kever Yang
2019-11-13 3:21 ` Kever Yang
2019-11-18 1:05 ` Heiko Stuebner
2019-11-18 1:05 ` Heiko Stuebner
2019-11-18 1:05 ` Heiko Stuebner
2019-11-12 8:16 ` Markus Reichl
2019-11-12 8:16 ` Markus Reichl
2019-11-12 8:16 ` Markus Reichl
2019-11-12 8:44 ` Sören Moch
2019-11-12 8:44 ` Sören Moch
2019-11-12 8:44 ` Sören Moch
2019-11-12 8:51 ` Markus Reichl
2019-11-12 8:51 ` Markus Reichl
2019-11-12 8:51 ` Markus Reichl
2019-11-12 10:02 ` Kever Yang
2019-11-12 10:02 ` Kever Yang
2019-11-12 10:19 ` Soeren Moch
2019-11-12 10:19 ` Soeren Moch
2019-11-12 10:19 ` Soeren Moch
2019-11-12 11:06 ` Markus Reichl
2019-11-12 11:06 ` Markus Reichl
2019-11-12 11:06 ` Markus Reichl
2019-11-12 11:42 ` [PATCH] arm64: dts: rockchip: Fix vdd_log on rk3399-roc-pc Markus Reichl
2019-11-12 11:42 ` Markus Reichl
2019-11-18 1:03 ` Heiko Stuebner
2019-11-18 1:03 ` Heiko Stuebner
2019-11-18 1:03 ` Heiko Stuebner
2019-11-13 17:01 ` [PATCH 3/3] arm64: dts: rk3399: Add init voltage for vdd_log Doug Anderson
2019-11-13 17:01 ` Doug Anderson
2019-11-13 17:01 ` Doug Anderson
2019-11-14 1:53 ` Kever Yang
2019-11-14 1:53 ` Kever Yang
2019-11-14 1:53 ` Kever Yang
2019-11-13 17:50 ` Vicente Bergas
2019-11-13 17:50 ` Vicente Bergas
2019-11-13 17:50 ` Vicente Bergas
2019-11-18 1:04 ` [PATCH 1/3] arm64: dts: rockchip: Fix min voltage for rk3399-firefly vdd_log Heiko Stuebner
2019-11-18 1:04 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191111052232.GA2842@Mani-XPS-13-9360 \
--to=manivannan.sadhasivam@linaro.org \
--cc=akash@openedev.com \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel@collabora.com \
--cc=heiko@sntech.de \
--cc=jagan@amarulasolutions.com \
--cc=kever.yang@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.