From: Liviu Dudau <Liviu.Dudau@arm.com> To: Mihail Atanassov <Mihail.Atanassov@arm.com> Cc: "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, nd <nd@arm.com>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Sean Paul <sean@poorly.run>, Brian Starkey <Brian.Starkey@arm.com>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, "james qian wang (Arm Technology China)" <james.qian.wang@arm.com>, "Lowry Li (Arm Technology China)" <Lowry.Li@arm.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v2 5/5] drm/komeda: add rate limiting disable to err_verbosity Date: Mon, 11 Nov 2019 15:53:13 +0000 [thread overview] Message-ID: <20191111155313.iiz37se2f7526ehp@e110455-lin.cambridge.arm.com> (raw) In-Reply-To: <20191107114155.54307-6-mihail.atanassov@arm.com> On Thu, Nov 07, 2019 at 11:42:44AM +0000, Mihail Atanassov wrote: > It's possible to get multiple events in a single frame/flip, so add an > option to print them all. > > Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com> > Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com> For the whole series: Acked-by: Liviu Dudau <liviu.dudau@arm.com> Best regards, Liviu > --- > > v2: Clean up continuation line warning from checkpatch. > > drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 2 ++ > drivers/gpu/drm/arm/display/komeda/komeda_event.c | 2 +- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h > index d9fc9c48859a..15f52e304c08 100644 > --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h > @@ -224,6 +224,8 @@ struct komeda_dev { > #define KOMEDA_DEV_PRINT_INFO_EVENTS BIT(2) > /* Dump DRM state on an error or warning event. */ > #define KOMEDA_DEV_PRINT_DUMP_STATE_ON_EVENT BIT(8) > + /* Disable rate limiting of event prints (normally one per commit) */ > +#define KOMEDA_DEV_PRINT_DISABLE_RATELIMIT BIT(12) > }; > > static inline bool > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_event.c b/drivers/gpu/drm/arm/display/komeda/komeda_event.c > index 7fd624761a2b..bf269683f811 100644 > --- a/drivers/gpu/drm/arm/display/komeda/komeda_event.c > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_event.c > @@ -119,7 +119,7 @@ void komeda_print_events(struct komeda_events *evts, struct drm_device *dev) > /* reduce the same msg print, only print the first evt for one frame */ > if (evts->global || is_new_frame(evts)) > en_print = true; > - if (!en_print) > + if (!(err_verbosity & KOMEDA_DEV_PRINT_DISABLE_RATELIMIT) && !en_print) > return; > > if (err_verbosity & KOMEDA_DEV_PRINT_ERR_EVENTS) > -- > 2.23.0 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯
WARNING: multiple messages have this Message-ID (diff)
From: Liviu Dudau <Liviu.Dudau@arm.com> To: Mihail Atanassov <Mihail.Atanassov@arm.com> Cc: "Lowry Li \(Arm Technology China\)" <Lowry.Li@arm.com>, David Airlie <airlied@linux.ie>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "james qian wang \(Arm Technology China\)" <james.qian.wang@arm.com>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, nd <nd@arm.com>, Sean Paul <sean@poorly.run> Subject: Re: [PATCH v2 5/5] drm/komeda: add rate limiting disable to err_verbosity Date: Mon, 11 Nov 2019 15:53:13 +0000 [thread overview] Message-ID: <20191111155313.iiz37se2f7526ehp@e110455-lin.cambridge.arm.com> (raw) Message-ID: <20191111155313.53eVpaaR6xw3YrQUaav1up6mG4YrgJ4Xzirk-4da7eU@z> (raw) In-Reply-To: <20191107114155.54307-6-mihail.atanassov@arm.com> On Thu, Nov 07, 2019 at 11:42:44AM +0000, Mihail Atanassov wrote: > It's possible to get multiple events in a single frame/flip, so add an > option to print them all. > > Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com> > Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com> For the whole series: Acked-by: Liviu Dudau <liviu.dudau@arm.com> Best regards, Liviu > --- > > v2: Clean up continuation line warning from checkpatch. > > drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 2 ++ > drivers/gpu/drm/arm/display/komeda/komeda_event.c | 2 +- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h > index d9fc9c48859a..15f52e304c08 100644 > --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h > @@ -224,6 +224,8 @@ struct komeda_dev { > #define KOMEDA_DEV_PRINT_INFO_EVENTS BIT(2) > /* Dump DRM state on an error or warning event. */ > #define KOMEDA_DEV_PRINT_DUMP_STATE_ON_EVENT BIT(8) > + /* Disable rate limiting of event prints (normally one per commit) */ > +#define KOMEDA_DEV_PRINT_DISABLE_RATELIMIT BIT(12) > }; > > static inline bool > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_event.c b/drivers/gpu/drm/arm/display/komeda/komeda_event.c > index 7fd624761a2b..bf269683f811 100644 > --- a/drivers/gpu/drm/arm/display/komeda/komeda_event.c > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_event.c > @@ -119,7 +119,7 @@ void komeda_print_events(struct komeda_events *evts, struct drm_device *dev) > /* reduce the same msg print, only print the first evt for one frame */ > if (evts->global || is_new_frame(evts)) > en_print = true; > - if (!en_print) > + if (!(err_verbosity & KOMEDA_DEV_PRINT_DISABLE_RATELIMIT) && !en_print) > return; > > if (err_verbosity & KOMEDA_DEV_PRINT_ERR_EVENTS) > -- > 2.23.0 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯ _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-11-11 15:53 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-07 11:42 [PATCH v2 0/5] drm/komeda: Improve IRQ error event prints Mihail Atanassov 2019-11-07 11:42 ` Mihail Atanassov 2019-11-07 11:42 ` Mihail Atanassov 2019-11-07 11:42 ` [PATCH v2 1/5] drm/komeda: Add debugfs node to control error verbosity Mihail Atanassov 2019-11-07 11:42 ` Mihail Atanassov 2019-11-07 11:42 ` Mihail Atanassov 2019-11-11 15:52 ` Liviu Dudau 2019-11-11 15:52 ` Liviu Dudau 2019-11-07 11:42 ` [PATCH v2 2/5] drm/komeda: Remove CONFIG_KOMEDA_ERROR_PRINT Mihail Atanassov 2019-11-07 11:42 ` Mihail Atanassov 2019-11-07 11:42 ` Mihail Atanassov 2019-11-07 11:42 ` [PATCH v2 3/5] drm/komeda: Optionally dump DRM state on interrupts Mihail Atanassov 2019-11-07 11:42 ` Mihail Atanassov 2019-11-07 11:42 ` Mihail Atanassov 2019-11-07 11:42 ` [PATCH v2 4/5] drm/komeda: Add option to print WARN- and INFO-level IRQ events Mihail Atanassov 2019-11-07 11:42 ` Mihail Atanassov 2019-11-07 11:42 ` Mihail Atanassov 2019-11-07 11:42 ` [PATCH v2 5/5] drm/komeda: add rate limiting disable to err_verbosity Mihail Atanassov 2019-11-07 11:42 ` Mihail Atanassov 2019-11-07 11:42 ` Mihail Atanassov 2019-11-11 15:53 ` Liviu Dudau [this message] 2019-11-11 15:53 ` Liviu Dudau 2019-11-12 13:00 ` Mihail Atanassov 2019-11-12 13:00 ` Mihail Atanassov 2019-11-12 13:00 ` Mihail Atanassov 2019-11-12 18:24 ` Daniel Vetter 2019-11-12 18:24 ` Daniel Vetter 2019-11-12 18:24 ` Daniel Vetter 2019-11-13 1:42 ` james qian wang (Arm Technology China) 2019-11-13 1:42 ` james qian wang (Arm Technology China) 2019-11-13 1:42 ` james qian wang (Arm Technology China) 2019-11-13 13:43 ` Mihail Atanassov 2019-11-13 13:43 ` Mihail Atanassov 2019-11-13 13:43 ` Mihail Atanassov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191111155313.iiz37se2f7526ehp@e110455-lin.cambridge.arm.com \ --to=liviu.dudau@arm.com \ --cc=Brian.Starkey@arm.com \ --cc=Lowry.Li@arm.com \ --cc=Mihail.Atanassov@arm.com \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=james.qian.wang@arm.com \ --cc=linux-kernel@vger.kernel.org \ --cc=maarten.lankhorst@linux.intel.com \ --cc=mripard@kernel.org \ --cc=nd@arm.com \ --cc=sean@poorly.run \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.