From: Ville Syrjala <ville.syrjala@linux.intel.com> To: intel-gfx@lists.freedesktop.org Subject: [PATCH 02/10] drm/i915: Add intel_crtc_vblank_off() Date: Tue, 12 Nov 2019 16:14:55 +0200 [thread overview] Message-ID: <20191112141503.1116-3-ville.syrjala@linux.intel.com> (raw) In-Reply-To: <20191112141503.1116-1-ville.syrjala@linux.intel.com> From: Ville Syrjälä <ville.syrjala@linux.intel.com> We already have intel_crtc_vblank_on(). Add a counterpart so we don't have to inline the disable+assert all over. Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> --- drivers/gpu/drm/i915/display/intel_display.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index da01fa6928a2..194029ff8617 100644 --- a/drivers/gpu/drm/i915/display/intel_display.c +++ b/drivers/gpu/drm/i915/display/intel_display.c @@ -1831,6 +1831,12 @@ static void intel_crtc_vblank_on(const struct intel_crtc_state *crtc_state) drm_crtc_vblank_on(&crtc->base); } +static void intel_crtc_vblank_off(struct intel_crtc *crtc) +{ + drm_crtc_vblank_off(&crtc->base); + assert_vblank_disabled(&crtc->base); +} + static void intel_enable_pipe(const struct intel_crtc_state *new_crtc_state) { struct intel_crtc *crtc = to_intel_crtc(new_crtc_state->uapi.crtc); @@ -6736,8 +6742,7 @@ static void ironlake_crtc_disable(struct intel_crtc_state *old_crtc_state, intel_encoders_disable(state, intel_crtc); - drm_crtc_vblank_off(crtc); - assert_vblank_disabled(crtc); + intel_crtc_vblank_off(intel_crtc); intel_disable_pipe(old_crtc_state); @@ -6786,8 +6791,7 @@ static void haswell_crtc_disable(struct intel_crtc_state *old_crtc_state, intel_encoders_disable(state, intel_crtc); - drm_crtc_vblank_off(crtc); - assert_vblank_disabled(crtc); + intel_crtc_vblank_off(intel_crtc); /* XXX: Do the pipe assertions at the right place for BXT DSI. */ if (!transcoder_is_dsi(cpu_transcoder)) @@ -7163,8 +7167,7 @@ static void i9xx_crtc_disable(struct intel_crtc_state *old_crtc_state, intel_encoders_disable(state, intel_crtc); - drm_crtc_vblank_off(crtc); - assert_vblank_disabled(crtc); + intel_crtc_vblank_off(intel_crtc); intel_disable_pipe(old_crtc_state); -- 2.23.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Ville Syrjala <ville.syrjala@linux.intel.com> To: intel-gfx@lists.freedesktop.org Subject: [Intel-gfx] [PATCH 02/10] drm/i915: Add intel_crtc_vblank_off() Date: Tue, 12 Nov 2019 16:14:55 +0200 [thread overview] Message-ID: <20191112141503.1116-3-ville.syrjala@linux.intel.com> (raw) Message-ID: <20191112141455.TD37TfKBKnLYoRbnHDb1be4hIT12wULHSXgYrfMdRa4@z> (raw) In-Reply-To: <20191112141503.1116-1-ville.syrjala@linux.intel.com> From: Ville Syrjälä <ville.syrjala@linux.intel.com> We already have intel_crtc_vblank_on(). Add a counterpart so we don't have to inline the disable+assert all over. Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> --- drivers/gpu/drm/i915/display/intel_display.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index da01fa6928a2..194029ff8617 100644 --- a/drivers/gpu/drm/i915/display/intel_display.c +++ b/drivers/gpu/drm/i915/display/intel_display.c @@ -1831,6 +1831,12 @@ static void intel_crtc_vblank_on(const struct intel_crtc_state *crtc_state) drm_crtc_vblank_on(&crtc->base); } +static void intel_crtc_vblank_off(struct intel_crtc *crtc) +{ + drm_crtc_vblank_off(&crtc->base); + assert_vblank_disabled(&crtc->base); +} + static void intel_enable_pipe(const struct intel_crtc_state *new_crtc_state) { struct intel_crtc *crtc = to_intel_crtc(new_crtc_state->uapi.crtc); @@ -6736,8 +6742,7 @@ static void ironlake_crtc_disable(struct intel_crtc_state *old_crtc_state, intel_encoders_disable(state, intel_crtc); - drm_crtc_vblank_off(crtc); - assert_vblank_disabled(crtc); + intel_crtc_vblank_off(intel_crtc); intel_disable_pipe(old_crtc_state); @@ -6786,8 +6791,7 @@ static void haswell_crtc_disable(struct intel_crtc_state *old_crtc_state, intel_encoders_disable(state, intel_crtc); - drm_crtc_vblank_off(crtc); - assert_vblank_disabled(crtc); + intel_crtc_vblank_off(intel_crtc); /* XXX: Do the pipe assertions at the right place for BXT DSI. */ if (!transcoder_is_dsi(cpu_transcoder)) @@ -7163,8 +7167,7 @@ static void i9xx_crtc_disable(struct intel_crtc_state *old_crtc_state, intel_encoders_disable(state, intel_crtc); - drm_crtc_vblank_off(crtc); - assert_vblank_disabled(crtc); + intel_crtc_vblank_off(intel_crtc); intel_disable_pipe(old_crtc_state); -- 2.23.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-11-12 14:15 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-12 14:14 [PATCH 00/10] drm/i915: Cleanups around .crtc_enable/disable() Ville Syrjala 2019-11-12 14:14 ` [Intel-gfx] " Ville Syrjala 2019-11-12 14:14 ` [PATCH 01/10] drm/i915: Change intel_encoders_<hook>() calling convention Ville Syrjala 2019-11-12 14:14 ` [Intel-gfx] " Ville Syrjala 2019-11-13 23:48 ` Manasi Navare 2019-11-13 23:48 ` [Intel-gfx] " Manasi Navare 2019-11-12 14:14 ` Ville Syrjala [this message] 2019-11-12 14:14 ` [Intel-gfx] [PATCH 02/10] drm/i915: Add intel_crtc_vblank_off() Ville Syrjala 2019-11-13 23:50 ` Manasi Navare 2019-11-13 23:50 ` [Intel-gfx] " Manasi Navare 2019-11-12 14:14 ` [PATCH 03/10] drm/i915: Move assert_vblank_disabled() into intel_crtc_vblank_on() Ville Syrjala 2019-11-12 14:14 ` [Intel-gfx] " Ville Syrjala 2019-11-14 0:05 ` Manasi Navare 2019-11-14 0:05 ` [Intel-gfx] " Manasi Navare 2019-11-12 14:14 ` [PATCH 04/10] drm/i915: Move crtc_state to tighter scope Ville Syrjala 2019-11-12 14:14 ` [Intel-gfx] " Ville Syrjala 2019-11-14 0:09 ` Manasi Navare 2019-11-14 0:09 ` [Intel-gfx] " Manasi Navare 2019-11-12 14:14 ` [PATCH 05/10] drm/i915: Pass intel_crtc to ironlake_fdi_disable() Ville Syrjala 2019-11-12 14:14 ` [Intel-gfx] " Ville Syrjala 2019-11-14 0:10 ` Manasi Navare 2019-11-14 0:10 ` [Intel-gfx] " Manasi Navare 2019-11-12 14:14 ` [PATCH 06/10] drm/i915: Change watermark hook calling convention Ville Syrjala 2019-11-12 14:14 ` [Intel-gfx] " Ville Syrjala 2019-11-14 0:22 ` Manasi Navare 2019-11-14 0:22 ` [Intel-gfx] " Manasi Navare 2019-11-15 15:18 ` Ville Syrjälä 2019-11-15 15:18 ` [Intel-gfx] " Ville Syrjälä 2019-11-12 14:15 ` [PATCH 07/10] drm/i915: Pass dev_priv to cpt_verify_modeset() Ville Syrjala 2019-11-12 14:15 ` [Intel-gfx] " Ville Syrjala 2019-11-14 0:23 ` Manasi Navare 2019-11-14 0:23 ` [Intel-gfx] " Manasi Navare 2019-11-12 14:15 ` [PATCH 08/10] drm/i915: s/intel_crtc/crtc/ in .crtc_enable() and .crtc_disable() Ville Syrjala 2019-11-12 14:15 ` [Intel-gfx] " Ville Syrjala 2019-11-14 0:27 ` Manasi Navare 2019-11-14 0:27 ` [Intel-gfx] " Manasi Navare 2019-11-12 14:15 ` [PATCH 09/10] drm/i915: s/pipe_config/new_crtc_state/ in .crtc_enable() Ville Syrjala 2019-11-12 14:15 ` [Intel-gfx] " Ville Syrjala 2019-11-14 0:35 ` Manasi Navare 2019-11-14 0:35 ` [Intel-gfx] " Manasi Navare 2019-11-15 15:15 ` Ville Syrjälä 2019-11-15 15:15 ` [Intel-gfx] " Ville Syrjälä 2019-11-12 14:15 ` [PATCH 10/10] drm/i915: Change .crtc_enable/disable() calling convention Ville Syrjala 2019-11-12 14:15 ` [Intel-gfx] " Ville Syrjala 2019-11-14 0:37 ` Manasi Navare 2019-11-14 0:37 ` [Intel-gfx] " Manasi Navare 2019-11-12 15:37 ` ✗ Fi.CI.BAT: failure for drm/i915: Cleanups around .crtc_enable/disable() Patchwork 2019-11-12 15:37 ` [Intel-gfx] " Patchwork 2019-11-15 21:36 ` ✗ Fi.CI.BUILD: failure for drm/i915: Cleanups around .crtc_enable/disable() (rev2) Patchwork 2019-11-15 21:36 ` [Intel-gfx] " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191112141503.1116-3-ville.syrjala@linux.intel.com \ --to=ville.syrjala@linux.intel.com \ --cc=intel-gfx@lists.freedesktop.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.