All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jacopo Mondi <jacopo+renesas@jmondi.org>
To: laurent.pinchart@ideasonboard.com,
	kieran.bingham+renesas@ideasonboard.com, geert@linux-m68k.org,
	horms@verge.net.au, uli+renesas@fpond.eu
Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>,
	airlied@linux.ie, daniel@ffwll.ch,
	linux-renesas-soc@vger.kernel.org,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [PATCH v7 6/7] drm: rcar-du: crtc: Register GAMMA_LUT properties
Date: Wed, 13 Nov 2019 11:05:55 +0100	[thread overview]
Message-ID: <20191113100556.15616-7-jacopo+renesas@jmondi.org> (raw)
In-Reply-To: <20191113100556.15616-1-jacopo+renesas@jmondi.org>

Enable the GAMMA_LUT KMS property using the framework helpers to
register the property and set the associated gamma table maximum size.

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: Ulrich Hecht <uli+renesas@fpond.eu>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
---
 drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
index 3f0f16946f42..e12ce9c8923b 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
@@ -1136,6 +1136,7 @@ static const struct drm_crtc_funcs crtc_funcs_gen3 = {
 	.set_crc_source = rcar_du_crtc_set_crc_source,
 	.verify_crc_source = rcar_du_crtc_verify_crc_source,
 	.get_crc_sources = rcar_du_crtc_get_crc_sources,
+	.gamma_set = drm_atomic_helper_legacy_gamma_set,
 };
 
 /* -----------------------------------------------------------------------------
@@ -1259,6 +1260,9 @@ int rcar_du_crtc_create(struct rcar_du_group *rgrp, unsigned int swindex,
 	if (rcdu->cmms[swindex]) {
 		rcrtc->cmm = rcdu->cmms[swindex];
 		rgrp->cmms_mask |= BIT(hwindex % 2);
+
+		drm_mode_crtc_set_gamma_size(crtc, CM2_LUT_SIZE);
+		drm_crtc_enable_color_mgmt(crtc, 0, false, CM2_LUT_SIZE);
 	}
 
 	drm_crtc_helper_add(crtc, &crtc_helper_funcs);
-- 
2.23.0


WARNING: multiple messages have this Message-ID (diff)
From: Jacopo Mondi <jacopo+renesas@jmondi.org>
To: laurent.pinchart@ideasonboard.com,
	kieran.bingham+renesas@ideasonboard.com, geert@linux-m68k.org,
	horms@verge.net.au, uli+renesas@fpond.eu
Cc: airlied@linux.ie, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	Jacopo Mondi <jacopo+renesas@jmondi.org>
Subject: [PATCH v7 6/7] drm: rcar-du: crtc: Register GAMMA_LUT properties
Date: Wed, 13 Nov 2019 11:05:55 +0100	[thread overview]
Message-ID: <20191113100556.15616-7-jacopo+renesas@jmondi.org> (raw)
Message-ID: <20191113100555.zWqft1kjcbBh9E4Kygr3Pq4Voj9S0uZMJfmeB6kbRIk@z> (raw)
In-Reply-To: <20191113100556.15616-1-jacopo+renesas@jmondi.org>

Enable the GAMMA_LUT KMS property using the framework helpers to
register the property and set the associated gamma table maximum size.

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: Ulrich Hecht <uli+renesas@fpond.eu>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
---
 drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
index 3f0f16946f42..e12ce9c8923b 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
@@ -1136,6 +1136,7 @@ static const struct drm_crtc_funcs crtc_funcs_gen3 = {
 	.set_crc_source = rcar_du_crtc_set_crc_source,
 	.verify_crc_source = rcar_du_crtc_verify_crc_source,
 	.get_crc_sources = rcar_du_crtc_get_crc_sources,
+	.gamma_set = drm_atomic_helper_legacy_gamma_set,
 };
 
 /* -----------------------------------------------------------------------------
@@ -1259,6 +1260,9 @@ int rcar_du_crtc_create(struct rcar_du_group *rgrp, unsigned int swindex,
 	if (rcdu->cmms[swindex]) {
 		rcrtc->cmm = rcdu->cmms[swindex];
 		rgrp->cmms_mask |= BIT(hwindex % 2);
+
+		drm_mode_crtc_set_gamma_size(crtc, CM2_LUT_SIZE);
+		drm_crtc_enable_color_mgmt(crtc, 0, false, CM2_LUT_SIZE);
 	}
 
 	drm_crtc_helper_add(crtc, &crtc_helper_funcs);
-- 
2.23.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2019-11-13 10:04 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-13 10:05 [PATCH v7 0/7] drm: rcar-du: Add Color Management Module (CMM) Jacopo Mondi
2019-11-13 10:05 ` Jacopo Mondi
2019-11-13 10:05 ` [PATCH v7 1/7] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation Jacopo Mondi
2019-11-13 10:05   ` [PATCH v7 1/7] dt-bindings: display: renesas, cmm: " Jacopo Mondi
2019-11-13 10:05 ` [PATCH v7 2/7] dt-bindings: display, renesas,du: Document cmms property Jacopo Mondi
2019-11-13 10:05   ` [PATCH v7 2/7] dt-bindings: display, renesas, du: " Jacopo Mondi
2019-11-13 13:34   ` [PATCH v7 2/7] dt-bindings: display, renesas,du: " Geert Uytterhoeven
2019-11-13 13:34     ` [PATCH v7 2/7] dt-bindings: display, renesas, du: " Geert Uytterhoeven
2019-11-28  1:50     ` [PATCH v7 2/7] dt-bindings: display, renesas,du: " Laurent Pinchart
2019-11-28  1:50       ` Laurent Pinchart
2019-11-13 10:05 ` [PATCH v7 3/7] drm: rcar-du: Add support for CMM Jacopo Mondi
2019-11-13 10:05   ` Jacopo Mondi
2019-11-28  1:52   ` Laurent Pinchart
2019-11-28  1:52     ` Laurent Pinchart
2019-11-28  7:56   ` Geert Uytterhoeven
2019-11-28  7:56     ` Geert Uytterhoeven
2019-11-28  8:09     ` Laurent Pinchart
2019-11-28  8:09       ` Laurent Pinchart
2019-11-28  8:24       ` Geert Uytterhoeven
2019-11-28  8:24         ` Geert Uytterhoeven
2019-11-13 10:05 ` [PATCH v7 4/7] drm: rcar-du: kms: Initialize CMM instances Jacopo Mondi
2019-11-13 10:05   ` Jacopo Mondi
2019-11-13 10:05 ` [PATCH v7 5/7] drm: rcar-du: crtc: Control CMM operations Jacopo Mondi
2019-11-13 10:05   ` Jacopo Mondi
2019-12-17 23:02   ` [PATCH v7.1 5.7] " Laurent Pinchart
2019-12-17 23:02     ` Laurent Pinchart
2019-11-13 10:05 ` Jacopo Mondi [this message]
2019-11-13 10:05   ` [PATCH v7 6/7] drm: rcar-du: crtc: Register GAMMA_LUT properties Jacopo Mondi
2019-11-13 10:05 ` [PATCH v7 7/7] drm: rcar-du: kms: Expand comment in vsps parsing routine Jacopo Mondi
2019-11-13 10:05   ` Jacopo Mondi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191113100556.15616-7-jacopo+renesas@jmondi.org \
    --to=jacopo+renesas@jmondi.org \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=geert@linux-m68k.org \
    --cc=horms@verge.net.au \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=uli+renesas@fpond.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.