From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> To: alsa-devel@alsa-project.org Cc: linux-kernel@vger.kernel.org, tiwai@suse.de, broonie@kernel.org, vkoul@kernel.org, gregkh@linuxfoundation.org, jank@cadence.com, srinivas.kandagatla@linaro.org, slawomir.blauciak@intel.com, Bard liao <yung-chuan.liao@linux.intel.com>, Rander Wang <rander.wang@linux.intel.com>, Ranjani Sridharan <ranjani.sridharan@linux.intel.com>, Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Subject: [PATCH v3 00/22] soundwire: code hardening and suspend-resume support Date: Thu, 14 Nov 2019 12:16:40 -0600 [thread overview] Message-ID: <20191114181702.22254-1-pierre-louis.bossart@linux.intel.com> (raw) this patchset applies on top of "[PATCH v3 00/15] soundwire: intel: implement new ASoC interfaces". It implements a series of improvements for: a) interrupt handling on Intel platforms in MSI mode b) race conditions on codec probe and enumeration c) suspend-resume issues (clock-stop mode not supported for now) d) underflow handling e) updates to the stream state machine which did not support valid ALSA transitions. These patches were tested extensively on 4 different platforms and are viewed as required for any sort of SoundWire-based product. While tested extensively on Intel platforms only, they should also benefit Qualcomm platforms who haven't yet enabled power management. Changes since v2: (no feedback received since November 6) Added idle scheduling to deal with pm_runtime issues when devices are exposed in the DSDT, but are not populated on the board. A quirk is introduced to deal with potential cases where the devices might be powered at a later time, in which case it's legit to leave the bus active. Fixed .prepare callback to handle both underflow and resume cases. The previous version was incorrect in the first case and did not follow recommended programming sequence Fixed an additional race condition leading to a timeout when the codec device was suspended while the master remained active. Fixed a couple of warnings reported by static analysis Removed non-essential pr_err() traces in stream.c, left others when useful Changed subject of patches dealing with race conditions to make sure reviewers can link with the interface changes. Changes since v1: (no feedback received since October 23) added support for initialization_complete, integration with Realtek codecs exposed an additional race condition between the resume operation and restoration of settings in separate thread triggered by Slave status change. No other functional change Bard Liao (3): soundwire: intel/cadence: fix timeouts in MSI mode soundwire: stream: only prepare stream when it is configured. soundwire: intel: reinitialize IP+DSP in .prepare(), but only when resuming Pierre-Louis Bossart (19): soundwire: bus: fix race condition with probe_complete signaling soundwire: bus: add PM/no-PM versions of read/write functions soundwire: bus: write Slave Device Number without runtime_pm soundwire: intel: add helpers for link power down and shim wake soundwire: intel: Add basic power management support soundwire: intel: add pm_runtime support soundwire: intel: reset pm_runtime status during system resume soundwire: bus: add helper to reset Slave status to UNATTACHED soundwire: intel: call helper to reset Slave states on resume soundwire: bus: check first if Slaves become UNATTACHED soundwire: bus: fix race condition with enumeration_complete signaling soundwire: bus: fix race condition with initialization_complete signaling soundwire: bus: fix race condition by tracking UNATTACHED transition soundwire: intel: disable pm_runtime when removing a master soundwire: bus: disable pm_runtime in sdw_slave_delete soundwire: stream: remove redundant pr_err traces soundwire: stream: update state machine and add state checks soundwire: stream: do not update parameters during DISABLED-PREPARED transition soundwire: intel: pm_runtime idle scheduling Documentation/driver-api/soundwire/stream.rst | 63 ++- drivers/soundwire/bus.c | 169 +++++++- drivers/soundwire/bus.h | 9 + drivers/soundwire/bus_type.c | 5 + drivers/soundwire/cadence_master.c | 17 +- drivers/soundwire/cadence_master.h | 8 + drivers/soundwire/intel.c | 400 ++++++++++++++++-- drivers/soundwire/intel.h | 2 + drivers/soundwire/intel_init.c | 45 +- drivers/soundwire/slave.c | 4 + drivers/soundwire/stream.c | 71 +++- include/linux/soundwire/sdw.h | 1 + include/linux/soundwire/sdw_intel.h | 4 + 13 files changed, 714 insertions(+), 84 deletions(-) -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> To: alsa-devel@alsa-project.org Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, tiwai@suse.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Ranjani Sridharan <ranjani.sridharan@linux.intel.com>, vkoul@kernel.org, broonie@kernel.org, srinivas.kandagatla@linaro.org, jank@cadence.com, slawomir.blauciak@intel.com, Bard liao <yung-chuan.liao@linux.intel.com>, Rander Wang <rander.wang@linux.intel.com> Subject: [alsa-devel] [PATCH v3 00/22] soundwire: code hardening and suspend-resume support Date: Thu, 14 Nov 2019 12:16:40 -0600 [thread overview] Message-ID: <20191114181702.22254-1-pierre-louis.bossart@linux.intel.com> (raw) this patchset applies on top of "[PATCH v3 00/15] soundwire: intel: implement new ASoC interfaces". It implements a series of improvements for: a) interrupt handling on Intel platforms in MSI mode b) race conditions on codec probe and enumeration c) suspend-resume issues (clock-stop mode not supported for now) d) underflow handling e) updates to the stream state machine which did not support valid ALSA transitions. These patches were tested extensively on 4 different platforms and are viewed as required for any sort of SoundWire-based product. While tested extensively on Intel platforms only, they should also benefit Qualcomm platforms who haven't yet enabled power management. Changes since v2: (no feedback received since November 6) Added idle scheduling to deal with pm_runtime issues when devices are exposed in the DSDT, but are not populated on the board. A quirk is introduced to deal with potential cases where the devices might be powered at a later time, in which case it's legit to leave the bus active. Fixed .prepare callback to handle both underflow and resume cases. The previous version was incorrect in the first case and did not follow recommended programming sequence Fixed an additional race condition leading to a timeout when the codec device was suspended while the master remained active. Fixed a couple of warnings reported by static analysis Removed non-essential pr_err() traces in stream.c, left others when useful Changed subject of patches dealing with race conditions to make sure reviewers can link with the interface changes. Changes since v1: (no feedback received since October 23) added support for initialization_complete, integration with Realtek codecs exposed an additional race condition between the resume operation and restoration of settings in separate thread triggered by Slave status change. No other functional change Bard Liao (3): soundwire: intel/cadence: fix timeouts in MSI mode soundwire: stream: only prepare stream when it is configured. soundwire: intel: reinitialize IP+DSP in .prepare(), but only when resuming Pierre-Louis Bossart (19): soundwire: bus: fix race condition with probe_complete signaling soundwire: bus: add PM/no-PM versions of read/write functions soundwire: bus: write Slave Device Number without runtime_pm soundwire: intel: add helpers for link power down and shim wake soundwire: intel: Add basic power management support soundwire: intel: add pm_runtime support soundwire: intel: reset pm_runtime status during system resume soundwire: bus: add helper to reset Slave status to UNATTACHED soundwire: intel: call helper to reset Slave states on resume soundwire: bus: check first if Slaves become UNATTACHED soundwire: bus: fix race condition with enumeration_complete signaling soundwire: bus: fix race condition with initialization_complete signaling soundwire: bus: fix race condition by tracking UNATTACHED transition soundwire: intel: disable pm_runtime when removing a master soundwire: bus: disable pm_runtime in sdw_slave_delete soundwire: stream: remove redundant pr_err traces soundwire: stream: update state machine and add state checks soundwire: stream: do not update parameters during DISABLED-PREPARED transition soundwire: intel: pm_runtime idle scheduling Documentation/driver-api/soundwire/stream.rst | 63 ++- drivers/soundwire/bus.c | 169 +++++++- drivers/soundwire/bus.h | 9 + drivers/soundwire/bus_type.c | 5 + drivers/soundwire/cadence_master.c | 17 +- drivers/soundwire/cadence_master.h | 8 + drivers/soundwire/intel.c | 400 ++++++++++++++++-- drivers/soundwire/intel.h | 2 + drivers/soundwire/intel_init.c | 45 +- drivers/soundwire/slave.c | 4 + drivers/soundwire/stream.c | 71 +++- include/linux/soundwire/sdw.h | 1 + include/linux/soundwire/sdw_intel.h | 4 + 13 files changed, 714 insertions(+), 84 deletions(-) -- 2.20.1 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next reply other threads:[~2019-11-14 18:17 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-14 18:16 Pierre-Louis Bossart [this message] 2019-11-14 18:16 ` [alsa-devel] [PATCH v3 00/22] soundwire: code hardening and suspend-resume support Pierre-Louis Bossart 2019-11-14 18:16 ` [PATCH v3 01/22] soundwire: intel/cadence: fix timeouts in MSI mode Pierre-Louis Bossart 2019-11-14 18:16 ` [alsa-devel] " Pierre-Louis Bossart 2019-11-14 18:16 ` [PATCH v3 02/22] soundwire: bus: fix race condition with probe_complete signaling Pierre-Louis Bossart 2019-11-14 18:16 ` [alsa-devel] " Pierre-Louis Bossart 2019-11-14 18:16 ` [PATCH v3 03/22] soundwire: bus: add PM/no-PM versions of read/write functions Pierre-Louis Bossart 2019-11-14 18:16 ` [alsa-devel] " Pierre-Louis Bossart 2019-11-14 18:16 ` [PATCH v3 04/22] soundwire: bus: write Slave Device Number without runtime_pm Pierre-Louis Bossart 2019-11-14 18:16 ` [alsa-devel] " Pierre-Louis Bossart 2019-11-14 18:16 ` [PATCH v3 05/22] soundwire: intel: add helpers for link power down and shim wake Pierre-Louis Bossart 2019-11-14 18:16 ` [alsa-devel] " Pierre-Louis Bossart 2019-11-14 18:16 ` [PATCH v3 06/22] soundwire: intel: Add basic power management support Pierre-Louis Bossart 2019-11-14 18:16 ` [alsa-devel] " Pierre-Louis Bossart 2019-11-14 18:16 ` [PATCH v3 07/22] soundwire: intel: add pm_runtime support Pierre-Louis Bossart 2019-11-14 18:16 ` [alsa-devel] " Pierre-Louis Bossart 2019-11-14 18:16 ` [PATCH v3 08/22] soundwire: intel: reset pm_runtime status during system resume Pierre-Louis Bossart 2019-11-14 18:16 ` [alsa-devel] " Pierre-Louis Bossart 2019-11-14 18:16 ` [PATCH v3 09/22] soundwire: bus: add helper to reset Slave status to UNATTACHED Pierre-Louis Bossart 2019-11-14 18:16 ` [alsa-devel] " Pierre-Louis Bossart 2019-11-14 18:16 ` [PATCH v3 10/22] soundwire: intel: call helper to reset Slave states on resume Pierre-Louis Bossart 2019-11-14 18:16 ` [alsa-devel] " Pierre-Louis Bossart 2019-11-14 18:16 ` [PATCH v3 11/22] soundwire: bus: check first if Slaves become UNATTACHED Pierre-Louis Bossart 2019-11-14 18:16 ` [alsa-devel] " Pierre-Louis Bossart 2019-11-14 18:16 ` [PATCH v3 12/22] soundwire: bus: fix race condition with enumeration_complete signaling Pierre-Louis Bossart 2019-11-14 18:16 ` [alsa-devel] " Pierre-Louis Bossart 2019-11-14 18:16 ` [PATCH v3 13/22] soundwire: bus: fix race condition with initialization_complete signaling Pierre-Louis Bossart 2019-11-14 18:16 ` [alsa-devel] " Pierre-Louis Bossart 2019-11-14 18:16 ` [PATCH v3 14/22] soundwire: bus: fix race condition by tracking UNATTACHED transition Pierre-Louis Bossart 2019-11-14 18:16 ` [alsa-devel] " Pierre-Louis Bossart 2019-11-14 18:16 ` [PATCH v3 15/22] soundwire: intel: disable pm_runtime when removing a master Pierre-Louis Bossart 2019-11-14 18:16 ` [alsa-devel] " Pierre-Louis Bossart 2019-11-14 18:16 ` [PATCH v3 16/22] soundwire: bus: disable pm_runtime in sdw_slave_delete Pierre-Louis Bossart 2019-11-14 18:16 ` [alsa-devel] " Pierre-Louis Bossart 2019-11-14 18:16 ` [PATCH v3 17/22] soundwire: stream: remove redundant pr_err traces Pierre-Louis Bossart 2019-11-14 18:16 ` [alsa-devel] " Pierre-Louis Bossart 2019-11-14 18:16 ` [PATCH v3 18/22] soundwire: stream: update state machine and add state checks Pierre-Louis Bossart 2019-11-14 18:16 ` [alsa-devel] " Pierre-Louis Bossart 2019-11-14 18:16 ` [PATCH v3 19/22] soundwire: stream: only prepare stream when it is configured Pierre-Louis Bossart 2019-11-14 18:16 ` [alsa-devel] " Pierre-Louis Bossart 2019-11-14 18:17 ` [PATCH v3 20/22] soundwire: stream: do not update parameters during DISABLED-PREPARED transition Pierre-Louis Bossart 2019-11-14 18:17 ` [alsa-devel] " Pierre-Louis Bossart 2019-11-14 18:17 ` [PATCH v3 21/22] soundwire: intel: reinitialize IP+DSP in .prepare(), but only when resuming Pierre-Louis Bossart 2019-11-14 18:17 ` [alsa-devel] " Pierre-Louis Bossart 2019-11-14 18:17 ` [PATCH v3 22/22] soundwire: intel: pm_runtime idle scheduling Pierre-Louis Bossart 2019-11-14 18:17 ` [alsa-devel] " Pierre-Louis Bossart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191114181702.22254-1-pierre-louis.bossart@linux.intel.com \ --to=pierre-louis.bossart@linux.intel.com \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=jank@cadence.com \ --cc=linux-kernel@vger.kernel.org \ --cc=rander.wang@linux.intel.com \ --cc=ranjani.sridharan@linux.intel.com \ --cc=slawomir.blauciak@intel.com \ --cc=srinivas.kandagatla@linaro.org \ --cc=tiwai@suse.de \ --cc=vkoul@kernel.org \ --cc=yung-chuan.liao@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.